)]}'
{"id":"openstack%2Fopenstack-ansible-security~426892","triplet_id":"openstack%2Fopenstack-ansible-security~master~I9ff9f45c0c5bdd749c9491431e2dcb8836587e78","project":"openstack/openstack-ansible-security","branch":"master","topic":"bug/1659120","hashtags":[],"change_id":"I9ff9f45c0c5bdd749c9491431e2dcb8836587e78","subject":"Configure pam_faildelay on Ubuntu","status":"MERGED","created":"2017-01-30 19:22:23.000000000","updated":"2017-02-03 10:29:25.000000000","submitted":"2017-02-03 10:29:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"663c55c0e8e26874b3dd5f20c660d97a893b6119","_number":426892,"virtual_id_number":426892,"owner":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":0,"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},{"value":0,"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2017-02-03 10:29:25.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"recommended":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"all":[{"value":1,"date":"2017-01-30 20:05:15.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":1,"date":"2017-02-01 11:01:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},{"value":1,"date":"2017-01-31 00:37:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},{"value":2,"date":"2017-02-01 13:47:19.000000000","_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":2,"date":"2017-02-03 10:12:42.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":0,"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"value":0,"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},{"value":0,"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},{"value":0,"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"value":1,"date":"2017-02-03 10:12:42.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},{"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-30 20:05:15.000000000","updated_by":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"reviewer":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"state":"REVIEWER"},{"updated":"2017-01-31 00:37:28.000000000","updated_by":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"reviewer":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"state":"REVIEWER"},{"updated":"2017-02-01 11:01:43.000000000","updated_by":{"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},"reviewer":{"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},"state":"REVIEWER"},{"updated":"2017-02-01 13:47:19.000000000","updated_by":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"reviewer":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"state":"REVIEWER"},{"updated":"2017-02-03 10:12:42.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2017-02-03 10:29:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f400213e681b7efb89947058bd333e6305f97199","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2017-01-30 19:22:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31f3025be7b1bc059ee7d42bd12f3a3ed3a97ce2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-30 19:34:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-security-docs-ubuntu-xenial http://docs-draft.openstack.org/92/426892/1/check/gate-openstack-ansible-security-docs-ubuntu-xenial/fd1576f//doc/build/html/ : SUCCESS in 2m 03s\n- gate-openstack-ansible-security-linters-ubuntu-xenial http://logs.openstack.org/92/426892/1/check/gate-openstack-ansible-security-linters-ubuntu-xenial/f803ce8/ : SUCCESS in 3m 00s\n- gate-openstack-ansible-security-ansible-func-centos-7 http://logs.openstack.org/92/426892/1/check/gate-openstack-ansible-security-ansible-func-centos-7/d5556d2/ : SUCCESS in 8m 12s\n- gate-openstack-ansible-security-ansible-func-ubuntu-xenial http://logs.openstack.org/92/426892/1/check/gate-openstack-ansible-security-ansible-func-ubuntu-xenial/6870a56/ : SUCCESS in 8m 58s\n- gate-openstack-ansible-security-ansible-func_rhel7-centos-7 http://logs.openstack.org/92/426892/1/check/gate-openstack-ansible-security-ansible-func_rhel7-centos-7/27bc7cc/ : SUCCESS in 6m 53s\n- gate-openstack-ansible-security-ansible-func_rhel7-ubuntu-xenial http://logs.openstack.org/92/426892/1/check/gate-openstack-ansible-security-ansible-func_rhel7-ubuntu-xenial/dde2756/ : SUCCESS in 11m 46s","accounts_in_message":[],"_revision_number":1},{"id":"22c5be27d3089cd69504d971eddcd42d4b26c4bd","author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"date":"2017-01-30 20:05:15.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d4022b4bcee479cffb9d244404e5577cb6e04550","author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"date":"2017-01-31 00:37:28.000000000","message":"Patch Set 1: Code-Review+1\n\nI pulled the patch and kicked off a multi node deploy on openPOWER.  It worked great.\n\n# Enforce a minimal delay in case of failure (in microseconds).\n# (Replaces the `FAIL_DELAY\u0027 setting from login.defs)\n# Note that other modules may require another minimal delay. (for example,\n# to disable any delay, you should add the nodelay option to pam_unix)\nauth       optional   pam_faildelay.so delay\u003d4000000","accounts_in_message":[],"_revision_number":1},{"id":"f5ef97e7c50436a8d7c210a534f7fc2414878a9d","author":{"_account_id":22981,"name":"Donovan Francesco (drifterza)","email":"donovan.francesco@gmail.com","username":"drifterza"},"date":"2017-02-01 11:01:43.000000000","message":"Patch Set 1: Code-Review+1\n\nNice one !","accounts_in_message":[],"_revision_number":1},{"id":"f6e51330f095d48dbdea83662820bb1256379bb3","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2017-02-01 13:44:27.000000000","message":"Patch Set 1:\n\nThanks for the quick feedback, Kyle! :)","accounts_in_message":[],"_revision_number":1},{"id":"eace73328175fcb8fe741faa0ac01fb30fbdabe6","author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"date":"2017-02-01 13:47:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c63df4386bdb302d3520912816176cb3e6aa5d5f","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2017-02-03 10:12:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2dafd6eea3d71acb70c57d644b3683f0f93fdd4e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-03 10:13:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"36abff3cf65bbf63cea626562611e0a2156bdd4f","date":"2017-02-03 10:29:25.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"644b94779f587c37426dd2f187cbd93d7855edcd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-03 10:29:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-security-docs-ubuntu-xenial http://docs-draft.openstack.org/92/426892/1/gate/gate-openstack-ansible-security-docs-ubuntu-xenial/1586b7b//doc/build/html/ : SUCCESS in 2m 17s\n- gate-openstack-ansible-security-linters-ubuntu-xenial http://logs.openstack.org/92/426892/1/gate/gate-openstack-ansible-security-linters-ubuntu-xenial/4c3a8fd/ : SUCCESS in 1m 40s\n- gate-openstack-ansible-security-ansible-func-centos-7 http://logs.openstack.org/92/426892/1/gate/gate-openstack-ansible-security-ansible-func-centos-7/ba45083/ : SUCCESS in 15m 27s\n- gate-openstack-ansible-security-ansible-func-ubuntu-xenial http://logs.openstack.org/92/426892/1/gate/gate-openstack-ansible-security-ansible-func-ubuntu-xenial/566712b/ : SUCCESS in 7m 36s\n- gate-openstack-ansible-security-ansible-func_rhel6-ubuntu-trusty http://logs.openstack.org/92/426892/1/gate/gate-openstack-ansible-security-ansible-func_rhel6-ubuntu-trusty/d78e5fe/ : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c15d75ecf43efc5d61bbb0199aed3aee08c685a9","revisions":{"c15d75ecf43efc5d61bbb0199aed3aee08c685a9":{"kind":"REWORK","_number":1,"created":"2017-01-30 19:22:23.000000000","uploader":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"ref":"refs/changes/92/426892/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-security","ref":"refs/changes/92/426892/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/92/426892/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/92/426892/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-security refs/changes/92/426892/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-security refs/changes/92/426892/1"}}},"commit":{"parents":[{"commit":"b14056ee44fad250900a0b44fc2436ae509daca4","subject":"Don\u0027t fail when checking for FIPS","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/b14056ee44fad250900a0b44fc2436ae509daca4"}]}],"author":{"name":"Major Hayden","email":"major@mhtx.net","date":"2017-01-30 19:14:39.000000000","tz":-360},"committer":{"name":"Major Hayden","email":"major@mhtx.net","date":"2017-01-30 19:22:19.000000000","tz":-360},"subject":"Configure pam_faildelay on Ubuntu","message":"Configure pam_faildelay on Ubuntu\n\nAs noted in the bug, Ubuntu 16.04 doesn\u0027t use FAIL_DELAY in\n`/etc/login.defs` as CentOS 7 does. This patch ensures that\n`pam_faildelay` is properly configured on Xenial.\n\nCloses-Bug: 1659120\nChange-Id: I9ff9f45c0c5bdd749c9491431e2dcb8836587e78\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/c15d75ecf43efc5d61bbb0199aed3aee08c685a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-security/commit/c15d75ecf43efc5d61bbb0199aed3aee08c685a9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b14056ee44fad250900a0b44fc2436ae509daca4","is_merged_in_target_branch":true,"change_id":"I4023b8e85e61a8e9883045ef488c75e65790035a","change_number":424660,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
