)]}'
{"specs/queens/cleanup-openstack-user-config.rst":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"27c1ba91f685ddce6a891cd8988596cfdf4be0c3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Upgrade impact"},{"line_number":89,"context_line":"--------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If we chose to follow this approach instead of a big/bang approach,"},{"line_number":92,"context_line":"each of those work items would need an explained migration path."},{"line_number":93,"context_line":"This could be achieved by release notes and documentation changes,"},{"line_number":94,"context_line":"to avoid technical debt of a migration script."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_c897ac3a","line":94,"range":{"start_line":91,"start_character":0,"end_line":94,"end_character":46},"updated":"2017-09-03 05:42:45.000000000","message":"I think some form of a migration tool will be needed. Without it, existing deployments would likely be hung out to dry.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0162f91602c05b4db8c0c380d706cb76e37321ed","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Upgrade impact"},{"line_number":89,"context_line":"--------------"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"If we chose to follow this approach instead of a big/bang approach,"},{"line_number":92,"context_line":"each of those work items would need an explained migration path."},{"line_number":93,"context_line":"This could be achieved by release notes and documentation changes,"},{"line_number":94,"context_line":"to avoid technical debt of a migration script."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_201cee11","line":94,"range":{"start_line":91,"start_character":0,"end_line":94,"end_character":46},"in_reply_to":"7f287b81_c897ac3a","updated":"2017-09-05 14:39:50.000000000","message":"You are right.\n\nIt would be better. I don\u0027t know yet how we can do it, but we should do it indeed.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"27c1ba91f685ddce6a891cd8988596cfdf4be0c3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Performance impact"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Reducing the variables can only have a positive performance impact."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"End user impact"},{"line_number":107,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_e892684b","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":67},"updated":"2017-09-03 05:42:45.000000000","message":"In this case we\u0027d be increasing the variables. The user config file is a direct input into inventory which is loaded as a meta host entry and is being done to maximize performance. http://docs.ansible.com/ansible/latest/dev_guide/developing_inventory.html#tuning-the-external-inventory-script\n\nMoving all of the content in the user config into group vars and/or extra variables may have an adverse effect on performance as the user config content would no longer be part of the inventory. Before we get too far into this effort we should probably conduct a bit of of a study on this to ensure we\u0027re actually moving in the right direction. \n\nAll that said, I\u0027m greatly in favor of simplifying the user config and eliminating things where we can and if this work results in a performance impact but is easier for everyone that comes into the project (new and old) then +2.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"27c1ba91f685ddce6a891cd8988596cfdf4be0c3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"Deployer impact"},{"line_number":113,"context_line":"---------------"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The deployer would have to update its configuration file to match"},{"line_number":116,"context_line":"the new structure."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Developer impact"},{"line_number":119,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_c8a9ec90","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":18},"updated":"2017-09-03 05:42:45.000000000","message":"I think this spec should provide for some sort of a migration utility so existing deployers whom have been accustom to the user config for many cycles are not left out in the cold or required to tinker with new structures when they upgrade.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"27c1ba91f685ddce6a891cd8988596cfdf4be0c3","unresolved":false,"context_lines":[{"line_number":142,"context_line":"- phase out all the variables in o_u_c that we could define as"},{"line_number":143,"context_line":"  user variables."},{"line_number":144,"context_line":"- same for group variables."},{"line_number":145,"context_line":"- Simplify the networking to use group variables where possible."},{"line_number":146,"context_line":"- Split the inventory in two parts internally: One for container"},{"line_number":147,"context_line":"  name and IP generation, one for the rest of the hosts/group"},{"line_number":148,"context_line":"  structure."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_08893425","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":64},"updated":"2017-09-03 05:42:45.000000000","message":"a simplification of the networking (\"provider_networks\") would be great however care will need to be taken to ensure whatever we move to is 100% compatible with what we have today. Secondly, we should not break away from any known structures or network wiring in a single cycle.\n\nIt\u0027s well known that group vars using the same variable name across multiple groups can be trampled on in unexpected ways when a host is a member of many groups. As such I\u0027m a little leary of this change when it comes to networking and would rather see this included as an extra variable if we\u0027re looking to take it out of the inventory.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0162f91602c05b4db8c0c380d706cb76e37321ed","unresolved":false,"context_lines":[{"line_number":142,"context_line":"- phase out all the variables in o_u_c that we could define as"},{"line_number":143,"context_line":"  user variables."},{"line_number":144,"context_line":"- same for group variables."},{"line_number":145,"context_line":"- Simplify the networking to use group variables where possible."},{"line_number":146,"context_line":"- Split the inventory in two parts internally: One for container"},{"line_number":147,"context_line":"  name and IP generation, one for the rest of the hosts/group"},{"line_number":148,"context_line":"  structure."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_712ab97e","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":64},"in_reply_to":"7f287b81_08893425","updated":"2017-09-05 14:39:50.000000000","message":"Fair enough.","commit_id":"9b385a56e11020f9f6e62ad9c9991f993e4a1cb5"}]}