)]}'
{"specs/queens/hyperconverged-containers.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The \"opt-in\" container cleanup playbooks will need to be created and documented."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_dcd0a456","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":80},"updated":"2017-09-01 16:00:43.000000000","message":"Could you rephrase that?\nI guess you mean that we will provide a series of playbooks to move from the old setup to the new setup, cleaning up the old unused containers, after all the software has been installed on the converged container ones?\n\nShouldn\u0027t that be more explicited on how you\u0027d do it?","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0f530ab84883f7c12c133386d7a127d5c4951f55","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The \"opt-in\" container cleanup playbooks will need to be created and documented."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_a0eb3e10","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":80},"in_reply_to":"7f287b81_cd9d7e0b","updated":"2017-09-04 18:07:05.000000000","message":"For me to understand what is the intent here, I need to have more details on the change of the \"cleanup\". This way I can understand the impact of this spec.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b2d35e3402139d8d8b2f0567b5454ca69c651ade","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The \"opt-in\" container cleanup playbooks will need to be created and documented."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_cd9d7e0b","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":80},"in_reply_to":"7f287b81_dcd0a456","updated":"2017-09-03 03:41:41.000000000","message":"I\u0027ve not provided details on the implantation at this point, I\u0027m trying to keep the focus ob intent.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"What, if any, are the alternatives to the changes you are proposing? What other"},{"line_number":46,"context_line":"ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t have to be"},{"line_number":47,"context_line":"a full literature review, but it should demonstrate that thought has been put"},{"line_number":48,"context_line":"into why the proposed solution is an appropriate one."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Playbook/Role impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_1cbe2cff","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":53},"updated":"2017-09-01 16:00:43.000000000","message":"We should say here that the alternative is the status quo, with the risk explained in the problem description that could eventually grow with more openstack services appearing.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b2d35e3402139d8d8b2f0567b5454ca69c651ade","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"What, if any, are the alternatives to the changes you are proposing? What other"},{"line_number":46,"context_line":"ways could we do this thing? Why aren\u0027t we using those? This doesn\u0027t have to be"},{"line_number":47,"context_line":"a full literature review, but it should demonstrate that thought has been put"},{"line_number":48,"context_line":"into why the proposed solution is an appropriate one."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Playbook/Role impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_0d94a6e7","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":53},"in_reply_to":"7f287b81_1cbe2cff","updated":"2017-09-03 03:41:41.000000000","message":"Done","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Playbook/Role impact"},{"line_number":52,"context_line":"--------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"What impact will there be on the playbooks?"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_bc3a7895","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":43},"updated":"2017-09-01 16:00:43.000000000","message":"New playbooks for migrations I guess... To be explicited.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b2d35e3402139d8d8b2f0567b5454ca69c651ade","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Playbook/Role impact"},{"line_number":52,"context_line":"--------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"What impact will there be on the playbooks?"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_2df9a24c","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":43},"in_reply_to":"7f287b81_bc3a7895","updated":"2017-09-03 03:41:41.000000000","message":"Done","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Upgrade impact"},{"line_number":58,"context_line":"--------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"There is no upgrade impact with this change as any existing deployment would"},{"line_number":61,"context_line":"already have the all required associations within inventory. Services would"},{"line_number":62,"context_line":"continue to function normally after this change. Greenfield deployments on the"},{"line_number":63,"context_line":"other hand would have fewer containers to manage which reduces the resource"},{"line_number":64,"context_line":"requirements while also ensuring we retain the host, network, and process"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_9c269c68","line":61,"range":{"start_line":60,"start_character":0,"end_line":61,"end_character":59},"updated":"2017-09-01 16:00:43.000000000","message":"There is an upgrade impact, because:\n- Service on those containers would be running, so we need to clean them up properly. Because the spec doesn\u0027t explain what it does it could go wrong. Let\u0027s say we are cleaning up cinder volumes (I guess it won\u0027t be the case, but just for the exercise, because it wasn\u0027t written), cleaning these cinder_volumes could be disastrous depending on the backend. I guess there are other containers that we need to carefully adapt.\n- Load balancer would probably need adaptations. If you\u0027re running haproxy, that could be also included in the opt-in playbooks, but what about the rest?\n- Last, if we have less containers, will there be an impact on doing upgrades? We currently implement rolling system, that could break it if we\u0027re not careful. I don\u0027t see any analysis of it.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":64,"context_line":"requirements while also ensuring we retain the host, network, and process"},{"line_number":65,"context_line":"separation we have today."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"We will create a set of playbooks to cleanup some of the redundant containers"},{"line_number":68,"context_line":"that would exist post upgrade however the execution of this playbook would be"},{"line_number":69,"context_line":"opt-in."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_3c468823","line":69,"range":{"start_line":67,"start_character":0,"end_line":69,"end_character":7},"updated":"2017-09-01 16:00:43.000000000","message":"That\u0027s more clear and should probably be explicited above.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Assignee(s)"},{"line_number":120,"context_line":"-----------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":123,"context_line":"throwing it out there to see who picks it up?"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":126,"context_line":"primary author and contact."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Primary assignee:"},{"line_number":129,"context_line":"  Kevin Carter (IRC: cloudnull)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_37d8e17d","line":126,"range":{"start_line":121,"start_character":0,"end_line":126,"end_character":27},"updated":"2017-09-01 16:00:43.000000000","message":"You can remove that.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b2d35e3402139d8d8b2f0567b5454ca69c651ade","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Assignee(s)"},{"line_number":120,"context_line":"-----------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Who is leading the writing of the code? Or is this a blueprint where you\u0027re"},{"line_number":123,"context_line":"throwing it out there to see who picks it up?"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"If more than one person is working on the implementation, please designate the"},{"line_number":126,"context_line":"primary author and contact."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Primary assignee:"},{"line_number":129,"context_line":"  Kevin Carter (IRC: cloudnull)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_4dfcee3d","line":126,"range":{"start_line":121,"start_character":0,"end_line":126,"end_character":27},"in_reply_to":"7f287b81_37d8e17d","updated":"2017-09-03 03:41:41.000000000","message":"Done","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"e1e23bcb236cb07f459ddeb6cdaca4635a6b740d","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_685a062b","line":146,"updated":"2017-09-01 17:51:34.000000000","message":"Isn\u0027t this dependent on us having an upgrade CI job for openstack-ansible?","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"af084c8f9553a34c5150eee1225a77e377237c16","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_97caf59e","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":12},"updated":"2017-09-01 16:00:43.000000000","message":"That is, IMO, mandatory. We need to replace the conditional \"could\" there :p","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b2d35e3402139d8d8b2f0567b5454ca69c651ade","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_6dffaa34","line":146,"in_reply_to":"7f287b81_685a062b","updated":"2017-09-03 03:41:41.000000000","message":"Yes having an container removal test would depend on an upgrade CI job which is not contained within the scope of this spec.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"48c14d985c3aef7b30e4266fce45eee8d3e21427","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_a0869e64","line":146,"in_reply_to":"7f287b81_6dffaa34","updated":"2017-09-04 18:05:09.000000000","message":"I don\u0027t understand why voting negatively on another spec that has disruptive changes, and not on this one then.\n\nWe do have a periodic job testing upgrades IIRC, and this work should be included in to have a seemless upgrade to master...","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"78ff7ab45e8f2131822b772ed20b147c48667897","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f287b81_6ddf75d6","line":146,"in_reply_to":"7f287b81_a0869e64","updated":"2017-09-05 19:06:22.000000000","message":"I\u0027m not sure I follow however if we\u0027re talking about this spec [ https://review.openstack.org/#/c/499686/ ] I think both have upgrade impact however that spec puts the burden of compatibility on existing deployers and has the potential to disenfranchise existing deployments if upgrade tooling is not created. This spec on the other hand has NO negative impact on a running environments.","commit_id":"86124669844179b6f2a5e8e7488ff5105723a55f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"54e15012f38f45b7c752e7b009778e1af3d2a4f8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial convergence work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_e04ee636","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":35},"updated":"2017-09-04 18:13:43.000000000","message":"A generic idea of this part of the proposed change should be part of the spec, instead of letting uncertainty in the implementation.\n\nReviewers of the implementation will have to compare the spec and the code to see if there is a match.","commit_id":"33d457e15af0ee76ea7cadc687796178be5481cc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"41cadadd48d77e4c35099694cfc4a1597897f675","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial convergence work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_4de95918","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":35},"in_reply_to":"7f287b81_e04ee636","updated":"2017-09-05 19:01:22.000000000","message":"What more would you like to see here? We\u0027re proposing a \"set of tasks which will cleanup containers and services wherever necessary\". Are we saying that we want a complete abstract covering this work?","commit_id":"33d457e15af0ee76ea7cadc687796178be5481cc"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"54e15012f38f45b7c752e7b009778e1af3d2a4f8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Upgrade impact"},{"line_number":64,"context_line":"--------------"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"There is no upgrade impact with this change as any existing deployment would"},{"line_number":67,"context_line":"already have the all required associations within inventory. Services would"},{"line_number":68,"context_line":"continue to function normally after this change. Greenfield deployments on the"},{"line_number":69,"context_line":"other hand would have fewer containers to manage which reduces the resource"},{"line_number":70,"context_line":"requirements while also ensuring we retain the host, network, and process"},{"line_number":71,"context_line":"separation we have today."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"We will create a set of playbooks to cleanup some of the redundant containers"},{"line_number":74,"context_line":"that would exist post upgrade however the execution of this playbook would be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_605c36ed","line":71,"range":{"start_line":66,"start_character":0,"end_line":71,"end_character":25},"updated":"2017-09-04 18:13:43.000000000","message":"See patchset 2 comments.","commit_id":"33d457e15af0ee76ea7cadc687796178be5481cc"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"54e15012f38f45b7c752e7b009778e1af3d2a4f8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_20f3cee9","line":146,"range":{"start_line":144,"start_character":43,"end_line":146,"end_character":12},"updated":"2017-09-04 18:13:43.000000000","message":"Let\u0027s make it official, shall we? (I meant the inclusing of this cleanup playbook in the upgrade path). If we do not, there will be a broken upgrade path.","commit_id":"33d457e15af0ee76ea7cadc687796178be5481cc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"41cadadd48d77e4c35099694cfc4a1597897f675","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Testing"},{"line_number":142,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"This patch will be tested on every commit. If we wanted,  we could create"},{"line_number":145,"context_line":"a code path within the periodic gates with test the \"opt-in\" cleanup playbooks"},{"line_number":146,"context_line":"on upgrades."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f287b81_8dace18c","line":146,"range":{"start_line":144,"start_character":43,"end_line":146,"end_character":12},"in_reply_to":"7f287b81_20f3cee9","updated":"2017-09-05 19:01:22.000000000","message":"Added to the dependencies.","commit_id":"33d457e15af0ee76ea7cadc687796178be5481cc"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c5521348911858ececf1a139900e877f47aacdd7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial convergence work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_84ddba71","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":37},"updated":"2017-09-06 18:11:29.000000000","message":"Couldn\u0027t this be included in the same body of work? This way we can immediately test in our periodics.","commit_id":"e6a97a8ddc72f58631f8a8e4137ec05577152f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f924823bd79494acd9d1d955b138d87f231f76fa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"to get the core functionality of this spec into master but there will be little"},{"line_number":37,"context_line":"to no development required to get the initial convergence work completed."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_92229c51","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":37},"in_reply_to":"7f287b81_84ddba71","updated":"2017-09-06 19:12:25.000000000","message":"It could be, though I would prefer it to be a follow on PR.","commit_id":"e6a97a8ddc72f58631f8a8e4137ec05577152f12"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"c5521348911858ececf1a139900e877f47aacdd7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_e4c11e56","line":42,"updated":"2017-09-06 18:11:29.000000000","message":"Here was the extract of my comments on PS2:\n\nIf someone wants to reduce the amount of containers, which we should do by default in an upgrade, because the current expectations will be to be more converged by default, he will probably hit a few issues.\nI\u0027d like to see an analysis of it to take a decision.\n\nWhat I can understand from reading between the lines:\n- Service on those containers would be running, so we need to clean them up properly, that\u0027s in the spec, so we\u0027re good\n- Containers will be deleted. That\u0027s also described in the spec, and no code has to be written, because we already have these kind of playbooks. So, we are good there again.\n- Load balancers may require a change, or may not depending on which container gets deleted, or IN which container we\u0027ll converge. That\u0027s probably worth explaining.\n- Playbooks may be impacted by the host changes (due to the current rolling fashion of our playbooks). What\u0027s the impact there? Probably none, but I\u0027d rather know if this has been thought of.","commit_id":"e6a97a8ddc72f58631f8a8e4137ec05577152f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f924823bd79494acd9d1d955b138d87f231f76fa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Once the convergence work is complete we intend to develop a set of playbooks"},{"line_number":40,"context_line":"which will allow the deployer to run an \"opt-in\" set of tasks which will cleanup"},{"line_number":41,"context_line":"containers and services wherever necessary. These playbooks will need to be"},{"line_number":42,"context_line":"created, exercised, and documented."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f287b81_72e4d00d","line":42,"in_reply_to":"7f287b81_e4c11e56","updated":"2017-09-06 19:12:25.000000000","message":"Done","commit_id":"e6a97a8ddc72f58631f8a8e4137ec05577152f12"}]}
