)]}'
{"specs/rocky/refactor-inventory.rst":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f41dd2abc619ac8d7cf23c4b9b59643e84632763","unresolved":false,"context_lines":[{"line_number":67,"context_line":"lxc_container_networks with the \"container_networks\" variable, which is"},{"line_number":68,"context_line":"part of the inventory."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This last part can be stripped off, and we can use a lookup instead."},{"line_number":71,"context_line":"By using a lookup, we would simplify the inventory, by completely removing its"},{"line_number":72,"context_line":"container networks section of the generated json. We only need to replace all"},{"line_number":73,"context_line":"the references to container_networks with a lookup, or with the ansible facts"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_e359f28d","line":70,"range":{"start_line":70,"start_character":51,"end_line":70,"end_character":59},"updated":"2018-03-29 11:29:53.000000000","message":"A lookup to what?","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"456af18c939d76bf85fafa4d3bc0cdd669b560df","unresolved":false,"context_lines":[{"line_number":67,"context_line":"lxc_container_networks with the \"container_networks\" variable, which is"},{"line_number":68,"context_line":"part of the inventory."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"This last part can be stripped off, and we can use a lookup instead."},{"line_number":71,"context_line":"By using a lookup, we would simplify the inventory, by completely removing its"},{"line_number":72,"context_line":"container networks section of the generated json. We only need to replace all"},{"line_number":73,"context_line":"the references to container_networks with a lookup, or with the ansible facts"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_ab1bbec7","line":70,"range":{"start_line":70,"start_character":51,"end_line":70,"end_character":59},"in_reply_to":"bf659307_e359f28d","updated":"2018-03-30 06:15:43.000000000","message":"A new ansible lookup.","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f41dd2abc619ac8d7cf23c4b9b59643e84632763","unresolved":false,"context_lines":[{"line_number":84,"context_line":"This tool should be optional, but be used by default. This tool would, like"},{"line_number":85,"context_line":"we do for now with our env.d/conf.d, generate container names for components"},{"line_number":86,"context_line":"running inside containers. The inputs for this tool has to be defined further,"},{"line_number":87,"context_line":"but the output would be an inventory containing the generated hostnames and their"},{"line_number":88,"context_line":"group hierarchy. If this tool doesn\u0027t make use of env.d/conf.d, we would be"},{"line_number":89,"context_line":"further on the way of complete independance of the inventory, but I consider"},{"line_number":90,"context_line":"this as a stretch goal of the step 2."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_83dfd6d4","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":15},"updated":"2018-03-29 11:29:53.000000000","message":"Is there a reason why we couldn\u0027t just provide a default set of groups and group hierarchiy in an in-repo yaml file? Then if people want to add more, they do that in user-space using the same standard mechanism.\n\nI\u0027m ok with adding a tool which converts the env.d stuff into a standard file as a migration tool, but I think our interface should be a hard change.","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"456af18c939d76bf85fafa4d3bc0cdd669b560df","unresolved":false,"context_lines":[{"line_number":84,"context_line":"This tool should be optional, but be used by default. This tool would, like"},{"line_number":85,"context_line":"we do for now with our env.d/conf.d, generate container names for components"},{"line_number":86,"context_line":"running inside containers. The inputs for this tool has to be defined further,"},{"line_number":87,"context_line":"but the output would be an inventory containing the generated hostnames and their"},{"line_number":88,"context_line":"group hierarchy. If this tool doesn\u0027t make use of env.d/conf.d, we would be"},{"line_number":89,"context_line":"further on the way of complete independance of the inventory, but I consider"},{"line_number":90,"context_line":"this as a stretch goal of the step 2."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_8bfa7a40","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":15},"in_reply_to":"bf659307_83dfd6d4","updated":"2018-03-30 06:15:43.000000000","message":"This is indeed an alternative.\n\nWe can define a set of groups inside a default inventory. We can define variables there.\n\nHowever, we\u0027d miss some of the current features:\n- No container will be automatically created (no container name generation)\n- No group based on hostname (like aio1_containers) will be created\n\nBy running on static files we are simplifying our inventory but also losing features. I am trying to find a path where some things are optional, and keeping our code light.","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f41dd2abc619ac8d7cf23c4b9b59643e84632763","unresolved":false,"context_lines":[{"line_number":89,"context_line":"further on the way of complete independance of the inventory, but I consider"},{"line_number":90,"context_line":"this as a stretch goal of the step 2."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For greenfields, this tool would be used by default. For upgrades, we assume"},{"line_number":93,"context_line":"the inventory is ready, and therefore the tooling does not need to be used."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Step 3"},{"line_number":96,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_23c92a25","line":93,"range":{"start_line":92,"start_character":53,"end_line":93,"end_character":22},"updated":"2018-03-29 11:29:53.000000000","message":"There may be changes to the inventory in an upgrade which need to be applied, so this is not strictly true. However, the run-upgrade script can easily do whatever needs to be done.","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"456af18c939d76bf85fafa4d3bc0cdd669b560df","unresolved":false,"context_lines":[{"line_number":89,"context_line":"further on the way of complete independance of the inventory, but I consider"},{"line_number":90,"context_line":"this as a stretch goal of the step 2."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"For greenfields, this tool would be used by default. For upgrades, we assume"},{"line_number":93,"context_line":"the inventory is ready, and therefore the tooling does not need to be used."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Step 3"},{"line_number":96,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_4b96a2f2","line":93,"range":{"start_line":92,"start_character":53,"end_line":93,"end_character":22},"in_reply_to":"bf659307_23c92a25","updated":"2018-03-30 06:15:43.000000000","message":"Yup, I think that should be outside the scope.","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f41dd2abc619ac8d7cf23c4b9b59643e84632763","unresolved":false,"context_lines":[{"line_number":106,"context_line":"------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"With the tool written in step 3 allowing inventory manipulation, we should"},{"line_number":109,"context_line":"be able to read current openstack_inventory.json, based on the conf.d/env.d, and "},{"line_number":110,"context_line":"generate a static inventory that is more friendly for our users. It would allow"},{"line_number":111,"context_line":"them to group hosts the way they want by editing a text file."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_43ce9e2e","line":109,"updated":"2018-03-29 11:29:53.000000000","message":"nit: remove trailing whitespace","commit_id":"7611f05a7194a7d35353828ca884c3d343b48445"}]}