)]}'
{"specs/rocky/designate-backend-provider.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"03af6b0f50879a3e3ee1c67b28b2db90b6b828a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container and install bind with a rndc key so that it may be controlled"},{"line_number":23,"context_line":"with that key by designate.  A possible further enhancement would be to also"},{"line_number":24,"context_line":"register the bind back end in designate so everything is ready to go from the"},{"line_number":25,"context_line":"start."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_2a9aa86d","line":22,"updated":"2018-03-27 08:58:16.000000000","message":"Best practice would be to deploy multiple bind instances, not sure though how much HA integration OSA provides. Might be reasonable to plan for that anyway.\n\nAlso might discuss whether you want to focus on bind only or allow for alternative backends like powerdns.","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5d674d935a80f6eabd6dee7f9ec864946c279bbb","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container and install bind with a rndc key so that it may be controlled"},{"line_number":23,"context_line":"with that key by designate.  A possible further enhancement would be to also"},{"line_number":24,"context_line":"register the bind back end in designate so everything is ready to go from the"},{"line_number":25,"context_line":"start."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_fb3b19ce","line":22,"updated":"2018-03-27 14:34:55.000000000","message":"yes, I was not sure where to put it in this doc, but the end goal is to have bind be the first \u0027plugin\u0027 providing a dns back end.  Further, treat it like the databases and deploy 3 of them by default.","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5c4d8ffffd74d49114e008ae4c51ebdf2f76303b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"--------------------"},{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_a92214a3","line":44,"updated":"2018-03-28 16:03:12.000000000","message":"It\u0027d be a unique rndc key per backend.","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"03af6b0f50879a3e3ee1c67b28b2db90b6b828a6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"--------------------"},{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_ca8f6c21","line":44,"updated":"2018-03-27 08:58:16.000000000","message":"This second variant would not seem to work when deploying multiple instances.","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"5d674d935a80f6eabd6dee7f9ec864946c279bbb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"--------------------"},{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_1b37ede5","line":44,"updated":"2018-03-27 14:34:55.000000000","message":"We could store a key value pair (key being ip, value being the keydata)","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"404a12a266f2c2057f571c0c45d8d87db62d9980","unresolved":false,"context_lines":[{"line_number":41,"context_line":"--------------------"},{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_745ffa0d","line":44,"in_reply_to":"bf659307_1b37ede5","updated":"2018-03-28 10:21:21.000000000","message":"I\u0027m not sure whether designate could handle that. All setup I have seen are using a unique rndc key.","commit_id":"66d90a07f548fd820e5bb204f6634492b95365fd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Openstack Ansible supports setting up the API services for the designate project."},{"line_number":7,"context_line":"While the API services are set up we currently leave setting up the back-end"},{"line_number":8,"context_line":"services (bind, unbound, etc.) to the end user.  The goal of this spec is to"},{"line_number":9,"context_line":"outline a plan to set up those services."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-ansible/+spec/designate-backends"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_9544cfb9","line":9,"range":{"start_line":8,"start_character":49,"end_line":9,"end_character":40},"updated":"2018-04-12 08:28:01.000000000","message":"Bind is tested in our os_designate tests. We set it up there.\n\nMy comment here is just formulating the fact that we _already_ set up those services, in the role tests, and maybe what you are looking for is the integration into openstack-ansible.\n\nCould you please clarify what you want to achieve?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-ansible/+spec/designate-backends"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Openstack Ansible installs designate but does not set up or connect a back end"},{"line_number":16,"context_line":"to it.  This means that the default deployment of designate does not have all"},{"line_number":17,"context_line":"the required pieces in place to create and manage DNS records."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_752d7b93","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":19},"updated":"2018-04-12 08:28:01.000000000","message":"nit: Out of consistency, it would be nice to have newlines after titles.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://blueprints.launchpad.net/openstack-ansible/+spec/designate-backends"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Openstack Ansible installs designate but does not set up or connect a back end"},{"line_number":16,"context_line":"to it.  This means that the default deployment of designate does not have all"},{"line_number":17,"context_line":"the required pieces in place to create and manage DNS records."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_f6b8a711","line":14,"updated":"2018-04-12 16:15:15.000000000","message":"sure, this is a relic from my war on whitespace","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Openstack Ansible installs designate but does not set up or connect a back end"},{"line_number":16,"context_line":"to it.  This means that the default deployment of designate does not have all"},{"line_number":17,"context_line":"the required pieces in place to create and manage DNS records."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_9637ebb0","line":18,"updated":"2018-04-12 16:15:15.000000000","message":"I\u0027m not sure how to state in in the problem description, but I mean \u0027openstack-ansible\u0027 not the designate role.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Openstack Ansible installs designate but does not set up or connect a back end"},{"line_number":16,"context_line":"to it.  This means that the default deployment of designate does not have all"},{"line_number":17,"context_line":"the required pieces in place to create and manage DNS records."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_7519fbd4","line":18,"updated":"2018-04-12 08:28:01.000000000","message":"Is that integration for the ``openstack-ansible`` repo, or do you want to integrate better inside the ``openstack-ansible-os_designate``?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_95eccff4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":59},"updated":"2018-04-12 08:28:01.000000000","message":"I think that wording is confusing, it means it\u0027s forced to be a container, which it shouldn\u0027t.\n\nAlso, do we need to create extra containers? We have designate_backends and designate_workers as groups, which may (or may not) contain hosts/containers. I thought if something would be deployed, it would be in one of those hosts/containers. No need of an extra one...","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_b63c6f93","line":22,"updated":"2018-04-12 16:15:15.000000000","message":"I\u0027ve removed the container specification.  I\u0027m not sure if those groups are sufficient, I also cannot find any refrence to those groups (so I can\u0027t truly determine if those groups would work).","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_359aa361","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":52},"updated":"2018-04-12 08:28:01.000000000","message":"With the comment above, I\u0027d say this sentence would be then:\n\n\"This specs covers the installation of bind inside openstack-ansible. This will deploy bind with a rndc key, to be controlled with designate by the designate-backend component\" (if I am not mistaken).","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Proposed change"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_563dd38b","line":23,"updated":"2018-04-12 16:15:15.000000000","message":"Yep, reformatted","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Control of the bind container could be done via one of two routes."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_76425711","line":25,"updated":"2018-04-12 16:15:15.000000000","message":"Done","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":22,"context_line":"Create a container per infrastructure node and install bind with a rndc key so"},{"line_number":23,"context_line":"that it may be controlled with that key by designate.  A possible further"},{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Control of the bind container could be done via one of two routes."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_75bd7bb5","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":41},"updated":"2018-04-12 08:28:01.000000000","message":"I don\u0027t understand this sentence. Could you rephrase?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":24,"context_line":"enhancement would be to also register the bind back end in designate so"},{"line_number":25,"context_line":"everything is ready to go from the start."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Control of the bind container could be done via one of two routes."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"1. Management network.  Would not need any routing as both the bind container"},{"line_number":30,"context_line":"   and the designate container would be on the same L2 network."},{"line_number":31,"context_line":"2. Via the same interface that bind is expected to serve records on.  This"},{"line_number":32,"context_line":"   network would be user defined (and likely the same as one of the neutron"},{"line_number":33,"context_line":"   controlled networks."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_15fc3f70","line":33,"range":{"start_line":27,"start_character":0,"end_line":33,"end_character":23},"updated":"2018-04-12 08:28:01.000000000","message":"Shouldn\u0027t that be outside the scope of the spec?\n\nI think we should focus on designate integration with bind, and we shouldn\u0027t care about the networking at first, as management network would be alright, and if we scale to different networks, it would just be a different network configuration, which is a user level configuration.\n\nMaybe we can say: \"The implementation will have to be flexible, so that deployers can use configure on which interface bind would listen to.\" ?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   and the designate container would be on the same L2 network."},{"line_number":31,"context_line":"2. Via the same interface that bind is expected to serve records on.  This"},{"line_number":32,"context_line":"   network would be user defined (and likely the same as one of the neutron"},{"line_number":33,"context_line":"   controlled networks."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Alternatives"},{"line_number":36,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_164bdb2a","line":33,"updated":"2018-04-12 16:15:15.000000000","message":"Ya, that makes sense, I guess the point I am trying to make is that bind\u0027s control needs to be on a interface/network designate can access and bind\u0027s \u0027client interface\u0027 (port 53) needs to be on an interface that is consumable by neutron at large (so \u0027clients\u0027 can connect).  I\u0027ll modify this to state that more clearly, but I do think it\u0027s important enough to be stated.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"},{"line_number":48,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_36485f2b","line":45,"updated":"2018-04-12 16:15:15.000000000","message":"Added clarifying language","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Playbook/Role impact"},{"line_number":41,"context_line":"--------------------"},{"line_number":42,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":43,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":44,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":45,"context_line":"and manage bind."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"},{"line_number":48,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_5505d7c0","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":16},"updated":"2018-04-12 08:28:01.000000000","message":"We already deploy bind in our tests. That\u0027s simple.\nI don\u0027t have a problem of using an external role, it\u0027s even welcomed.\n\nBut you don\u0027t explain what will be the impact on the designate role here. How do you plan to do that?\n\nDo you plan to have a series of variables inside the designate role to target or not if we run the external bind role?\nOr do you plan to have a separate playbook, targetted on a group of nodes \"bind\", deploying bind there, and wiring them inside the role if group[\u0027bind\u0027] | length \u003e 0?\n\nThat\u0027s not clear.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"},{"line_number":48,"context_line":"--------------"},{"line_number":49,"context_line":"Minimal, the bind container can be upgrade or replaced with minimal effort."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Security impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_d65003d8","line":49,"updated":"2018-04-12 16:15:15.000000000","message":"done","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Upgrade impact"},{"line_number":48,"context_line":"--------------"},{"line_number":49,"context_line":"Minimal, the bind container can be upgrade or replaced with minimal effort."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Security impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_750a5bd2","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":42},"updated":"2018-04-12 08:28:01.000000000","message":"upgraded","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Performance impact"},{"line_number":56,"context_line":"------------------"},{"line_number":57,"context_line":"The bind container should be a very small one."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"End user impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_b51a33c3","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":46},"updated":"2018-04-12 08:28:01.000000000","message":"I don\u0027t think we should assume a new container, but instead let the deployer use what they want.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Performance impact"},{"line_number":56,"context_line":"------------------"},{"line_number":57,"context_line":"The bind container should be a very small one."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"End user impact"},{"line_number":60,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_f64d073b","line":57,"updated":"2018-04-12 16:15:15.000000000","message":"done","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"End user impact"},{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":"Allows users to start using designate as soon as Openstack Ansible is deployed."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Deployer impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_96604ba7","line":61,"updated":"2018-04-12 16:15:15.000000000","message":"Sure, I\u0027ll rephrase","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"End user impact"},{"line_number":60,"context_line":"---------------"},{"line_number":61,"context_line":"Allows users to start using designate as soon as Openstack Ansible is deployed."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Deployer impact"},{"line_number":64,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_f5850bae","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":79},"updated":"2018-04-12 08:28:01.000000000","message":"This looks like it\u0027s integrating things with openstack-ansible main repo.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Deployer impact"},{"line_number":64,"context_line":"---------------"},{"line_number":65,"context_line":"The deployer may need to define the network the bind container is attached."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_75f57b56","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":75},"updated":"2018-04-12 08:28:01.000000000","message":"I think we should default to work on the management network. People can then change their networks, and bind to a separate public network if need be. And that should be documented.\n\nBut it\u0027s so easy to mess up the bind configuration for non-experienced dns deployer, that being public by default would be, IMO more of a security risk.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Deployer impact"},{"line_number":64,"context_line":"---------------"},{"line_number":65,"context_line":"The deployer may need to define the network the bind container is attached."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_b6654fb7","line":65,"updated":"2018-04-12 16:15:15.000000000","message":"Sure, I\u0027ll be more specific, since there are really two interfaces (the control and the client), it was the client interface I was talking about here.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"* Extend bind role to either allow pre-defining the rndc key, or to register the"},{"line_number":90,"context_line":"  key in a variable for later use."},{"line_number":91,"context_line":"* Extend existing openstack-ansible-os_designate role to register the bind"},{"line_number":92,"context_line":"  servers created."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Testing"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_565633d0","line":92,"updated":"2018-04-12 16:15:15.000000000","message":"Clarified","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* Extend bind role to either allow pre-defining the rndc key, or to register the"},{"line_number":90,"context_line":"  key in a variable for later use."},{"line_number":91,"context_line":"* Extend existing openstack-ansible-os_designate role to register the bind"},{"line_number":92,"context_line":"  servers created."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Testing"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_35b94378","line":92,"range":{"start_line":91,"start_character":0,"end_line":92,"end_character":18},"updated":"2018-04-12 08:28:01.000000000","message":"This looks like the wiring is done inside os_designate rather than in openstack-ansible main repo. What should I expect then?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Have the openstack-ansible-os_designate gate job create and verify a domain and"},{"line_number":98,"context_line":"associated records."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Documentation impact"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_765b37f5","line":98,"updated":"2018-04-12 16:15:15.000000000","message":"Clarified","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Testing"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Have the openstack-ansible-os_designate gate job create and verify a domain and"},{"line_number":98,"context_line":"associated records."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Documentation impact"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_b5a4734c","line":98,"range":{"start_line":97,"start_character":0,"end_line":98,"end_character":19},"updated":"2018-04-12 08:28:01.000000000","message":"Could you please clarify what\u0027s currently missing from the one already wiring designate with bind?","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"cf3c999e85272aa7f9877b98b3eadc183d8e3d45","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Documentation impact"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"New variables may need to be defined for use by deployers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"References"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_d576c7d8","line":103,"range":{"start_line":103,"start_character":57,"end_line":103,"end_character":58},"updated":"2018-04-12 08:28:01.000000000","message":"I\u0027d add here the documentation example of the network configuration if a deployer wants to add bind on a public network.","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"3b722302728da5bf07bd61f315c59337107eb5c5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"Documentation impact"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"New variables may need to be defined for use by deployers."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"References"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_16743b67","line":103,"updated":"2018-04-12 16:15:15.000000000","message":"ackkkkj","commit_id":"c80fa084ce63645a8af78475c9750899f5a98888"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"eca1a793929254ad3f77ca44e326093ecd230e35","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Developer impact"},{"line_number":88,"context_line":"----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Interacting with the upstream Ansible role."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_7340b336","line":90,"updated":"2018-08-07 07:27:57.000000000","message":"Are you seeking a statement that I\u0027d be removing code from os-designate that duplicates the behavior of the new code?  Or specificaly about some of the stuff the tests does to set up a bind env for testing (since this is basically using upstream roles to do the same behaviour)?","commit_id":"8c69e4c7c1c585924e5407cf2ee87a8dfacdc791"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e0c08c4048b141e1cbbe8a5612a6309b64278604","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Developer impact"},{"line_number":88,"context_line":"----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Interacting with the upstream Ansible role."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Dependencies"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_d8ef6685","line":90,"updated":"2018-08-07 07:19:26.000000000","message":"Could you add:\n\"Removal of similar features of the tests folder in the openstack-ansible-os_designate role\"","commit_id":"8c69e4c7c1c585924e5407cf2ee87a8dfacdc791"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Set up backend name service infrastructure for designate service"},{"line_number":2,"context_line":"#######################################################"},{"line_number":3,"context_line":":date: 2018-03-19 00:00"},{"line_number":4,"context_line":":tags: bind, name server, infra"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Openstack-Ansible supports setting up the API services for the designate project."},{"line_number":7,"context_line":"While the API services are set up we currently leave setting up the back-end"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_4282b500","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":11},"updated":"2018-09-21 16:00:19.000000000","message":"can probably remove the bind tag","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"services (bind, unbound, etc.) to the end user.  The goal of this spec is to"},{"line_number":9,"context_line":"outline a plan to set up those services."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https8://blueprints.launchpad.net/openstack-ansible/+spec/designate-backends"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e27c2121","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":6},"updated":"2018-09-21 16:00:19.000000000","message":"typo","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This specs covers the installation of a pluggable backend within"},{"line_number":25,"context_line":"OpenStack-Ansible. This will deploy any backend the deployer wants"},{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_62b7b1d9","line":25,"range":{"start_line":25,"start_character":36,"end_line":25,"end_character":39},"updated":"2018-09-21 16:00:19.000000000","message":"`any supported`?  \u0027any\u0027 is a bit too open.","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"By default, on each infrastructure node, install bind with a rndc key so"},{"line_number":30,"context_line":"that it may be controlled with that key by designate.  Register each bind"},{"line_number":31,"context_line":"back end in designate via the designate_pools_yaml hash."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"There are two interfaces we need to be concerned about."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"1. RNDC (port 953), designate needs to be able to connect to this interface"},{"line_number":36,"context_line":"   in order to configure bind.  This is the interface that will be entered"},{"line_number":37,"context_line":"   into the designate_pools_yaml hash."},{"line_number":38,"context_line":"2. BIND (port 53), this implementation will have to be flexible, so deployers"},{"line_number":39,"context_line":"   can configure on which interface bind would listen."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Both of these interfaces can be the same or different addresses/networks."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Alternatives"},{"line_number":44,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_425ab581","line":41,"range":{"start_line":29,"start_character":0,"end_line":41,"end_character":73},"updated":"2018-09-21 16:00:19.000000000","message":"implementation specific","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Extend https://galaxy.ansible.com/netzwirt/bind/ to support pre-defining the"},{"line_number":53,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":54,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":55,"context_line":"and manage bind.  The os_designate role will be extended to check for the"},{"line_number":56,"context_line":"variable(s) defined by the bind role and will consume them to auto-populate"},{"line_number":57,"context_line":"the designate_pools_yaml hash."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_c217a59c","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":15},"updated":"2018-09-21 16:00:19.000000000","message":"?!?!","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"rndc key that gets installed as a secret.  Alternatively, register the key"},{"line_number":54,"context_line":"generated as a variable for registration in designate. Use the role to set up"},{"line_number":55,"context_line":"and manage bind.  The os_designate role will be extended to check for the"},{"line_number":56,"context_line":"variable(s) defined by the bind role and will consume them to auto-populate"},{"line_number":57,"context_line":"the designate_pools_yaml hash."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Upgrade impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_627811f7","line":56,"range":{"start_line":56,"start_character":27,"end_line":56,"end_character":31},"updated":"2018-09-21 16:00:19.000000000","message":"!?!?","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Upgrade impact"},{"line_number":60,"context_line":"--------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Minimal, bind can be upgraded or replaced with minimal effort."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_a271490f","line":62,"range":{"start_line":62,"start_character":9,"end_line":62,"end_character":13},"updated":"2018-09-21 16:00:19.000000000","message":"nope","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Security impact"},{"line_number":65,"context_line":"---------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Depending on the interface used for rndc communication, minimal."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Performance impact"},{"line_number":70,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_82644d4a","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":64},"updated":"2018-09-21 16:00:19.000000000","message":"more implementation specifc","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Performance impact"},{"line_number":70,"context_line":"------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Bind is a very small service, very minimal impact is expected."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"End user impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_c2d005f7","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":4},"updated":"2018-09-21 16:00:19.000000000","message":"bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"---------------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"A more streamlined deployment.  If OpenStack-Ansible deploys the Designate"},{"line_number":78,"context_line":"backend (Bind) and auto-populates the relevant config files, it will make"},{"line_number":79,"context_line":"Designate easier to consume."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Deployer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_62057179","line":78,"range":{"start_line":78,"start_character":9,"end_line":78,"end_character":13},"updated":"2018-09-21 16:00:19.000000000","message":"more bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"Deployer impact"},{"line_number":82,"context_line":"---------------"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The deployer may need to define the network the bind client interface is"},{"line_number":85,"context_line":"attached.  The interface will default to the management interface, but that"},{"line_number":86,"context_line":"may not be accessible by the deployer\u0027s target audience."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_42fe356a","line":84,"range":{"start_line":84,"start_character":48,"end_line":84,"end_character":52},"updated":"2018-09-21 16:00:19.000000000","message":"more more bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Work items"},{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Extend bind role to either allow pre-defining the rndc key, or to register the"},{"line_number":113,"context_line":"  key in a variable for later use."},{"line_number":114,"context_line":"* Extend existing openstack-ansible-os_designate role to check for"},{"line_number":115,"context_line":"  OpenStack-Ansible deployed bind servers and register them via the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_02391d3d","line":112,"range":{"start_line":112,"start_character":9,"end_line":112,"end_character":13},"updated":"2018-09-21 16:00:19.000000000","message":"alsø bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"* Extend bind role to either allow pre-defining the rndc key, or to register the"},{"line_number":113,"context_line":"  key in a variable for later use."},{"line_number":114,"context_line":"* Extend existing openstack-ansible-os_designate role to check for"},{"line_number":115,"context_line":"  OpenStack-Ansible deployed bind servers and register them via the"},{"line_number":116,"context_line":"  designate_pools_yaml hash."},{"line_number":117,"context_line":"* Add additional backend options"},{"line_number":118,"context_line":"  (PowerDNS 4 (https://github.com/PowerDNS/pdns-ansible), etc.)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_a24389af","line":115,"range":{"start_line":115,"start_character":29,"end_line":115,"end_character":33},"updated":"2018-09-21 16:00:19.000000000","message":"alsø alsø bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Have the openstack-ansible-os_designate gate job create and verify a domain and"},{"line_number":125,"context_line":"associated records with the new bind role, much like is already done with the"},{"line_number":126,"context_line":"test bind role use by openstack-ansible-os_designate already."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_420cf591","line":125,"range":{"start_line":125,"start_character":32,"end_line":125,"end_character":36},"updated":"2018-09-21 16:00:19.000000000","message":"this bind goes, next one in paragraph is good (referencing current)","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"d08b13ce1d657b28e41e2951764e377982818f0c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"* New variables may need to be defined for use by deployers."},{"line_number":132,"context_line":"* Documentation for setting bind\u0027s client interface on a deployer defined"},{"line_number":133,"context_line":"  network."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_02227d01","line":132,"range":{"start_line":132,"start_character":28,"end_line":132,"end_character":32},"updated":"2018-09-21 16:00:19.000000000","message":"Møre bind","commit_id":"86d63d86a32bbb04c33704dd8871c50c9df3ae48"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Proposed change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This specs covers the installation of a pluggable backend within"},{"line_number":25,"context_line":"OpenStack-Ansible. This will deploy any supported backend the deployer wants"},{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_1323ad59","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":34},"updated":"2018-09-21 18:03:52.000000000","message":"installation and configuration","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This specs covers the installation of a pluggable backend within"},{"line_number":25,"context_line":"OpenStack-Ansible. This will deploy any supported backend the deployer wants"},{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_d320d54b","line":25,"range":{"start_line":25,"start_character":36,"end_line":25,"end_character":39},"updated":"2018-09-21 18:03:52.000000000","message":"a","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This specs covers the installation of a pluggable backend within"},{"line_number":25,"context_line":"OpenStack-Ansible. This will deploy any supported backend the deployer wants"},{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_53d28535","line":26,"range":{"start_line":26,"start_character":29,"end_line":26,"end_character":44},"updated":"2018-09-21 18:03:52.000000000","message":"connected to","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":24,"context_line":"This specs covers the installation of a pluggable backend within"},{"line_number":25,"context_line":"OpenStack-Ansible. This will deploy any supported backend the deployer wants"},{"line_number":26,"context_line":"(BIND, PowerDNS, etc.) to be controlled with designate by the designate-backend"},{"line_number":27,"context_line":"component."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Alternatives"},{"line_number":30,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_73d5411a","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":9},"updated":"2018-09-21 18:03:52.000000000","message":"I\u0027m not sure what this \u0027component\u0027 is.","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Playbook/Role impact"},{"line_number":36,"context_line":"--------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Extend the backend role (BIND, PowerDNS, etc.) to support interaction with"},{"line_number":39,"context_line":"registration of DNS in designate. Use the role to set up and manage the backend."},{"line_number":40,"context_line":"The os_designate role will be extended to check for the variable(s) defined by"},{"line_number":41,"context_line":"the backend role and will consume them to auto-populate the designate_pools_yaml"},{"line_number":42,"context_line":"hash."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_f3e071fa","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":33},"updated":"2018-09-21 18:03:52.000000000","message":"Consume upstream roles","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7fce6b3c84766c96a974613cf2eec83a97da1f67","unresolved":false,"context_lines":[{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The deployer may need to define the network the backend server is"},{"line_number":70,"context_line":"attached. "},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Developer impact"},{"line_number":73,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_53a045a5","line":70,"range":{"start_line":70,"start_character":9,"end_line":70,"end_character":10},"updated":"2018-09-21 18:03:52.000000000","message":"extra space at the end","commit_id":"983535294154b7bfab3a918fb4782bee6163a53f"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"88e6c58b6b75eb1bdc0f51357cb7594bdc2acef4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"This specs covers the installation and configuration of a pluggable backend"},{"line_number":25,"context_line":"withinn OpenStack-Ansible. This will deploy a supported backend the deployer"},{"line_number":26,"context_line":"wants (BIND, PowerDNS, etc.) to be connected with designate by the"},{"line_number":27,"context_line":"designate-backend component."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Alternatives"},{"line_number":30,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_732d41fb","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"updated":"2018-09-21 18:14:58.000000000","message":"I\u0027m still not sure what a \u0027designate-backend component\u0027 is (it\u0027s not defined anywhere I think).","commit_id":"d659c06d9c0e1be398f091e05fe57d9d17d58027"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"88e6c58b6b75eb1bdc0f51357cb7594bdc2acef4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---------------"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The deployer may need to define the network the backend server is"},{"line_number":69,"context_line":"attached. "},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Developer impact"},{"line_number":72,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_13308d54","line":69,"range":{"start_line":69,"start_character":9,"end_line":69,"end_character":10},"updated":"2018-09-21 18:14:58.000000000","message":"still has an extra space at the end.","commit_id":"d659c06d9c0e1be398f091e05fe57d9d17d58027"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"564879c42ae0ad829ecdf16216f4f67f94a86cc2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This specs covers the installation and configuration of a pluggable backend"},{"line_number":25,"context_line":"within OpenStack-Ansible. This will deploy a supported backend the deployer"},{"line_number":26,"context_line":"wants (BIND, PowerDNS, etc.)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Alternatives"},{"line_number":29,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_5d94d697","line":26,"updated":"2018-12-11 16:00:48.000000000","message":"Where will this additional service be setup? Will it be opt-in or opt-out? How will a deployer who already has a DNS service do their integration?","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fed3526d2950a84c3757e8c74e132ed39fbc8a1b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Document that Designate backend set up and registration is the responsibility"},{"line_number":32,"context_line":"of the deployer."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Playbook/Role impact"},{"line_number":35,"context_line":"--------------------"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_26d0d8c7","line":33,"updated":"2018-12-12 11:37:20.000000000","message":"I am a little bit confused by this spec. I had thought that the agreement at the PTG was to implement this in the openstack-ansible-ops repository and to write up a \u0027user story\u0027 to accompany it. DNS is highly opinionated and so any implementation of this is likely to only be useful for small environments or as an example for how to do the integration, similar to the ELK stack implementation in the openstack-ansible-ops repo.\n\nOSA is about setting up OpenStack and the minimal services to accompany it. Non essential services really should, in my opinion, not be part of the mainline integrated repository - they should be \u0027user stories\u0027 which provide meaningful examples of how to integrated \u003cyour service here\u003e with OSA.","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e1f847ff7ddd7abe5ba0654517c946d373190004","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Playbook/Role impact"},{"line_number":35,"context_line":"--------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Consume upstream roles (BIND, PowerDNS, etc.). Use the role to set up and manage"},{"line_number":38,"context_line":"the backend. The os_designate role will be extended to check for the variable(s)"},{"line_number":39,"context_line":"defined by the backend role and will consume them to auto-populate the"},{"line_number":40,"context_line":"designate_pools_yaml hash."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_7380e148","line":38,"range":{"start_line":37,"start_character":47,"end_line":38,"end_character":11},"updated":"2018-12-11 17:40:59.000000000","message":"Should this spec be more opinionated about how that is architected? Best practice might have this backend be an authoritative non-recursive dns server, design decisions like that will heavily affect the test harness requirements.","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e1f847ff7ddd7abe5ba0654517c946d373190004","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Security impact"},{"line_number":48,"context_line":"---------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Depending on the backend used, minimal."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Performance impact"},{"line_number":53,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_333909a0","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":38},"updated":"2018-12-11 17:40:59.000000000","message":"Presumably the \u0027external\u0027 interface of a backend dns server is intended to be in some way \u0027public\u0027 to be of any use. Exposing additional services must come with some security impact which should be assessed. Architectural decisions in this spec will have a profound security impact.","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"564879c42ae0ad829ecdf16216f4f67f94a86cc2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Deployer impact"},{"line_number":65,"context_line":"---------------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"The deployer may need to define the network the backend server is attached."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Developer impact"},{"line_number":70,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_dd39c6cf","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":75},"updated":"2018-12-11 16:00:48.000000000","message":"This is an incomplete sentence, resulting in ambiguous meaning. Please clarify.","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"564879c42ae0ad829ecdf16216f4f67f94a86cc2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Work items"},{"line_number":94,"context_line":"----------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Extend existing openstack-ansible-os_designate role to check for"},{"line_number":97,"context_line":"  OpenStack-Ansible deployed backend servers and register them via the"},{"line_number":98,"context_line":"  designate_pools_yaml hash."},{"line_number":99,"context_line":"* Add additional backend options"},{"line_number":100,"context_line":"  (PowerDNS 4 (https://github.com/PowerDNS/pdns-ansible, etc.)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_5d461658","line":97,"range":{"start_line":96,"start_character":54,"end_line":97,"end_character":44},"updated":"2018-12-11 16:00:48.000000000","message":"I don\u0027t understand what\u0027s meant here - how would this check happen?","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"564879c42ae0ad829ecdf16216f4f67f94a86cc2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  OpenStack-Ansible deployed backend servers and register them via the"},{"line_number":98,"context_line":"  designate_pools_yaml hash."},{"line_number":99,"context_line":"* Add additional backend options"},{"line_number":100,"context_line":"  (PowerDNS 4 (https://github.com/PowerDNS/pdns-ansible, etc.)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_9d86ee5f","line":100,"updated":"2018-12-11 16:00:48.000000000","message":"I\u0027m not seeing the work item here for a playbook to use the below-mentioned roles for setting up the services... or are they going to be included from inside the os_designate role (which is a really, really bad idea because role inclusion within roles brings a bunch of issues).","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"},{"author":{"_account_id":25023,"name":"Jonathan Rosser","email":"jonathan.rosser@rd.bbc.co.uk","username":"jrosser"},"change_message_id":"e1f847ff7ddd7abe5ba0654517c946d373190004","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Testing"},{"line_number":104,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Have the openstack-ansible-os_designate gate job create and verify a domain and"},{"line_number":107,"context_line":"associated records with the new backend role, much like is already done with the"},{"line_number":108,"context_line":"test bind role used by openstack-ansible-os_designate already."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Documentation impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_b33af9be","line":107,"range":{"start_line":106,"start_character":49,"end_line":107,"end_character":10},"updated":"2018-12-11 17:40:59.000000000","message":"would this done by using the designate testing built into tempest or something more homebrew in the os_designate role? It\u0027s not clear from the text.","commit_id":"5bd691751c20cc9adcd9da6385db233951436de1"}]}