)]}'
{"id":"openstack%2Fopenstack-ansible-specs~788057","triplet_id":"openstack%2Fopenstack-ansible-specs~master~Ie9e25fd9b6aa8ac8e97e13d3d9b1e2bea4c4d762","project":"openstack/openstack-ansible-specs","branch":"master","topic":"bp/s","hashtags":[],"change_id":"Ie9e25fd9b6aa8ac8e97e13d3d9b1e2bea4c4d762","subject":"Author: yeremko \u003cAlexander.Yeremko@walmart.com\u003e Date: 2021-04-23","status":"ABANDONED","created":"2021-04-26 17:37:54.000000000","updated":"2021-04-30 17:42:54.000000000","total_comment_count":5,"unresolved_comment_count":5,"has_review_started":true,"meta_rev_id":"57b2027062a89202e37840f0ec0855000eea6445","_number":788057,"virtual_id_number":788057,"owner":{"_account_id":33396,"name":"Oleksandr Yeremko","display_name":"yeremko","email":"Alexander.Yeremko@walmart.com","username":"yeremko"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-04-26 18:28:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"all":[{"value":-1,"date":"2021-04-27 05:59:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-26 18:28:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-27 05:34:07.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"CC"},{"updated":"2021-04-27 05:59:46.000000000","updated_by":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"reviewer":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"state":"REVIEWER"}],"messages":[{"id":"e7f4e61da655a461a311e063815dc8d91ac7a706","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33396,"name":"Oleksandr Yeremko","display_name":"yeremko","email":"Alexander.Yeremko@walmart.com","username":"yeremko"},"date":"2021-04-26 17:37:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"136e35d0002e69439c1a67d705230c55d1f830ec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 18:28:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/92f6ce4b7f514fc0bbe17be5e0ea3db0 : FAILURE in 3m 59s","accounts_in_message":[],"_revision_number":1},{"id":"63ceefa3a2cda18f0fc1c1e3f7d3f00b4f925828","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-27 05:34:07.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n1. I believe wrong path has been used for the spec, since Xena release is upcoming, stein is already in EM state.\n2. Please check suggested page for the trailing whitespaces, CI won\u0027t pass otherways\n3. Really a pity you haven\u0027t joined PTG that took place previous week so we could discuss that idea 😞 Also Vault implementation is a bit broken right now, but probably it\u0027s only for Barbican and not castellan (ie https://review.opendev.org/c/openstack/barbican/+/763835)\n\nFWIW I have a Vault role locally that might be suitable and published, so it shouldn\u0027t be much effort in writing it.","accounts_in_message":[],"_revision_number":1},{"id":"eeb4dd1edd37c6e95dcb55cb35672802e489b4db","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-27 05:59:46.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)\n\nI tried to find any references in oslo.config, and I don\u0027t think it has been ever implemented. For config sources I don\u0027t see castelan - only env or url https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/sources\n\nI don\u0027t think we should discuss implementation in openstack-ansible until things are done in oslo.\n\nAnd what comes to implementation in oslo, I\u0027d actually prefer having it without 2 extra files, that actually can be implemented inside same config.\n\nI.e in Nova there\u0027s already key_manager section https://docs.openstack.org/nova/latest/configuration/config.html#key-manager (but it\u0027s used for encryption at rest rather then auth storage afaik)","accounts_in_message":[],"_revision_number":1},{"id":"7ecfc0947bb34a1491db3b5bc87f4d28812d83f4","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2021-04-27 07:02:38.000000000","message":"Patch Set 1:\n\n\u003e I tried to find any references in oslo.config, and I don\u0027t think it has been ever implemented. For config sources I don\u0027t see castelan - only env or url https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/sources\n\u003e \n\nThanks @jrosser for pointing me to the https://opendev.org/openstack/castellan/src/branch/master/castellan/_config_driver.py#L23-L29\n\nSo it\u0027s implemented. But leaving -1 to fix other comments.","accounts_in_message":[],"_revision_number":1},{"id":"57b2027062a89202e37840f0ec0855000eea6445","tag":"autogenerated:gerrit:abandon","author":{"_account_id":33396,"name":"Oleksandr Yeremko","display_name":"yeremko","email":"Alexander.Yeremko@walmart.com","username":"yeremko"},"date":"2021-04-30 17:42:54.000000000","message":"Abandoned\n\nerrors fixed and new version of spec proposed","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"86cc15b4310407f877fa70c1a6489125e9a2efde","revisions":{"86cc15b4310407f877fa70c1a6489125e9a2efde":{"kind":"REWORK","_number":1,"created":"2021-04-26 17:37:54.000000000","uploader":{"_account_id":33396,"name":"Oleksandr Yeremko","display_name":"yeremko","email":"Alexander.Yeremko@walmart.com","username":"yeremko"},"ref":"refs/changes/57/788057/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible-specs","ref":"refs/changes/57/788057/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible-specs refs/changes/57/788057/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible-specs refs/changes/57/788057/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible-specs refs/changes/57/788057/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible-specs refs/changes/57/788057/1"}}},"commit":{"parents":[{"commit":"eb2f69cfb2af709103f880c4137b9788bdbfdb5f","subject":"Replace deprecated UPPER_CONSTRAINTS_FILE variable","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-specs/commit/eb2f69cfb2af709103f880c4137b9788bdbfdb5f"}]}],"author":{"name":"Alexander Yeremko","email":"yeremko@gmail.com","date":"2021-04-26 17:37:08.000000000","tz":180},"committer":{"name":"Alexander Yeremko","email":"yeremko@gmail.com","date":"2021-04-26 17:37:08.000000000","tz":180},"subject":"Author: yeremko \u003cAlexander.Yeremko@walmart.com\u003e Date: 2021-04-23","message":"Author: yeremko \u003cAlexander.Yeremko@walmart.com\u003e\nDate: 2021-04-23\n\n  Protecting plaintext configs\n\n  Spec for automation of securing OpenStack plaintext config files is proposed\n\n  Initial blueprint:\n  https://blueprints.launchpad.net/oslo.config/+spec/protect-plaintext-passwords\n\nChange-Id: Ie9e25fd9b6aa8ac8e97e13d3d9b1e2bea4c4d762\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-specs/commit/86cc15b4310407f877fa70c1a6489125e9a2efde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible-specs/commit/86cc15b4310407f877fa70c1a6489125e9a2efde"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
