)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"41ab0240173df5020edcd1ebbce28428495ed6c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     root \u003cnish.patwa@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-17 17:20:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added tasks in nova and neutron test yml files"},{"line_number":8,"context_line":"Moved Rabbitmq and DB tasks to generic files."},{"line_number":9,"context_line":"Change-Id: Ibd94e1ebdce45b782ab447ca3db5068588a1e368"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_dee55738","line":7,"updated":"2016-08-17 17:26:42.000000000","message":"For the commit message, rather than describing only what the change does, instead detail why it was changed. What was incorrect about the previous behavior, and/or what is improved by the change?","commit_id":"dd503e5341e0cd8a86bc0328d62275c79ad12d35"}],"create-grant-db.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"- name: DB Playbook"},{"line_number":16,"context_line":"  hosts: all_containers"},{"line_number":17,"context_line":"  tasks: "},{"line_number":18,"context_line":"  - name: Create DB for service"},{"line_number":19,"context_line":"    mysql_db:"},{"line_number":20,"context_line":"      login_user: \"root\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_520f5336","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":9},"updated":"2016-08-18 16:06:21.000000000","message":"remove trailing whitespace","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      state: \"present\""},{"line_number":25,"context_line":"    delegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\""},{"line_number":26,"context_line":"    when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":27,"context_line":"    tags:"},{"line_number":28,"context_line":"      - mysql-db-setup"},{"line_number":29,"context_line":"  - name: Grant access to the DB for the service"},{"line_number":30,"context_line":"    mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_0d082027","line":27,"updated":"2016-08-18 16:06:21.000000000","message":"Nit, no need for tags here","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0e0fc28bfbf5963b2307346d348fd75072c81a22","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"- name: DB Playbook"},{"line_number":16,"context_line":"  hosts: all_containers"},{"line_number":17,"context_line":"  tasks:"},{"line_number":18,"context_line":"  - name: Create DB for service"},{"line_number":19,"context_line":"    mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_f17d2f1d","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":23},"updated":"2016-08-22 13:11:49.000000000","message":"We have two choices for this file:\nBe a playbook or be tasks.\n\nHere you define it as a playbook, but include it in the other files as tasks. This will not work.\n\nSo, if we use playbooks:\nInstead of doing hosts: all_containers and doing delegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\", we can directly hit the proper node by setting\nhosts: galera_all[0]\n\nWe then have to remove the delegate_to: and the when:, and update the level of the inclusion in the main calling playbook.\n\nIf we use tasks include, we have to remove hosts: \nIt\u0027s then gonna delegate to the proper galera nodes when the target inventory node is reached.","commit_id":"c56ef380f54b1732a41a933e4801a5b1bb7025ae"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0e0fc28bfbf5963b2307346d348fd75072c81a22","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      login_host: \"localhost\""},{"line_number":23,"context_line":"      name: \"{{ db_name }}\""},{"line_number":24,"context_line":"      state: \"present\""},{"line_number":25,"context_line":"    delegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\""},{"line_number":26,"context_line":"    when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":27,"context_line":"  - name: Grant access to the DB for the service"},{"line_number":28,"context_line":"    mysql_user:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_5193634f","line":25,"updated":"2016-08-22 13:11:49.000000000","message":"see comment above","commit_id":"c56ef380f54b1732a41a933e4801a5b1bb7025ae"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0e0fc28bfbf5963b2307346d348fd75072c81a22","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      name: \"{{ db_name }}\""},{"line_number":24,"context_line":"      state: \"present\""},{"line_number":25,"context_line":"    delegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\""},{"line_number":26,"context_line":"    when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":27,"context_line":"  - name: Grant access to the DB for the service"},{"line_number":28,"context_line":"    mysql_user:"},{"line_number":29,"context_line":"      login_user: \"root\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_b16e17ff","line":26,"updated":"2016-08-22 13:11:49.000000000","message":"if you plan to use this file as playbook, you\u0027re gonna have to find another way.\n\nIf you plan to use this file as tasks, maybe you should replace inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0] by inventory_hostname \u003d\u003d \"{{ group_name }}\"","commit_id":"c56ef380f54b1732a41a933e4801a5b1bb7025ae"}],"ensure-rabbitmq.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"- name: RabbitMQ Playbook"},{"line_number":16,"context_line":"  hosts: all_containers"},{"line_number":17,"context_line":"  tasks:"},{"line_number":18,"context_line":"  - name: Ensure rabbitmq vhost"},{"line_number":19,"context_line":"    rabbitmq_vhost:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_ed21449f","line":16,"updated":"2016-08-18 16:06:21.000000000","message":"This play should target rabbitmq_all","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      state: \"present\""},{"line_number":22,"context_line":"    delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":23,"context_line":"    when: inventory_hostname \u003d\u003d \"{{ group_name }}\""},{"line_number":24,"context_line":"    tags:"},{"line_number":25,"context_line":"      - \"{{service_name}}-rabbitmq\""},{"line_number":26,"context_line":"      - \"{{service_name}}-rabbitmq-vhost\""},{"line_number":27,"context_line":"  - name: Ensure rabbitmq user"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_8d1c106b","line":24,"updated":"2016-08-18 16:06:21.000000000","message":"No need for tags here","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      state: \"present\""},{"line_number":36,"context_line":"    delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":37,"context_line":"    when: inventory_hostname \u003d\u003d \"{{ group_name }}\""},{"line_number":38,"context_line":"    tags:"},{"line_number":39,"context_line":"      - \"{{service_name}}-rabbitmq\""},{"line_number":40,"context_line":"      - \"{{service_name}}-rabbitmq-user\""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_6d171445","line":38,"updated":"2016-08-18 16:06:21.000000000","message":"Likewise, no need for the tags","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"}],"setting-netpool-variables.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ac371cc_8baa1f6f","updated":"2016-08-15 08:44:32.000000000","message":"the filename should be named \"setting-nodepool-variables\" instead.","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check if this is an OpenStack-CI nodepool instance"},{"line_number":2,"context_line":"      stat:"},{"line_number":3,"context_line":"        path: /etc/nodepool/provider"},{"line_number":4,"context_line":"      register: nodepool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_cbe1b7d2","line":1,"updated":"2016-08-15 08:44:32.000000000","message":"the content of the file should be more standard, like:\n\n- name: Setting nodepool variables\n  hosts: all\n  gather_facts: false","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check if this is an OpenStack-CI nodepool instance"},{"line_number":2,"context_line":"      stat:"},{"line_number":3,"context_line":"        path: /etc/nodepool/provider"},{"line_number":4,"context_line":"      register: nodepool"},{"line_number":5,"context_line":"      delegate_to: localhost"},{"line_number":6,"context_line":"- name: Determine the existing Ubuntu repo URL (only on OpenStack-CI)"},{"line_number":7,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":8,"context_line":"      register: ubuntu_repo_url"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_8bd85f1f","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":28},"updated":"2016-08-15 08:44:32.000000000","message":"the identation seems off.","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      register: nodepool"},{"line_number":5,"context_line":"      delegate_to: localhost"},{"line_number":6,"context_line":"- name: Determine the existing Ubuntu repo URL (only on OpenStack-CI)"},{"line_number":7,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":8,"context_line":"      register: ubuntu_repo_url"},{"line_number":9,"context_line":"      changed_when: false"},{"line_number":10,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":11,"context_line":"      delegate_to: localhost"},{"line_number":12,"context_line":"- name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":13,"context_line":"      set_fact:"},{"line_number":14,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_8befbfaf","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":28},"updated":"2016-08-15 08:44:32.000000000","message":"Same issue with identation: too many spaces (2 are enough)","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":11,"context_line":"      delegate_to: localhost"},{"line_number":12,"context_line":"- name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":13,"context_line":"      set_fact:"},{"line_number":14,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""},{"line_number":15,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":16,"context_line":"- name: Include OVS testing vars"},{"line_number":17,"context_line":"      include_vars: ovs_test_vars.yml"},{"line_number":18,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_4b3ca72f","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":39},"updated":"2016-08-15 08:44:32.000000000","message":"identation here too.","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      set_fact:"},{"line_number":14,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""},{"line_number":15,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":16,"context_line":"- name: Include OVS testing vars"},{"line_number":17,"context_line":"      include_vars: ovs_test_vars.yml"},{"line_number":18,"context_line":"      when:"},{"line_number":19,"context_line":"        - groups[\u0027neutron_openvswitch_agent\u0027] | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_cb16d7a6","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":58},"updated":"2016-08-15 08:44:32.000000000","message":"this should be removed from generic nodepool file and introduced in neutron plays","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"}],"setting-nodepool-variables.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"114e7e8c45281cb202295dff22dcc4aead865a4f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        path: /etc/nodepool/provider"},{"line_number":23,"context_line":"      register: nodepool"},{"line_number":24,"context_line":"      delegate_to: localhost"},{"line_number":25,"context_line":"    - name: Determine the existing Ubuntu repo URL (only on OpenStack-CI)"},{"line_number":26,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":27,"context_line":"      register: ubuntu_repo_url"},{"line_number":28,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_7a7abaf2","line":25,"updated":"2016-08-16 15:05:47.000000000","message":"This should have a when clause so this task and the one below only run on Ubuntu CI hosts","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d86f5d763bd09944db762849eb187c8354d2ea92","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        path: /etc/nodepool/provider"},{"line_number":23,"context_line":"      register: nodepool"},{"line_number":24,"context_line":"      delegate_to: localhost"},{"line_number":25,"context_line":"    - name: Determine the existing Ubuntu repo URL (only on OpenStack-CI)"},{"line_number":26,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":27,"context_line":"      register: ubuntu_repo_url"},{"line_number":28,"context_line":"      changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_df43a011","line":25,"in_reply_to":"3ac371cc_7a7abaf2","updated":"2016-08-17 14:54:57.000000000","message":"Agreed","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":27,"context_line":"      register: ubuntu_repo_url"},{"line_number":28,"context_line":"      changed_when: false"},{"line_number":29,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027 or  nodepool.stat.exists \u003d\u003d True"},{"line_number":30,"context_line":"      delegate_to: localhost"},{"line_number":31,"context_line":"    - name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":32,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_cd9d68bd","line":29,"range":{"start_line":29,"start_character":40,"end_line":29,"end_character":41},"updated":"2016-08-18 16:06:21.000000000","message":"remove extraneous space","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    - name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""},{"line_number":34,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027 or  nodepool.stat.exists \u003d\u003d True"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_6db3944d","line":34,"range":{"start_line":34,"start_character":40,"end_line":34,"end_character":41},"updated":"2016-08-18 16:06:21.000000000","message":"see above","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"39d5f18c51ef7fefad21eb6ef2ad0df3ebe9611f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":27,"context_line":"      register: ubuntu_repo_url"},{"line_number":28,"context_line":"      changed_when: false"},{"line_number":29,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027 or nodepool.stat.exists \u003d\u003d True"},{"line_number":30,"context_line":"      delegate_to: localhost"},{"line_number":31,"context_line":"    - name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":32,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1ac06dbe_356d4ecd","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":39},"updated":"2016-08-24 15:27:42.000000000","message":"Shouldn\u0027t this be an \"and\"","commit_id":"583fd3b913c226ad56bdd71c7757d04a694103cc"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"39d5f18c51ef7fefad21eb6ef2ad0df3ebe9611f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    - name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":32,"context_line":"      set_fact:"},{"line_number":33,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""},{"line_number":34,"context_line":"      when: ansible_pkg_mgr \u003d\u003d \u0027apt\u0027 or nodepool.stat.exists \u003d\u003d True"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1ac06dbe_955ec210","line":34,"range":{"start_line":34,"start_character":37,"end_line":34,"end_character":39},"updated":"2016-08-24 15:27:42.000000000","message":"likewise, would think this should be an \"and\"","commit_id":"583fd3b913c226ad56bdd71c7757d04a694103cc"}],"test-install-glance.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"39d5f18c51ef7fefad21eb6ef2ad0df3ebe9611f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      vhost_name: \"{{ glance_rabbitmq_vhost }}\""},{"line_number":24,"context_line":"      user_name: \"{{ glance_rabbitmq_userid }}\""},{"line_number":25,"context_line":"      user_password: \"{{ glance_rabbitmq_password }}\""},{"line_number":26,"context_line":"      group_name: groups[\u0027glance_all\u0027][0]"},{"line_number":27,"context_line":"    - include: create-grant-db.yml"},{"line_number":28,"context_line":"      db_name: \"{{  glance_galera_database }}\""},{"line_number":29,"context_line":"      db_password: \"{{ glance_container_mysql_password }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1ac06dbe_35f26e07","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":16},"updated":"2016-08-24 15:27:42.000000000","message":"This isn\u0027t a group, its a hostname. I think the variable naming choice here is overly confusing.","commit_id":"583fd3b913c226ad56bdd71c7757d04a694103cc"}],"test-install-keystone.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - name: Set keystone_messaging fact no rabbit"},{"line_number":22,"context_line":"      set_fact:"},{"line_number":23,"context_line":"        keystone_messaging_enabled: false"},{"line_number":24,"context_line":"      when: groups[\u0027rabbitmq_all\u0027] is not defined"},{"line_number":25,"context_line":"    - name: Set keystone_messaging fact rabbit"},{"line_number":26,"context_line":"      set_fact:"},{"line_number":27,"context_line":"        keystone_messaging_enabled: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_2dccfc87","line":24,"updated":"2016-08-18 16:06:21.000000000","message":"This can be collapsed to a single set_fact task using the ternary filter to test the group definition","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a3ab90a87243879548b211aa175a2eaf8fa14a71","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Set keystone_messaging fact"},{"line_number":22,"context_line":"      set_fact:"},{"line_number":23,"context_line":"        keystone_messaging_enabled: \"{{ groups[\u0027rabbitmq_all\u0027] is defined | ternery(true,false) }}\""},{"line_number":24,"context_line":"    - include: ensure-rabbitmq.yml"},{"line_number":25,"context_line":"      service_name: \"keystone\""},{"line_number":26,"context_line":"      vhost_name: \"{{ keystone_rabbitmq_vhost }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1ac06dbe_8a8478d4","line":23,"range":{"start_line":23,"start_character":80,"end_line":23,"end_character":81},"updated":"2016-08-22 16:05:22.000000000","message":"a","commit_id":"badfc8b97b8a035579b1c50c7525597630d99397"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"39d5f18c51ef7fefad21eb6ef2ad0df3ebe9611f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Set keystone_messaging fact"},{"line_number":22,"context_line":"      set_fact:"},{"line_number":23,"context_line":"        keystone_messaging_enabled: \"{{ groups[\u0027rabbitmq_all\u0027] is defined | ternary(true,false) }}\""},{"line_number":24,"context_line":"    - include: ensure-rabbitmq.yml"},{"line_number":25,"context_line":"      service_name: \"keystone\""},{"line_number":26,"context_line":"      vhost_name: \"{{ keystone_rabbitmq_vhost }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1ac06dbe_95ba4209","line":23,"updated":"2016-08-24 15:27:42.000000000","message":"This can just be:\n\nkeystone_messaging_enabled: \"{{ groups[\u0027rabbitmq_all\u0027 is defined }}\"","commit_id":"583fd3b913c226ad56bdd71c7757d04a694103cc"}],"test-install-neutron.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"114e7e8c45281cb202295dff22dcc4aead865a4f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: setting-netpool-variables.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Make /lib/modules accessible on neutron_agent containers"},{"line_number":19,"context_line":"  hosts: neutron_agent"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_3a4b22cb","line":16,"updated":"2016-08-16 15:05:47.000000000","message":"Name changed to nodepool, so it needs to change here","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d86f5d763bd09944db762849eb187c8354d2ea92","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: setting-netpool-variables.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Make /lib/modules accessible on neutron_agent containers"},{"line_number":19,"context_line":"  hosts: neutron_agent"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_1f4a5826","line":16,"in_reply_to":"3ac371cc_3a4b22cb","updated":"2016-08-17 14:54:57.000000000","message":"Agreed","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d86f5d763bd09944db762849eb187c8354d2ea92","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      when: inventory_hostname \u003d\u003d groups[\u0027neutron_all\u0027][0]"},{"line_number":110,"context_line":"      tags:"},{"line_number":111,"context_line":"        - mysql-db-setup"},{"line_number":112,"context_line":"    - name: Include OVS testing vars"},{"line_number":113,"context_line":"      include_vars: ovs_test_vars.yml"},{"line_number":114,"context_line":"      when:"},{"line_number":115,"context_line":"        - groups[\u0027neutron_openvswitch_agent\u0027] | length \u003e 0"},{"line_number":116,"context_line":"  roles:"},{"line_number":117,"context_line":"    - role: \"{{ neutron_rolename | default(\u0027os_neutron\u0027) }}\""},{"line_number":118,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_1f2418c3","line":115,"range":{"start_line":112,"start_character":0,"end_line":115,"end_character":58},"updated":"2016-08-17 14:54:57.000000000","message":"Could we remove this part? It seems specific to neutron gates instead of being generic.","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"}],"test-install-nova.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b41fa0b607a5590cf1f44135a36c6b3c872766de","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":82,"context_line":"      tags:"},{"line_number":83,"context_line":"        - mysql-db-setup"},{"line_number":84,"context_line":"    - name: Check if this is an OpenStack-CI nodepool instance"},{"line_number":85,"context_line":"      stat:"},{"line_number":86,"context_line":"        path: /etc/nodepool/provider"},{"line_number":87,"context_line":"      register: nodepool"},{"line_number":88,"context_line":"      delegate_to: localhost"},{"line_number":89,"context_line":"    - name: Determine the existing Ubuntu repo URL (only on OpenStack-CI)"},{"line_number":90,"context_line":"      shell: \u0027awk \"/^deb .*ubuntu\\/? {{ ansible_distribution_release }} main/ {print \\$2; exit}\" /etc/apt/sources.list\u0027"},{"line_number":91,"context_line":"      register: ubuntu_repo_url"},{"line_number":92,"context_line":"      changed_when: false"},{"line_number":93,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":94,"context_line":"      delegate_to: localhost"},{"line_number":95,"context_line":"    - name: Set Ubuntu Cloud Archive repo URL based on discovered information"},{"line_number":96,"context_line":"      set_fact:"},{"line_number":97,"context_line":"        uca_apt_repo_url: \"{{ ubuntu_repo_url.stdout | netorigin }}/ubuntu-cloud-archive\""},{"line_number":98,"context_line":"      when: nodepool.stat.exists | bool"},{"line_number":99,"context_line":"  roles:"},{"line_number":100,"context_line":"    - role: \"{{ nova_rolename | default(\u0027os_nova\u0027) }}\""},{"line_number":101,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_c3d072fa","line":98,"range":{"start_line":84,"start_character":0,"end_line":98,"end_character":39},"updated":"2016-08-12 17:05:04.000000000","message":"Because this content is the same in the other file edited in this commit, wouldn\u0027t it be better to create a new file like \"setting-netpool-variables.yml\" and include this new task file on both consuming task files?","commit_id":"e5c447e6a965c66d0c5e01d4939a698a06ef2e98"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0d824b84a8ff033373939012d8eda2cad489aa30","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        - mysql-db-setup"},{"line_number":84,"context_line":"  roles:"},{"line_number":85,"context_line":"    - role: \"{{ nova_rolename | default(\u0027os_nova\u0027) }}\""},{"line_number":86,"context_line":"  include: setting-netpool-variables.yml"},{"line_number":87,"context_line":"  vars_files:"},{"line_number":88,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3ac371cc_0bd62fc5","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":40},"updated":"2016-08-15 08:44:32.000000000","message":"IMO, the include should be the first line (I mean after the license and an empty line).\n\nIt should also have a \"-\" as first character","commit_id":"2202a74885e994bff1e0b78995ed6f0026688770"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d86f5d763bd09944db762849eb187c8354d2ea92","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: setting-netpool-variables.yml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Playbook for deploying nova"},{"line_number":19,"context_line":"  hosts: nova_all"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_ff0f7c36","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":22},"updated":"2016-08-17 14:54:57.000000000","message":"nodepool here too","commit_id":"8fb4b87a89227960eae138d077c21dd151990b6f"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"b0bf8a0a7663a590968fa1aa2f2047de4b591a61","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        - libffi-dev"},{"line_number":32,"context_line":"        - pkg-config"},{"line_number":33,"context_line":"        - libvirt-dev"},{"line_number":34,"context_line":"      when: inventory_hostname in groups[\u0027nova_all\u0027]"},{"line_number":35,"context_line":"    - include: ensure-rabbitmq.yml"},{"line_number":36,"context_line":"      service_name: \"nova\""},{"line_number":37,"context_line":"      vhost_name: \"{{ nova_rabbitmq_vhost }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3ac371cc_edb144e1","line":34,"updated":"2016-08-18 16:06:21.000000000","message":"add condition around ansible_package_mgr","commit_id":"87e4692c895e4e695f30b55f5b6530caa8c90dd8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0e0fc28bfbf5963b2307346d348fd75072c81a22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      db_name: \"{{ nova_galera_database }}\""},{"line_number":45,"context_line":"      db_password: \"{{ nova_container_mysql_password }}\""},{"line_number":46,"context_line":"      group_name: groups[\u0027nova_all\u0027][0]"},{"line_number":47,"context_line":"    - name: Create API DB for service"},{"line_number":48,"context_line":"      mysql_db:"},{"line_number":49,"context_line":"        login_user: \"{{ galera_root_user }}\""},{"line_number":50,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":51,"context_line":"        login_host: \"{{ nova_api_galera_address }}\""},{"line_number":52,"context_line":"        name: \"{{ nova_api_galera_database }}\""},{"line_number":53,"context_line":"        state: \"present\""},{"line_number":54,"context_line":"      when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":55,"context_line":"    - name: Grant access to the API DB for the service"},{"line_number":56,"context_line":"      mysql_user:"},{"line_number":57,"context_line":"        login_user: \"{{ galera_root_user }}\""},{"line_number":58,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":59,"context_line":"        login_host: \"{{ nova_api_galera_address }}\""},{"line_number":60,"context_line":"        name: \"{{ nova_api_galera_user }}\""},{"line_number":61,"context_line":"        password: \"{{ nova_api_container_mysql_password }}\""},{"line_number":62,"context_line":"        host: \"{{ item }}\""},{"line_number":63,"context_line":"        state: \"present\""},{"line_number":64,"context_line":"        priv: \"{{ nova_api_galera_database }}.*:ALL\""},{"line_number":65,"context_line":"      with_items:"},{"line_number":66,"context_line":"        - \"localhost\""},{"line_number":67,"context_line":"        - \"%\""},{"line_number":68,"context_line":"      when: inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":69,"context_line":"  roles:"},{"line_number":70,"context_line":"    - role: \"{{ nova_rolename | default(\u0027os_nova\u0027) }}\""},{"line_number":71,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ac06dbe_915cbbee","line":68,"range":{"start_line":47,"start_character":0,"end_line":68,"end_character":55},"updated":"2016-08-22 13:11:49.000000000","message":"We\u0027ll probably want to remove this.","commit_id":"c56ef380f54b1732a41a933e4801a5b1bb7025ae"}]}