)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c17695bf8581989ee282a0f2dd49f542510e8d28","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update for openstack-hosts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"this change adds the `test-install-hostmachines.yml` and"},{"line_number":10,"context_line":"a `test-force-bin-update.yml` common play. The common play"},{"line_number":11,"context_line":"has been added to the isntall test playbooks that use binary"},{"line_number":12,"context_line":"packages in their pre-steps. The \"test-install-hostmachines.yml\""},{"line_number":13,"context_line":"play is used to test the openstack-hosts role."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib2ec8840966aea574fef7387cee2ffabd597b4cb"},{"line_number":16,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_ff08912f","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":46},"updated":"2016-08-25 01:50:40.000000000","message":"This doesn\u0027t match up. I wouldn\u0027t bother explaining what\u0027s included - rather just why.","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"}],"common-tasks/test-force-package-cache-update.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2660c2e3c931c6174208e028aa54f0b5a7a68f1b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: First ensure apt cache is always refreshed"},{"line_number":17,"context_line":"  apt:"},{"line_number":18,"context_line":"    update_cache: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_2d48435b","line":15,"updated":"2016-08-25 02:15:12.000000000","message":"I would think that the cache expiration tasks would be of value here - perhaps not for gate testing itself, but instead for when you\u0027re doing the tests yourself repeatedly.","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ed7bb067c88202ab1e9a7838251886745d835847","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: First ensure apt cache is always refreshed"},{"line_number":17,"context_line":"  apt:"},{"line_number":18,"context_line":"    update_cache: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_424bc72b","line":15,"in_reply_to":"1ac06dbe_2d48435b","updated":"2016-08-26 00:08:05.000000000","message":"there\u0027s no need to add the `stat` task, simply updating the cache always is good enough for the tests to run.","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2660c2e3c931c6174208e028aa54f0b5a7a68f1b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  apt:"},{"line_number":18,"context_line":"    update_cache: true"},{"line_number":19,"context_line":"  when:"},{"line_number":20,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":21,"context_line":"- name: First ensure yum cache is always refreshed"},{"line_number":22,"context_line":"  yum:"},{"line_number":23,"context_line":"    update_cache: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_0d3aa7cd","line":20,"updated":"2016-08-25 02:15:12.000000000","message":"Can we have a line break between the tasks for improved readability?","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"}],"test-force-bin-update.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"d88559e5b06d53186c2f3d24c43f8d6fbff71ca2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_b9ec7990","line":1,"updated":"2016-08-25 00:58:35.000000000","message":"Maybe rename to test-force-package-cache-update for clarity","commit_id":"016b7cc1b94f23f9931c32cc6f328af0a8d1678c"}],"test-install-hostmachines.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"d88559e5b06d53186c2f3d24c43f8d6fbff71ca2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - include: \"test-force-bin-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_f9fef136","line":23,"range":{"start_line":23,"start_character":16,"end_line":23,"end_character":24},"updated":"2016-08-25 00:58:35.000000000","message":"think you\u0027ll need to specify the role name here","commit_id":"016b7cc1b94f23f9931c32cc6f328af0a8d1678c"}],"test-install-neutron.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"d88559e5b06d53186c2f3d24c43f8d6fbff71ca2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  user: root"},{"line_number":49,"context_line":"  gather_facts: true"},{"line_number":50,"context_line":"  pre_tasks:"},{"line_number":51,"context_line":"    - include: \"test-force-bin-update.yml\""},{"line_number":52,"context_line":"    # NOTE: These are typically installed in the repo server where we build the"},{"line_number":53,"context_line":"    #       neutron wheel"},{"line_number":54,"context_line":"    - name: Install packages required to build neutron python package"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac06dbe_7999611f","line":51,"updated":"2016-08-25 00:58:35.000000000","message":"Let\u0027s include this in the test-setup-host play instead...","commit_id":"016b7cc1b94f23f9931c32cc6f328af0a8d1678c"}],"test-install-openstack-hosts.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c17695bf8581989ee282a0f2dd49f542510e8d28","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Playbook for role testing"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  gather_facts: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_9f499d91","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"updated":"2016-08-25 01:50:40.000000000","message":"The name should be more descriptive of what it\u0027s doing.","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c17695bf8581989ee282a0f2dd49f542510e8d28","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_7fc021e1","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":38},"updated":"2016-08-25 01:50:40.000000000","message":"This will need the actual role name, won\u0027t it?","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3fcb0445c09213986e08675460d53592dc54b2d2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_02f55682","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":38},"in_reply_to":"1ac06dbe_7fc021e1","updated":"2016-08-25 02:03:15.000000000","message":"Done","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c17695bf8581989ee282a0f2dd49f542510e8d28","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"},{"line_number":27,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_1fb00d8b","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":76},"updated":"2016-08-25 01:50:40.000000000","message":"Why are these vars here?","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3fcb0445c09213986e08675460d53592dc54b2d2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"},{"line_number":27,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_e2dc7a48","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":76},"in_reply_to":"1ac06dbe_1fb00d8b","updated":"2016-08-25 02:03:15.000000000","message":"they\u0027re part of the original test and exercise the global environment variable settings.","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"68473d223c9d693006730f6a0ee3f9f8267c1670","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ rolename | basename }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"},{"line_number":27,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1ac06dbe_0d13c75d","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":76},"in_reply_to":"1ac06dbe_e2dc7a48","updated":"2016-08-25 02:11:20.000000000","message":"If the goal is to exercise something then that should go into the test-vars.yml for the role itself. If it\u0027s essential for the execution of this role across all roles, then it should be in the common test-vars.yml.","commit_id":"6b68a02980e1bb4b71e31762b168825ed6ebfbe0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2660c2e3c931c6174208e028aa54f0b5a7a68f1b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Test the openstack-host role"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  gather_facts: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_4d62dfd9","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":12},"updated":"2016-08-25 02:15:12.000000000","message":"Perhaps \u0027Execute\u0027 instead of test? The purpose of this playbook is simply to execute it - other playbooks will test.","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ed7bb067c88202ab1e9a7838251886745d835847","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Test the openstack-host role"},{"line_number":17,"context_line":"  hosts: localhost"},{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  gather_facts: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_824b0f59","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":12},"in_reply_to":"1ac06dbe_4d62dfd9","updated":"2016-08-26 00:08:05.000000000","message":"Done","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2660c2e3c931c6174208e028aa54f0b5a7a68f1b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - include: \"common-tasks/test-force-package-cache-update.yml\""},{"line_number":22,"context_line":"  roles:"},{"line_number":23,"context_line":"    - role: \"{{ openstack_hosts_rolename | default(\u0027openstack_hosts\u0027) }}\""},{"line_number":24,"context_line":"      global_environment_variables:"},{"line_number":25,"context_line":"        PATH: \"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":26,"context_line":"  vars_files:"},{"line_number":27,"context_line":"    - test-vars.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1ac06dbe_0daf47e4","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":76},"updated":"2016-08-25 02:15:12.000000000","message":"See comment in previous patch set.","commit_id":"ad7f08ea2a3d6f01b1c856c382cf5e22df055006"}]}