)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the ansible-role-requirements file to the tests"},{"line_number":10,"context_line":"repo based on data provided by OpenStack project-config. To build"},{"line_number":11,"context_line":"the file a script has been prodiced that will extract our roles"},{"line_number":12,"context_line":"from project-config and insert them into a standard"},{"line_number":13,"context_line":"ansible-role-requirements format."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_f0ed608c","line":11,"updated":"2016-09-05 11:53:55.000000000","message":"Nit: should this be \"produced?\"","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"}],"ansible-role-requirements-gen.sh":[{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Simple script to generate a new ansible role requirements file."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_707f90aa","line":19,"updated":"2016-09-05 11:53:55.000000000","message":"Might be good to enclose this in quotes (also when referenced) in case dir has special chars","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Simple script to generate a new ansible role requirements file."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_b105be15","line":19,"in_reply_to":"9a89bdaa_707f90aa","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_5030cc01","line":20,"updated":"2016-09-05 11:53:55.000000000","message":"Is it possible that this might exist already and cause a problem? If so, could perhaps add seconds since epoch to make it a bit more unique:\nWORKSPACE\u003d\"/tmp/workspace-$(date +%s)\"","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_545b802e","line":20,"in_reply_to":"9a89bdaa_5030cc01","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dfa3bc8b5d12698ee3079b473218507da091ee19","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_96c7ac11","line":20,"in_reply_to":"9a89bdaa_5030cc01","updated":"2016-09-05 12:24:42.000000000","message":"or use mktemp?","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_74408436","line":20,"in_reply_to":"9a89bdaa_96c7ac11","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"ac34cba4a4983c281980e26319c6a16130811801","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_9ca0abf6","line":20,"in_reply_to":"9a89bdaa_96c7ac11","updated":"2016-09-05 12:42:58.000000000","message":"Yep, that\u0027s even better :-) Also, not sure if we should clean it up at the end?","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_943d08be","line":20,"in_reply_to":"9a89bdaa_9ca0abf6","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"282ec00fea10d211bba6dfc0c2ea40c8a18c1987","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_bc264f66","line":20,"in_reply_to":"9a89bdaa_9ca0abf6","updated":"2016-09-05 12:46:45.000000000","message":"Perhaps allow the WORKSPACE var to be set through export, but default to using mktmp. Also then do a cleanup, but only if a flag is set to do so (and make that the default behaviour).","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BRANCH\u003d\"${BRANCH:-master}\""},{"line_number":19,"context_line":"CURRENT_DIR\u003d$(pwd)"},{"line_number":20,"context_line":"WORKSPACE\u003d/tmp/workspace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function role_entry {"},{"line_number":23,"context_line":"    cat \u003e\u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\" \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_7495e486","line":20,"in_reply_to":"9a89bdaa_bc264f66","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"pushd \"${WORKSPACE}/project-config\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Store information about all of our known repos"},{"line_number":39,"context_line":"PROJECTS\u003d$(python \u003c\u003cEOR"},{"line_number":40,"context_line":"import yaml"},{"line_number":41,"context_line":"with open(\u0027gerrit/projects.yaml\u0027) as f:"},{"line_number":42,"context_line":"    projects \u003d yaml.load(f.read())"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_b32be281","line":39,"updated":"2016-09-05 11:53:55.000000000","message":"Should we make this /usr/bin/env python?","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dfa3bc8b5d12698ee3079b473218507da091ee19","unresolved":false,"context_lines":[{"line_number":43,"context_line":"for project in projects:"},{"line_number":44,"context_line":"    if project[\u0027project\u0027].startswith(\u0027openstack/openstack-ansible\u0027):"},{"line_number":45,"context_line":"        project_name \u003d project[\u0027project\u0027].split(\u0027/\u0027)[-1].split(\u0027openstack-ansible-\u0027)[-1]"},{"line_number":46,"context_line":"        project_github \u003d \u0027https://github.com/%s\u0027 % project[\u0027project\u0027]"},{"line_number":47,"context_line":"        print(\u0027%s|%s\u0027 % (project_name, project_github))"},{"line_number":48,"context_line":"EOR"},{"line_number":49,"context_line":")"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_56828495","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":44},"updated":"2016-09-05 12:24:42.000000000","message":"As the role requirements will be used in OpenStack-CI, this should rather make use of the git.o.o sources instead of github.","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"EOR"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# If an existing role requirements file is it\u0027ll be removed."},{"line_number":52,"context_line":"echo \u0027---\u0027 \u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Generate the ansible role requirements file."}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_f35c8a27","line":51,"updated":"2016-09-05 11:53:55.000000000","message":"Nit: is \u003d\u003d exists?","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"EOR"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# If an existing role requirements file is it\u0027ll be removed."},{"line_number":52,"context_line":"echo \u0027---\u0027 \u003e \"${CURRENT_DIR}/ansible-role-requirements.yaml\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Generate the ansible role requirements file."}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_94d98886","line":51,"in_reply_to":"9a89bdaa_f35c8a27","updated":"2016-09-09 05:32:54.000000000","message":"Done","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"969820c3c3e5e593609f90107392715768da0af4","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Generate the ansible role requirements file."},{"line_number":55,"context_line":"for project in ${PROJECTS}; do"},{"line_number":56,"context_line":"    git clone ${project#*\u0027|\u0027} \"${WORKSPACE}/${project%%\u0027|\u0027*}\""},{"line_number":57,"context_line":"    pushd \"${WORKSPACE}/${project%%\u0027|\u0027*}\""},{"line_number":58,"context_line":"      git fetch --all"},{"line_number":59,"context_line":"      git checkout \"${BRANCH}\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9a89bdaa_d37ce674","line":56,"updated":"2016-09-05 11:53:55.000000000","message":"could you just do -b \"${BRANCH}\" here to save the following lines?","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"}],"ansible-role-requirements.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dfa3bc8b5d12698ee3079b473218507da091ee19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a89bdaa_e1aaf4d3","updated":"2016-09-05 12:24:42.000000000","message":"I don\u0027t know how usable this file is going to be. The roles have to be listed in import order - ie the meta deps must come first, then those that consume them must come later. If this ordering isn\u0027t right, then the ansible-galaxy role download fails to recognise that it already has the role and fails. This can be worked around with making ansible-galaxy ignore errors, but then we also ignore legitimate errors and get more obscure failures further in the test execution.","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9f29c30819301ed1f7e91ef9ec2b84e329050f6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a89bdaa_34251c5c","in_reply_to":"9a89bdaa_e1aaf4d3","updated":"2016-09-09 05:32:54.000000000","message":"Since we\u0027ve moved to 2.1 I\u0027ve not seen the ordering issues like we used to have with 1.9.x while trying to leverage galaxy. That said, if we could get some repos testing with the file we could rule out any potential issues. The single requirements file will be particularly useful in the role based gates as there will be a single source of truth instead of the sprawl we have today.","commit_id":"9873220e7f01a04c73e16716344337c6b5038f12"}]}
