)]}'
{"README.rst":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0142eb35a9779144ec7f1befbaf76c7080d6f627","unresolved":false,"context_lines":[{"line_number":6,"context_line":"integrate new projects, and ensure that code duplication is minimized whilst"},{"line_number":7,"context_line":"allowing the addition of new testing scenarios with greater ease."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Roles Currently using the ``openstack-ansible-tests`` repository"},{"line_number":10,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- openstack-ansible-galera_server"},{"line_number":13,"context_line":"- openstack-ansible-tests"},{"line_number":14,"context_line":"- openstack-ansible-os_rally"},{"line_number":15,"context_line":"- openstack-ansible-memcached_server"},{"line_number":16,"context_line":"- openstack-ansible-openstack_hosts"},{"line_number":17,"context_line":"- openstack-ansible-repo_build"},{"line_number":18,"context_line":"- openstack-ansible-repo_server"},{"line_number":19,"context_line":"- openstack-ansible-lxc_container_create"},{"line_number":20,"context_line":"- openstack-ansible-os_keystone"},{"line_number":21,"context_line":"- openstack-ansible-os_aodh"},{"line_number":22,"context_line":"- openstack-ansible-os_zaqar"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Variables are generic and based on inventory so variable overrides should be"},{"line_number":25,"context_line":"able to be very minimal."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Role Integration"},{"line_number":28,"context_line":"~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7a8ec9b2_5512fc09","line":25,"range":{"start_line":9,"start_character":0,"end_line":25,"end_character":24},"updated":"2016-09-16 14:28:17.000000000","message":"Do we need to maintain this list?\n\nWe should just go to the role and check the tox file.","commit_id":"f4eb09c498a6ec88effb40140572138aee8c2892"}],"network_interfaces/debian_interface_default.cfg.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dbe0e546413c3891d7ce518cb054aafaa0697eb3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    address {{ item.ip_addr | default(\u002710.1.0.1\u0027) }}"},{"line_number":9,"context_line":"    netmask {{ item.netmask | default(\u0027255.255.255.0\u0027) }}"},{"line_number":10,"context_line":"    offload-sg off"},{"line_number":11,"context_line":"{% if ssh_checksum_interface is defined %}"},{"line_number":12,"context_line":"    # To ensure ssh checksum is correct"},{"line_number":13,"context_line":"    up /sbin/iptables -A POSTROUTING -t mangle -p tcp --dport 22 -j CHECKSUM --checksum-fill"},{"line_number":14,"context_line":"    down /sbin/iptables -D POSTROUTING -t mangle -p tcp --dport 22 -j CHECKSUM --checksum-fill"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_d5d6224e","line":11,"updated":"2016-09-16 08:33:11.000000000","message":"The checksumming should be on an interface basis.\nSo I\u0027d use item.ssh_checksum_interface","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dbe0e546413c3891d7ce518cb054aafaa0697eb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    up /sbin/iptables -A POSTROUTING -t mangle -p tcp --dport 22 -j CHECKSUM --checksum-fill"},{"line_number":14,"context_line":"    down /sbin/iptables -D POSTROUTING -t mangle -p tcp --dport 22 -j CHECKSUM --checksum-fill"},{"line_number":15,"context_line":"    # To provide internet connectivity to instances"},{"line_number":16,"context_line":"    up /sbin/iptables -t nat -A POSTROUTING -o {{ item.veth_peer | default(\u0027eth0\u0027) }} -j MASQUERADE"},{"line_number":17,"context_line":"    down /sbin/iptables -t nat -D POSTROUTING -o {{ item.veth_peer | default(\u0027eth0\u0027) }} -j MASQUERADE"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if veth_peer is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_d50b82d4","line":16,"updated":"2016-09-16 08:33:11.000000000","message":"veth_peer is probably incorrect here, you probably want to nat through an exit interface.\n\n(if you defined veth_peer, it\u0027s gonna be used by default as an exit, which doesn\u0027t seem right).","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dbe0e546413c3891d7ce518cb054aafaa0697eb3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    up /sbin/iptables -t nat -A POSTROUTING -o {{ item.veth_peer | default(\u0027eth0\u0027) }} -j MASQUERADE"},{"line_number":17,"context_line":"    down /sbin/iptables -t nat -D POSTROUTING -o {{ item.veth_peer | default(\u0027eth0\u0027) }} -j MASQUERADE"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if veth_peer is defined %}"},{"line_number":20,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":21,"context_line":"    pre-up ip link add {{ item.name | default(\u0027br-mgmt\u0027) }} type veth peer name {{ item.veth_peer | default(\u0027eth1\u0027) }} || true"},{"line_number":22,"context_line":"    # Set both ends UP"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_55f852c3","line":19,"updated":"2016-09-16 08:33:11.000000000","message":"This should also be defined per interface.","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dbe0e546413c3891d7ce518cb054aafaa0697eb3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if veth_peer is defined %}"},{"line_number":20,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":21,"context_line":"    pre-up ip link add {{ item.name | default(\u0027br-mgmt\u0027) }} type veth peer name {{ item.veth_peer | default(\u0027eth1\u0027) }} || true"},{"line_number":22,"context_line":"    # Set both ends UP"},{"line_number":23,"context_line":"    pre-up ip link set {{ item.name | default(\u0027br-mgmt\u0027) }}-veth up"},{"line_number":24,"context_line":"    pre-up ip link set {{ item.veth_peer | default(\u0027eth1\u0027) }} up"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_75c62e69","line":21,"updated":"2016-09-16 08:33:11.000000000","message":"isn\u0027t -veth missing here in the interface you adding?","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dbe0e546413c3891d7ce518cb054aafaa0697eb3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    pre-up ip link set {{ item.veth_peer | default(\u0027eth1\u0027) }} up"},{"line_number":25,"context_line":"    # Delete veth pair on DOWN"},{"line_number":26,"context_line":"    post-down ip link del {{ item.name | default(\u0027br-mgmt\u0027) }}-veth || true"},{"line_number":27,"context_line":"    bridge_ports {{ item.name | default(\u0027br-mgmt\u0027) }}-veth"},{"line_number":28,"context_line":"{% endif %}"},{"line_number":29,"context_line":"{%"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_35e906e7","line":27,"range":{"start_line":27,"start_character":17,"end_line":27,"end_character":58},"updated":"2016-09-16 08:33:11.000000000","message":"by this you don\u0027t allow any other ports to be bridged in the system.\nFine for me in tests, just not elegant, IMO.","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"}],"network_interfaces/redhat_interface_postup.cfg.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4b87b7351eedd8225ff51904123770dc2e552406","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # Set both ends UP"},{"line_number":21,"context_line":"    /usr/sbin/ip link set br-vlan-veth up || true"},{"line_number":22,"context_line":"    /usr/sbin/ip link set {{ item.veth_peer | default(\u0027eth0\u0027) }} up || true"},{"line_number":23,"context_line":"fi"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a8ec9b2_d58e222d","line":23,"updated":"2016-09-16 08:34:52.000000000","message":"Why don\u0027t we use theis script for ubuntu too?","commit_id":"7c8099ea7ddbdaf003d670af0a391b0fb3a0d700"}],"test-prepare-host.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"0142eb35a9779144ec7f1befbaf76c7080d6f627","unresolved":false,"context_lines":[{"line_number":94,"context_line":"      command: /sbin/iptables -A POSTROUTING -t mangle -p tcp --dport 22 -j CHECKSUM --checksum-fill"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    - name: Add iptables rule to provide internet connectivity to instances"},{"line_number":97,"context_line":"      command: /sbin/iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    - name: Add iptables rules for lxc natting"},{"line_number":100,"context_line":"      command: /usr/local/bin/lxc-system-manage iptables-create"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7a8ec9b2_d5ed2cb8","line":97,"range":{"start_line":97,"start_character":55,"end_line":97,"end_character":59},"updated":"2016-09-16 14:28:17.000000000","message":"I\u0027d still put a variable here:\n-o {{ output_interface | default(\u0027eth0\u0027) }}","commit_id":"f4eb09c498a6ec88effb40140572138aee8c2892"}]}