)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"a93378d6087309bc410e86100b795407d0afd189","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implemented git clone of roles."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added get-ansible-role-requirements.yml to a testing repo tha clones"},{"line_number":10,"context_line":"the roles mentioned in tests/ansible-role-requirements.yml instead"},{"line_number":11,"context_line":"of cloning the current ansible-galaxy."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3a98d1f4_b6b29592","line":9,"updated":"2016-09-30 12:58:18.000000000","message":"s/tha/that/ (small nit, no need to fix unless another patch needs to be pushed for something else) ;)","commit_id":"b8f97c94de2c1a080030fa8cb4eeaa5486104de2"}],"test-ansible-env-prep.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64455c7293b251aaab9ce3fa3561cb1d286f5c52","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# This is ignored if there is no ansible-role-requirements file."},{"line_number":63,"context_line":"if [ ! -d \"${ANSIBLE_ROLE_DIR}s\" ] \u0026\u0026 [ -f \"${ANSIBLE_ROLE_REQUIREMENTS_PATH}\" ]; then"},{"line_number":64,"context_line":"   ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":65,"context_line":"\t ${WORKING_DIR}/tests/get-ansible-role-requirements.yml \\"},{"line_number":66,"context_line":"\t -e \"toxinidir\u003d${WORKING_DIR} homedir\u003d${TESTING_HOME}\""},{"line_number":67,"context_line":"fi"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"5a8bc5a2_9e4ca2c9","line":65,"range":{"start_line":65,"start_character":2,"end_line":65,"end_character":23},"updated":"2016-09-26 17:41:53.000000000","message":"This should be ${COMMON_TESTS_PATH} to ensure that it works across all repositories.","commit_id":"b1a0b0ab6c69f1a975cf48364366672fd8d5acc4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"50525ab71fbe1edcd9c3480d268aea29aacc833a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# This is ignored if there is no ansible-role-requirements file."},{"line_number":63,"context_line":"if [ ! -d \"${ANSIBLE_ROLE_DIR}\" ] \u0026\u0026 [ -f \"${ANSIBLE_ROLE_REQUIREMENTS_PATH}\" ]; then"},{"line_number":64,"context_line":"   ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":65,"context_line":"   ${COMMON_TESTS_PATH}/tests/get-ansible-role-requirements.yml \\"},{"line_number":66,"context_line":"   -e \"toxinidir\u003d${WORKING_DIR} homedir\u003d${TESTING_HOME}\""},{"line_number":67,"context_line":"fi"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-sh","patch_set":13,"id":"5a8bc5a2_30e0fbcc","line":65,"range":{"start_line":65,"start_character":3,"end_line":65,"end_character":63},"updated":"2016-09-27 08:28:54.000000000","message":"This should be ${COMMON_TESTS_PATH}/get-ansible-role-requirements.yml","commit_id":"edf24a339460ecea1ad5f1060f5180efe0088f69"}],"tests/get-ansible-role-requirements.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64455c7293b251aaab9ce3fa3561cb1d286f5c52","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  connection: local"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  tasks:"},{"line_number":21,"context_line":"    - name: Remove  plugins and roles directory"},{"line_number":22,"context_line":"      shell: |"},{"line_number":23,"context_line":"         rm -rf {{ homedir }}/.ansible/plugins"},{"line_number":24,"context_line":"         rm -rf {{ homedir }}/.ansible/roles"},{"line_number":25,"context_line":"    - name: Clone the plugins repo"},{"line_number":26,"context_line":"      git:"},{"line_number":27,"context_line":"        repo: \"https://git.openstack.org/openstack/openstack-ansible-plugins\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_8171a378","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":44},"updated":"2016-09-26 17:41:53.000000000","message":"I don\u0027t think this is necessary. It will cause these directories to be removed and re-implemented over and over again in the linters test.","commit_id":"b1a0b0ab6c69f1a975cf48364366672fd8d5acc4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64455c7293b251aaab9ce3fa3561cb1d286f5c52","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      shell: |"},{"line_number":23,"context_line":"         rm -rf {{ homedir }}/.ansible/plugins"},{"line_number":24,"context_line":"         rm -rf {{ homedir }}/.ansible/roles"},{"line_number":25,"context_line":"    - name: Clone the plugins repo"},{"line_number":26,"context_line":"      git:"},{"line_number":27,"context_line":"        repo: \"https://git.openstack.org/openstack/openstack-ansible-plugins\""},{"line_number":28,"context_line":"        dest: \"{{ homedir }}/.ansible/plugins\""},{"line_number":29,"context_line":"    - name: Remove target directory if required"},{"line_number":30,"context_line":"      shell: |"},{"line_number":31,"context_line":"        if [[ ! -d \"{{ item.path | default(\u0027/etc/ansible/roles\u0027) }}/{{ item.name | default(item.src | basename) }}/.git\" ]]; then"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_a1e5bf38","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":46},"updated":"2016-09-26 17:41:53.000000000","message":"This is handled by https://github.com/openstack/openstack-ansible-tests/blob/master/test-ansible-env-prep.sh#L55-L59 - so either remove this, or ensure that like functionality is here and remove that item from the script.","commit_id":"b1a0b0ab6c69f1a975cf48364366672fd8d5acc4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64455c7293b251aaab9ce3fa3561cb1d286f5c52","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      when:"},{"line_number":47,"context_line":"        - item.scm \u003d\u003d \"git\" or item.scm is undefined"},{"line_number":48,"context_line":"      with_items: \"{{ roles }}\""},{"line_number":49,"context_line":"    - name: Remove the test roles, create symbolic link and clone current dir to tests/playbooks"},{"line_number":50,"context_line":"      shell: |"},{"line_number":51,"context_line":"         rm -rf {{ homedir }}/.ansible/roles/tests"},{"line_number":52,"context_line":"         bash -c \"ln -s {{ toxinidir }} {{ homedir }}/.ansible/roles/tests\""},{"line_number":53,"context_line":"         rm -rf {{ toxinidir }}/tests/playbooks"},{"line_number":54,"context_line":"         git clone . {{ toxinidir }}/tests/playbooks"},{"line_number":55,"context_line":"  vars:"},{"line_number":56,"context_line":"    role_file: \"{{ toxinidir }}/tests/ansible-role-requirements.yml\""},{"line_number":57,"context_line":"    roles: \"{{ lookup(\u0027file\u0027, role_file) | from_yaml }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_21336f63","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":52},"updated":"2016-09-26 17:41:53.000000000","message":"This would only work for this repo, not other repositories. https://github.com/openstack/openstack-ansible-tests/blob/master/test-ansible-env-prep.sh#L71-L81 implements it in a better way. Either remove this or replace with like functionality.","commit_id":"b1a0b0ab6c69f1a975cf48364366672fd8d5acc4"}],"tox.ini":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a7674bf42a6b2d3c5e36bdbbd42ef6ded8d6e01c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"commands \u003d"},{"line_number":119,"context_line":"    rm -rf {homedir}/.ansible/plugins"},{"line_number":120,"context_line":"    git clone https://git.openstack.org/openstack/openstack-ansible-plugins \\"},{"line_number":121,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":122,"context_line":"    rm -rf {homedir}/.ansible/roles"},{"line_number":123,"context_line":"    ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":124,"context_line":"                       {toxinidir}/tests/get-ansible-role-requirements.yml \\"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5a8bc5a2_03cb6054","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":40},"updated":"2016-09-22 20:23:25.000000000","message":"Why not add this to the playbook?","commit_id":"281bbf2eb9e1d622cc15cbe38d88ca487ca56e7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a7674bf42a6b2d3c5e36bdbbd42ef6ded8d6e01c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    rm -rf {homedir}/.ansible/plugins"},{"line_number":120,"context_line":"    git clone https://git.openstack.org/openstack/openstack-ansible-plugins \\"},{"line_number":121,"context_line":"              {homedir}/.ansible/plugins"},{"line_number":122,"context_line":"    rm -rf {homedir}/.ansible/roles"},{"line_number":123,"context_line":"    ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":124,"context_line":"                       {toxinidir}/tests/get-ansible-role-requirements.yml \\"},{"line_number":125,"context_line":"                       -e \"role_file\u003d{toxinidir}/tests/ansible-role-requirements.yml install_dir\u003d{homedir}/.ansible/roles\""}],"source_content_type":"text/x-properties","patch_set":6,"id":"5a8bc5a2_63c26435","line":122,"range":{"start_line":122,"start_character":4,"end_line":122,"end_character":35},"updated":"2016-09-22 20:23:25.000000000","message":"This can be removed - the playbook handles it.","commit_id":"281bbf2eb9e1d622cc15cbe38d88ca487ca56e7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a7674bf42a6b2d3c5e36bdbbd42ef6ded8d6e01c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":124,"context_line":"                       {toxinidir}/tests/get-ansible-role-requirements.yml \\"},{"line_number":125,"context_line":"                       -e \"role_file\u003d{toxinidir}/tests/ansible-role-requirements.yml install_dir\u003d{homedir}/.ansible/roles\""},{"line_number":126,"context_line":"    rm -rf {homedir}/.ansible/roles/tests"},{"line_number":127,"context_line":"    bash -c \"ln -s {toxinidir} {homedir}/.ansible/roles/tests\""},{"line_number":128,"context_line":"    rm -rf {toxinidir}/tests/playbooks"},{"line_number":129,"context_line":"    git clone . {toxinidir}/tests/playbooks"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"[testenv:ansible-syntax]"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5a8bc5a2_63d98421","line":129,"range":{"start_line":126,"start_character":0,"end_line":129,"end_character":43},"updated":"2016-09-22 20:23:25.000000000","message":"Why not move this into the playbook too?","commit_id":"281bbf2eb9e1d622cc15cbe38d88ca487ca56e7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f5f9011ab18a829f58c8ab3ec79837a0c7dcb8d7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    ansible-playbook -i \"localhost ansible-connection\u003dlocal,\" \\"},{"line_number":108,"context_line":"                       {toxinidir}/tests/get-ansible-role-requirements.yml \\"},{"line_number":109,"context_line":"                       -e \"toxinidir\u003d{toxinidir} homedir\u003d{homedir}\""},{"line_number":110,"context_line":"[testenv:ansible-syntax]"},{"line_number":111,"context_line":"deps \u003d"},{"line_number":112,"context_line":"    {[testenv:ansible]deps}"}],"source_content_type":"text/x-properties","patch_set":9,"id":"5a8bc5a2_130b328f","line":109,"updated":"2016-09-26 16:07:42.000000000","message":"Instead of adding this here, please rather replace this section:\nhttps://github.com/openstack/openstack-ansible-tests/blob/master/test-ansible-env-prep.sh#L64-L67\n\nThis will ensure that all repositories use the same method without requiring all repositories to have their tox.ini updated.","commit_id":"7c8dd80e0794a816f969e6d3b7b0ed89b738e6f8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"64455c7293b251aaab9ce3fa3561cb1d286f5c52","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    {[testenv:tests_clone]commands}"},{"line_number":105,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-env-prep.sh\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"[testenv:ansible-syntax]"},{"line_number":109,"context_line":"deps \u003d"},{"line_number":110,"context_line":"    {[testenv:ansible]deps}"}],"source_content_type":"text/x-properties","patch_set":10,"id":"5a8bc5a2_fed92658","side":"PARENT","line":107,"updated":"2016-09-26 17:41:53.000000000","message":"Please leave this line in place. There should be two line breaks between each tox env.","commit_id":"762216462b8afc04b5fb76a716cf18865b3ce7cb"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"50525ab71fbe1edcd9c3480d268aea29aacc833a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    {[testenv:tests_clone]commands}"},{"line_number":105,"context_line":"    bash -c \"{toxinidir}/tests/common/test-ansible-env-prep.sh\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"[testenv:ansible-syntax]"},{"line_number":109,"context_line":"deps \u003d"},{"line_number":110,"context_line":"    {[testenv:ansible]deps}"}],"source_content_type":"text/x-properties","patch_set":13,"id":"5a8bc5a2_900e2f8a","side":"PARENT","line":107,"updated":"2016-09-27 08:28:54.000000000","message":"Please do not remove this line.","commit_id":"882f325053ef035a8c7074054b8ba49540d0bb82"}]}