)]}'
{"run_tests.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"665f39a7ff920fe74a2bb1c5974deb45777d4685","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# run through each tox env and execute the test"},{"line_number":47,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":48,"context_line":"  if [ \"${tox_env}\" !\u003d \"functional\" ]; then"},{"line_number":49,"context_line":"    tox -e ${tox_env}"},{"line_number":50,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"functional\" ] \u0026\u0026 [ \"${FUNCTIONAL_TEST}\" \u003d\u003d \"true\" ]; then"},{"line_number":51,"context_line":"    tox -e ${tox_env}"}],"source_content_type":"text/x-sh","patch_set":28,"id":"5a8bc5a2_d85bbef4","line":48,"updated":"2016-09-26 10:01:31.000000000","message":"nit:\n\n#Skip functional tests if FUNCTIONAL_TEST is not true.\nif [ \"${tox_env}\" \u003d\u003d \"functional\" ] \u0026\u0026 [ \"${FUNCTIONAL_TEST}\" !\u003d \"true\" ];\n  continue\ntox -e ${tox_env}","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b228ae5686aafde9b134ccef6d3001f271359ebc","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# run through each tox env and execute the test"},{"line_number":47,"context_line":"for tox_env in $(awk -F\u003d \u0027/envlist/ {print $2}\u0027 tox.ini | sed \u0027s/,/ /g\u0027); do"},{"line_number":48,"context_line":"  if [ \"${tox_env}\" !\u003d \"functional\" ]; then"},{"line_number":49,"context_line":"    tox -e ${tox_env}"},{"line_number":50,"context_line":"  elif [ \"${tox_env}\" \u003d\u003d \"functional\" ] \u0026\u0026 [ \"${FUNCTIONAL_TEST}\" \u003d\u003d \"true\" ]; then"},{"line_number":51,"context_line":"    tox -e ${tox_env}"}],"source_content_type":"text/x-sh","patch_set":28,"id":"5a8bc5a2_336be586","line":48,"in_reply_to":"5a8bc5a2_d85bbef4","updated":"2016-09-26 10:13:02.000000000","message":"You\u0027re welcome to propose a follow on patch with an alternative solution. All I\u0027m doing in this patch is making this actually functional, which is currently is not.","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"}],"test-ansible-deps.txt":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"665f39a7ff920fe74a2bb1c5974deb45777d4685","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# target configuration in each role."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# The Ansible version used for testing"},{"line_number":11,"context_line":"ansible\u003d\u003d2.1.1"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# The Ansible lint version used for lint tests"},{"line_number":14,"context_line":"ansible-lint\u003e\u003d2.7.0,\u003c3.0.0"}],"source_content_type":"text/plain","patch_set":28,"id":"5a8bc5a2_18f9a6c7","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":14},"updated":"2016-09-26 10:01:31.000000000","message":"Should we stick with 2.1.1? \nOr do should we simply say ansible\u003d\u003d2.1?","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b228ae5686aafde9b134ccef6d3001f271359ebc","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# target configuration in each role."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# The Ansible version used for testing"},{"line_number":11,"context_line":"ansible\u003d\u003d2.1.1"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# The Ansible lint version used for lint tests"},{"line_number":14,"context_line":"ansible-lint\u003e\u003d2.7.0,\u003c3.0.0"}],"source_content_type":"text/plain","patch_set":28,"id":"5a8bc5a2_d312c108","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":14},"in_reply_to":"5a8bc5a2_18f9a6c7","updated":"2016-09-26 10:13:02.000000000","message":"Yes, 2.1.1 is our current standard. I\u0027m not sure why you\u0027re suggesting an alternative?","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"}],"test-ansible-env-prep.sh":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"8f95c963d94a591384cc716ca8c3f9d20681fcfc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  -o ForwardX11\u003dno \\"},{"line_number":49,"context_line":"  -o ForwardAgent\u003dyes\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO (odyssey4me) These are only here as they are non-standard folder"},{"line_number":52,"context_line":"# names for Ansible 1.9.x. We are using the standard folder names for"},{"line_number":53,"context_line":"# Ansible v2.x. We can remove this when we move to Ansible 2.x."},{"line_number":54,"context_line":"export ANSIBLE_ACTION_PLUGINS\u003d${TESTING_HOME}/.ansible/plugins/action"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_f281e44b","line":51,"updated":"2016-09-22 19:16:14.000000000","message":"Can be removed","commit_id":"84ce998ab3e85f0660f40fb8753120c3e9572ff4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ceff3317715bb89d025f7e2f1f257965a940a2d7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  -o ForwardX11\u003dno \\"},{"line_number":49,"context_line":"  -o ForwardAgent\u003dyes\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# TODO (odyssey4me) These are only here as they are non-standard folder"},{"line_number":52,"context_line":"# names for Ansible 1.9.x. We are using the standard folder names for"},{"line_number":53,"context_line":"# Ansible v2.x. We can remove this when we move to Ansible 2.x."},{"line_number":54,"context_line":"export ANSIBLE_ACTION_PLUGINS\u003d${TESTING_HOME}/.ansible/plugins/action"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_bef3a309","line":51,"in_reply_to":"5a8bc5a2_f281e44b","updated":"2016-09-22 20:38:22.000000000","message":"Done","commit_id":"84ce998ab3e85f0660f40fb8753120c3e9572ff4"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"063cbd5577d0a4340c408bfc8640f386f231856c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  echo \"Resetting all cloned data.\""},{"line_number":44,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/plugins\""},{"line_number":45,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/roles\""},{"line_number":46,"context_line":"  rm -f  \"${TESTING_HOME}/.ansible.cfg\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Download the Ansible plugins repository if it is not present on the host."}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a8bc5a2_0536df51","line":46,"updated":"2016-09-23 14:18:41.000000000","message":"Could we at the same time, remove the /etc/ansible/roles folder?","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82369ee6cdd87644b98c9aece15782eef0ee6ccd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  echo \"Resetting all cloned data.\""},{"line_number":44,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/plugins\""},{"line_number":45,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/roles\""},{"line_number":46,"context_line":"  rm -f  \"${TESTING_HOME}/.ansible.cfg\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Download the Ansible plugins repository if it is not present on the host."}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a8bc5a2_119d4159","line":46,"in_reply_to":"5a8bc5a2_0536df51","updated":"2016-09-23 14:22:25.000000000","message":"None of the roles use it, and the jenkins (non-root) user doesn\u0027t have rights to do it. So no, we can\u0027t and nor should we.","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2948d6857aede19dee28bb2a7fb16e6ef410dd05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if [ ! -z \"${ROLE_NAME}\" ]; then"},{"line_number":69,"context_line":"  echo \"Linking ${TESTING_HOME}/.ansible/roles/${ROLE_NAME} to ${WORKING_DIR}\""},{"line_number":70,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/roles/${ROLE_NAME}\""},{"line_number":71,"context_line":"  ln -s \"${WORKING_DIR}\" \"${TESTING_HOME}/.ansible/roles/${ROLE_NAME}\""},{"line_number":72,"context_line":"else"},{"line_number":73,"context_line":"  echo \"Skipping the role link because no role name was provided.\""},{"line_number":74,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a8bc5a2_d69e6fb7","line":71,"updated":"2016-09-23 14:09:05.000000000","message":"If there is no ansible-galaxy install above, .ansible/roles won\u0027t exist, so you\u0027ll want to create it here","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2e04404887e5e108d4e3204a668bd2a7e6d18ab","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if [ ! -z \"${ROLE_NAME}\" ]; then"},{"line_number":69,"context_line":"  echo \"Linking ${TESTING_HOME}/.ansible/roles/${ROLE_NAME} to ${WORKING_DIR}\""},{"line_number":70,"context_line":"  rm -rf \"${TESTING_HOME}/.ansible/roles/${ROLE_NAME}\""},{"line_number":71,"context_line":"  ln -s \"${WORKING_DIR}\" \"${TESTING_HOME}/.ansible/roles/${ROLE_NAME}\""},{"line_number":72,"context_line":"else"},{"line_number":73,"context_line":"  echo \"Skipping the role link because no role name was provided.\""},{"line_number":74,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a8bc5a2_d6bf4f5e","line":71,"in_reply_to":"5a8bc5a2_d69e6fb7","updated":"2016-09-23 14:13:30.000000000","message":"Good catch - done.","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"}],"test-ansible.cfg":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"063cbd5577d0a4340c408bfc8640f386f231856c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"5a8bc5a2_b19badc8","line":30,"updated":"2016-09-23 14:18:41.000000000","message":"Could we also make sure we store facts here?","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"82369ee6cdd87644b98c9aece15782eef0ee6ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"5a8bc5a2_f1e7f5e1","line":30,"in_reply_to":"5a8bc5a2_b19badc8","updated":"2016-09-23 14:22:25.000000000","message":"I\u0027ve implemented like-for-like functionality here. Enhancements can come later.","commit_id":"65cbff6e25ae1141638f004fe91125a4d6c14671"}],"tox.ini":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"925eed5cc3a3dd9494e2d42ad993907a060fe832","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# -b stable/mitaka https://git.openstack.org/openstack/openstack-ansible-tests"},{"line_number":63,"context_line":"[testenv:tests_clone]"},{"line_number":64,"context_line":"commands \u003d"},{"line_number":65,"context_line":"    bash -c \"if [ ! -d \"{toxinidir}/tests/common\" ]; then \\"},{"line_number":66,"context_line":"               git clone {toxinidir} {toxinidir}/tests/common; \\"},{"line_number":67,"context_line":"             fi\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-properties","patch_set":26,"id":"5a8bc5a2_9c2a457d","line":65,"updated":"2016-09-23 14:42:55.000000000","message":"Why the change, this is going to break all the consuming roles","commit_id":"a3a7242440fa25b762a655094a2dde48a6cd4cc1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bc2b333fc428399255d2c9157ff165e30c8d1bff","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# -b stable/mitaka https://git.openstack.org/openstack/openstack-ansible-tests"},{"line_number":63,"context_line":"[testenv:tests_clone]"},{"line_number":64,"context_line":"commands \u003d"},{"line_number":65,"context_line":"    bash -c \"if [ ! -d \"{toxinidir}/tests/common\" ]; then \\"},{"line_number":66,"context_line":"               git clone {toxinidir} {toxinidir}/tests/common; \\"},{"line_number":67,"context_line":"             fi\""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-properties","patch_set":26,"id":"5a8bc5a2_1c9395a4","line":65,"in_reply_to":"5a8bc5a2_9c2a457d","updated":"2016-09-23 14:44:52.000000000","message":"@This will only affect the consuming roles when they are configured to consume this set of scripts. There\u0027s no impact to any of the roles as they are configured now.\n\nWhen they\u0027re configured to use this set of scripts, they can be changed to use the new path.","commit_id":"a3a7242440fa25b762a655094a2dde48a6cd4cc1"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"665f39a7ff920fe74a2bb1c5974deb45777d4685","unresolved":false,"context_lines":[{"line_number":25,"context_line":"setenv \u003d"},{"line_number":26,"context_line":"    PYTHONUNBUFFERED\u003d1"},{"line_number":27,"context_line":"    VIRTUAL_ENV\u003d{envdir}"},{"line_number":28,"context_line":"    WORKING_DIR\u003d{toxinidir}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":28,"id":"5a8bc5a2_98bdb6b9","line":28,"updated":"2016-09-26 10:01:31.000000000","message":"Should we define \nCOMMON_DIR\u003d{toxinidir}/tests/common\nand reuse this?","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b228ae5686aafde9b134ccef6d3001f271359ebc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"setenv \u003d"},{"line_number":26,"context_line":"    PYTHONUNBUFFERED\u003d1"},{"line_number":27,"context_line":"    VIRTUAL_ENV\u003d{envdir}"},{"line_number":28,"context_line":"    WORKING_DIR\u003d{toxinidir}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":28,"id":"5a8bc5a2_f3d09d21","line":28,"in_reply_to":"5a8bc5a2_98bdb6b9","updated":"2016-09-26 10:13:02.000000000","message":"No need - the common directory is derived from the WORKING_DIR. We don\u0027t need to add another var that may need to change in every repo. This current set is as minimal as possible to reduce churn.","commit_id":"9a09e9ff0791eddfae92a831ac9db581196f1a5f"}]}