)]}'
{"test-log-collect.sh":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"1d6fe9ea33c8ef7b26745a7df84dc5f47342fa02","unresolved":false,"context_lines":[{"line_number":29,"context_line":"export RSYNC_CMD\u003d\"rsync --archive --verbose --safe-links --ignore-errors\""},{"line_number":30,"context_line":"export ARA_CMD\u003d\"${WORKING_DIR}/.tox/functional/bin/ara generate html\""},{"line_number":31,"context_line":"export TESTING_HOME\u003d${TESTING_HOME:-$HOME}"},{"line_number":32,"context_line":"export CURRENT_USER\u003d$(whoami)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_a23751ff","line":32,"updated":"2017-07-27 20:24:17.000000000","message":"Not really. I\u0027ll just use it below without the export.","commit_id":"b90e7e82a873a52948d465ac397fea767d1f13c3"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"b649df91200c922c8f6b545180425ccc4922964e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"export RSYNC_CMD\u003d\"rsync --archive --verbose --safe-links --ignore-errors\""},{"line_number":30,"context_line":"export ARA_CMD\u003d\"${WORKING_DIR}/.tox/functional/bin/ara generate html\""},{"line_number":31,"context_line":"export TESTING_HOME\u003d${TESTING_HOME:-$HOME}"},{"line_number":32,"context_line":"export CURRENT_USER\u003d$(whoami)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_22dd0570","line":32,"updated":"2017-07-25 14:46:27.000000000","message":"does this really need to be exported?","commit_id":"b90e7e82a873a52948d465ac397fea767d1f13c3"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"1d6fe9ea33c8ef7b26745a7df84dc5f47342fa02","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  # when trying to read the logs in the job results."},{"line_number":46,"context_line":"  sudo chown -R ${CURRENT_USER} \"${WORKING_DIR}/logs/\""},{"line_number":47,"context_line":"  sudo chmod -R u+r,g+r,o+r \"${WORKING_DIR}/logs/\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  if [ ! -z \"${ANSIBLE_LOG_DIR}\" ]; then"},{"line_number":50,"context_line":"    mkdir -p \"${WORKING_DIR}/logs/ansible\""},{"line_number":51,"context_line":"    ${RSYNC_CMD} \"${ANSIBLE_LOG_DIR}/\" \"${WORKING_DIR}/logs/ansible\" || true"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_8238cded","line":48,"updated":"2017-07-27 20:24:17.000000000","message":"I\u0027d rather chmod/chown after moving the stuff over, but it really doesn\u0027t matter since the entire VM is thrown out shortly afterwards. ;)","commit_id":"b90e7e82a873a52948d465ac397fea767d1f13c3"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"b649df91200c922c8f6b545180425ccc4922964e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  # when trying to read the logs in the job results."},{"line_number":46,"context_line":"  sudo chown -R ${CURRENT_USER} \"${WORKING_DIR}/logs/\""},{"line_number":47,"context_line":"  sudo chmod -R u+r,g+r,o+r \"${WORKING_DIR}/logs/\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  if [ ! -z \"${ANSIBLE_LOG_DIR}\" ]; then"},{"line_number":50,"context_line":"    mkdir -p \"${WORKING_DIR}/logs/ansible\""},{"line_number":51,"context_line":"    ${RSYNC_CMD} \"${ANSIBLE_LOG_DIR}/\" \"${WORKING_DIR}/logs/ansible\" || true"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_a237b5b0","line":48,"updated":"2017-07-25 14:46:27.000000000","message":"might just be safer to revert the logic here? for example maybe worth chown/chmod the /var/log and /openstack/log and then copy them with rsync without sudo so you can avoid using sudo 4 times? I know it looks safe as is but...","commit_id":"b90e7e82a873a52948d465ac397fea767d1f13c3"}]}