)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ffdb79fe682f9ea062f351cb32e65073baa27d34","unresolved":false,"context_lines":[{"line_number":13,"context_line":"values to be set in user_variables to establish a connection."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2164a1f27f632ce254cc2711ada2c449a9961fed"},{"line_number":16,"context_line":"Implements: bp/implement-ceilometer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"ba3cc151_9e9bea65","line":16,"updated":"2015-07-02 16:10:22.000000000","message":"Implements: blueprint implement-ceilometer","commit_id":"43201e2d3623a9da19dfa4eab5b25daa9e7a74ec"}],"etc/openstack_deploy/env.d/ceilometer_environment.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      service_name: ceilometer"},{"line_number":54,"context_line":"      container_release: trusty"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"physical_skil:"},{"line_number":57,"context_line":"  metering-compute_containers:"},{"line_number":58,"context_line":"    belongs_to:"},{"line_number":59,"context_line":"    - all_containers"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab921fb_ce3927d9","line":56,"updated":"2015-04-24 22:21:23.000000000","message":"this should be `physical_skel`.","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ba3cc151_d625995c","updated":"2015-06-29 09:47:57.000000000","message":"nit: to match the style of other files in the env.d folder this should just be named \u0027ceilometer.yml\u0027","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"etc/openstack_deploy/user_group_vars.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ceilometer_service_tenant_name: service"},{"line_number":83,"context_line":"ceilometer_service_adminuri: \"{{ ceilometer_service_proto }}://{{ internal_lb_vip_address }}:{{ ceilometer_service_port }}\""},{"line_number":84,"context_line":"ceilometer_service_adminurl: \"{{ ceilometer_service_adminuri }}/\""},{"line_number":85,"context_line":"ceilometer_service_region: RegionOne"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"## Nova"},{"line_number":88,"context_line":"nova_service_port: 8774"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_b6e4950d","line":85,"updated":"2015-06-29 09:47:57.000000000","message":"The service_region in group_vars should be set to  \"{{ service_region }}\" to match all the other services, simplifying the override.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/ansible.cfg":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ccea1009813384c3e0e1229714fbd01b9300d1b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"fa32b979_c7323b10","updated":"2015-06-23 21:01:01.000000000","message":"These changes should not be here - they\u0027re changes applied by bootstrap-aio which you should not have committed.","commit_id":"b566e632f184a5943b2554f2c3dc743595e370b5"}],"playbooks/defaults/repo_packages/openstack_services.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ccea1009813384c3e0e1229714fbd01b9300d1b1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"## Ceilometer service"},{"line_number":32,"context_line":"ceilometer_git_repo: https://github.com/openstack/ceilometer"},{"line_number":33,"context_line":"ceilometer_git_install_branch: master"},{"line_number":34,"context_line":"ceilometer_git_dest: \"/opt/ceilometer_{{ceilometer_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fa32b979_47270bca","line":33,"updated":"2015-06-23 21:01:01.000000000","message":"This should be pinned to a SHA like the other branches, otherwise you\u0027re trying to keep up with a moving target.","commit_id":"b566e632f184a5943b2554f2c3dc743595e370b5"}],"playbooks/roles/os_ceilometer/CONTRIBUTING.rst":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Extra"},{"line_number":33,"context_line":"-----"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Tags: "},{"line_number":36,"context_line":"    If it\u0027s a bug that needs fixing in a branch in addition to Master, add a \u0027\\\u003crelease\\\u003e-backport-potential\u0027 tag (eg ``juno-backport-potential``).  There are predefined tags that will autocomplete."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Status:"}],"source_content_type":"text/x-rst","patch_set":27,"id":"ba3cc151_16a1c1a9","line":35,"updated":"2015-06-29 09:47:57.000000000","message":"nit: whitespace","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_ceilometer/README.rst":[{"author":{"_account_id":1613,"name":"Sudarshan Acharya","email":"sudarshan.acharya@gmail.com","username":"sudarshan.acharya"},"change_message_id":"8e308bf9e667d53a4398557db3778d51238348db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack glance"},{"line_number":2,"context_line":"################"},{"line_number":3,"context_line":":tags: openstack, glance, cloud, ansible"},{"line_number":4,"context_line":":category: \\*nix"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aaa499b_3f0c383a","line":1,"updated":"2015-04-15 18:02:21.000000000","message":"Rename to ceilometer","commit_id":"cb7dee5e5ffcb2d3ec5aaa8ade5ed48fb7368953"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OpenStack ceilometer"},{"line_number":2,"context_line":"################"},{"line_number":3,"context_line":":tags: openstack, ceilometer, cloud, ansible"},{"line_number":4,"context_line":":category: \\*nix"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":27,"id":"ba3cc151_5676693f","line":2,"updated":"2015-06-29 09:47:57.000000000","message":"The # line here needs to be the same length as the line above it.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_ceilometer/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ceilometer_system_comment: ceilometer system user"},{"line_number":28,"context_line":"ceilometer_system_user_home: \"/var/lib/{{ ceilometer_system_user_name }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"## Need swift infromation in here."},{"line_number":31,"context_line":"swift_system_user_name: swift"},{"line_number":32,"context_line":"swift_system_group_name: swift"},{"line_number":33,"context_line":"swift_system_shell: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_f610ddaa","line":30,"updated":"2015-06-29 09:47:57.000000000","message":"nit: \u0027information\u0027","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ceilometer_system_user_home: \"/var/lib/{{ ceilometer_system_user_name }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"## Need swift infromation in here."},{"line_number":31,"context_line":"swift_system_user_name: swift"},{"line_number":32,"context_line":"swift_system_group_name: swift"},{"line_number":33,"context_line":"swift_system_shell: /bin/bash"},{"line_number":34,"context_line":"swift_system_comment: swift system user"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_96db91ed","line":31,"updated":"2015-06-29 09:47:57.000000000","message":"Are these variables intended to match those used in the swift role? Should these not then be in user_group_vars to ensure that they\u0027re consistent between roles?","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"765b9c5a0a4ebf5921d7134e57caf1c6744b2ca9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ceilometer_system_user_home: \"/var/lib/{{ ceilometer_system_user_name }}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"## Need swift infromation in here."},{"line_number":31,"context_line":"swift_system_user_name: swift"},{"line_number":32,"context_line":"swift_system_group_name: swift"},{"line_number":33,"context_line":"swift_system_shell: /bin/bash"},{"line_number":34,"context_line":"swift_system_comment: swift system user"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_7cbb44c5","line":31,"in_reply_to":"ba3cc151_96db91ed","updated":"2015-06-29 14:19:06.000000000","message":"Right. Thank you!","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"swift_system_home_folder: \"/var/lib/{{ swift_system_user_name }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"## Pipline configurations"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_f6877dd5","line":38,"updated":"2015-06-29 09:47:57.000000000","message":"Is this meant to be \u0027pipeline\u0027?","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_ceilometer/tasks/ceilometer_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ba3cc151_36364504","updated":"2015-06-29 09:47:57.000000000","message":"This file is missing the \u0027---\u0027 first line and the license boilerplate.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_ceilometer/tasks/ceilometer_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  tags:"},{"line_number":62,"context_line":"    - ceilometer-dirs"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Test for log directory or link"},{"line_number":65,"context_line":"  shell: |"},{"line_number":66,"context_line":"    if [ -h \"/var/log/ceilometer\"  ]; then"},{"line_number":67,"context_line":"      chown -h {{ ceilometer_system_user_name }}:{{ ceilometer_system_group_name }} \"/var/log/ceilometer\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_514bd359","line":64,"updated":"2015-06-29 09:47:57.000000000","message":"Can you please explain why this method of test, then create was used? Why couldn\u0027t the file module simply be used to create a directory or change its ownership?","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"765b9c5a0a4ebf5921d7134e57caf1c6744b2ca9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  tags:"},{"line_number":62,"context_line":"    - ceilometer-dirs"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Test for log directory or link"},{"line_number":65,"context_line":"  shell: |"},{"line_number":66,"context_line":"    if [ -h \"/var/log/ceilometer\"  ]; then"},{"line_number":67,"context_line":"      chown -h {{ ceilometer_system_user_name }}:{{ ceilometer_system_group_name }} \"/var/log/ceilometer\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"ba3cc151_b9a79e4e","line":64,"in_reply_to":"ba3cc151_514bd359","updated":"2015-06-29 14:19:06.000000000","message":"I copied this over from another role..I think it was the cinder role. I\u0027m honestly not sure why it was done this way for that role.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_ceilometer/tasks/ceilometer_service_setup.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    service_adminurl: \"{{ ceilometer_service_adminurl }}\""},{"line_number":28,"context_line":"    role_name: \"{{ ceilometer_role_name }}\""},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - ceilometer"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab921fb_eb04dd4a","line":30,"updated":"2015-04-24 22:21:23.000000000","message":"if we could have this tag be more descriptive it would be very helpful for deployers.","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"playbooks/roles/os_ceilometer/tasks/ceilometer_upstart_init.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bab921fb_6bc9ed25","updated":"2015-04-24 22:21:23.000000000","message":"every task within this file should have a tag. that way the various init scripts can be created on demand if needed.","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"playbooks/roles/os_ceilometer/tasks/main.yml":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"86ab9683e14387457ff0bcb7f1f20345751ee434","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: ceilometer_pre_install.yml"},{"line_number":17,"context_line":"- include: ceilometer_install.yml"},{"line_number":18,"context_line":"- include: ceilometer_post_install.yml"},{"line_number":19,"context_line":"- include: ceilometer_upstart_init.yml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: ceilometer_service_setup.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aaa499b_9fd717bf","line":18,"updated":"2015-04-14 02:49:18.000000000","message":"I don\u0027t see ceilometer_install.yml or ceilometer_post_install.yml in the repo. I realize this is a WIP patch; have they just not been written yet?","commit_id":"03d0bdfcb3fd02ba6b9d0018b83187e24b34a45a"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"c40c4bd7592b1813b78d5d82d823e67ee2f27c19","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: ceilometer_pre_install.yml"},{"line_number":17,"context_line":"- include: ceilometer_install.yml"},{"line_number":18,"context_line":"- include: ceilometer_post_install.yml"},{"line_number":19,"context_line":"- include: ceilometer_upstart_init.yml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: ceilometer_service_setup.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7aaa499b_c115ab49","line":18,"in_reply_to":"7aaa499b_9fd717bf","updated":"2015-04-14 14:32:32.000000000","message":"Correct. Thanks for the advice! :)","commit_id":"03d0bdfcb3fd02ba6b9d0018b83187e24b34a45a"}],"playbooks/roles/os_ceilometer/templates/ceilometer.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"rpc_backend \u003d rabbit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[oslo_policy]"},{"line_number":10,"context_line":"policy_file\u003d/etc/ceilometer/policy.json"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[oslo_messaging_rabbit]"},{"line_number":13,"context_line":"rpc_backend \u003d rabbit"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bab921fb_ab4705bb","line":10,"updated":"2015-04-24 22:21:23.000000000","message":"nit: can we have a space before and after the \"\u003d\"","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"playbooks/roles/os_cinder/templates/cinder.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"enable_v1_api \u003d {{ cinder_enable_v1_api }}"},{"line_number":20,"context_line":"enable_v2_api \u003d {{ cinder_enable_v2_api }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% if inventory_hostname in groups[\u0027cinder_volume\u0027] %}"},{"line_number":24,"context_line":"{% if cinder_service_backup_program_enabled \u003d\u003d true %}"},{"line_number":25,"context_line":"## Cinder Backup"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"ba3cc151_b1ac9fee","line":22,"updated":"2015-06-29 09:47:57.000000000","message":"nit: unnecessary change","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"#Ceilometer configurations"},{"line_number":83,"context_line":"{% if cinder_ceilometer_enabled %}"},{"line_number":84,"context_line":"#control_exchange \u003d cinder"},{"line_number":85,"context_line":"notification_driver \u003d cinder.openstack.common.notifier.rpc_notifier"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"ba3cc151_31ee4f23","line":84,"updated":"2015-06-29 09:47:57.000000000","message":"This looks like something that should be left out as it\u0027s a default? It certainly doesn\u0027t look like a comment.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"765b9c5a0a4ebf5921d7134e57caf1c6744b2ca9","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"#Ceilometer configurations"},{"line_number":83,"context_line":"{% if cinder_ceilometer_enabled %}"},{"line_number":84,"context_line":"#control_exchange \u003d cinder"},{"line_number":85,"context_line":"notification_driver \u003d cinder.openstack.common.notifier.rpc_notifier"},{"line_number":86,"context_line":"{% endif %}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"ba3cc151_b9555e1e","line":84,"in_reply_to":"ba3cc151_31ee4f23","updated":"2015-06-29 14:19:06.000000000","message":"That\u0027s right. Nice catch.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"{% endfor %}"},{"line_number":99,"context_line":"{% endif %}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[database]"},{"line_number":103,"context_line":"connection \u003d mysql://{{ cinder_galera_user }}:{{ cinder_container_mysql_password }}@{{ cinder_galera_address }}/{{ cinder_galera_database }}?charset\u003dutf8"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"ba3cc151_71b6173f","line":101,"updated":"2015-06-29 09:47:57.000000000","message":"nit: unnecessary change","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"playbooks/roles/os_glance/templates/glance-api.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{% else %}"},{"line_number":31,"context_line":"notification_driver \u003d {{ glance_notification_driver }}"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":"{% if glance_notification_driver \u003d\u003d \"messaging\" or  glance_ceilometer_notification_driver \u003d\u003d \"messagingv2\" and glance_ceilometer_enabled%}"},{"line_number":34,"context_line":"##### RPC MESSAGING OPTIONS #####"},{"line_number":35,"context_line":"rpc_backend \u003d {{ glance_rpc_backend }}"},{"line_number":36,"context_line":"rabbit_hosts \u003d {{ rabbitmq_servers }}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bab921fb_cbc9195b","line":33,"updated":"2015-04-24 22:21:23.000000000","message":"the statement after the or will need to be in parentheses. The if should look something like this: \n\n{% if glance_notification_driver \u003d\u003d \"messaging\" or  (glance_ceilometer_notification_driver \u003d\u003d \"messagingv2\" and glance_ceilometer_enabled) %}\n...","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"playbooks/roles/os_heat/templates/heat.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Ceilometer options"},{"line_number":31,"context_line":"{% if heat_ceilometer_enabled %}"},{"line_number":32,"context_line":"notification_driver\u003dheat.openstack.common.notifier.rpc_notifier"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bab921fb_cb1fd906","line":32,"updated":"2015-04-24 22:21:23.000000000","message":"nit: can we have a space before and after the \"\u003d\" sign?","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"playbooks/roles/os_swift/defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"verbose: True"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"## Swift User / Group"},{"line_number":24,"context_line":"swift_system_user_name: swift"},{"line_number":25,"context_line":"swift_system_group_name: swift"},{"line_number":26,"context_line":"swift_system_shell: /bin/bash"},{"line_number":27,"context_line":"swift_system_comment: swift system user"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab921fb_cbf8f9c5","side":"PARENT","line":24,"updated":"2015-04-24 22:21:23.000000000","message":"why was this removed? if this is being set in groupvars thats ok however the defaults should remain here as well.","commit_id":"bdee1d5ac8ef50c33a821fec19d9f3c7002f237f"}],"playbooks/vars/repo_packages/openstack_services.yml":[{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"8f6edbf0256d7e7d7ac4e3200d0fd12e6d4390a2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"### or have a comment / reason attached to them as to why a tag can not work."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"## Ceilometer service"},{"line_number":32,"context_line":"ceilometer_get_repo: https://github.com/openstack/ceilometer"},{"line_number":33,"context_line":"ceilometer_git_install_branch: master"},{"line_number":34,"context_line":"ceilometer_git_dest: \"/opt/ceilometer_{{ceilometer_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aa745d1_84636cb1","line":32,"updated":"2015-04-16 14:02:38.000000000","message":"Typo. ceilometer_GIT_repo not \"get\"","commit_id":"cb7dee5e5ffcb2d3ec5aaa8ade5ed48fb7368953"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cdc0af2067c861c0d9a0469b9d956839767cd14f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"### or have a comment / reason attached to them as to why a tag can not work."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"## Ceilometer service"},{"line_number":32,"context_line":"ceilometer_git_repo: https://github.com/openstack/ceilometer "},{"line_number":33,"context_line":"ceilometer_git_install_branch: master"},{"line_number":34,"context_line":"ceilometer_git_dest: \"/opt/ceilometer_{{ceilometer_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bab921fb_2ba3f501","line":32,"updated":"2015-04-24 22:21:23.000000000","message":"nit: whitespace.","commit_id":"42374d5a7b4038b3a83c8724f5d0770de82b5de2"}],"scripts/bootstrap-aio.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35ba2ede45001fa5b3304c39af693034b74c074c","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"if [ ${DEPLOY_CEILOMETER} ]; then"},{"line_number":298,"context_line":"  # Install mongodb on the aio1 host"},{"line_number":299,"context_line":"  apt-get install mongodb-server mongodb-clients python-pymongo -y"},{"line_number":300,"context_line":"  # Change bind_ip to management ip"},{"line_number":301,"context_line":"  sed -i \"s/^bind_ip.*/bind_ip \u003d 172.29.236.100/\" /etc/mongodb.conf"},{"line_number":302,"context_line":"  # Asserting smallfiles key"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba3cc151_11122bb5","line":299,"updated":"2015-06-29 09:47:57.000000000","message":"It would seem that the playbook/role doesn\u0027t deploy mongodb. Is that correct? If so, it hasn\u0027t been clear to me up until now that this was the case and that the mongodb back-end was expected to be installed outside of the playbooks/roles. While I think it\u0027s good to handle this case, I think that perhaps it should be better handled within another role and used in the ceilometer playbook. If the base premise to operate from is that mongodb is already deployed, then at the very least this must be made clear in the commit message and the process for deploying mongo beforehand must be documented. I really do think that this should be deployed by a role which is consumed by the ceilometer playbook though. Also, if there is no role/playbook deploying it, then the run_playbooks script must have deploying ceilometer set to \u0027no\u0027 as a default as this script is used for AIO and non-AIO environments.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"765b9c5a0a4ebf5921d7134e57caf1c6744b2ca9","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"if [ ${DEPLOY_CEILOMETER} ]; then"},{"line_number":298,"context_line":"  # Install mongodb on the aio1 host"},{"line_number":299,"context_line":"  apt-get install mongodb-server mongodb-clients python-pymongo -y"},{"line_number":300,"context_line":"  # Change bind_ip to management ip"},{"line_number":301,"context_line":"  sed -i \"s/^bind_ip.*/bind_ip \u003d 172.29.236.100/\" /etc/mongodb.conf"},{"line_number":302,"context_line":"  # Asserting smallfiles key"}],"source_content_type":"text/x-sh","patch_set":27,"id":"ba3cc151_5cba00e3","line":299,"in_reply_to":"ba3cc151_11122bb5","updated":"2015-06-29 14:19:06.000000000","message":"I\u0027ve looked around for suitable mongodb ansible roles, but wasn\u0027t able to find a good one. That\u0027s when I decided to do a simple install for testing purposes. \nIt\u0027s mentioned a little in the BP that mongo is expected to be up and ready for ceilometer, but I\u0027ll document that more clearly in the deployment docs once I get around to it. Are the docs expected to be complete before the code can merge?\nIn the meantime, I\u0027ll change the default for \"depoying_ceilometer\" in the run_playbooks script. It doesn\u0027t look like we are going to be getting a role for deploying mongo.","commit_id":"5548639e3089ad2d87db57c4559d8d74874c4cf4"}],"scripts/bootstrap-ansible.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ccea1009813384c3e0e1229714fbd01b9300d1b1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"export GET_PIP_URL\u003d${GET_PIP_URL:-\"https://bootstrap.pypa.io/get-pip.py\"}"},{"line_number":28,"context_line":"export SSH_DIR\u003d${SSH_DIR:-\"/root/.ssh\"}"},{"line_number":29,"context_line":"export UPDATE_ANSIBLE_REQUIREMENTS\u003d${UPDATE_ANSIBLE_REQUIREMENTS:-\"yes\"}"},{"line_number":30,"context_line":"export PUBLIC_INTERFACE\u003d${PUBLIC_INTERFACE:-$(ip route show | awk \u0027/default/ { print $NF }\u0027)}"},{"line_number":31,"context_line":"export PUBLIC_ADDRESS\u003d${PUBLIC_ADDRESS:-$(ip -o -4 addr show dev ${PUBLIC_INTERFACE} | awk -F \u0027[ /]+\u0027 \u0027/global/ {print $4}\u0027)}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-sh","patch_set":23,"id":"fa32b979_4a15d23d","line":30,"updated":"2015-06-23 21:01:01.000000000","message":"Why\u0027re these being added here?","commit_id":"b566e632f184a5943b2554f2c3dc743595e370b5"}],"scripts/gate-check-commit.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ccea1009813384c3e0e1229714fbd01b9300d1b1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"export DEPLOY_LOGGING\u003d${DEPLOY_LOGGING:-\"yes\"}"},{"line_number":32,"context_line":"export DEPLOY_OPENSTACK\u003d${DEPLOY_OPENSTACK:-\"yes\"}"},{"line_number":33,"context_line":"export DEPLOY_SWIFT\u003d${DEPLOY_SWIFT:-\"yes\"}"},{"line_number":34,"context_line":"export DEPLOY_CEILOMETER\u003d${DEPLOY_CEILOMETER:-\"yes\"}"},{"line_number":35,"context_line":"export DEPLOY_TEMPEST\u003d${DEPLOY_TEMPEST:-\"yes\"}"},{"line_number":36,"context_line":"# Limit the gate check to only performing one attempt, unless already set"},{"line_number":37,"context_line":"export MAX_RETRIES\u003d${MAX_RETRIES:-\"1\"}"}],"source_content_type":"text/x-sh","patch_set":23,"id":"fa32b979_aa59fe36","line":34,"updated":"2015-06-23 21:01:01.000000000","message":"As this is defaulting to \"yes\" and exported in bootstrap-aio, this isn\u0027t necessary.","commit_id":"b566e632f184a5943b2554f2c3dc743595e370b5"}]}
