)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4d736dc297537bebdcc991156fbbef53dabe7040","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Carter \u003ckevin.carter@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-15 20:56:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated MariaDB to the new release version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change updates master to use the latest stable version of"},{"line_number":10,"context_line":"MariaDB. This change is to open up new dev work in master and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa32b979_5563831a","line":7,"updated":"2015-06-22 14:23:16.000000000","message":"Ideally the subject line should reference the actual version being updated to.","commit_id":"62b5d648e0fb677ddc416779972c324b179c7dc5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"56e65668eada3fa60f97ae60ce288cce35746a8a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"potentially other releases which will allow us to evaluate the"},{"line_number":12,"context_line":"the new version of this supporting service."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d773e569667e07106862507b881e3f0aca85591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa32b979_a322c7ff","line":14,"updated":"2015-06-16 09:07:54.000000000","message":"Please include a blueprint/bug reference, or mark the patch as WIP.","commit_id":"62b5d648e0fb677ddc416779972c324b179c7dc5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c8448d5f62ed6ffb256be367a90ae9732fa72367","unresolved":false,"context_lines":[{"line_number":11,"context_line":"potentially other releases which will allow us to evaluate the"},{"line_number":12,"context_line":"the new version of this supporting service."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d773e569667e07106862507b881e3f0aca85591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa32b979_2edb091d","line":14,"in_reply_to":"fa32b979_08987d1a","updated":"2015-06-22 15:39:08.000000000","message":"I will submit a spec for the version change.","commit_id":"62b5d648e0fb677ddc416779972c324b179c7dc5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e0477c5fed3cde7be188b830361f0d2d667373e0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"potentially other releases which will allow us to evaluate the"},{"line_number":12,"context_line":"the new version of this supporting service."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d773e569667e07106862507b881e3f0aca85591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa32b979_dac5823d","line":14,"in_reply_to":"fa32b979_a322c7ff","updated":"2015-06-22 13:46:57.000000000","message":"There is no bug this is simply an update for all release versions. IMO Referencing a \"bug/BP\" would be a waist of effort as it would be the same bug every two weeks as we are constantly updating everything to ensure we have the latest security / bug fixes in a stable branch.","commit_id":"62b5d648e0fb677ddc416779972c324b179c7dc5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d7a59a04e83644dc88b7c3066a7ecbde0c4f5b47","unresolved":false,"context_lines":[{"line_number":11,"context_line":"potentially other releases which will allow us to evaluate the"},{"line_number":12,"context_line":"the new version of this supporting service."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2d773e569667e07106862507b881e3f0aca85591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa32b979_08987d1a","line":14,"in_reply_to":"fa32b979_dac5823d","updated":"2015-06-22 15:10:35.000000000","message":"This is a major release version update, so I think this should have a specific bp/bug relationship instead of being handled like a minor patch.","commit_id":"62b5d648e0fb677ddc416779972c324b179c7dc5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9d9f0833f30256e89b0bb362357ceb027754c329","unresolved":false,"context_lines":[{"line_number":19,"context_line":"These changes enable us to leverage all of the new features and stability"},{"line_number":20,"context_line":"found within the updated version of MariaDB+Galera."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"BackportPotential"},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":"Implements: Blueprint MariaDB-upgrade-to-v10"},{"line_number":25,"context_line":"Change-Id: I2d773e569667e07106862507b881e3f0aca85591"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"da20952f_0547bf4b","line":22,"updated":"2015-08-29 21:13:17.000000000","message":"I think that marking this for backport potential is rather ambitious, but UpgradeImpact would be a good tag.","commit_id":"0215658d652d6283e11a6e216d16daacc7994033"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The change updates mariadb to use version 10."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* The percona-xtrabackup repository was added"},{"line_number":12,"context_line":"* the custom mysql init script was removed infavor of allowing the"},{"line_number":13,"context_line":"  packages to resolve its own init script"},{"line_number":14,"context_line":"* the install process was modified such that its faster while preserving"},{"line_number":15,"context_line":"  the variable functionality already implemented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"da20952f_4838de3d","line":12,"range":{"start_line":12,"start_character":42,"end_line":12,"end_character":43},"updated":"2015-09-09 07:43:24.000000000","message":"s/infavor/in favor/","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* The percona-xtrabackup repository was added"},{"line_number":12,"context_line":"* the custom mysql init script was removed infavor of allowing the"},{"line_number":13,"context_line":"  packages to resolve its own init script"},{"line_number":14,"context_line":"* the install process was modified such that its faster while preserving"},{"line_number":15,"context_line":"  the variable functionality already implemented."},{"line_number":16,"context_line":"* The Galera cluster.cnf was modified to allow the user to define the wsrep"},{"line_number":17,"context_line":"  method and a section for xtrabackup was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"da20952f_3b42a369","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":61},"updated":"2015-09-09 07:43:24.000000000","message":"s/its/it\u0027s/\n\n\nHow much faster is it?","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* The percona-xtrabackup repository was added"},{"line_number":12,"context_line":"* the custom mysql init script was removed infavor of allowing the"},{"line_number":13,"context_line":"  packages to resolve its own init script"},{"line_number":14,"context_line":"* the install process was modified such that its faster while preserving"},{"line_number":15,"context_line":"  the variable functionality already implemented."},{"line_number":16,"context_line":"* The Galera cluster.cnf was modified to allow the user to define the wsrep"},{"line_number":17,"context_line":"  method and a section for xtrabackup was added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"da20952f_f17c31b7","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":61},"in_reply_to":"da20952f_3b42a369","updated":"2015-09-09 14:25:17.000000000","message":"had to quantify when only running in the gate, gate times are erratic, however with the lxc container profile set previously being done serially within the play as well as an ssh wait I\u0027d assume that its in the area of around 30 seconds faster on initial deployment and 10 seconds faster on a subsequent run per container, if not more.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"}],"playbooks/galera-install.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"4114566d45b99cb019279ab979604a557955877d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        - galera-ssh-wait"},{"line_number":103,"context_line":"  vars:"},{"line_number":104,"context_line":"    galera_ignore_cluster_state: false"},{"line_number":105,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":106,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":107,"context_line":"  tags:"},{"line_number":108,"context_line":"    - galera-discover-cluster-state"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"da20952f_ab837455","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":20},"updated":"2015-08-28 11:27:28.000000000","message":"I appreciate that this isn\u0027t introduced by this patch, but seems unnecessary.","commit_id":"15b8965c1dabda8d9a3c6d0006a5f7a3ff88efe1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"60feb4ba36172fec887f066fba05d3d9ff2ed780","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        - galera-ssh-wait"},{"line_number":103,"context_line":"  vars:"},{"line_number":104,"context_line":"    galera_ignore_cluster_state: false"},{"line_number":105,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":106,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":107,"context_line":"  tags:"},{"line_number":108,"context_line":"    - galera-discover-cluster-state"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"da20952f_b75671d0","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":20},"in_reply_to":"da20952f_ab837455","updated":"2015-08-28 14:43:06.000000000","message":"Done","commit_id":"15b8965c1dabda8d9a3c6d0006a5f7a3ff88efe1"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Discover galera server state"},{"line_number":17,"context_line":"  hosts: galera_all"},{"line_number":18,"context_line":"  max_fail_percentage: 0"},{"line_number":19,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_1bd79fc0","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":16},"updated":"2015-09-09 07:43:24.000000000","message":"This name seems a bit misleading now the lxc stuff is part of the play","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Discover galera server state"},{"line_number":17,"context_line":"  hosts: galera_all"},{"line_number":18,"context_line":"  max_fail_percentage: 0"},{"line_number":19,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_b17c79ec","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":16},"in_reply_to":"da20952f_1bd79fc0","updated":"2015-09-09 14:25:17.000000000","message":"I disagree, if the deployment was using lxc, the default, the lxc container would have to have its profile set accordingly which would be part of the \"server state\"","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"0686219aa5f5a1dd4c50fb4c4dce784e065373f0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        galera_existing_cluster: true"},{"line_number":66,"context_line":"      with_items: play_hosts"},{"line_number":67,"context_line":"      when: hostvars[item].mysql_running.rc \u003d\u003d 0"},{"line_number":68,"context_line":"  tasks:"},{"line_number":69,"context_line":"    - name: Use the lxc-openstack aa profile"},{"line_number":70,"context_line":"      lxc_container:"},{"line_number":71,"context_line":"        name: \"{{ container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_c34931b9","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":8},"updated":"2015-09-09 07:44:30.000000000","message":"Do any of these tasks cause containers to reboot?","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        galera_existing_cluster: true"},{"line_number":66,"context_line":"      with_items: play_hosts"},{"line_number":67,"context_line":"      when: hostvars[item].mysql_running.rc \u003d\u003d 0"},{"line_number":68,"context_line":"  tasks:"},{"line_number":69,"context_line":"    - name: Use the lxc-openstack aa profile"},{"line_number":70,"context_line":"      lxc_container:"},{"line_number":71,"context_line":"        name: \"{{ container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_91861515","line":68,"range":{"start_line":68,"start_character":7,"end_line":68,"end_character":8},"in_reply_to":"da20952f_c34931b9","updated":"2015-09-09 14:25:17.000000000","message":"None of the changes that I have added to this file cause the container to reboot. Obviously the existing LN:73 could cause the container to restart if the apparmor profile was not already defined as \"lxc-openstack\" however at this point that should not be a general concern. the \"lxc-openstack\" aa profile is our default across the board and has been since Kilo.\n\nAll of these changes simply give the existing tasks a name and move the lxc_container commands to this task set because there\u0027s really no reason that it need to be serial.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"}],"playbooks/roles/galera_server/handlers/main.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 3"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    inventory_hostname !\u003d galera_server_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_5b019769","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":54},"updated":"2015-09-09 07:43:24.000000000","message":"What happens when the config etc is updated on the bootstrap node? Based on this it will never be restarted.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"33c009124a2ea452a67803cc7beeecf06147d470","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 3"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    inventory_hostname !\u003d galera_server_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_00fdc36d","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":54},"in_reply_to":"da20952f_50bcf2da","updated":"2015-09-09 17:47:54.000000000","message":"Done, I\u0027ll remove the conditional.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 3"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    inventory_hostname !\u003d galera_server_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_a16746e9","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":54},"in_reply_to":"da20952f_5b019769","updated":"2015-09-09 14:25:17.000000000","message":"If it was a running cluster and the config changes simply restarting the service will result in a running cluster; wsrep is already running so there\u0027s no need to re-bootstrap. In fact doing so will result in error. If the cluster is down and etc config changes the state of those files will not matter as the cluster will need to be re-bootstrapped regardless.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"c540b579ac227ee9144d89d421e963de947e9ab1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 3"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    inventory_hostname !\u003d galera_server_bootstrap_node"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_50bcf2da","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":54},"in_reply_to":"da20952f_a16746e9","updated":"2015-09-09 15:53:16.000000000","message":"What restarts the node with inventory_hostname \u003d\u003d galera_server_bootstrap_node if, for example, the task \u0027Drop mariadb config(s)\u0027 updates a conf file?","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"}],"playbooks/roles/galera_server/tasks/galera_add_node.yml":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"939bd9a3f97bf453171a54f84c2ad6469c0ee719","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a50d1a3_dd8920cc","line":2,"updated":"2015-07-20 14:54:43.000000000","message":"s/2014/2015","commit_id":"957c81a64a5609861418a7da6923b934a66866da"}],"playbooks/roles/galera_server/tasks/galera_bootstrap.yml":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"939bd9a3f97bf453171a54f84c2ad6469c0ee719","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a50d1a3_fdadfc31","line":2,"updated":"2015-07-20 14:54:43.000000000","message":"s/2014/2015","commit_id":"957c81a64a5609861418a7da6923b934a66866da"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - galera-bootstrap"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Serially check for an operational cluster and notify the additional nodes to restart"},{"line_number":28,"context_line":"- name: Wait for operational state"},{"line_number":29,"context_line":"  command: mysql --silent --skip-column-names -e \u0027SHOW STATUS LIKE \"wsrep_evs_state\"\u0027"},{"line_number":30,"context_line":"  register: galera_check_wait"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_bba8f321","line":27,"updated":"2015-09-09 07:43:24.000000000","message":"I don\u0027t think this comment is accurate. Nothing is serialised by this task. The only node it will run on is galera_server_bootstrap_node and there\u0027s not much point restarting that when it\u0027s just been bootstrapped.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - galera-bootstrap"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Serially check for an operational cluster and notify the additional nodes to restart"},{"line_number":28,"context_line":"- name: Wait for operational state"},{"line_number":29,"context_line":"  command: mysql --silent --skip-column-names -e \u0027SHOW STATUS LIKE \"wsrep_evs_state\"\u0027"},{"line_number":30,"context_line":"  register: galera_check_wait"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"da20952f_c1d7da4d","line":27,"in_reply_to":"da20952f_bba8f321","updated":"2015-09-09 14:25:17.000000000","message":"Done","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"45009d8790c2a63049b1ecfb1d354025e1c08349","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - galera-bootstrap"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Wait for operational state"},{"line_number":28,"context_line":"  command: mysql --silent --skip-column-names -e \u0027SHOW STATUS LIKE \"wsrep_evs_state\"\u0027"},{"line_number":29,"context_line":"  register: galera_check_wait"},{"line_number":30,"context_line":"  until: galera_check_wait|success"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"da20952f_708fb675","line":27,"updated":"2015-09-09 15:52:42.000000000","message":"Nothing will ever be restarted by this task because the \u0027Restart mysql\u0027 handler is skipped when run on galera_server_bootstrap_node and the only host that will ever be notified by this task is galera_server_bootstrap_node and only when there isn\u0027t an existing cluster.","commit_id":"023fad90c8aa245709a733da131703c8f540d054"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"726d424747e5dae7909cab46a7b177977a00cdaa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  tags:"},{"line_number":25,"context_line":"    - galera-bootstrap"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Wait for operational state"},{"line_number":28,"context_line":"  command: mysql --silent --skip-column-names -e \u0027SHOW STATUS LIKE \"wsrep_evs_state\"\u0027"},{"line_number":29,"context_line":"  register: galera_check_wait"},{"line_number":30,"context_line":"  until: galera_check_wait|success"}],"source_content_type":"text/x-yaml","patch_set":39,"id":"da20952f_40b5fbcd","line":27,"in_reply_to":"da20952f_708fb675","updated":"2015-09-09 17:48:08.000000000","message":"Done, I\u0027ll remove the notify as its not really needed.","commit_id":"023fad90c8aa245709a733da131703c8f540d054"}],"playbooks/roles/galera_server/tasks/galera_cluster_state.yml":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"9b8a82bb6599c51a63f0b5dec5e0dbace5f6be62","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - not galera_ignore_cluster_state | bool"},{"line_number":33,"context_line":"    - mysql_running.rc \u003d\u003d 1"},{"line_number":34,"context_line":"    - mysql_running.stderr | search(\"Check that mysqld is running and that the socket\")"},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"  - galera-cluster-state-check"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Gather mysql facts"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"9a1a9d01_786acf82","line":35,"updated":"2015-09-29 19:31:20.000000000","message":"Style nit: The list under \"when\" is indented while this (and other tags in the file aren\u0027t)","commit_id":"5fdc2300e04a5c23b1f54406e89d3d2766be2088"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"62757b41eb4a401b0fed4810755274b6ef31e6b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    - not galera_ignore_cluster_state | bool"},{"line_number":33,"context_line":"    - mysql_running.rc \u003d\u003d 1"},{"line_number":34,"context_line":"    - mysql_running.stderr | search(\"Check that mysqld is running and that the socket\")"},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"  - galera-cluster-state-check"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Gather mysql facts"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"9a1a9d01_aafa4973","line":35,"in_reply_to":"9a1a9d01_786acf82","updated":"2015-09-29 22:19:51.000000000","message":"Done","commit_id":"5fdc2300e04a5c23b1f54406e89d3d2766be2088"}],"playbooks/roles/galera_server/templates/mysql_defaults.j2":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"215f9fd7f211fb06f447e5149cba70669c3bee49","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{%- set all_calculated_max_connections \u003d [] %}"},{"line_number":4,"context_line":"{%- for galera_node in groups[\u0027galera_all\u0027] %}"},{"line_number":5,"context_line":"    {%- if all_calculated_max_connections.append(hostvars[galera_node][\u0027ansible_processor_vcpus\u0027] * 100) %}"},{"line_number":6,"context_line":"    {%- endif %}"},{"line_number":7,"context_line":"{%- endfor %}"},{"line_number":8,"context_line":"{%- set calculated_max_connections \u003d all_calculated_max_connections|sort %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"fa1b9901_5de96419","line":5,"updated":"2015-08-24 15:43:00.000000000","message":"I prefer {% set _ \u003d ... %} Instead of an if. Easier to see that _ is unused, rather than the if block.","commit_id":"9a28cbe65f30c550a05e61ad97393aa52f3d900a"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"215f9fd7f211fb06f447e5149cba70669c3bee49","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# Startup can take a while if it requires a galera state transfer."},{"line_number":12,"context_line":"MYSQLD_STARTUP_TIMEOUT\u003d1800"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"ulimit -Hn  {{ galera_max_connections | default(calculated_max_connections[0]) }}"},{"line_number":15,"context_line":"ulimit -n  {{ galera_max_connections | default(calculated_max_connections[0]) }}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"fa1b9901_fd771839","line":14,"range":{"start_line":14,"start_character":48,"end_line":14,"end_character":74},"updated":"2015-08-24 15:43:00.000000000","message":"\"all_calculated_max_connections|min\" may be clearer than |sort [0]","commit_id":"9a28cbe65f30c550a05e61ad97393aa52f3d900a"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"da81fab3b5db9f58f62193b6921d03b0175fc0b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"da20952f_7b2fbba7","updated":"2015-09-09 07:43:24.000000000","message":"To which section of the commit message does this change relate?","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8273c32bbaa6848daac591d61fdd69cb4385734d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"da20952f_41398aa2","in_reply_to":"da20952f_7b2fbba7","updated":"2015-09-09 14:25:17.000000000","message":"I believe you were looking for the title \"Updated MariaDB to the new release version (10.0)\" however I also added a note to the role defaults which indicates how the \"galera_max_connection\" value can be used and what is done if it\u0027s not set. Additionally to satisfy your requirement for truthiness I have added a point to the commit message.","commit_id":"a73446e17b2df46a968d14a467311ba5f33712d9"}]}