)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"1d65a38ef89b2f0fbaa3b78f0d21a690c11dfa84","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow Swift middleware to be set via a variable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch allows the swift-proxy pipeline to be adjusted via a variable"},{"line_number":10,"context_line":"\"swift_middleware_list\", which can be ammended to add additional"},{"line_number":11,"context_line":"middleware as required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The default remains the same - which is to include the default pipeline"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_453e95db","line":10,"updated":"2015-06-26 14:29:49.000000000","message":"amended","commit_id":"70c3a280086907acacfd3ef2e88ebae2a0dd829d"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d394c935c1eb97367d6e76f470e9143c4ab82a1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     5a228e28 (Merge \"Updated keystone to use fernet as the default\")"},{"line_number":2,"context_line":"Author:     Andy McCrae \u003candy.mccrae@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-06-26 12:21:47 +0100"},{"line_number":4,"context_line":"Commit:     Andy McCrae \u003candy.mccrae@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-26 17:41:02 +0100"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa32b979_2ccd6a86","line":2,"updated":"2015-06-26 21:27:44.000000000","message":"Maybe a co-authored line for Julian?","commit_id":"f817b0f3ee6aff7940860a9312eb559cc3bccc26"}],"playbooks/roles/os_swift/defaults/main.yml":[{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"5993ae3ab94b91da4a4a5562d42de64125967f94","unresolved":false,"context_lines":[{"line_number":161,"context_line":"swift_proxy_program_names:"},{"line_number":162,"context_line":"  - swift-proxy-server"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"swift_middleware_program_names:"},{"line_number":165,"context_line":"  - catch_errors"},{"line_number":166,"context_line":"  - gatekeeper"},{"line_number":167,"context_line":"  - healthcheck"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a016987_6ea68eaf","line":164,"updated":"2015-05-20 17:40:44.000000000","message":"This might\u0027ve been just a copy/paste thing. But since these are really just references to paste filters in the config rather than programs, and since it\u0027s possible to have custom middlewares in account/container/object servers as well, it might be more appropriate to call this swift_proxy_middleware_names.","commit_id":"c78ffad49f1d15dbd043f3319c5565386604f490"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"1738fa7df3b317a2f6da7e1e84c4ccab39d96fa1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"  - name_check"},{"line_number":186,"context_line":"  - list-endpoints"},{"line_number":187,"context_line":"  - xprofile"},{"line_number":188,"context_line":"  - proxy-server"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a016987_2c455a6f","line":188,"updated":"2015-05-19 00:09:35.000000000","message":"Can we set this to the default for swift, which is:\ncatch_errors gatekeeper healthcheck proxy-logging cache container_sync bulk tempurl ratelimit tempauth container-quotas account-quotas slo dlo proxy-logging proxy-server\n\nWe\u0027d use the authtoken/keystoneauth rather than tempauth by default though - other than that though.","commit_id":"c78ffad49f1d15dbd043f3319c5565386604f490"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"1d65a38ef89b2f0fbaa3b78f0d21a690c11dfa84","unresolved":false,"context_lines":[{"line_number":30,"context_line":"## Auth token"},{"line_number":31,"context_line":"# NB If you set swift_authtoken_active: False you should adjust swift_middleware_list below."},{"line_number":32,"context_line":"# Replace \"authtoken\" \u0026 \"keystoneauth\" with \"tempauth\". Order is important."},{"line_number":33,"context_line":"swift_authtoken_active: True"},{"line_number":34,"context_line":"swift_delay_auth_decision: true"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"## Swift middleware"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_0573ade8","line":33,"updated":"2015-06-26 14:29:49.000000000","message":"Instead of manually setting this var why not set it to something like:\n\n{{ \u0027authtoken\u0027 in swift_middleware_list and \u0027keystoneauth\u0027 in swift_middleware_list }}","commit_id":"70c3a280086907acacfd3ef2e88ebae2a0dd829d"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"48f96814d3a96af540ae917705938c7413d8fae4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  - gatekeeper"},{"line_number":41,"context_line":"  - healthcheck"},{"line_number":42,"context_line":"  - proxy-logging"},{"line_number":43,"context_line":"#  - ceilometer"},{"line_number":44,"context_line":"  - cache"},{"line_number":45,"context_line":"  - container_sync"},{"line_number":46,"context_line":"  - bulk"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a50d1a3_a67c7171","line":43,"updated":"2015-07-29 22:10:09.000000000","message":"Nah, I don\u0027t think it\u0027s that big of a deal. We probably just need to document the fact that this is off-by-default for people who want to use ceilometer with osad and expect swift to be using the middleware. That\u0027s probably a follow-on patch though.","commit_id":"2ed2bde1b0e728831c17b32b8805a3435f1ee38f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"030484be21d9655929bfe6a2027382d0c34eabf8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  - gatekeeper"},{"line_number":41,"context_line":"  - healthcheck"},{"line_number":42,"context_line":"  - proxy-logging"},{"line_number":43,"context_line":"#  - ceilometer"},{"line_number":44,"context_line":"  - cache"},{"line_number":45,"context_line":"  - container_sync"},{"line_number":46,"context_line":"  - bulk"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a50d1a3_61c65b9b","line":43,"updated":"2015-07-29 19:30:09.000000000","message":"Should this be on by default since we now have playbooks for ceilometer?","commit_id":"2ed2bde1b0e728831c17b32b8805a3435f1ee38f"},{"author":{"_account_id":14202,"name":"Julian Montez","email":"julian.montez@gmail.com","username":"jmontez"},"change_message_id":"3700a20d37f42319200a9a37a552560fb51f284e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  - gatekeeper"},{"line_number":41,"context_line":"  - healthcheck"},{"line_number":42,"context_line":"  - proxy-logging"},{"line_number":43,"context_line":"#  - ceilometer"},{"line_number":44,"context_line":"  - cache"},{"line_number":45,"context_line":"  - container_sync"},{"line_number":46,"context_line":"  - bulk"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3a50d1a3_04d8c551","line":43,"in_reply_to":"3a50d1a3_61c65b9b","updated":"2015-07-29 20:00:39.000000000","message":"I commented out by default because the variable for whether it\u0027s enabled further up in the `os_swift` defaults is false.\n\nSee: https://github.com/stackforge/os-ansible-deployment/blob/78d1bb611055177f393d3a9c08047a4f83c3ab23/playbooks/roles/os_swift/defaults/main.yml#L19-L20\n\nIt\u0027s changed using sed in the `bootstrap-aio.sh` script, though.\n\nSee: https://github.com/stackforge/os-ansible-deployment/blob/39409db9b9caea199fd61110f348c0be209e6754/scripts/bootstrap-aio.sh#L337-L339\n\nShould we can use sed to un-comment the line in the middleware list for the bootstrap, as well?","commit_id":"2ed2bde1b0e728831c17b32b8805a3435f1ee38f"}],"playbooks/roles/os_swift/templates/proxy-server.conf.j2":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"1738fa7df3b317a2f6da7e1e84c4ccab39d96fa1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"log_facility \u003d LOG_LOCAL1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[pipeline:main]"},{"line_number":15,"context_line":"{% if swift_authtoken_active %}"},{"line_number":16,"context_line":"pipeline \u003d authtoken {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"pipeline \u003d {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a016987_cc2126b6","line":15,"updated":"2015-05-19 00:09:35.000000000","message":"This mechanism becomes problematic if we are using a set variable list, since the order of the pipeline is important, and the auth value in the middle is the change from the if/else statement.\n\nPerhaps a better way to do this is to remove this conditional altogether and just use the default vars, if you want to use something else you can change it then. (This could be documented)\n\nOr you could get clever and set a \"auth_token_pipeline_var\" or something which is set, and then used in the swift_middleware_program_names, but that could be overcomplicating things.","commit_id":"c78ffad49f1d15dbd043f3319c5565386604f490"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"fcc0b4d7acbbb9d47cbc8fb114c9297b2ee21e29","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[pipeline:main]"},{"line_number":15,"context_line":"{% if swift_authtoken_active %}"},{"line_number":16,"context_line":"pipeline \u003d authtoken {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"pipeline \u003d {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a016987_ea472a1b","line":16,"updated":"2015-05-18 15:56:04.000000000","message":"By default, won\u0027t this result in authtoken appearing twice in the pipeline? Does order matter with the pipeline?\n\nMaybe get rid of the authtoken if-block for pipeline and replace the other one in this file with a membership test on swift_middleware_program_names?","commit_id":"c78ffad49f1d15dbd043f3319c5565386604f490"},{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"5993ae3ab94b91da4a4a5562d42de64125967f94","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[pipeline:main]"},{"line_number":15,"context_line":"{% if swift_authtoken_active %}"},{"line_number":16,"context_line":"pipeline \u003d authtoken {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"pipeline \u003d {% for item in swift_middleware_program_names %} {{ item }} {% endfor %}"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a016987_f53d9b8f","line":16,"in_reply_to":"7a016987_ea472a1b","updated":"2015-05-20 17:40:44.000000000","message":"Yes, with this changeset it will appear twice, and the pipeline order definitely matters. Since this list is now being explicitly defined and defaulted in config, it\u0027s probably best not to use any automatic middleware insertion.","commit_id":"c78ffad49f1d15dbd043f3319c5565386604f490"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d394c935c1eb97367d6e76f470e9143c4ab82a1b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"log_facility \u003d LOG_LOCAL1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[pipeline:main]"},{"line_number":15,"context_line":"pipeline \u003d{% for item in swift_middleware_list %} {{ item }}{% endfor %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[app:proxy-server]"},{"line_number":18,"context_line":"use \u003d egg:swift#proxy"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_4c922ea1","line":15,"updated":"2015-06-26 21:27:44.000000000","message":"I think this could also be written as:\n\npipeline \u003d {{ swift_middleware_list | join(\u0027 \u0027) }}","commit_id":"f817b0f3ee6aff7940860a9312eb559cc3bccc26"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d394c935c1eb97367d6e76f470e9143c4ab82a1b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[filter:tempauth]"},{"line_number":34,"context_line":"use \u003d egg:swift#tempauth"},{"line_number":35,"context_line":"{% if \u0027tempauth\u0027 in swift_middleware_list %}"},{"line_number":36,"context_line":"user_admin_admin \u003d admin .admin .reseller_admin"},{"line_number":37,"context_line":"user_test_tester \u003d testing .admin"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_8c2356a7","line":34,"updated":"2015-06-26 21:27:44.000000000","message":"Would it make more sense if the above two lines were part of the following if-block?","commit_id":"f817b0f3ee6aff7940860a9312eb559cc3bccc26"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"d394c935c1eb97367d6e76f470e9143c4ab82a1b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"{% endif %}"},{"line_number":63,"context_line":"# The reseller admin role has the ability to create and delete accounts"},{"line_number":64,"context_line":"reseller_admin_role \u003d reseller_admin"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"[filter:healthcheck]"},{"line_number":67,"context_line":"use \u003d egg:swift#healthcheck"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_ec18e220","line":65,"updated":"2015-06-26 21:27:44.000000000","message":"Would there be any benefit in wrapping each filter in an if-block, so that it is only added to the file if it is specified in swift_middleware_list?","commit_id":"f817b0f3ee6aff7940860a9312eb559cc3bccc26"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3d161c6d438ed794611cde47e3fee8af8238aaf8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"use \u003d egg:swift#keystoneauth"},{"line_number":61,"context_line":"{% if swift_allow_all_users is defined and swift_allow_all_users \u003d\u003d True %}"},{"line_number":62,"context_line":"{% if \u0027ceilometer\u0027 in swift_middleware_list %}"},{"line_number":63,"context_line":"operator_roles \u003d admin, swiftoperator, _member_, ResellerAdmin"},{"line_number":64,"context_line":"{% else %}"},{"line_number":65,"context_line":"operator_roles \u003d admin, swiftoperator, _member_"},{"line_number":66,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3a50d1a3_f5cbe570","line":63,"updated":"2015-07-20 09:04:17.000000000","message":"Why not handle the operator roles as an array? Order is not important here as far as I know.","commit_id":"c3979c491983393a7ca0a6f66850f85a2cfffd94"}]}