)]}'
{"scripts/update-revision.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c4c630baf803b507dee6e1c2097010b39f73bc2a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_fd5ba0f4","line":44,"updated":"2015-06-08 08:03:19.000000000","message":"The \u0027\u0027 which has been removed here was to enable the script to be used on more than just an Ubuntu linux workstation. It should work more universally, including on Mac OS X.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"61732d79cb939508c483d1743872f5ccc9888723","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_fbb7e137","line":44,"in_reply_to":"3afb71cf_2901c56a","updated":"2015-06-09 14:49:57.000000000","message":"That\u0027s what the \u0027\u0027 was for - an empty suffix, which means no backup file.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e6dd2c506254c5ca99e88574dbd63f624b59066f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_60a8b977","line":44,"in_reply_to":"3afb71cf_2ee2c42f","updated":"2015-06-10 08:16:30.000000000","message":"Or we could ignore .bk files through git - but as I stated earlier in this thread, I don\u0027t care enough for this to hold up the patch. I suggest letting it through as-is.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8d55ccac0b7e0291f936c2e9898e0a64c531beb7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_d72b0793","line":44,"in_reply_to":"3afb71cf_37413baa","updated":"2015-06-08 17:56:51.000000000","message":"if there\u0027s a way to support both we should do that, maybe ill dig into it a bit first.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c6d948be196d41b48fbcc0921f071f62a521b7d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_fca7a6a4","line":44,"in_reply_to":"3afb71cf_60a8b977","updated":"2015-06-10 13:38:03.000000000","message":"Done","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"38d50d4b1579626c0325ab1e2c4ec7730b2550a5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_2ee2c42f","line":44,"in_reply_to":"3afb71cf_735d4346","updated":"2015-06-09 22:46:33.000000000","message":"I guess it depends on where you\u0027re doing your dev work, if you\u0027re working from a local copy on your MBP you will want the BSD version to work.  I propose that we make the change and then add:\n\n    rm playbooks/inventory/group_vars/all.yml.bk\n\nAt the end of the script.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"147888f9332bf861ba35f55ace3e30bfc41c18db","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_37413baa","line":44,"in_reply_to":"3afb71cf_77de9340","updated":"2015-06-08 17:50:50.000000000","message":"Odd, I thought I had tested and confirmed that it worked both ways. Oh well, in that case I agree.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"ee382c21ef076f7593610d2fc9bd2565d00ca476","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_2901c56a","line":44,"in_reply_to":"3afb71cf_d72b0793","updated":"2015-06-09 10:07:30.000000000","message":"Specify a suffix to -i, then it works on both. eg -i.bk","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2c54095c7f00d91a2fe39d73ca8beeaa9e3bdc45","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_735d4346","line":44,"in_reply_to":"3afb71cf_fbb7e137","updated":"2015-06-09 22:36:17.000000000","message":"-i.bk will work on both Linux and OSX but -i \u0027\u0027 does not work. However do we want to create backup files everytime we run this, and do we really care if it runs on OSX?","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"87d88e1773e0233ab85d8be9187d22e0312a9ad0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"shift"},{"line_number":42,"context_line":"done"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"sed -i \"s/^openstack_release\\:.*/openstack_release\\: ${REVISION}/\" playbooks/inventory/group_vars/all.yml"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3afb71cf_77de9340","line":44,"in_reply_to":"3afb71cf_fd5ba0f4","updated":"2015-06-08 17:45:35.000000000","message":"This breaks usage on Linux with GNU sed but works on BSD sed (OSX) so im of the opinion that we should be making the scripts work on Linux more so than on OSX.","commit_id":"9ee8362ad77bee58e88c708adc191af9f4bedee7"}]}