)]}'
{"rpc_deployment/playbooks/openstack/neutron-all.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"1eb5f097e565dffaa4f48c05d2401680fb394822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa32b979_fec70810","updated":"2015-06-16 09:23:57.000000000","message":"I\u0027m curious as to why you\u0027ve moved these conditionals to the role level?","commit_id":"d71a44e37bcfbcd9246bb333a3d86fddd782158a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7d0a753a17814cd2f3182dd6777bebb554a18491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa32b979_d0646823","in_reply_to":"fa32b979_fec70810","updated":"2015-06-16 12:21:35.000000000","message":"All of these conditionals were moved from. Here because ansible does not evaluate the \"when\" cinditional on a playbook include they simply always evaluate to true.","commit_id":"d71a44e37bcfbcd9246bb333a3d86fddd782158a"}],"rpc_deployment/roles/neutron_common/tasks/plumgrid_config.yml":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"78e932fce272937de0d56b9fe5b2cd5c537fd679","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3afb71cf_5a485e87","line":2,"updated":"2015-06-08 18:15:05.000000000","message":"Is this true of the result of a copy-paste?","commit_id":"be3c8a857d3bfe50724b35b9f5a63ee5ae5220ce"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"c224b69d1c18acff7184fdeb22c5e6d479914e07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3afb71cf_ad64be21","line":2,"in_reply_to":"3afb71cf_2d6a0eb4","updated":"2015-06-08 18:39:02.000000000","message":"IMO you should update the year or organization (or just leave out the line). I don\u0027t know the project policy, but I prefer to not have copyrights in the files since they don\u0027t provide any value.","commit_id":"be3c8a857d3bfe50724b35b9f5a63ee5ae5220ce"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"f3b6c744d3aa8fedf380605782ce1377003497d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3afb71cf_2d6a0eb4","line":2,"in_reply_to":"3afb71cf_5a485e87","updated":"2015-06-08 18:19:33.000000000","message":"No, I assumed this was what the community preferred to use for all the playbooks inside OSAD. Would using our organization be more appropriate?","commit_id":"be3c8a857d3bfe50724b35b9f5a63ee5ae5220ce"},{"author":{"_account_id":15823,"name":"Serge van Ginderachter","email":"serge@vanginderachter.be","username":"svg"},"change_message_id":"0a9157820fb683c38b619d8606e95a76353d145c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Setup PLUMlib Neutron Config"},{"line_number":16,"context_line":"  template: \u003e"},{"line_number":17,"context_line":"    src\u003dplugins/plumgrid/plumlib.ini"},{"line_number":18,"context_line":"    dest\u003d/etc/neutron/plugins/plumgrid/plumlib.ini"},{"line_number":19,"context_line":"    owner\u003d{{ system_group }}"},{"line_number":20,"context_line":"    group\u003d{{ system_user }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa32b979_4e51bb0d","line":17,"updated":"2015-06-15 19:27:42.000000000","message":"I believe this task should be rewritten in pure yaml syntax.","commit_id":"234bea93cd64a2c3919778b00ff280a564be3877"}],"rpc_deployment/roles/neutron_common/templates/plugins/plumgrid/plumgrid.ini":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e130b7031a02daaffc3b1909a3020fe62f837d7f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username\u003dplumgrid"},{"line_number":12,"context_line":"password\u003dplumgrid"},{"line_number":13,"context_line":"servertimeout\u003d70"},{"line_number":14,"context_line":"connection \u003d mysql://neutron:{{ neutron_container_mysql_password }}@{{ internal_lb_vip_address }}/neutron?charset\u003dutf8"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_2686abb9","line":14,"updated":"2015-06-08 19:51:12.000000000","message":"The DB user may not be \"neutron\" the variable should be set as \"container_mysql_user\" as defined in the groupvars found here: https://github.com/stackforge/os-ansible-deployment/blob/juno/rpc_deployment/inventory/group_vars/neutron_all.yml#L52","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"3851c34adf0120353ccd68f43da20e2db216e58f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"username\u003dplumgrid"},{"line_number":12,"context_line":"password\u003dplumgrid"},{"line_number":13,"context_line":"servertimeout\u003d70"},{"line_number":14,"context_line":"connection \u003d mysql://neutron:{{ neutron_container_mysql_password }}@{{ internal_lb_vip_address }}/neutron?charset\u003dutf8"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_777b1af6","line":14,"in_reply_to":"3afb71cf_2686abb9","updated":"2015-06-09 07:45:37.000000000","message":"Right, good catch, fixed it in next patch.","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dbc52cfc006ecdf16eed7902e149851dcb0702c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# This line should point to the PLUMgrid Director Virtual-IP,"},{"line_number":5,"context_line":"# for the PLUMgrid Platform."},{"line_number":6,"context_line":"director_server\u003d{{ pg_vip }}"},{"line_number":7,"context_line":"director_server_port\u003d443"},{"line_number":8,"context_line":"# Authentification parameters for the Director."},{"line_number":9,"context_line":"# These are the admin credentials to manage and control"},{"line_number":10,"context_line":"# the PLUMgrid Director server."}],"source_content_type":"text/x-properties","patch_set":4,"id":"3afb71cf_be393bd9","line":7,"updated":"2015-06-10 02:56:33.000000000","message":"unless this will always be 443 we may want to parameterize this.","commit_id":"9fe28b291861a8dd5e31e3f995aa3710a2de116a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dbc52cfc006ecdf16eed7902e149851dcb0702c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Authentification parameters for the Director."},{"line_number":9,"context_line":"# These are the admin credentials to manage and control"},{"line_number":10,"context_line":"# the PLUMgrid Director server."},{"line_number":11,"context_line":"username\u003dplumgrid"},{"line_number":12,"context_line":"password\u003dplumgrid"},{"line_number":13,"context_line":"servertimeout\u003d70"},{"line_number":14,"context_line":"connection \u003d mysql://{{ container_mysql_user }}:{{ neutron_container_mysql_password }}@{{ internal_lb_vip_address }}/neutron?charset\u003dutf8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3afb71cf_9e32fff0","line":11,"updated":"2015-06-10 02:56:33.000000000","message":"if we\u0027re setting the pg_vip as a variable in this file I think it would be good to have these variables available to be set, using the role.\n\nI\u0027d image `pg_username` and `pg_password` can be set within the role.","commit_id":"9fe28b291861a8dd5e31e3f995aa3710a2de116a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"04f1191f273ab62b482a3d75946a4ba99afde11e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Authentification parameters for the Director."},{"line_number":9,"context_line":"# These are the admin credentials to manage and control"},{"line_number":10,"context_line":"# the PLUMgrid Director server."},{"line_number":11,"context_line":"username\u003dplumgrid"},{"line_number":12,"context_line":"password\u003dplumgrid"},{"line_number":13,"context_line":"servertimeout\u003d70"},{"line_number":14,"context_line":"connection \u003d mysql://{{ container_mysql_user }}:{{ neutron_container_mysql_password }}@{{ internal_lb_vip_address }}/neutron?charset\u003dutf8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3afb71cf_5906e186","line":11,"in_reply_to":"3afb71cf_1ee5efda","updated":"2015-06-10 03:59:57.000000000","message":"I\u0027d say that they be added as a variable but left unset so that the role will fail to converge if unset elsewhere.","commit_id":"9fe28b291861a8dd5e31e3f995aa3710a2de116a"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"773dfb2c6c08fd2817cbc856e2a2f32cdd292fef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Authentification parameters for the Director."},{"line_number":9,"context_line":"# These are the admin credentials to manage and control"},{"line_number":10,"context_line":"# the PLUMgrid Director server."},{"line_number":11,"context_line":"username\u003dplumgrid"},{"line_number":12,"context_line":"password\u003dplumgrid"},{"line_number":13,"context_line":"servertimeout\u003d70"},{"line_number":14,"context_line":"connection \u003d mysql://{{ container_mysql_user }}:{{ neutron_container_mysql_password }}@{{ internal_lb_vip_address }}/neutron?charset\u003dutf8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3afb71cf_1ee5efda","line":11,"in_reply_to":"3afb71cf_9e32fff0","updated":"2015-06-10 03:19:01.000000000","message":"Yes, I wasn\u0027t sure where it would be appropriate to include plumgrid variables, so \u0027pg_vip\u0027 was left as something that would error out unless the user replaced it with an appropriate value in this file. \nHaving all of these parametrized is a much better option, where do you suggest I put them?","commit_id":"9fe28b291861a8dd5e31e3f995aa3710a2de116a"}],"rpc_deployment/roles/neutron_common/templates/plugins/plumgrid/plumlib.ini":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e130b7031a02daaffc3b1909a3020fe62f837d7f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vapp_flag \u003d False"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[PLUMgridMetadata]"},{"line_number":18,"context_line":"metadata_ip\u003d169.254.169.254"},{"line_number":19,"context_line":"metadata_port\u003d8775"},{"line_number":20,"context_line":"metadata_key \u003d {{ nova_metadata_proxy_secret }}"},{"line_number":21,"context_line":"enable_pg_metadata \u003d False"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_e673f313","line":18,"updated":"2015-06-08 19:51:12.000000000","message":"Is this an address that will always be the same on a plumgrid deployment?","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"3851c34adf0120353ccd68f43da20e2db216e58f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vapp_flag \u003d False"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[PLUMgridMetadata]"},{"line_number":18,"context_line":"metadata_ip\u003d169.254.169.254"},{"line_number":19,"context_line":"metadata_port\u003d8775"},{"line_number":20,"context_line":"metadata_key \u003d {{ nova_metadata_proxy_secret }}"},{"line_number":21,"context_line":"enable_pg_metadata \u003d False"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_37fc8271","line":18,"in_reply_to":"3afb71cf_e673f313","updated":"2015-06-09 07:45:37.000000000","message":"Within a deployment, the metadata_ip will always have the same value. This is the default but its meant to be configurable, which can be done within this file.","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e130b7031a02daaffc3b1909a3020fe62f837d7f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[DNS]"},{"line_number":44,"context_line":"enable_dns_update \u003d False"},{"line_number":45,"context_line":"endpoint \u003d https://DNS_SERVICE_IP/api/v1/api.php"},{"line_number":46,"context_line":"api_key \u003d 162-22O8BEYWO0DQGIM"},{"line_number":47,"context_line":"secret_key \u003d 171de423af844bad400a98ea5b9fa56d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_462887e2","line":45,"updated":"2015-06-08 19:51:12.000000000","message":"Does this need to be a variable?","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"3851c34adf0120353ccd68f43da20e2db216e58f","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[DNS]"},{"line_number":44,"context_line":"enable_dns_update \u003d False"},{"line_number":45,"context_line":"endpoint \u003d https://DNS_SERVICE_IP/api/v1/api.php"},{"line_number":46,"context_line":"api_key \u003d 162-22O8BEYWO0DQGIM"},{"line_number":47,"context_line":"secret_key \u003d 171de423af844bad400a98ea5b9fa56d"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_f7ccaa6b","line":45,"in_reply_to":"3afb71cf_462887e2","updated":"2015-06-09 07:45:37.000000000","message":"I\u0027ve decided to move the DNS parameters to within the plumgrid playbooks, where they can be managed better.","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e130b7031a02daaffc3b1909a3020fe62f837d7f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"[DNS]"},{"line_number":44,"context_line":"enable_dns_update \u003d False"},{"line_number":45,"context_line":"endpoint \u003d https://DNS_SERVICE_IP/api/v1/api.php"},{"line_number":46,"context_line":"api_key \u003d 162-22O8BEYWO0DQGIM"},{"line_number":47,"context_line":"secret_key \u003d 171de423af844bad400a98ea5b9fa56d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[keystone_authtoken]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_263c6b2e","line":46,"updated":"2015-06-08 19:51:12.000000000","message":"is this always going to be the same? is this something that the users should add in as a variable?","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e130b7031a02daaffc3b1909a3020fe62f837d7f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"enable_dns_update \u003d False"},{"line_number":45,"context_line":"endpoint \u003d https://DNS_SERVICE_IP/api/v1/api.php"},{"line_number":46,"context_line":"api_key \u003d 162-22O8BEYWO0DQGIM"},{"line_number":47,"context_line":"secret_key \u003d 171de423af844bad400a98ea5b9fa56d"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[keystone_authtoken]"},{"line_number":50,"context_line":"admin_user \u003d {{ auth_admin_username }}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3afb71cf_86367f50","line":47,"updated":"2015-06-08 19:51:12.000000000","message":"Is this something that we could generate and or have the user enter as a required variable?","commit_id":"8c07f9b406ff741c7d71783614cc701eb8db1a0a"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6365f669a99c9c0777861de42a8d3f63f6e09ed4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"cdb_configuration \u003d True"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Name of the interface plugged on fabric network"},{"line_number":11,"context_line":"fabric_eth \u003d eth1"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Security Policy Flag"},{"line_number":14,"context_line":"enable_pg_security \u003d True"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3afb71cf_fe2401b3","line":11,"updated":"2015-06-12 05:04:02.000000000","message":"Would this need to be a configurable option as well?","commit_id":"234bea93cd64a2c3919778b00ff280a564be3877"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"a60f536af2a6bc1d6782f5c990bd781030df7107","unresolved":false,"context_lines":[{"line_number":8,"context_line":"cdb_configuration \u003d True"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Name of the interface plugged on fabric network"},{"line_number":11,"context_line":"fabric_eth \u003d eth1"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Security Policy Flag"},{"line_number":14,"context_line":"enable_pg_security \u003d True"}],"source_content_type":"text/x-properties","patch_set":5,"id":"1af86dd1_7686f1ba","line":11,"in_reply_to":"3afb71cf_fe2401b3","updated":"2015-06-12 07:15:41.000000000","message":"No, this one refers to an interface inside the plumgrid container, that we install later, so its static.","commit_id":"234bea93cd64a2c3919778b00ff280a564be3877"}]}