)]}'
{"etc/openstack_deploy/env.d/cinder.yml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"78b92a1c427221fbc16b88004c348d006208a9ff","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_8e374afe","line":61,"updated":"2015-06-10 19:24:45.000000000","message":"This physical_skel specification should be moved to it\u0027s own storage-infra.yml file.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"607a6a8b0a3f43d860166e032b581ed37d0d121d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_8666f8ea","line":61,"in_reply_to":"3afb71cf_8e374afe","updated":"2015-06-11 08:51:58.000000000","message":"While I don\u0027t disagree, I\u0027ve tried to put the physical sections with the services that consume them. In this case there is no other service that consumes this physical section so it makes sense to me that it stays with the component/container structures that consume them. This way it\u0027s all together and easier to relate to each other.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"83cdaed25a92974ef8b3275c861e61973b0ae8d7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3afb71cf_cbcdf7b8","line":61,"updated":"2015-06-11 20:48:39.000000000","message":"I understand the argument that you are making but for a couple of reasons I disagree.  First off for consistency I think that since we have certain physical_skels broken out then we should have them all broken out.\n\nSecondly consider the addition of a component like Ceph, I think that in Cephs case you would use storage-infra_containers and storage-infra_hosts, so this would still need to be split out in the future.","commit_id":"1be957c1b7d6e50f5885b53118e9f54068138d81"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f33bc44c9837e3f8fdc351bec93f525dfddd39da","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af86dd1_63f9834d","line":61,"in_reply_to":"1af86dd1_03e76fe5","updated":"2015-06-12 15:14:46.000000000","message":"I\u0027m short of a crystal ball to determine that. :P I think it\u0027s a good convention to break them out when they\u0027re shared, but not when they\u0027re specific to a service. This is the approach I\u0027ve used with this patch. I don\u0027t think it\u0027s a good idea to split any of them out until it needs to be done through the implementation of something new.","commit_id":"1be957c1b7d6e50f5885b53118e9f54068138d81"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"dcbf8d2cc47d2eb5523989f6fa578c8ecc9d307c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af86dd1_03e76fe5","line":61,"in_reply_to":"1af86dd1_11eea78b","updated":"2015-06-12 15:11:17.000000000","message":"You make a good point and I\u0027m inclined to agree with you, but I have one question.  Will a given container_skel ever be shared by multiple component_skels?  I can\u0027t think of a time when this would happen.","commit_id":"1be957c1b7d6e50f5885b53118e9f54068138d81"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"cb8b73897bb217604b56a7efab888e316e9fb477","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af86dd1_8d882924","line":61,"in_reply_to":"1af86dd1_63f9834d","updated":"2015-06-12 16:16:28.000000000","message":"I too lack the crystal ball, and your solution makes sense to me.","commit_id":"1be957c1b7d6e50f5885b53118e9f54068138d81"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4607160587edce8924db47ca1be98d2d158de29e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      - all_containers"},{"line_number":59,"context_line":"  storage_hosts:"},{"line_number":60,"context_line":"    belongs_to:"},{"line_number":61,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af86dd1_11eea78b","line":61,"in_reply_to":"3afb71cf_cbcdf7b8","updated":"2015-06-12 07:56:25.000000000","message":"By that logic should we also have all container_skel\u0027s broken out? I\u0027m not at a point where I agree. For me it makes better sense to try and keep the items that relate to each other together in the file as far as possible and only to split them out when necessary. This makes figuring out how it fits together a heck of a lot simpler! With regards to Ceph using the storage-infra_hosts - at the time of merging that in, I would agree that it should split because it becomes a shared structure. Right now it\u0027s only used by cinder. The patch for Ceph should ideally split this out if it chooses to use the same skels.","commit_id":"1be957c1b7d6e50f5885b53118e9f54068138d81"}],"etc/openstack_deploy/env.d/rsyslog.yml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"78b92a1c427221fbc16b88004c348d006208a9ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - all_containers"},{"line_number":37,"context_line":"  log_hosts:"},{"line_number":38,"context_line":"    belongs_to:"},{"line_number":39,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_69088828","line":39,"updated":"2015-06-10 19:24:45.000000000","message":"This physical_skel should be moved to log-infra.yml","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"607a6a8b0a3f43d860166e032b581ed37d0d121d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - all_containers"},{"line_number":37,"context_line":"  log_hosts:"},{"line_number":38,"context_line":"    belongs_to:"},{"line_number":39,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_06a1e8f7","line":39,"in_reply_to":"3afb71cf_69088828","updated":"2015-06-11 08:51:58.000000000","message":"While I don\u0027t disagree, I\u0027ve tried to put the physical sections with the services that consume them. In this case there is no other service that consumes this physical section so it makes sense to me that it stays with the component/container structures that consume them. This way it\u0027s all together and easier to relate to each other.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"}],"etc/openstack_deploy/env.d/swift.yml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"78b92a1c427221fbc16b88004c348d006208a9ff","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      - all_containers"},{"line_number":79,"context_line":"  swift-proxy_hosts:"},{"line_number":80,"context_line":"    belongs_to:"},{"line_number":81,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_293e10c1","line":81,"updated":"2015-06-10 19:24:45.000000000","message":"This physical_skel should be moved to something like object-storage-infra.yml.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"607a6a8b0a3f43d860166e032b581ed37d0d121d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      - all_containers"},{"line_number":79,"context_line":"  swift-proxy_hosts:"},{"line_number":80,"context_line":"    belongs_to:"},{"line_number":81,"context_line":"      - hosts"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3afb71cf_e6a36cfe","line":81,"in_reply_to":"3afb71cf_293e10c1","updated":"2015-06-11 08:51:58.000000000","message":"While I don\u0027t disagree, I\u0027ve tried to put the physical sections with the services that consume them. In this case there is no other service that consumes this physical section so it makes sense to me that it stays with the component/container structures that consume them. This way it\u0027s all together and easier to relate to each other.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"}],"etc/openstack_deploy/openstack_environment.yml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"78b92a1c427221fbc16b88004c348d006208a9ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3afb71cf_a985605a","updated":"2015-06-10 19:24:45.000000000","message":"This file should look something like this:\n    \n    component_skel: {}\n    container_skel: {}\n    physical_skel: {}\n\nThis will allow the inventory to look at this file making the additional container definitions unnecessary.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"607a6a8b0a3f43d860166e032b581ed37d0d121d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3afb71cf_26d3c461","in_reply_to":"3afb71cf_a985605a","updated":"2015-06-11 08:51:58.000000000","message":"Ah, I like that idea - that way I can break each of the sections into a separate file. Of course another way is to modify the dynamic inventory to not fall apart when the openstack_environment.yml file is not present.","commit_id":"6fee7b6dd9da4b9c40d4fadcabc1ea2a100d1d41"}]}