)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"134ce5c85480963c3702b9c1d1c87e48a30b8b3f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds the bits necessary to configure a Keystone instance as"},{"line_number":10,"context_line":"a service provider (SP) for federation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I78b3d740434ea4b3ca0bd9f144e4a07026be23c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_fc814d90","line":12,"updated":"2015-06-22 21:43:52.000000000","message":"Please reference the bp/spec for this change.","commit_id":"d0db86ab6e8abe37c61b8c622a5cc8f61ae6e887"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"df33ea7f8c3db14e8c1f036346e5b280ace90d30","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Keystone Federation Service Provider Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the ability to configure Keystone as a Service"},{"line_number":10,"context_line":"Provider (SP) for a Federated Identity Provider (IdP)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint keystone-federation"},{"line_number":13,"context_line":"Change-Id: I78b3d740434ea4b3ca0bd9f144e4a07026be23c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"9a41bdd9_703dfedb","line":10,"updated":"2015-07-15 14:38:20.000000000","message":"I assume a follow on patch will add the Keystone as an Identity Provider piece?","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d5084e3b4321985773de2f2afb50d81121849452","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Keystone Federation Service Provider Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the ability to configure Keystone as a Service"},{"line_number":10,"context_line":"Provider (SP) for a Federated Identity Provider (IdP)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint keystone-federation"},{"line_number":13,"context_line":"Change-Id: I78b3d740434ea4b3ca0bd9f144e4a07026be23c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"9a41bdd9_fbe1ef2a","line":10,"in_reply_to":"9a41bdd9_703dfedb","updated":"2015-07-15 14:44:43.000000000","message":"Yes, it\u0027s here: https://review.openstack.org/194259","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c9fe8074b49676c4f29b104dc96b12ecd26e31cb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Keystone Federation Service Provider Configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the ability to configure Keystone as a Service"},{"line_number":10,"context_line":"Provider (SP) for a Federated Identity Provider (IdP)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint keystone-federation"},{"line_number":13,"context_line":"Change-Id: I78b3d740434ea4b3ca0bd9f144e4a07026be23c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"9a41bdd9_21108a56","line":10,"in_reply_to":"9a41bdd9_fbe1ef2a","updated":"2015-07-15 15:24:42.000000000","message":"Awesome, thanks!","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"}],"playbooks/library/keystone":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"200a8f880d636479b10d0db1d851b1ca0a3350c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ba3cc151_acaa08d1","updated":"2015-07-10 08:38:29.000000000","message":"I think these should be incorporated into https://review.openstack.org/196943 or https://review.openstack.org/197677.","commit_id":"87cf7d92eb7660e3d6724cc332755e0dadc2cd14"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a03e978e5c2a2a07bf1f6ad7a26d599dead18d6b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    role_name: \"admin\""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Add a project role to a group"},{"line_number":256,"context_line":"- keystone:"},{"line_number":257,"context_line":"    command: \"ensure_group_role\""},{"line_number":258,"context_line":"    group_name: \"fedgroup\""},{"line_number":259,"context_line":"    project_name: \"fedproject\""}],"source_content_type":"application/octet-stream","patch_set":72,"id":"1a4dcd0f_d547dc75","line":256,"updated":"2015-08-07 20:02:40.000000000","message":"why are the group_name and project_name referring to federation?\n\nnot clear from the command name why these would be federation related.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2a83c901778540053396c2751a127ce2273f0b5a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    role_name: \"admin\""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Add a project role to a group"},{"line_number":256,"context_line":"- keystone:"},{"line_number":257,"context_line":"    command: \"ensure_group_role\""},{"line_number":258,"context_line":"    group_name: \"fedgroup\""},{"line_number":259,"context_line":"    project_name: \"fedproject\""}],"source_content_type":"application/octet-stream","patch_set":72,"id":"1a4dcd0f_c4108f5c","line":256,"in_reply_to":"1a4dcd0f_90fe4237","updated":"2015-08-07 20:59:57.000000000","message":"I figured as much. It can be addressed later, but a placeholder value of \u0027placeholder\u0027 would be clearer in intent and this entire file would benefit from some housekeeping to make it easier for contributors to find things in.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"becdaf05017834052c36c9397d767d58757b6282","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    role_name: \"admin\""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Add a project role to a group"},{"line_number":256,"context_line":"- keystone:"},{"line_number":257,"context_line":"    command: \"ensure_group_role\""},{"line_number":258,"context_line":"    group_name: \"fedgroup\""},{"line_number":259,"context_line":"    project_name: \"fedproject\""}],"source_content_type":"application/octet-stream","patch_set":72,"id":"1a4dcd0f_90fe4237","line":256,"in_reply_to":"1a4dcd0f_d547dc75","updated":"2015-08-07 20:23:04.000000000","message":"They\u0027re simply examples. The name prefixed with \u0027fed\u0027 referring to federation is just a name, and probably a personal inference. If this is distasteful it can easily be changed in a subsequent review.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/haproxy_server/templates/service.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_0c7a96bd","line":16,"updated":"2015-07-14 17:17:04.000000000","message":"This is a fix to the haproxy ssl patch which should probably be seperated into its own patch. Without this the reqadd line starts on the same line as the \u0027set request\u0027 and the forwarded protocol setting doesn\u0027t take effect.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"442ef17071872f61e580ead7a945901b951de705","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_039257f6","line":16,"in_reply_to":"9a41bdd9_0c7a96bd","updated":"2015-07-14 23:01:52.000000000","message":"Yes. I did see this problem, had the empty line at some point in the haproxy patch, I guess it got lost later on.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8294db69dc18293b12830f68d032550512215694","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_ada7b1bb","line":16,"updated":"2015-07-15 14:30:31.000000000","message":"unrelated whitespace change?","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"02aba8a82b219a46c67bba37cb49b94510e5b579","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_619e9208","line":16,"in_reply_to":"9a41bdd9_1b9a93b9","updated":"2015-07-15 15:23:28.000000000","message":"Ah, makes sense. Thanks!","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d291fb11e739213d38cc3966c25acdf22e734a1b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_1b9a93b9","line":16,"in_reply_to":"9a41bdd9_ada7b1bb","updated":"2015-07-15 14:41:22.000000000","message":"This is an intentional inclusion which does perhaps deserve being in another patch - without it the reqadd line gets put on the same line as the set request_option line.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a07364c7bf89710ffee2d08896effe979408104","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9a41bdd9_d0488ace","line":16,"updated":"2015-07-15 14:32:25.000000000","message":"unrelated whitespace change? or was this caught by a linter?","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f36e72a14f84488e915ed32b0ab1d9ee5546b651","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    option  tcplog"},{"line_number":14,"context_line":"    {%- set request_option \u003d \"tcp\" %}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if item.service.haproxy_ssl is defined and item.service.haproxy_ssl | bool %}"},{"line_number":18,"context_line":"    reqadd X-Forwarded-Proto:\\ https"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"9a41bdd9_90bf6260","line":16,"in_reply_to":"9a41bdd9_d0488ace","updated":"2015-07-15 14:40:48.000000000","message":"This is an intentional inclusion which does perhaps deserve being in another patch - without it the reqadd line gets put on the same line as the set request_option line.","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"}],"playbooks/roles/os_horizon/templates/horizon_local_settings.py.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"40a36a27d04f08e0924dddd33000cdd0d3d884ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ba3cc151_31340ffa","updated":"2015-07-10 08:34:22.000000000","message":"These changes should come out of this patch and go into a subsequent patch which is specifically for ADFS/WebSSO enablement.","commit_id":"87cf7d92eb7660e3d6724cc332755e0dadc2cd14"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b6269fa415d391022f6d27051ed506db538da00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"9a41bdd9_7f5f59e5","updated":"2015-07-14 10:47:34.000000000","message":"These changes should come out of this patch and go into a subsequent patch which is specifically for ADFS/WebSSO enablement.","commit_id":"2a6db56ec90c588f4ae758a93b32afe2a3c0b7c0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"adbc24789d6df8b47e162ad9ac6446c8adbca62a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"OPENSTACK_KEYSTONE_URL \u003d \"{{ horizon_keystone_endpoint }}\""},{"line_number":169,"context_line":"{% endif %}"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \"_member_\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"{% if keystone_sp is defined %}"},{"line_number":174,"context_line":"# Enables keystone web single-sign-on"}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"1a4dcd0f_b0fc9e73","line":171,"updated":"2015-08-07 20:25:47.000000000","message":"Does this need to be parameterized to match the SSO signing? Or do we assume it will always be member ?","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"23afd1c0b2f5223b065d36a72305fcfd9ea3f129","unresolved":false,"context_lines":[{"line_number":168,"context_line":"OPENSTACK_KEYSTONE_URL \u003d \"{{ horizon_keystone_endpoint }}\""},{"line_number":169,"context_line":"{% endif %}"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"OPENSTACK_KEYSTONE_DEFAULT_ROLE \u003d \"_member_\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"{% if keystone_sp is defined %}"},{"line_number":174,"context_line":"# Enables keystone web single-sign-on"}],"source_content_type":"text/x-jinja2","patch_set":72,"id":"1a4dcd0f_64ff3bab","line":171,"in_reply_to":"1a4dcd0f_b0fc9e73","updated":"2015-08-07 20:37:47.000000000","message":"This is being covered in a subsequent review which deals specifically with the role Horizon requires: https://review.openstack.org/202194","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/os_keystone/defaults/main.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"b0dfa20c1d9097c000a11135b7c88970c659a5c2","unresolved":false,"context_lines":[{"line_number":156,"context_line":"# Enable the following section on the Keystone SP"},{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp: \"https://\u003ckeystone.idp\u003e:5000\""},{"line_number":159,"context_line":"#  idp_entity_id: \"{{ idp }}/v3/OS-FEDERATION/saml2/idp\""},{"line_number":160,"context_line":"#  idp_metadata_provider: \"{{ idp }}/v3/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  cert_duration_years: 5"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_3f446e19","line":159,"updated":"2015-06-23 11:11:35.000000000","message":"This would need to be keystone_sp.idp, but thats a recursive definition without a base case.","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":156,"context_line":"# Enable the following section on the Keystone SP"},{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp: \"https://\u003ckeystone.idp\u003e:5000\""},{"line_number":159,"context_line":"#  idp_entity_id: \"{{ idp }}/v3/OS-FEDERATION/saml2/idp\""},{"line_number":160,"context_line":"#  idp_metadata_provider: \"{{ idp }}/v3/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  cert_duration_years: 5"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_92500134","line":159,"in_reply_to":"fa32b979_3f446e19","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"22426a1056677b18ff8ac024e220a464b4b73dd5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp_entity_id: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/idp\""},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_metadata_provider_uri: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata-keystone.xml\""},{"line_number":162,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":163,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_62d6a450","line":160,"updated":"2015-06-24 11:02:47.000000000","message":"Is pointing at self a sensible default for this? As this keystone is a service provider, we can assume the IdP is external. Could use a place holder such as \u003cidp_metadata_url\u003e ?","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c2738479e8e8d86f306acffa2382b1cf04092008","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp_entity_id: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/idp\""},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_metadata_provider_uri: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata-keystone.xml\""},{"line_number":162,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":163,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_e2d954f4","line":160,"in_reply_to":"fa32b979_62d6a450","updated":"2015-06-24 11:14:13.000000000","message":"Yeah, it\u0027s not - we should perhaps be clear in the example that the reference URL here is an external IDP (always).\nI think that ultimately we need to ensure that we\u0027re able to provide for multiple trusted dashboards, multiple IDP\u0027s and multiple SP\u0027s (in the IDP patch).\nFor now, though, it\u0027d be nice to get it right for just one. :)","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a2ec396ed64b70f0745646d8c3f6336bb6e2370b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp_entity_id: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/idp\""},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_metadata_provider_uri: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata-keystone.xml\""},{"line_number":162,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":163,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_e5c87e57","line":160,"in_reply_to":"fa32b979_e2d954f4","updated":"2015-06-24 11:36:42.000000000","message":"We should also provide examples of how to set it up to use a Keystone IDP, an ADFS IDP and perhaps also a test IDP like https://www.testshib.org. The examples should cover configuring the SP against one or more of the above.","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"352738ff1d6e5ffdba9d0220fcd03b0b433845a9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"#keystone_sp:"},{"line_number":158,"context_line":"#  idp_entity_id: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/idp\""},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_metadata_provider_uri: \"{{ keystone_service_publicurl_v3 }}/OS-FEDERATION/saml2/metadata\""},{"line_number":161,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata-keystone.xml\""},{"line_number":162,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":163,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_ad7ed1e1","line":160,"in_reply_to":"fa32b979_e5c87e57","updated":"2015-06-24 15:28:46.000000000","message":"This should not point at itself. The way I had it before your changes was syntactically wrong on purpose, to force the user to edit it and set the hostname/IP address of the IdP.","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"05eb92301dc3704f2658a300ab65b8912c84e5fd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"# trusts with specific Identity Providers (IdP)."},{"line_number":158,"context_line":"#keystone_sp:"},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_entity_id: \"\u003cyour IdP entity URL here\u003e\""},{"line_number":161,"context_line":"#    Examples:"},{"line_number":162,"context_line":"#      https://keystone-idp:5000/v3/OS-FEDERATION/saml2/idp"},{"line_number":163,"context_line":"#      https://idp.testshib.org/idp/shibboleth"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_89d86bf0","line":160,"updated":"2015-06-25 15:27:08.000000000","message":"The IDP\u0027s need to be a list so that we can handle multiple IDP\u0027s, so perhaps it should be something like:\n\nkeystone_sp:\n  idp:\n    - { name: \u0027\u0027,\n         entity_id: \u0027\u0027,\n         metadata_uri: \u0027\u0027,\n         metadata_file: \u0027\u0027,\n         metadata_reload: \u0027\u0027 }","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fe3c9dd35f687d32d2a1e98052137c4b3f7266fa","unresolved":false,"context_lines":[{"line_number":157,"context_line":"# trusts with specific Identity Providers (IdP)."},{"line_number":158,"context_line":"#keystone_sp:"},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  idp_entity_id: \"\u003cyour IdP entity URL here\u003e\""},{"line_number":161,"context_line":"#    Examples:"},{"line_number":162,"context_line":"#      https://keystone-idp:5000/v3/OS-FEDERATION/saml2/idp"},{"line_number":163,"context_line":"#      https://idp.testshib.org/idp/shibboleth"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba3cc151_bc00ecab","line":160,"in_reply_to":"fa32b979_89d86bf0","updated":"2015-06-29 14:15:16.000000000","message":"Done","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"05eb92301dc3704f2658a300ab65b8912c84e5fd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#    Examples:"},{"line_number":166,"context_line":"#      https://keystone-idp:5000/v3/OS-FEDERATION/saml2/metadata"},{"line_number":167,"context_line":"#      http://www.testshib.org/metadata/testshib-providers.xml"},{"line_number":168,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata.xml\""},{"line_number":169,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":170,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_c9e753e1","line":168,"updated":"2015-06-25 15:27:08.000000000","message":"This must not include a path unless shibd has access to the path, which it does not in this case. If just a filename is set here then it\u0027ll end up in /var/cache/shibboleth/ which shibd does have rights to. I\u0027d like us to actually default to something the user doesn\u0027t need to edit here - something along the lines of \u0027metadata-\u003cidp name\u003e.xml\u0027","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba68f1612c0ac55e226ecc236a2270066350df8f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#    Examples:"},{"line_number":166,"context_line":"#      https://keystone-idp:5000/v3/OS-FEDERATION/saml2/metadata"},{"line_number":167,"context_line":"#      http://www.testshib.org/metadata/testshib-providers.xml"},{"line_number":168,"context_line":"#  idp_metadata_provider_file: \"/etc/shibboleth/idp-metadata.xml\""},{"line_number":169,"context_line":"#  idp_metadata_provider_reload: 1800"},{"line_number":170,"context_line":"#  trusted_dashboard: \"https://{{ external_lb_vip_address }}/auth/websso/\""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_2f81eac3","line":168,"in_reply_to":"fa32b979_c9e753e1","updated":"2015-06-26 16:32:49.000000000","message":"Done","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"97cf9777786b2bbf878c1263a2b834a517a59ab0","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#keystone_sp:"},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  trusted_dashboard_list:"},{"line_number":161,"context_line":"#    - \"https://{{ external_lb_vip_address }}/auth/websso/\""},{"line_number":162,"context_line":"#  trusted_idp_list:"},{"line_number":163,"context_line":"#    note that only one of these is supported at any one time for now"},{"line_number":164,"context_line":"#    - { name: \u0027keystone-idp\u0027,"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ba3cc151_6d04de7d","line":161,"range":{"start_line":161,"start_character":19,"end_line":161,"end_character":42},"updated":"2015-06-29 22:11:13.000000000","message":"I think the list of trusted dashboards is supposed to include the remote (i.e. IdP) dashboards, not the local one. Keystone will only redirect to approved dashboards, to avoid man-in-the-middle attacks.\n\nSo instead of having a separate dashboard list, you can instead add a \"dashboard_uri\" to the trusted_idp_list below. For Keystone IdPs, the dashboard URI seems to be https://ip-address/auth/websso, though I have not been able to get that to work on my IdP yet.","commit_id":"ad15859dd897f18b9c55b46ad80b564688126ebe"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"69685e42baf3c7aefb014211ebf10b5e83bd7f02","unresolved":false,"context_lines":[{"line_number":158,"context_line":"#keystone_sp:"},{"line_number":159,"context_line":"#  cert_duration_years: 5"},{"line_number":160,"context_line":"#  trusted_dashboard_list:"},{"line_number":161,"context_line":"#    - \"https://{{ external_lb_vip_address }}/auth/websso/\""},{"line_number":162,"context_line":"#  trusted_idp_list:"},{"line_number":163,"context_line":"#    note that only one of these is supported at any one time for now"},{"line_number":164,"context_line":"#    - { name: \u0027keystone-idp\u0027,"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ba3cc151_a81df467","line":161,"range":{"start_line":161,"start_character":19,"end_line":161,"end_character":42},"in_reply_to":"ba3cc151_6d04de7d","updated":"2015-06-29 22:22:13.000000000","message":"Actually disregard the previous comment for now. This may be okay after all. Need to research it a little more.","commit_id":"ad15859dd897f18b9c55b46ad80b564688126ebe"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"deb38f221b1bc86dfab44d4183c6d0fdaf1e9a8e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"#      group: fedgroup"},{"line_number":178,"context_line":"#      user: feduser"},{"line_number":179,"context_line":"#      protocol: saml2"},{"line_number":180,"context_line":"#      mapping:"},{"line_number":181,"context_line":"#        name: keystone-idp-mapping"},{"line_number":182,"context_line":"#        rules:"},{"line_number":183,"context_line":"#          - remote:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_f4d0e02d","line":180,"updated":"2015-07-10 01:33:46.000000000","message":"Not a huge deal, since we only plan to support one IdP, but don\u0027t you think the mapping should be defined outside of the IdP list? That way you can use the same mapping for several IdPs. The protocol is what ties the idP to the mapping, so we can include just the mapping name here.","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d3f9ee307d0316b29b5a5a73a0b6e7a03e0b3a6a","unresolved":false,"context_lines":[{"line_number":177,"context_line":"#      group: fedgroup"},{"line_number":178,"context_line":"#      user: feduser"},{"line_number":179,"context_line":"#      protocol: saml2"},{"line_number":180,"context_line":"#      mapping:"},{"line_number":181,"context_line":"#        name: keystone-idp-mapping"},{"line_number":182,"context_line":"#        rules:"},{"line_number":183,"context_line":"#          - remote:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_f1df8738","line":180,"in_reply_to":"ba3cc151_f4d0e02d","updated":"2015-07-10 08:20:31.000000000","message":"Each IdP may present different information, so I think we definitely need to allow for a mapping per IdP.","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"442ef17071872f61e580ead7a945901b951de705","unresolved":false,"context_lines":[{"line_number":189,"context_line":"#                type: openstack_user"},{"line_number":190,"context_line":"#            local:"},{"line_number":191,"context_line":"#              - group:"},{"line_number":192,"context_line":"#                  id: fedgroup.id"},{"line_number":193,"context_line":"#                user:"},{"line_number":194,"context_line":"#                  name: federated_user"},{"line_number":195,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_be84de5d","line":192,"updated":"2015-07-14 23:01:52.000000000","message":"I forgot about this. I included the id of my group explicitly to make this work, which is inconvenient when the group is specified above by name. I think this should be (optionally) specified as a name, even if Keystone only accepts an id.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"204359dda518f480c39026245fc45e01de51af3e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"#                type: openstack_user"},{"line_number":190,"context_line":"#            local:"},{"line_number":191,"context_line":"#              - group:"},{"line_number":192,"context_line":"#                  id: fedgroup.id"},{"line_number":193,"context_line":"#                user:"},{"line_number":194,"context_line":"#                  name: federated_user"},{"line_number":195,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_a332795c","line":192,"in_reply_to":"9a41bdd9_be84de5d","updated":"2015-07-15 08:06:59.000000000","message":"Ah, but keystone doesn\u0027t only accept an id - it accepts any attribute reference, so a name is happily accepted. I do think that perhaps we should rather make the example use the name as it\u0027ll be easier to implement.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":193,"context_line":"#                user:"},{"line_number":194,"context_line":"#                  name: federated_user"},{"line_number":195,"context_line":"#"},{"line_number":196,"context_line":"#    - name: \u0027testshib\u0027,"},{"line_number":197,"context_line":"#      entity_ids:"},{"line_number":198,"context_line":"#         - \u0027https://idp.testshib.org/idp/shibboleth\u0027"},{"line_number":199,"context_line":"#      metadata_uri: \u0027http://www.testshib.org/metadata/testshib-providers.xml\u0027,"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_ec53b237","line":196,"updated":"2015-07-14 17:17:04.000000000","message":"The commas at the end of these lines should be removed.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":193,"context_line":"#                user:"},{"line_number":194,"context_line":"#                  name: federated_user"},{"line_number":195,"context_line":"#"},{"line_number":196,"context_line":"#    - name: \u0027testshib\u0027,"},{"line_number":197,"context_line":"#      entity_ids:"},{"line_number":198,"context_line":"#         - \u0027https://idp.testshib.org/idp/shibboleth\u0027"},{"line_number":199,"context_line":"#      metadata_uri: \u0027http://www.testshib.org/metadata/testshib-providers.xml\u0027,"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_4f895ec8","line":196,"in_reply_to":"9a41bdd9_ec53b237","updated":"2015-07-15 00:35:58.000000000","message":"Done","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"094213581f4909670cdde83c7cb9f9e442befe10","unresolved":false,"context_lines":[{"line_number":227,"context_line":"#                    name: Default"},{"line_number":228,"context_line":"#              - user:"},{"line_number":229,"context_line":"#                  name: \u0027{0}\u0027"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# Common apt packages"},{"line_number":232,"context_line":"keystone_apt_packages:"},{"line_number":233,"context_line":"  - apache2"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9a41bdd9_0dd25d28","line":230,"updated":"2015-07-15 14:27:36.000000000","message":"Are those comments intended here? If it\u0027s Work in progress please mark the patch as WIP.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d291fb11e739213d38cc3966c25acdf22e734a1b","unresolved":false,"context_lines":[{"line_number":227,"context_line":"#                    name: Default"},{"line_number":228,"context_line":"#              - user:"},{"line_number":229,"context_line":"#                  name: \u0027{0}\u0027"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# Common apt packages"},{"line_number":232,"context_line":"keystone_apt_packages:"},{"line_number":233,"context_line":"  - apache2"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9a41bdd9_b03706fe","line":230,"in_reply_to":"9a41bdd9_0dd25d28","updated":"2015-07-15 14:41:22.000000000","message":"Yes. These are intentionally left here as examples of how to use it. This is a current convention which could perhaps be done better differently.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"094213581f4909670cdde83c7cb9f9e442befe10","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"},{"line_number":250,"context_line":"keystone_pip_packages:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9a41bdd9_4ddce545","line":247,"updated":"2015-07-15 14:27:36.000000000","message":"i don\u0027t think you need xmlsec1 for  Keystone Service Provider.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8294db69dc18293b12830f68d032550512215694","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"},{"line_number":250,"context_line":"keystone_pip_packages:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9a41bdd9_50af9a7c","line":247,"in_reply_to":"9a41bdd9_4ddce545","updated":"2015-07-15 14:30:31.000000000","message":"It doesn\u0027t look like it [0]. Only required for the Keystone Identity Provider [1].\n\n\n[0] http://docs.openstack.org/developer/keystone/configure_federation.html#keystone-as-a-service-provider-sp\n\n[1] http://docs.openstack.org/developer/keystone/configure_federation.html#keystone-as-an-identity-provider-idp","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"efa0c366c6666d11a785c7e12fe375ae04806a60","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"},{"line_number":250,"context_line":"keystone_pip_packages:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9a41bdd9_d04deac4","line":247,"updated":"2015-07-15 14:36:34.000000000","message":"I don\u0027t this either of these dependencies are common. libapache2-mod-shib2 is only required for the Keystone Service Provider and the xmlsec1 package is required for Keystone as an Identity Provider. Is there a place where we can put each of these since they\u0027re not exactly common for either the SP or the IdP in the K2K case?\n\nhttp://docs.openstack.org/developer/keystone/configure_federation.html#keystone-as-an-identity-provider-idp\n\nhttp://docs.openstack.org/developer/keystone/configure_federation.html#keystone-as-a-service-provider-sp","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d5084e3b4321985773de2f2afb50d81121849452","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"},{"line_number":250,"context_line":"keystone_pip_packages:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9a41bdd9_bb3287a5","line":247,"in_reply_to":"9a41bdd9_d04deac4","updated":"2015-07-15 14:44:43.000000000","message":"We can figure out a better way of being a little more selective here - we may just want to have something like keystone_idp_apt_packages and union that in the apt install task.","commit_id":"bebdbce785440be345ab86cc04d12552c0e19082"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cb44ffc8830df11cfff35735ab709f82e1b54bba","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  - libsasl2-dev"},{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"9a41bdd9_a64d8b9b","line":246,"updated":"2015-07-15 16:31:48.000000000","message":"This is only required for the SP, not for the IDP. We should perhaps be more selective about that packages we deploy.","commit_id":"d41ff64623c0151aaaf1a78172ca639625348fe3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cb44ffc8830df11cfff35735ab709f82e1b54bba","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  - libxslt1.1"},{"line_number":245,"context_line":"  - rsync"},{"line_number":246,"context_line":"  - libapache2-mod-shib2"},{"line_number":247,"context_line":"  - xmlsec1"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Common pip packages"},{"line_number":250,"context_line":"keystone_pip_packages:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"9a41bdd9_6643036d","line":247,"updated":"2015-07-15 16:31:48.000000000","message":"This is only required for the IDP, not for the SP. We should perhaps be more selective about the packages we deploy.","commit_id":"d41ff64623c0151aaaf1a78172ca639625348fe3"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"2fddb47b6390677ad6bee8056c0bd82df6da256a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"#    note that only one of these is supported at any one time for now"},{"line_number":175,"context_line":"#    - name: \"keystone-idp\""},{"line_number":176,"context_line":"#      entity_ids:"},{"line_number":177,"context_line":"#         - \u0027https://keystone-idp:5000/v3/OS-FEDERATION/saml2/idp\u0027"},{"line_number":178,"context_line":"#      metadata_uri: \u0027https://keystone-idp:5000/v3/OS-FEDERATION/saml2/metadata\u0027"},{"line_number":179,"context_line":"#      metadata_file: \u0027metadata-keystone-idp.xml\u0027"},{"line_number":180,"context_line":"#      metadata_reload: 1800"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3a50d1a3_a650e75f","line":177,"updated":"2015-07-23 23:58:17.000000000","message":"Why is this a list? I don\u0027t think you can have more than one entity_id for an IdP.","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f1174de778568b2c01ba2dba18b38e2f982c7826","unresolved":false,"context_lines":[{"line_number":174,"context_line":"#    note that only one of these is supported at any one time for now"},{"line_number":175,"context_line":"#    - name: \"keystone-idp\""},{"line_number":176,"context_line":"#      entity_ids:"},{"line_number":177,"context_line":"#         - \u0027https://keystone-idp:5000/v3/OS-FEDERATION/saml2/idp\u0027"},{"line_number":178,"context_line":"#      metadata_uri: \u0027https://keystone-idp:5000/v3/OS-FEDERATION/saml2/metadata\u0027"},{"line_number":179,"context_line":"#      metadata_file: \u0027metadata-keystone-idp.xml\u0027"},{"line_number":180,"context_line":"#      metadata_reload: 1800"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3a50d1a3_f80f5c2c","line":177,"in_reply_to":"3a50d1a3_a650e75f","updated":"2015-07-24 08:51:12.000000000","message":"It was changed from a single entity to a list because it\u0027s a list in the keystone schema. I\u0027m happy to switch it back to a single entity as I don\u0027t see a use-case where anyone would want it as a list.","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"2fddb47b6390677ad6bee8056c0bd82df6da256a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#      metadata_reload: 1800"},{"line_number":181,"context_line":"#      domain_name: Default"},{"line_number":182,"context_line":"#      project: fedproject"},{"line_number":183,"context_line":"#      group: fedgroup"},{"line_number":184,"context_line":"#      protocol: saml2"},{"line_number":185,"context_line":"#      mapping:"},{"line_number":186,"context_line":"#        name: keystone-idp-mapping"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3a50d1a3_46fb2348","line":183,"updated":"2015-07-23 23:58:17.000000000","message":"The domain, project, role, group and user settings are insufficient for certain federation setups. Consider having two or more rules in the mappings below, where the \"local\" section uses different users/groups. I think this to be expanded into a list, where multiple sets of identities can be given.","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f1174de778568b2c01ba2dba18b38e2f982c7826","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#      metadata_reload: 1800"},{"line_number":181,"context_line":"#      domain_name: Default"},{"line_number":182,"context_line":"#      project: fedproject"},{"line_number":183,"context_line":"#      group: fedgroup"},{"line_number":184,"context_line":"#      protocol: saml2"},{"line_number":185,"context_line":"#      mapping:"},{"line_number":186,"context_line":"#        name: keystone-idp-mapping"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3a50d1a3_782a6c80","line":183,"in_reply_to":"3a50d1a3_46fb2348","updated":"2015-07-24 08:51:12.000000000","message":"Agreed.","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c3f12d6582534ab54b913b2024a693164808105b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#      metadata_reload: 1800"},{"line_number":181,"context_line":"#      domain_name: Default"},{"line_number":182,"context_line":"#      project: fedproject"},{"line_number":183,"context_line":"#      group: fedgroup"},{"line_number":184,"context_line":"#      protocol: saml2"},{"line_number":185,"context_line":"#      mapping:"},{"line_number":186,"context_line":"#        name: keystone-idp-mapping"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3a50d1a3_663f26d7","line":183,"in_reply_to":"3a50d1a3_782a6c80","updated":"2015-07-24 12:24:55.000000000","message":"Done","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"}],"playbooks/roles/os_keystone/files/sso_callback_template.html":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"adbc24789d6df8b47e162ad9ac6446c8adbca62a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_707b762a","updated":"2015-08-07 20:25:47.000000000","message":"Is this a dirived work from elsewhere? if so do we need to attribute the file accordingly or Can we add the boiler plate license headers here and adding the ansible managed comment?","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"23afd1c0b2f5223b065d36a72305fcfd9ea3f129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_a41c6314","in_reply_to":"1a4dcd0f_707b762a","updated":"2015-08-07 20:37:47.000000000","message":"This comes from the keystone source: https://github.com/openstack/keystone/blob/master/etc/sso_callback_template.html","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/os_keystone/tasks/keystone_apache.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"487d539a389517c25ac32b060508c19b4bb7ef76","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Ensure mod_shib2 is present"},{"line_number":61,"context_line":"  apache2_module:"},{"line_number":62,"context_line":"    name: mod_shib2"},{"line_number":63,"context_line":"    state: present"},{"line_number":64,"context_line":"  when: keystone_sp is defined"},{"line_number":65,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_1af3b80b","line":62,"updated":"2015-06-23 11:28:31.000000000","message":"should be:\n   name: shib2","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Ensure mod_shib2 is present"},{"line_number":61,"context_line":"  apache2_module:"},{"line_number":62,"context_line":"    name: mod_shib2"},{"line_number":63,"context_line":"    state: present"},{"line_number":64,"context_line":"  when: keystone_sp is defined"},{"line_number":65,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_6ddf9e3a","line":62,"in_reply_to":"fa32b979_1af3b80b","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  apache2_module:"},{"line_number":62,"context_line":"    name: ssl"},{"line_number":63,"context_line":"    state: \"{{ (keystone_ssl_enabled | bool) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":64,"context_line":"  notify:"},{"line_number":65,"context_line":"    - Restart Apache"},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - keystone-httpd"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_0c285699","line":64,"updated":"2015-07-14 17:17:04.000000000","message":"This fix actually belongs in a separate patch with an appropriate bug report.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  apache2_module:"},{"line_number":62,"context_line":"    name: ssl"},{"line_number":63,"context_line":"    state: \"{{ (keystone_ssl_enabled | bool) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":64,"context_line":"  notify:"},{"line_number":65,"context_line":"    - Restart Apache"},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - keystone-httpd"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_cf9c8e11","line":64,"in_reply_to":"9a41bdd9_0c285699","updated":"2015-07-15 00:35:58.000000000","message":"I\u0027ll let Hugh decide how to handle this, since he added it in one of his patches. My opinion is that this is just a simple fix that we might as well leave it here.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"204359dda518f480c39026245fc45e01de51af3e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  apache2_module:"},{"line_number":62,"context_line":"    name: ssl"},{"line_number":63,"context_line":"    state: \"{{ (keystone_ssl_enabled | bool) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":64,"context_line":"  notify:"},{"line_number":65,"context_line":"    - Restart Apache"},{"line_number":66,"context_line":"  tags:"},{"line_number":67,"context_line":"    - keystone-httpd"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9a41bdd9_6328f1e2","line":64,"in_reply_to":"9a41bdd9_cf9c8e11","updated":"2015-07-15 08:06:59.000000000","message":"I think the patch was actually Harry\u0027s, but yeah - may as well leave it here unless it gets called out in further reviews.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a03e978e5c2a2a07bf1f6ad7a26d599dead18d6b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  apache2_module:"},{"line_number":71,"context_line":"    name: shib2"},{"line_number":72,"context_line":"    state: \"{{ ( keystone_sp is defined ) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":73,"context_line":"  ignore_errors: yes"},{"line_number":74,"context_line":"  notify:"},{"line_number":75,"context_line":"    - Restart Apache"},{"line_number":76,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1a4dcd0f_3e9b8574","line":73,"updated":"2015-08-07 20:02:40.000000000","message":"This should have a when: clause instead. Rather than creating a failed task that ignores errors, the task should be skipped when federation is not in use.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"adbc24789d6df8b47e162ad9ac6446c8adbca62a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  apache2_module:"},{"line_number":71,"context_line":"    name: shib2"},{"line_number":72,"context_line":"    state: \"{{ ( keystone_sp is defined ) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":73,"context_line":"  ignore_errors: yes"},{"line_number":74,"context_line":"  notify:"},{"line_number":75,"context_line":"    - Restart Apache"},{"line_number":76,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1a4dcd0f_30c72e66","line":73,"in_reply_to":"1a4dcd0f_3e9b8574","updated":"2015-08-07 20:25:47.000000000","message":"+1 idk why we\u0027d ignore the errors. I also agree with adding a when.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"becdaf05017834052c36c9397d767d58757b6282","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  apache2_module:"},{"line_number":71,"context_line":"    name: shib2"},{"line_number":72,"context_line":"    state: \"{{ ( keystone_sp is defined ) | ternary(\u0027present\u0027, \u0027absent\u0027) }}\""},{"line_number":73,"context_line":"  ignore_errors: yes"},{"line_number":74,"context_line":"  notify:"},{"line_number":75,"context_line":"    - Restart Apache"},{"line_number":76,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1a4dcd0f_10679226","line":73,"in_reply_to":"1a4dcd0f_3e9b8574","updated":"2015-08-07 20:23:04.000000000","message":"This enabled the module if keystone_sp is defined, but disables it if keystone_sp is not defined. The idea is to clean up after itself if you\u0027re switching between enabling or disabling. see the mod_ssl task above for a similar pattern. The reason for the ignore_errors is that mod_shib2 may not be installed at all, so disabling it will fail. I agree that this could be done better (perhaps with a when to determine whether the package is installed), but that\u0027s easily done in a subsequent patch.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/os_keystone/tasks/keystone_db_setup.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"db67c244a5b2dd9924000acbf6354b13c2837062","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    - keystone-setup"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Enable the federation extension"},{"line_number":52,"context_line":"  command: keystone-manage db_sync --extension federation"},{"line_number":53,"context_line":"  sudo: yes"},{"line_number":54,"context_line":"  sudo_user: \"{{ keystone_system_user_name }}\""},{"line_number":55,"context_line":"  when: keystone_sp is defined"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_5ca10bf7","line":52,"updated":"2015-06-24 10:31:27.000000000","message":"http://blog.rodrigods.com/it-is-time-to-play-with-keystone-to-keystone-federation-in-kilo/ seems to indicate that this is no longer necessary from Kilo onwards","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"352738ff1d6e5ffdba9d0220fcd03b0b433845a9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    - keystone-setup"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Enable the federation extension"},{"line_number":52,"context_line":"  command: keystone-manage db_sync --extension federation"},{"line_number":53,"context_line":"  sudo: yes"},{"line_number":54,"context_line":"  sudo_user: \"{{ keystone_system_user_name }}\""},{"line_number":55,"context_line":"  when: keystone_sp is defined"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_ade251d3","line":52,"in_reply_to":"fa32b979_5ca10bf7","updated":"2015-06-24 15:28:46.000000000","message":"Yeah, I did not include this, as it seems it comes enabled by default on Kilo.","commit_id":"4c4092d4e315c52a4f6fe904e50d451157bce8cf"}],"playbooks/roles/os_keystone/tasks/keystone_external_idp_setup.yml":[{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"786be4b7022f42c4303221fa15be14eb21b03d55","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      tenant_name: \"{{ keystone_sp.trusted_idp_list.0.project }}\""},{"line_number":21,"context_line":"      token: \"{{ keystone_auth_admin_token }}\""},{"line_number":22,"context_line":"      endpoint: \"{{ keystone_service_adminurl }}\""},{"line_number":23,"context_line":"    when: keystone_sp|defined"},{"line_number":24,"context_line":"          and keystone_sp.trusted_idp_list|defined"},{"line_number":25,"context_line":"          and keystone_sp.trusted_idp_list.0.user|defined"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_4901f905","line":23,"updated":"2015-07-10 01:19:36.000000000","message":"Do we need to repeat keystone_sp here? It\u0027s in the main.yml, so this will never get included if keystone_sp isn\u0027t defined.","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"786be4b7022f42c4303221fa15be14eb21b03d55","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      tenant_name: \"{{ keystone_sp.trusted_idp_list.0.project }}\""},{"line_number":21,"context_line":"      token: \"{{ keystone_auth_admin_token }}\""},{"line_number":22,"context_line":"      endpoint: \"{{ keystone_service_adminurl }}\""},{"line_number":23,"context_line":"    when: keystone_sp|defined"},{"line_number":24,"context_line":"          and keystone_sp.trusted_idp_list|defined"},{"line_number":25,"context_line":"          and keystone_sp.trusted_idp_list.0.user|defined"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_a90f6538","line":23,"updated":"2015-07-10 01:19:36.000000000","message":"This jinja2 filter based syntax for defined isn\u0027t working, I don\u0027t think there is a filter that works in this way.","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"786be4b7022f42c4303221fa15be14eb21b03d55","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          and keystone_sp.trusted_idp_list|defined"},{"line_number":56,"context_line":"          and keystone_sp.trusted_idp_list.0.protocol|defined"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  - name: Ensure external IDP"},{"line_number":59,"context_line":"    keystone:"},{"line_number":60,"context_line":"      command: ensure_identity_provider"},{"line_number":61,"context_line":"      idp_name: pbidp"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_940e3431","line":58,"updated":"2015-07-10 01:19:36.000000000","message":"Debugging left over?","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f264aace8b5f09618b0b1d13b3a8c847e560505c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  - name: Ensure project which remote IDP users are mapped onto exists"},{"line_number":29,"context_line":"    keystone:"},{"line_number":30,"context_line":"      command: ensure_project"},{"line_number":31,"context_line":"      project_name: \"{{ keystone_sp.trusted_idp_list.0.project }}\""},{"line_number":32,"context_line":"      domain: \"{{ keystone_sp.trusted_idp_list.0.domain|default(\u0027default\u0027) }}\""},{"line_number":33,"context_line":"      token: \"{{ keystone_auth_admin_token }}\""},{"line_number":34,"context_line":"      endpoint: \"{{ keystone_service_adminurl }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba3cc151_31bf2f62","line":31,"updated":"2015-07-10 08:32:26.000000000","message":"Why don\u0027t we already do a with_items loop in all these tasks so that multiple IdP\u0027s can be defined (they just won\u0027t work until we have an embedded DS service somewhere)?","commit_id":"87cf7d92eb7660e3d6724cc332755e0dadc2cd14"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f264aace8b5f09618b0b1d13b3a8c847e560505c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    tags:"},{"line_number":40,"context_line":"      - keystone-idp-setup"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  - name: Ensure user which remote IDP users are mapped onto exists"},{"line_number":43,"context_line":"    keystone:"},{"line_number":44,"context_line":"      command: ensure_user"},{"line_number":45,"context_line":"      user_name: \"{{ keystone_sp.trusted_idp_list.0.user }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba3cc151_31b96fcc","line":42,"updated":"2015-07-10 08:32:26.000000000","message":"This is not required. While it may be desired in some cases, it\u0027s not needed. In fact, it defeats the purpose of federation to have any users in the keystone DB.","commit_id":"87cf7d92eb7660e3d6724cc332755e0dadc2cd14"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b6269fa415d391022f6d27051ed506db538da00","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      insecure: \"{{ keystone_service_adminuri_insecure }}\""},{"line_number":23,"context_line":"    when: keystone_sp is defined"},{"line_number":24,"context_line":"          and keystone_sp.trusted_idp_list is defined"},{"line_number":25,"context_line":"          and keystone_sp.trusted_idp_list.0.domain is defined"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  - name: Ensure project which remote IDP users are mapped onto exists"},{"line_number":28,"context_line":"    keystone:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a41bdd9_1fa08d8f","line":25,"updated":"2015-07-14 10:47:34.000000000","message":"Instead of fixing to the first item in the list, we should loop through all items in keystone_sp.trusted_idp_list. Our support of only one IdP will be for a limited time and only pertains to the automated redirects that WebSSO uses, so let\u0027s implement the loops to support multiple IdP\u0027s now.","commit_id":"2a6db56ec90c588f4ae758a93b32afe2a3c0b7c0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3b6269fa415d391022f6d27051ed506db538da00","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    tags:"},{"line_number":39,"context_line":"      - keystone-idp-setup"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - name: Ensure user which remote IDP users are mapped onto exists"},{"line_number":42,"context_line":"    keystone:"},{"line_number":43,"context_line":"      command: ensure_user"},{"line_number":44,"context_line":"      user_name: \"{{ keystone_sp.trusted_idp_list.0.user }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a41bdd9_3fb1d1e1","line":41,"updated":"2015-07-14 10:47:34.000000000","message":"Note that a local user to map the remote use to is entirely optional. In our use-cases this is not required so we need to ensure that this can be done, but is optional.","commit_id":"2a6db56ec90c588f4ae758a93b32afe2a3c0b7c0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"84ac1615e0f421df558b6945055510e63d5a91b6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      idp_name: \"{{ keystone_sp.trusted_idp_list.0.name }}\""},{"line_number":89,"context_line":"      idp_remote_ids:"},{"line_number":90,"context_line":"        - \"{{ keystone_sp.trusted_idp_list.0.entity_id }}\""},{"line_number":91,"context_line":"      enabled: true"},{"line_number":92,"context_line":"      token: \"{{ keystone_auth_admin_token }}\""},{"line_number":93,"context_line":"      endpoint: \"{{ keystone_service_adminurl }}\""},{"line_number":94,"context_line":"      insecure: \"{{ keystone_service_adminuri_insecure }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a41bdd9_1f372de4","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":19},"updated":"2015-07-14 10:42:52.000000000","message":"s/enabled/idp_enabled/","commit_id":"2a6db56ec90c588f4ae758a93b32afe2a3c0b7c0"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"1e74debb54eb9f8028ddb815d4d4baa12be65aae","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - keystone-apt-packages"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Install apt packages"},{"line_number":31,"context_line":"  apt:"},{"line_number":32,"context_line":"    pkg: \"{{ item }}\""},{"line_number":33,"context_line":"    state: latest"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"9a41bdd9_fc7a3b23","line":30,"updated":"2015-07-15 21:29:54.000000000","message":"This can\u0027t be in this file, as this runs only for a single keystone node. I\u0027m moving it to keystone_install.yml","commit_id":"67ef5e74d924f4cf98bf62b215e4b60992a1c69a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9a17fe596b2d8d9d3a577fad7a97be006ea2305d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - keystone-apt-packages"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Install apt packages"},{"line_number":31,"context_line":"  apt:"},{"line_number":32,"context_line":"    pkg: \"{{ item }}\""},{"line_number":33,"context_line":"    state: latest"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"9a41bdd9_16856158","line":30,"in_reply_to":"9a41bdd9_fc7a3b23","updated":"2015-07-16 09:13:05.000000000","message":"Good catch.","commit_id":"67ef5e74d924f4cf98bf62b215e4b60992a1c69a"}],"playbooks/roles/os_keystone/tasks/keystone_post_install.yml":[{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"27bdbd4a993c415ba1249c30aace71fe445f12eb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - keystone-config"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Generate Shibboleth\u0027s key-pair"},{"line_number":78,"context_line":"  shell: \"shib-keygen -h {{ container_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":79,"context_line":"  sudo: yes"},{"line_number":80,"context_line":"  sudo_user: \"{{ keystone_system_user_name }}\""},{"line_number":81,"context_line":"  creates: \"/etc/shibboleth/sp-cert.pem\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_fc206df9","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":14},"updated":"2015-06-22 21:41:31.000000000","message":"FYI: working on allowing users to optionally provide their own certs here.","commit_id":"d0db86ab6e8abe37c61b8c622a5cc8f61ae6e887"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"604de7996ef565349a8e349b241ddb15abc383e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    - { src: \"shibboleth2.xml.j2\", dest: \"/etc/shibboleth/shibboleth2.xml\" }"},{"line_number":71,"context_line":"  when: keystone_sp is defined"},{"line_number":72,"context_line":"  notify:"},{"line_number":73,"context_line":"    - Restart Apache"},{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - keystone-config"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_ccb3534c","line":73,"updated":"2015-06-23 14:18:38.000000000","message":"These changes require the restart of the service \u0027shibd\u0027 - it would seem that Apache doesn\u0027t need to be restarted in this case.","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    - { src: \"shibboleth2.xml.j2\", dest: \"/etc/shibboleth/shibboleth2.xml\" }"},{"line_number":71,"context_line":"  when: keystone_sp is defined"},{"line_number":72,"context_line":"  notify:"},{"line_number":73,"context_line":"    - Restart Apache"},{"line_number":74,"context_line":"  tags:"},{"line_number":75,"context_line":"    - keystone-config"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_0de932e6","line":73,"in_reply_to":"fa32b979_ccb3534c","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"e147d16e8331a1d6ddcef0939782c28dd789ca0d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  shell: \"shib-keygen -h {{ container_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":79,"context_line":"  sudo: yes"},{"line_number":80,"context_line":"  sudo_user: \"{{ keystone_system_user_name }}\""},{"line_number":81,"context_line":"  creates: \"/etc/shibboleth/sp-cert.pem\""},{"line_number":82,"context_line":"  when: keystone_sp is defined"},{"line_number":83,"context_line":"  notify:"},{"line_number":84,"context_line":"    - Restart Apache"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_04503d5d","line":81,"updated":"2015-06-23 11:00:23.000000000","message":"creates is an argument to the shell module, not the task.\n\n  shell:\n    command: \"blah\"\n    creates: /path/to/file","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  shell: \"shib-keygen -h {{ container_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":79,"context_line":"  sudo: yes"},{"line_number":80,"context_line":"  sudo_user: \"{{ keystone_system_user_name }}\""},{"line_number":81,"context_line":"  creates: \"/etc/shibboleth/sp-cert.pem\""},{"line_number":82,"context_line":"  when: keystone_sp is defined"},{"line_number":83,"context_line":"  notify:"},{"line_number":84,"context_line":"    - Restart Apache"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_2de67615","line":81,"in_reply_to":"fa32b979_04503d5d","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"adc1e32b3ca3f74c410e04486949a94ce5ef2bca","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - keystone-config"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Generate the Shibboleth SP key-pair"},{"line_number":78,"context_line":"  shell: \"shib-keygen -h {{ container_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":79,"context_line":"  args:"},{"line_number":80,"context_line":"    creates: \"/etc/shibboleth/sp-cert.pem\""},{"line_number":81,"context_line":"  when: keystone_sp is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_7fa81d78","line":78,"updated":"2015-06-26 07:12:44.000000000","message":"I think it is safer to use the external_lb_vip_address here as hostname. I was getting cert verfication errors on the IdP assertions because the IdP cert hostname did not match the hostname in the URL, so probably best to make the same change on this side.","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba68f1612c0ac55e226ecc236a2270066350df8f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - keystone-config"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Generate the Shibboleth SP key-pair"},{"line_number":78,"context_line":"  shell: \"shib-keygen -h {{ container_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":79,"context_line":"  args:"},{"line_number":80,"context_line":"    creates: \"/etc/shibboleth/sp-cert.pem\""},{"line_number":81,"context_line":"  when: keystone_sp is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_af1e5ab9","line":78,"in_reply_to":"fa32b979_7fa81d78","updated":"2015-06-26 16:32:49.000000000","message":"Done","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a3b1c0b96fad682436b04034cba68cc8feba7d7e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  tags:"},{"line_number":76,"context_line":"    - keystone-config"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: Generate the Shibboleth SP key-pair"},{"line_number":79,"context_line":"  shell: \"shib-keygen -h {{ external_lb_vip_address }} -y {{ keystone_sp.cert_duration_years }}\""},{"line_number":80,"context_line":"  args:"},{"line_number":81,"context_line":"    creates: \"/etc/shibboleth/sp-cert.pem\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"9a41bdd9_d740040a","line":78,"updated":"2015-07-17 15:23:14.000000000","message":"We need to ensure that the sp-cert and sp-key are distributed to all keystone containers.","commit_id":"5d3c6abb72f5656c271e055b079b5476eebe3548"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a03e978e5c2a2a07bf1f6ad7a26d599dead18d6b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    mode: \"{{ item.mode|default(\u00270644\u0027) }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    - { src: \"keystone-paste.ini\", dest: \"/etc/keystone/keystone-paste.ini\" }"},{"line_number":39,"context_line":"    - { src: \"sso_callback_template.html\", dest: \"/etc/keystone/sso_callback_template.html\" }"},{"line_number":40,"context_line":"    - { src: \"keystone-wsgi.py\", dest: \"/var/www/cgi-bin/keystone/admin\", mode: \"0755\" }"},{"line_number":41,"context_line":"    - { src: \"keystone-wsgi.py\", dest: \"/var/www/cgi-bin/keystone/main\", mode: \"0755\" }"},{"line_number":42,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1a4dcd0f_3eedc5ef","line":39,"updated":"2015-08-07 20:02:40.000000000","message":"nit: would prefer to not be dropping files like this when they are not needed or used.  This can be addressed in a following patch, however.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"becdaf05017834052c36c9397d767d58757b6282","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    mode: \"{{ item.mode|default(\u00270644\u0027) }}\""},{"line_number":37,"context_line":"  with_items:"},{"line_number":38,"context_line":"    - { src: \"keystone-paste.ini\", dest: \"/etc/keystone/keystone-paste.ini\" }"},{"line_number":39,"context_line":"    - { src: \"sso_callback_template.html\", dest: \"/etc/keystone/sso_callback_template.html\" }"},{"line_number":40,"context_line":"    - { src: \"keystone-wsgi.py\", dest: \"/var/www/cgi-bin/keystone/admin\", mode: \"0755\" }"},{"line_number":41,"context_line":"    - { src: \"keystone-wsgi.py\", dest: \"/var/www/cgi-bin/keystone/main\", mode: \"0755\" }"},{"line_number":42,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"1a4dcd0f_b039fef4","line":39,"in_reply_to":"1a4dcd0f_3eedc5ef","updated":"2015-08-07 20:23:04.000000000","message":"This is now a standard file in the keystone deployment - whether you use federation or not. All package-based installations will drop it regardless. I do agree that perhaps we could do better to combat dropping unnecessary files, but this will be a large effort spanning multiple roles.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/os_keystone/tasks/main.yml":[{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"786be4b7022f42c4303221fa15be14eb21b03d55","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- include: keystone_external_idp_setup.yml"},{"line_number":44,"context_line":"  when: \u003e"},{"line_number":45,"context_line":"    keystone_sp|defined"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Flush handlers"},{"line_number":48,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba3cc151_492a5992","line":45,"updated":"2015-07-10 01:19:36.000000000","message":"This syntax with a jinja2 filter does not seem to work. I\u0027m changing it to \"keystone_sp is defined\".","commit_id":"5ad6da1e7fa87193acfa79a2e006dd04b5de239e"}],"playbooks/roles/os_keystone/templates/keystone-httpd.conf.j2":[{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"adc1e32b3ca3f74c410e04486949a94ce5ef2bca","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        Require valid-user"},{"line_number":36,"context_line":"    \u003c/Location\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":39,"context_line":"        ShibRequestSetting requireSession 1"},{"line_number":40,"context_line":"        AuthType shibboleth"},{"line_number":41,"context_line":"        ShibExportAssertion Off"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_9f75e1cd","line":38,"updated":"2015-06-26 07:12:44.000000000","message":"This route is returning 404 for me. If I change this to a \u003cLocation\u003e block with the explicit name of the IdP, I get a 500 instead with the following error in the log:\n\n    2015-06-26 07:00:23 INFO Shibboleth.SessionInitiator.Shib1 [2]: unable to locate Shibboleth-aware identity provider role for provider (http://23.253.97.205:5000/v3/OS-FEDERATION/saml2/idp)\n\nSounds like this may be a legit configuration issue.\n\nMaybe for some reason the pattern based LocationMatch does not work?","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"df8d07b49fa8269b7f1d07a1f4201e9b77ad31fa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        Require valid-user"},{"line_number":43,"context_line":"    \u003c/LocationMatch\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    WSGIScriptAliasMatch ^(/v3/OS-FEDERATION/identity_providers/.*?/protocols/.*?/auth)$ /var/www/keystone/main/$1"},{"line_number":46,"context_line":"    {% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    WSGIScriptAlias /  /var/www/cgi-bin/keystone/main"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_fb1bcc1a","line":45,"updated":"2015-06-26 14:56:32.000000000","message":"the path /var/www/keystone/main/$1 is wrong - change to /var/www/cgi-bin/keystone/main/$1","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba68f1612c0ac55e226ecc236a2270066350df8f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        Require valid-user"},{"line_number":43,"context_line":"    \u003c/LocationMatch\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    WSGIScriptAliasMatch ^(/v3/OS-FEDERATION/identity_providers/.*?/protocols/.*?/auth)$ /var/www/keystone/main/$1"},{"line_number":46,"context_line":"    {% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    WSGIScriptAlias /  /var/www/cgi-bin/keystone/main"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"fa32b979_ca8b8c67","line":45,"in_reply_to":"fa32b979_fb1bcc1a","updated":"2015-06-26 16:32:49.000000000","message":"Done","commit_id":"7d308378251194a9eeb474c948fdd27d8fe6fee9"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"094213581f4909670cdde83c7cb9f9e442befe10","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        Require valid-user"},{"line_number":48,"context_line":"    \u003c/Location\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    \u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":51,"context_line":"        ShibRequestSetting requireSession 1"},{"line_number":52,"context_line":"        AuthType shibboleth"},{"line_number":53,"context_line":"        ShibExportAssertion Off"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_50c9daaa","line":50,"updated":"2015-07-15 14:27:36.000000000","message":"protocols here should be \u0027*\u0027.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"47ede43f967158c684f05f5597bd0cf5d85a78f5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        Require valid-user"},{"line_number":48,"context_line":"    \u003c/Location\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    \u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":51,"context_line":"        ShibRequestSetting requireSession 1"},{"line_number":52,"context_line":"        AuthType shibboleth"},{"line_number":53,"context_line":"        ShibExportAssertion Off"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_a9d31c5f","line":50,"in_reply_to":"9a41bdd9_50c9daaa","updated":"2015-07-15 16:31:16.000000000","message":"Should it be \u0027/v3/OS-FEDERATION/identity_providers/.*?/*/saml2/auth\u0027 then?","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"}],"playbooks/roles/os_keystone/templates/keystone.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"81ef8fe346749ba5d1baf656fb6b108efc272066","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"{% if keystone_sp is defined %}"},{"line_number":103,"context_line":"[saml2]"},{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_5253f5e1","line":103,"updated":"2015-06-25 12:41:47.000000000","message":"The right heading is \u0027saml\u0027 and it is used for idp settings, so there\u0027s no need for it here.","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67de0394692ad5b8bc0e98ab70cf8f58394cfada","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"{% if keystone_sp is defined %}"},{"line_number":103,"context_line":"[saml2]"},{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_37e3c0a5","line":103,"in_reply_to":"fa32b979_5253f5e1","updated":"2015-06-25 13:33:28.000000000","message":"Done","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"81ef8fe346749ba5d1baf656fb6b108efc272066","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"{% if keystone_sp is defined %}"},{"line_number":103,"context_line":"[saml2]"},{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"},{"line_number":107,"context_line":"driver \u003d keystone.contrib.federation.backends.sql.Federation"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_92c65d98","line":104,"updated":"2015-06-25 12:41:47.000000000","message":"This setting belongs in the \u0027federation\u0027 section.","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67de0394692ad5b8bc0e98ab70cf8f58394cfada","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"{% if keystone_sp is defined %}"},{"line_number":103,"context_line":"[saml2]"},{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"},{"line_number":107,"context_line":"driver \u003d keystone.contrib.federation.backends.sql.Federation"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_57de84da","line":104,"in_reply_to":"fa32b979_92c65d98","updated":"2015-06-25 13:33:28.000000000","message":"Done","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"81ef8fe346749ba5d1baf656fb6b108efc272066","unresolved":false,"context_lines":[{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"},{"line_number":107,"context_line":"driver \u003d keystone.contrib.federation.backends.sql.Federation"},{"line_number":108,"context_line":"trusted_dashboard \u003d {{ keystone_sp.trusted_dashboard }}"},{"line_number":109,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_f27c8972","line":107,"updated":"2015-06-25 12:41:47.000000000","message":"This appears unnecessary as it\u0027s the default driver according to http://docs.openstack.org/kilo/config-reference/content/keystone-configuration-file.html","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67de0394692ad5b8bc0e98ab70cf8f58394cfada","unresolved":false,"context_lines":[{"line_number":104,"context_line":"remote_id_attribute \u003d Shib-Identity-Provider"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[federation]"},{"line_number":107,"context_line":"driver \u003d keystone.contrib.federation.backends.sql.Federation"},{"line_number":108,"context_line":"trusted_dashboard \u003d {{ keystone_sp.trusted_dashboard }}"},{"line_number":109,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa32b979_f7ef9884","line":107,"in_reply_to":"fa32b979_f27c8972","updated":"2015-06-25 13:33:28.000000000","message":"Done","commit_id":"d4c94bb359c35a78a86ca76b464f573fea01f5e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8294db69dc18293b12830f68d032550512215694","unresolved":false,"context_lines":[{"line_number":45,"context_line":"[auth]"},{"line_number":46,"context_line":"{% if keystone_sp is defined %}"},{"line_number":47,"context_line":"methods \u003d {{ keystone_auth_methods }},saml2"},{"line_number":48,"context_line":"saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":49,"context_line":"{% else %}"},{"line_number":50,"context_line":"methods \u003d {{ keystone_auth_methods }}"},{"line_number":51,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_7043be13","line":48,"updated":"2015-07-15 14:30:31.000000000","message":"Depending on the version of Keystone that you\u0027re using (or latest python wheels), you might not need the keystone.auth.plugins.mapped.Mapped part, since Keystone now supports loading plugins/drivers with stevedore [0].\n\nhttps://review.openstack.org/#/c/182102/11","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d291fb11e739213d38cc3966c25acdf22e734a1b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"[auth]"},{"line_number":46,"context_line":"{% if keystone_sp is defined %}"},{"line_number":47,"context_line":"methods \u003d {{ keystone_auth_methods }},saml2"},{"line_number":48,"context_line":"saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":49,"context_line":"{% else %}"},{"line_number":50,"context_line":"methods \u003d {{ keystone_auth_methods }}"},{"line_number":51,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_7b22bfa4","line":48,"in_reply_to":"9a41bdd9_7043be13","updated":"2015-07-15 14:41:22.000000000","message":"This is good to know for liberty, so once we\u0027ve completed this work and backported it to our kilo branch we can put in a review for this line\u0027s removal.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"}],"playbooks/roles/os_keystone/templates/shibboleth-attribute-map.xml.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cAttributes xmlns\u003d\"urn:mace:shibboleth:2.0:attribute-map\" xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    \u003c!--"},{"line_number":4,"context_line":"    The mappings are a mix of SAML 1.1 and SAML 2.0 attribute names agreed to within the Shibboleth"},{"line_number":5,"context_line":"    community. The non-OID URNs are SAML 1.1 names and most of the OIDs are SAML 2.0 names, with a"},{"line_number":6,"context_line":"    few exceptions for newer attributes where the name is the same for both versions. You will"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_a754e5fe","line":3,"updated":"2015-07-14 17:17:04.000000000","message":"We should remove all the comments from this file.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cAttributes xmlns\u003d\"urn:mace:shibboleth:2.0:attribute-map\" xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    \u003c!--"},{"line_number":4,"context_line":"    The mappings are a mix of SAML 1.1 and SAML 2.0 attribute names agreed to within the Shibboleth"},{"line_number":5,"context_line":"    community. The non-OID URNs are SAML 1.1 names and most of the OIDs are SAML 2.0 names, with a"},{"line_number":6,"context_line":"    few exceptions for newer attributes where the name is the same for both versions. You will"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_efc2b233","line":3,"in_reply_to":"9a41bdd9_a754e5fe","updated":"2015-07-15 00:35:58.000000000","message":"Not a huge deal, but consider that for people who are configuring this by hand these examples in the comments might be useful to have. Remember that we are going to trash the original config installed by shibboleth, so this is all they\u0027ll have.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5c9539650c5bc08ceaabcfc2197833c55b83b267","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cAttributes xmlns\u003d\"urn:mace:shibboleth:2.0:attribute-map\" xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    \u003c!--"},{"line_number":4,"context_line":"    The mappings are a mix of SAML 1.1 and SAML 2.0 attribute names agreed to within the Shibboleth"},{"line_number":5,"context_line":"    community. The non-OID URNs are SAML 1.1 names and most of the OIDs are SAML 2.0 names, with a"},{"line_number":6,"context_line":"    few exceptions for newer attributes where the name is the same for both versions. You will"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_ba712a78","line":3,"in_reply_to":"9a41bdd9_c3d3fdd3","updated":"2015-07-15 12:29:28.000000000","message":"Scratch this idea - we can leave the bits in the template.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"204359dda518f480c39026245fc45e01de51af3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cAttributes xmlns\u003d\"urn:mace:shibboleth:2.0:attribute-map\" xmlns:xsi\u003d\"http://www.w3.org/2001/XMLSchema-instance\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"    \u003c!--"},{"line_number":4,"context_line":"    The mappings are a mix of SAML 1.1 and SAML 2.0 attribute names agreed to within the Shibboleth"},{"line_number":5,"context_line":"    community. The non-OID URNs are SAML 1.1 names and most of the OIDs are SAML 2.0 names, with a"},{"line_number":6,"context_line":"    few exceptions for newer attributes where the name is the same for both versions. You will"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_c3d3fdd3","line":3,"in_reply_to":"9a41bdd9_efc2b233","updated":"2015-07-15 08:06:59.000000000","message":"How about we have a task that renames the default file to shibboleth2.example?","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \u003cAttribute name\u003d\"urn:oid:2.5.4.19\" id\u003d\"physicalDeliveryOfficeName\"/\u003e"},{"line_number":142,"context_line":"    --\u003e"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    \u003cAttribute name\u003d\"openstack_user\" id\u003d\"openstack_user\"/\u003e"},{"line_number":145,"context_line":"    \u003cAttribute name\u003d\"openstack_roles\" id\u003d\"openstack_roles\"/\u003e"},{"line_number":146,"context_line":"    \u003cAttribute name\u003d\"openstack_project\" id\u003d\"openstack_project\"/\u003e"},{"line_number":147,"context_line":"    \u003cAttribute name\u003d\"openstack_user_domain\" id\u003d\"openstack_user_domain\"/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_6771fda7","line":144,"updated":"2015-07-14 17:17:04.000000000","message":"We need to include these name:id pairs as a hash in the variables and allow them to be specified per IdP. Every IdP may present different attributes, so we\u0027ll need to iterate through them to add them to this file.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \u003cAttribute name\u003d\"urn:oid:2.5.4.19\" id\u003d\"physicalDeliveryOfficeName\"/\u003e"},{"line_number":142,"context_line":"    --\u003e"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    \u003cAttribute name\u003d\"openstack_user\" id\u003d\"openstack_user\"/\u003e"},{"line_number":145,"context_line":"    \u003cAttribute name\u003d\"openstack_roles\" id\u003d\"openstack_roles\"/\u003e"},{"line_number":146,"context_line":"    \u003cAttribute name\u003d\"openstack_project\" id\u003d\"openstack_project\"/\u003e"},{"line_number":147,"context_line":"    \u003cAttribute name\u003d\"openstack_user_domain\" id\u003d\"openstack_user_domain\"/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_8f852608","line":144,"in_reply_to":"9a41bdd9_6771fda7","updated":"2015-07-15 00:35:58.000000000","message":"Done","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"094213581f4909670cdde83c7cb9f9e442befe10","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \u003cAttributeDecoder xsi:type\u003d\"NameIDAttributeDecoder\" formatter\u003d\"$NameQualifier!$SPNameQualifier!$Name\" defaultQualifiers\u003d\"true\"/\u003e"},{"line_number":60,"context_line":"    \u003c/Attribute\u003e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    \u003c!-- Some more eduPerson attributes, uncomment these to use them... --\u003e"},{"line_number":63,"context_line":"    \u003c!--"},{"line_number":64,"context_line":"    \u003cAttribute name\u003d\"urn:mace:dir:attribute-def:eduPersonPrimaryAffiliation\" id\u003d\"primary-affiliation\"\u003e"},{"line_number":65,"context_line":"        \u003cAttributeDecoder xsi:type\u003d\"StringAttributeDecoder\" caseSensitive\u003d\"false\"/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_d002cab3","line":62,"updated":"2015-07-15 14:27:36.000000000","message":"let\u0027s remove comments since we don\u0027t use them anyway.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"47ede43f967158c684f05f5597bd0cf5d85a78f5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \u003cAttributeDecoder xsi:type\u003d\"NameIDAttributeDecoder\" formatter\u003d\"$NameQualifier!$SPNameQualifier!$Name\" defaultQualifiers\u003d\"true\"/\u003e"},{"line_number":60,"context_line":"    \u003c/Attribute\u003e"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    \u003c!-- Some more eduPerson attributes, uncomment these to use them... --\u003e"},{"line_number":63,"context_line":"    \u003c!--"},{"line_number":64,"context_line":"    \u003cAttribute name\u003d\"urn:mace:dir:attribute-def:eduPersonPrimaryAffiliation\" id\u003d\"primary-affiliation\"\u003e"},{"line_number":65,"context_line":"        \u003cAttributeDecoder xsi:type\u003d\"StringAttributeDecoder\" caseSensitive\u003d\"false\"/\u003e"}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"9a41bdd9_c988e073","line":62,"in_reply_to":"9a41bdd9_d002cab3","updated":"2015-07-15 16:31:16.000000000","message":"Yeah, these comments do get in the way - they\u0027re a bit verbose.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"adbc24789d6df8b47e162ad9ac6446c8adbca62a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_f061c612","updated":"2015-08-07 20:25:47.000000000","message":"Is this a dirived work from elsewhere? if so do we need to attribute the file accordingly or Can we add the boiler plate license headers here and adding the ansible managed comment?","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"23afd1c0b2f5223b065d36a72305fcfd9ea3f129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_44c79f64","in_reply_to":"1a4dcd0f_f061c612","updated":"2015-08-07 20:37:47.000000000","message":"This is based on what mod_shib2 installs and places there by default. It\u0027s been customised quite extensively.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}],"playbooks/roles/os_keystone/templates/shibboleth2.xml.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"40275d1efe376862db02d4d2ceac2ed447db61bb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    --\u003e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":23,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\""},{"line_number":24,"context_line":"                         REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        \u003c!--"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_acc12f31","line":23,"updated":"2015-06-23 14:21:55.000000000","message":"\u0027https://sp.example.org/shibboleth\u0027 here is an identifier which apparently can be anything, although I think this is best set to http(s)://public_LB_IP:5000/shibboleth or something like that","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    --\u003e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":23,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\""},{"line_number":24,"context_line":"                         REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        \u003c!--"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_ed996e7a","line":23,"in_reply_to":"fa32b979_acc12f31","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"40275d1efe376862db02d4d2ceac2ed447db61bb","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":23,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\""},{"line_number":24,"context_line":"                         REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        \u003c!--"},{"line_number":27,"context_line":"        Controls session lifetimes, address checks, cookie handling, and the protocol handlers."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_2c23df59","line":24,"updated":"2015-06-23 14:21:55.000000000","message":"The \u0027REMOTE_USER\u0027 line should be removed.","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    \u003c!-- The ApplicationDefaults element is where most of Shibboleth\u0027s SAML bits are defined. --\u003e"},{"line_number":23,"context_line":"    \u003cApplicationDefaults entityID\u003d\"https://sp.example.org/shibboleth\""},{"line_number":24,"context_line":"                         REMOTE_USER\u003d\"eppn persistent-id targeted-id\"\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        \u003c!--"},{"line_number":27,"context_line":"        Controls session lifetimes, address checks, cookie handling, and the protocol handlers."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_ad8e062c","line":24,"in_reply_to":"fa32b979_2c23df59","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"604de7996ef565349a8e349b241ddb15abc383e2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \u003c!-- Low-level configuration about protocols and bindings available for use. --\u003e"},{"line_number":117,"context_line":"    \u003cProtocolProvider type\u003d\"XML\" validate\u003d\"true\" reloadChanges\u003d\"false\" path\u003d\"protocols.xml\"/\u003e"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    \u003cSSO entityID\u003d\"{{ keystone_sp.idp_entity_id }}\"\u003e"},{"line_number":120,"context_line":"        SAML2 SAML1"},{"line_number":121,"context_line":"    \u003c/SSO\u003e"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_0cc37b8a","line":119,"updated":"2015-06-23 14:18:38.000000000","message":"This needs to go under \u0027Sessions\u0027 at line 44","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    \u003c!-- Low-level configuration about protocols and bindings available for use. --\u003e"},{"line_number":117,"context_line":"    \u003cProtocolProvider type\u003d\"XML\" validate\u003d\"true\" reloadChanges\u003d\"false\" path\u003d\"protocols.xml\"/\u003e"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    \u003cSSO entityID\u003d\"{{ keystone_sp.idp_entity_id }}\"\u003e"},{"line_number":120,"context_line":"        SAML2 SAML1"},{"line_number":121,"context_line":"    \u003c/SSO\u003e"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_2d7bd629","line":119,"in_reply_to":"fa32b979_0cc37b8a","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"604de7996ef565349a8e349b241ddb15abc383e2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        SAML2 SAML1"},{"line_number":121,"context_line":"    \u003c/SSO\u003e"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    \u003cMetadataProvider type\u003d\"XML\" uri\u003d\"{{ keystone_sp.idp_metadata_provider }}\"/\u003e"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\u003c/SPConfig\u003e"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_cc4fd332","line":123,"updated":"2015-06-23 14:18:38.000000000","message":"This needs to go under ApplicationDefaults at around line 86","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"6d24d5bad227fd9f934d6cf1413b13a75e6c4f24","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        SAML2 SAML1"},{"line_number":121,"context_line":"    \u003c/SSO\u003e"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    \u003cMetadataProvider type\u003d\"XML\" uri\u003d\"{{ keystone_sp.idp_metadata_provider }}\"/\u003e"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\u003c/SPConfig\u003e"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa32b979_0da5b2a0","line":123,"in_reply_to":"fa32b979_cc4fd332","updated":"2015-06-23 15:57:07.000000000","message":"Done","commit_id":"d9d02106b31dcfdaa19520a474c0c28e955a9a87"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"11a7bbd8e5b18bff04079850478ae0775a0598a5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"},{"line_number":22,"context_line":"            \u003cSSO ECP\u003d\"true\" entityID\u003d\"{{ keystone_sp.trusted_idp_list.0.entity_id }}\"\u003e"},{"line_number":23,"context_line":"                SAML2 SAML1"},{"line_number":24,"context_line":"            \u003c/SSO\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ba3cc151_dcca904f","line":22,"updated":"2015-06-29 14:17:18.000000000","message":"Using multiple IdP\u0027s requires a discovery URL (it seems) that supplies information about multiple IdP\u0027s. For now I\u0027ve left the data structures in place to provide for multiple IdP\u0027s later, but for now due to this only one IdP can be configured.","commit_id":"167f511ecb5c8b20c1ca45f9a455fc1118302f39"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e6270eda49059702a1ffb19a063cb6ee1e8f38ce","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"ba3cc151_e199c46f","line":17,"updated":"2015-06-30 10:09:52.000000000","message":"We need to change this to true if the IdP entity_id is being served via HTTPS.","commit_id":"ad15859dd897f18b9c55b46ad80b564688126ebe"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e6270eda49059702a1ffb19a063cb6ee1e8f38ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"ba3cc151_61ae1487","line":18,"updated":"2015-06-30 10:09:52.000000000","message":"We need to change this to https if the IdP entity_id is being served via HTTPS.","commit_id":"ad15859dd897f18b9c55b46ad80b564688126ebe"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6a5dfbe5a58bc8f8dda266e9af3b65e35fe6151a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"},{"line_number":22,"context_line":"            \u003cSSO ECP\u003d\"true\" entityID\u003d\"{{ keystone_sp.trusted_idp_list.0.entity_id }}\"\u003e"},{"line_number":23,"context_line":"                SAML2 SAML1"},{"line_number":24,"context_line":"            \u003c/SSO\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"ba3cc151_a38d277d","line":22,"updated":"2015-06-29 15:50:26.000000000","message":"For multiple IdP back-ends, the entityID needs to be removed from here.","commit_id":"ad15859dd897f18b9c55b46ad80b564688126ebe"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_477ab978","line":17,"updated":"2015-07-14 17:17:04.000000000","message":"handlerSSL should be \u0027true\u0027 when keystone_ssl_enabled is true","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"204359dda518f480c39026245fc45e01de51af3e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_e3bde168","line":17,"in_reply_to":"9a41bdd9_1973a416","updated":"2015-07-15 08:06:59.000000000","message":"Nope, for this in particular it must only be true if the Apache providing Shibboleth is running SSL - at least that\u0027s what it says here: https://wiki.shibboleth.net/confluence/display/SHIB2/SPReverseProxy","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_1973a416","line":17,"in_reply_to":"9a41bdd9_477ab978","updated":"2015-07-15 00:35:58.000000000","message":"I believe it is more accurate to use keystone_service_publicuri_proto. That covers the case of haproxy SSL.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"805894e83db95f91814fa8ab011a0c8d50d669d1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_a7f065ff","line":18,"updated":"2015-07-14 17:17:04.000000000","message":"cookieProps should be set to the same value as keystone_service_publicuri_proto by default, I think.","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"7c87b2e27ad5e2df17fb30a1d517892929a4c0d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"false\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"http\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"9a41bdd9_d9f53c57","line":18,"in_reply_to":"9a41bdd9_a7f065ff","updated":"2015-07-15 00:35:58.000000000","message":"Done","commit_id":"dbe4e465a227ebbbc96f74a043a54dee53fcece1"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"094213581f4909670cdde83c7cb9f9e442befe10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"9a41bdd9_2d2401c3","updated":"2015-07-15 14:27:36.000000000","message":"how about removing useless tesshib generated comments from this template?","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"47ede43f967158c684f05f5597bd0cf5d85a78f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"9a41bdd9_696d14cb","in_reply_to":"9a41bdd9_2d2401c3","updated":"2015-07-15 16:31:16.000000000","message":"We\u0027ve reduced the comments down to stuff that is helpful for an operator to understand what it\u0027s about. While the referred documentation is pretty bad, the comments aren\u0027t overbearing so we\u0027re happy for them to stay. That said, I don\u0027t feel too strongly about it and will happily do this if others would like to see them removed.","commit_id":"da74eeec84b1e4362e7157715da7f061ff1b7239"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"0fd3c56bca2c429f0cb9565a9157a00292dcbc9a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"{% if keystone_ssl_enabled | bool %}true{% else %}false{% endif %}\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"{{ keystone_service_publicuri_proto }}\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a41bdd9_1fa59645","line":17,"updated":"2015-07-15 17:17:46.000000000","message":"Isn\u0027t this going to be false when we enable SSL through haproxy? I think checking for keystone_service_publicuri_proto \u003d\u003d \"https\" covers both the local SSL and the haproxy SSL cases.","commit_id":"67ef5e74d924f4cf98bf62b215e4b60992a1c69a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fbe9e461f40e46a3e996da8459e33a5f1a029b61","unresolved":false,"context_lines":[{"line_number":14,"context_line":"                  timeout\u003d\"3600\""},{"line_number":15,"context_line":"                  relayState\u003d\"ss:mem\""},{"line_number":16,"context_line":"                  checkAddress\u003d\"false\""},{"line_number":17,"context_line":"                  handlerSSL\u003d\"{% if keystone_ssl_enabled | bool %}true{% else %}false{% endif %}\""},{"line_number":18,"context_line":"                  cookieProps\u003d\"{{ keystone_service_publicuri_proto }}\"\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"9a41bdd9_203a9f99","line":17,"in_reply_to":"9a41bdd9_1fa59645","updated":"2015-07-16 08:32:26.000000000","message":"Yes, and it must be false if SSL is handled by haproxy.","commit_id":"67ef5e74d924f4cf98bf62b215e4b60992a1c69a"},{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"2fddb47b6390677ad6bee8056c0bd82df6da256a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"},{"line_number":22,"context_line":"            \u003cSSO ECP\u003d\"true\" entityID\u003d\"{{ keystone_sp.trusted_idp_list.0.entity_ids.0 }}\"\u003e"},{"line_number":23,"context_line":"                SAML2 SAML1"},{"line_number":24,"context_line":"            \u003c/SSO\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":57,"id":"3a50d1a3_461fa3b7","line":22,"updated":"2015-07-23 23:58:17.000000000","message":"It\u0027s odd that even with the limitation that this \u003cSSO\u003e element is created for the first IdP only, I can attach a second IdP and get it work. Do we understand why the second IdP works even though it isn\u0027t configured here?","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f1174de778568b2c01ba2dba18b38e2f982c7826","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"            \u003c!-- Triggers a login request directly to the IdP. --\u003e"},{"line_number":21,"context_line":"            \u003c!-- https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPServiceSSO --\u003e"},{"line_number":22,"context_line":"            \u003cSSO ECP\u003d\"true\" entityID\u003d\"{{ keystone_sp.trusted_idp_list.0.entity_ids.0 }}\"\u003e"},{"line_number":23,"context_line":"                SAML2 SAML1"},{"line_number":24,"context_line":"            \u003c/SSO\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":57,"id":"3a50d1a3_18f24807","line":22,"in_reply_to":"3a50d1a3_461fa3b7","updated":"2015-07-24 08:51:12.000000000","message":"This entityID is a \u0027default\u0027 which is used for WebSSO as the default entity to redirect the web browser to. The second IDP works when authenticating to it specifically due to the metadata items output in a loop in lines 63-70. That loops defined the list of trusted IDP\u0027s for this SP, all of which may be authenticated against.","commit_id":"32fea8bfaac2cf336ba0be0b11cd1d3bb3809c7a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"adbc24789d6df8b47e162ad9ac6446c8adbca62a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_507d1ab0","updated":"2015-08-07 20:25:47.000000000","message":"Is this a dirived work from elsewhere? if so do we need to attribute the file accordingly or Can we add the boiler plate license headers here and adding the ansible managed comment?","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"23afd1c0b2f5223b065d36a72305fcfd9ea3f129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"1a4dcd0f_c4808ffa","in_reply_to":"1a4dcd0f_507d1ab0","updated":"2015-08-07 20:37:47.000000000","message":"This is based on what mod_shib2 installs and places there by default. It\u0027s been customised quite extensively.","commit_id":"23da164fe467898e08dfcccefafebd9641343b09"}]}
