)]}'
{"playbooks/roles/haproxy_server/meta/main.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"7276d13d9b77648b3bbb0c3c92a7fec09b42e3e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"galaxy_info:"},{"line_number":17,"context_line":"  author: rcbops"},{"line_number":18,"context_line":"  description: Installation and setup of HAPtoxy"},{"line_number":19,"context_line":"  company: Rackspace"},{"line_number":20,"context_line":"  license: Apache2"},{"line_number":21,"context_line":"  min_ansible_version: 1.9.0"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_a611c055","line":18,"updated":"2015-07-10 12:48:55.000000000","message":"nit: obviously not directly related to this patch but if this does need another patchset s/HAPtoxy/HAProxy/","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eff0a3404f719d833dd88e567fb7de67a2867263","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"galaxy_info:"},{"line_number":17,"context_line":"  author: rcbops"},{"line_number":18,"context_line":"  description: Installation and setup of HAPtoxy"},{"line_number":19,"context_line":"  company: Rackspace"},{"line_number":20,"context_line":"  license: Apache2"},{"line_number":21,"context_line":"  min_ansible_version: 1.9.0"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_f1b44e36","line":18,"in_reply_to":"ba3cc151_a611c055","updated":"2015-07-10 16:28:31.000000000","message":"Done","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"}],"playbooks/roles/os_keystone/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dc463102ed01d9710400ac10695070e48850c489","unresolved":false,"context_lines":[{"line_number":117,"context_line":"## Apache setup"},{"line_number":118,"context_line":"keystone_apache_log_level: info"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"keystone_ssl_enabled: false"},{"line_number":121,"context_line":"keystone_self_signed: true"},{"line_number":122,"context_line":"keystone_self_signed_regen: false"},{"line_number":123,"context_line":"keystone_server_name: \"keystone\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba3cc151_8e57d9c9","line":120,"updated":"2015-07-06 15:28:00.000000000","message":"I think that we should rather key off from keystone_service_*_proto, which enables https on a per endpoint basis. We should have logic which makes the two :5000 endpoints always be the same protocol, but :35357 can be different. eg: :5000 can be setup as https and :35357 as http.","commit_id":"03c1b92c7398b7093ba647aca22ae0e8f7a9ff68"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"7276d13d9b77648b3bbb0c3c92a7fec09b42e3e7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"## Apache setup"},{"line_number":122,"context_line":"keystone_apache_log_level: info"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_ssl: false"},{"line_number":125,"context_line":"keystone_ssl_cert: /etc/ssl/certs/keystone.pem"},{"line_number":126,"context_line":"keystone_ssl_key: /etc/ssl/private/keystone.key"},{"line_number":127,"context_line":"keystone_ssl_ca_cert: /etc/ssl/certs/keystone-ca.pem"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_86159ce6","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":12},"updated":"2015-07-10 12:48:55.000000000","message":"Is this var really necessary? For example, when would I want \u0027not keystone_ssl | bool and keystone_service_adminuri_proto \u003d\u003d \"https\"\u0027?","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eff0a3404f719d833dd88e567fb7de67a2867263","unresolved":false,"context_lines":[{"line_number":121,"context_line":"## Apache setup"},{"line_number":122,"context_line":"keystone_apache_log_level: info"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_ssl: false"},{"line_number":125,"context_line":"keystone_ssl_cert: /etc/ssl/certs/keystone.pem"},{"line_number":126,"context_line":"keystone_ssl_key: /etc/ssl/private/keystone.key"},{"line_number":127,"context_line":"keystone_ssl_ca_cert: /etc/ssl/certs/keystone-ca.pem"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_717fde66","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":12},"in_reply_to":"ba3cc151_3ca93591","updated":"2015-07-10 16:28:31.000000000","message":"Done","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"863af4df8199776bbc9635e13fc5702e2ead3d75","unresolved":false,"context_lines":[{"line_number":121,"context_line":"## Apache setup"},{"line_number":122,"context_line":"keystone_apache_log_level: info"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_ssl: false"},{"line_number":125,"context_line":"keystone_ssl_cert: /etc/ssl/certs/keystone.pem"},{"line_number":126,"context_line":"keystone_ssl_key: /etc/ssl/private/keystone.key"},{"line_number":127,"context_line":"keystone_ssl_ca_cert: /etc/ssl/certs/keystone-ca.pem"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_de91209c","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":12},"in_reply_to":"ba3cc151_86159ce6","updated":"2015-07-10 14:18:15.000000000","message":"You\u0027d want keystone_ssl to be false if you were doing ssl offloading at the load balancer.","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"5a7c98cbc06be466f048466b2d333c42cfec95f5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"## Apache setup"},{"line_number":122,"context_line":"keystone_apache_log_level: info"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_ssl: false"},{"line_number":125,"context_line":"keystone_ssl_cert: /etc/ssl/certs/keystone.pem"},{"line_number":126,"context_line":"keystone_ssl_key: /etc/ssl/private/keystone.key"},{"line_number":127,"context_line":"keystone_ssl_ca_cert: /etc/ssl/certs/keystone-ca.pem"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_3ca93591","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":12},"in_reply_to":"ba3cc151_de91209c","updated":"2015-07-10 15:19:33.000000000","message":"Ah, okay. It might be worth putting a comment above this line to explain what this var represents. It\u0027s not immediately apparent what this is for.","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"}],"playbooks/roles/os_keystone/tasks/keystone_apache.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"9de8cf437dc569c42928c77b493e183af8f008e8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    name: ssl"},{"line_number":63,"context_line":"    state: present"},{"line_number":64,"context_line":"  when: \u003e"},{"line_number":65,"context_line":"    keystone_service_publicuri_proto \u003d\u003d \"https\" or"},{"line_number":66,"context_line":"    keystone_service_internaluri_proto \u003d\u003d \"https\" or"},{"line_number":67,"context_line":"    keystone_service_adminuri_proto \u003d\u003d \"https\""},{"line_number":68,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_da063e1b","line":65,"updated":"2015-07-09 16:22:07.000000000","message":"Could this test also be true for LB terminated SSL?","commit_id":"c93c2ef1dc884c1ca9e9ea51ac3ae71a3a6e0cda"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bd97b609b8f9d23e493d70b8e1e2a01e226d8e52","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    name: ssl"},{"line_number":63,"context_line":"    state: present"},{"line_number":64,"context_line":"  when: \u003e"},{"line_number":65,"context_line":"    keystone_service_publicuri_proto \u003d\u003d \"https\" or"},{"line_number":66,"context_line":"    keystone_service_internaluri_proto \u003d\u003d \"https\" or"},{"line_number":67,"context_line":"    keystone_service_adminuri_proto \u003d\u003d \"https\""},{"line_number":68,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba3cc151_3272ceb1","line":65,"in_reply_to":"ba3cc151_da063e1b","updated":"2015-07-10 09:02:52.000000000","message":"Yeah, so I\u0027ve switched this method out to use a boolean again so that SSL endpoints can be enabled at the Keystone service and/or the load balancer.","commit_id":"c93c2ef1dc884c1ca9e9ea51ac3ae71a3a6e0cda"}],"playbooks/roles/os_keystone/tasks/keystone_ssl.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"98c870b707b00a792d25b16b2ec9d41a0d5d35fe","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: keystone_ssl_self_signed.yml"},{"line_number":17,"context_line":"  when: \u003e"},{"line_number":18,"context_line":"    keystone_self_signed \u003d\u003d true or"},{"line_number":19,"context_line":"    keystone_self_signed \u003d\u003d \"True\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: keystone_ssl_user_provided.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba3cc151_e35ec544","line":18,"updated":"2015-06-29 20:05:41.000000000","message":"if the user were to have keys that they wanted to use and variables like `keystone_user_ssl_cert` and `keystone_user_ssl_key` were set for the location of the local keys to distribute to the remote keystone host the variable `keystone_self_signed` would not be required.","commit_id":"03c1b92c7398b7093ba647aca22ae0e8f7a9ff68"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"dc463102ed01d9710400ac10695070e48850c489","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: keystone_ssl_self_signed.yml"},{"line_number":17,"context_line":"  when: \u003e"},{"line_number":18,"context_line":"    keystone_self_signed \u003d\u003d true or"},{"line_number":19,"context_line":"    keystone_self_signed \u003d\u003d \"True\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: keystone_ssl_user_provided.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba3cc151_aee17d00","line":18,"in_reply_to":"ba3cc151_e35ec544","updated":"2015-07-06 15:28:00.000000000","message":"So if the user_ssl variables are defined, then deploy them from the deployment host - otherwise automatically assume that the key/cert should be self-signed?","commit_id":"03c1b92c7398b7093ba647aca22ae0e8f7a9ff68"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"7276d13d9b77648b3bbb0c3c92a7fec09b42e3e7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - keystone-ssl"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- include: keystone_ssl_user_provided.yml"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    keystone_user_ssl_ca_cert is defined or"},{"line_number":26,"context_line":"    (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)"},{"line_number":27,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_81e02698","line":24,"updated":"2015-07-10 12:48:55.000000000","message":"This when isn\u0027t required because the conditions are already defined on the tasks.","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"5a7c98cbc06be466f048466b2d333c42cfec95f5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - keystone-ssl"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- include: keystone_ssl_user_provided.yml"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    keystone_user_ssl_ca_cert is defined or"},{"line_number":26,"context_line":"    (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)"},{"line_number":27,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_7c16dd59","line":24,"in_reply_to":"ba3cc151_5e08b0d9","updated":"2015-07-10 15:19:33.000000000","message":"The when condition here duplicates what is already in the task file.\n\nSo \u0027Drop user provided ssl cert and key\u0027 will run when (keystone_user_ssl_ca_cert is defined or (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)) and (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)\n\n\u0027Drop user provided ssl CA cert\u0027 will run when (keystone_user_ssl_ca_cert is defined or (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)) and (keystone_user_ssl_ca_cert is defined)\n\nSo it will work either way, I just thought the duplication was unnecessary.","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"eff0a3404f719d833dd88e567fb7de67a2867263","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - keystone-ssl"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- include: keystone_ssl_user_provided.yml"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    keystone_user_ssl_ca_cert is defined or"},{"line_number":26,"context_line":"    (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)"},{"line_number":27,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_763ef4db","line":24,"in_reply_to":"ba3cc151_7c16dd59","updated":"2015-07-10 16:28:31.000000000","message":"Ah, good point. Nice catch!","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"863af4df8199776bbc9635e13fc5702e2ead3d75","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - keystone-ssl"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- include: keystone_ssl_user_provided.yml"},{"line_number":24,"context_line":"  when: \u003e"},{"line_number":25,"context_line":"    keystone_user_ssl_ca_cert is defined or"},{"line_number":26,"context_line":"    (keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined)"},{"line_number":27,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba3cc151_5e08b0d9","line":24,"in_reply_to":"ba3cc151_81e02698","updated":"2015-07-10 14:18:15.000000000","message":"This is specifically to allow the distribution of the user-provided ca cert which may be desired even if there\u0027s no user provided key/cert.","commit_id":"3ccdce85b3fc7cb83650a5bb37a58506685e8bf5"}],"playbooks/roles/os_keystone/tasks/keystone_ssl_user_provided.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"98c870b707b00a792d25b16b2ec9d41a0d5d35fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba3cc151_c3f9414f","updated":"2015-06-29 20:05:41.000000000","message":"this assumes that the user is uploading their signed certs to the deployment host within the \"/etc/ssl/certs\" I feel like it would be better to require the user to provide a path to the cert and key file if they\u0027re wanting to copy these items over into keystone. This can be accomplished by creating new variables IE: `keystone_user_ssl_cert` and `keystone_user_ssl_key` which are undefined by default and documented as comments in the \"defaults/main.yml\"","commit_id":"03c1b92c7398b7093ba647aca22ae0e8f7a9ff68"}],"playbooks/roles/os_keystone/templates/keystone.conf.j2":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"9de8cf437dc569c42928c77b493e183af8f008e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"admin_endpoint \u003d {{ keystone_service_adminuri }}"},{"line_number":11,"context_line":"fatal_deprecations \u003d {{ keystone_fatal_deprecations }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% if keystone_service_publicuri_proto \u003d\u003d true and  keystone_secure_proxy_ssl_header is defined %}"},{"line_number":14,"context_line":"secure_proxy_ssl_header \u003d {{ keystone_secure_proxy_ssl_header }}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba3cc151_faa54202","line":13,"updated":"2015-07-09 16:22:07.000000000","message":"keystone_service_publicuri_proto \u003d\u003d https  (Rather than true?)","commit_id":"c93c2ef1dc884c1ca9e9ea51ac3ae71a3a6e0cda"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bd97b609b8f9d23e493d70b8e1e2a01e226d8e52","unresolved":false,"context_lines":[{"line_number":10,"context_line":"admin_endpoint \u003d {{ keystone_service_adminuri }}"},{"line_number":11,"context_line":"fatal_deprecations \u003d {{ keystone_fatal_deprecations }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% if keystone_service_publicuri_proto \u003d\u003d true and  keystone_secure_proxy_ssl_header is defined %}"},{"line_number":14,"context_line":"secure_proxy_ssl_header \u003d {{ keystone_secure_proxy_ssl_header }}"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"ba3cc151_b2381ed6","line":13,"in_reply_to":"ba3cc151_faa54202","updated":"2015-07-10 09:02:52.000000000","message":"Done","commit_id":"c93c2ef1dc884c1ca9e9ea51ac3ae71a3a6e0cda"}],"playbooks/vars/configs/haproxy_config.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ceb46b0ee328caf2e1e708ac9c55de1b9dc24779","unresolved":false,"context_lines":[{"line_number":137,"context_line":"      haproxy_backend_port: 8181"},{"line_number":138,"context_line":"      haproxy_balance_type: http"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"haproxy_keystone_service_configs:"},{"line_number":141,"context_line":"  - service:"},{"line_number":142,"context_line":"      haproxy_service_name: keystone_admin"},{"line_number":143,"context_line":"      haproxy_backend_nodes: \"{{ groups[\u0027keystone_all\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba3cc151_ee93054e","line":140,"updated":"2015-07-06 15:29:27.000000000","message":"This assumes an all-or-nothing approach, whereas it is plausible to have the service/internal endpoint using HTTPS while the admin endpoint is HTTP.","commit_id":"03c1b92c7398b7093ba647aca22ae0e8f7a9ff68"}]}
