)]}'
{"playbooks/repo-clone-mirror.yml":[{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"cd1198d219fb4365127ec7fdc3fcfa0b92942e89","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_bb0fb6de","line":39,"range":{"start_line":39,"start_character":9,"end_line":39,"end_character":24},"updated":"2015-06-25 15:35:33.000000000","message":"I presume the addition of \u0027python_packages\u0027 vs the previous version was intentional?","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b1fbf57db6a654917eca8b4e83a840ac33536f5e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_4053d86c","line":39,"in_reply_to":"fa32b979_bb0fb6de","updated":"2015-06-26 18:35:47.000000000","message":"yes this is intentional, the python_packages directory is something that only supports the juno/icehouse releases.","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"4c04ae5eb10663792eb217209c796e3381be4a83","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_57b76739","line":40,"updated":"2015-06-25 12:14:06.000000000","message":"presumably repo_mirror_excludes can be provided somewhere else? Is it worth adding docs or a note to that effect somewhere?\nAlso, if that var is provided, it will override default_mirror_excludes. Is that desired, or would you want the list appended to?","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2c3eb0338881ae4eb8d23a6804f74ae9304db7a4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_6573a0b2","line":40,"in_reply_to":"ba3cc151_fb81a1fc","updated":"2015-06-29 17:35:56.000000000","message":"Done","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5e7d548873addaa6d93cd0a83a142514f3666209","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_6efacd76","line":40,"in_reply_to":"fa32b979_57b76739","updated":"2015-06-25 15:03:57.000000000","message":"the intention is to have it `repo_mirror_excludes` as an override.","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"62e758a0ca489a677981383d5bdf1ead9a58cf34","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_af9f6c00","line":40,"in_reply_to":"fa32b979_6efacd76","updated":"2015-06-25 16:53:28.000000000","message":"why don\u0027t you just have mirror_excludes as a list, and allow that to be overridden?","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b1fbf57db6a654917eca8b4e83a840ac33536f5e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa32b979_e0f1cc6b","line":40,"in_reply_to":"fa32b979_af9f6c00","updated":"2015-06-26 18:35:47.000000000","message":"vars are imutable so to allow this to be overridden the variable `repo_mirror_excludes` is used.","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"ed936bdc28f1baf14629be5daf6bca3f9caa7419","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""},{"line_number":39,"context_line":"      - \"python_packages\""},{"line_number":40,"context_line":"    mirror_excludes: \"{% for i in repo_mirror_excludes|default(default_mirror_excludes) %} --exclude\u003d{{ i }} {% endfor %}\""},{"line_number":41,"context_line":"    mirror_path: \"{{ repo_service_home_folder }}/repo\""},{"line_number":42,"context_line":"    mirror_name: \"{{ repo_mirror_name|default(\u0027openstack_mirror\u0027) }}\""},{"line_number":43,"context_line":"    mirror_source_host: \"{{ repo_mirror_source_host|default(\u0027rpc-repo.rackspace.com\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba3cc151_fb81a1fc","line":40,"in_reply_to":"fa32b979_e0f1cc6b","updated":"2015-06-29 12:07:38.000000000","message":"Vars defined in a play can be overridden by -e vars. So I\u0027m not sure why repo_mirror_excludes couldn\u0027t be defined here, and overridden in user_variables.","commit_id":"f9a0563f085f2bb84df29f73fe843e6daf1171c4"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"f173738c2cfcf438041e8b0073405823ed90c2f8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tasks:"},{"line_number":26,"context_line":"    - name: Sync the upstream repo(s)"},{"line_number":27,"context_line":"      shell: |"},{"line_number":28,"context_line":"        rsync -avzlHAX --delete \\"},{"line_number":29,"context_line":"              {{ mirror_excludes }} \\"},{"line_number":30,"context_line":"              {{ mirror_source_host }}::{{ mirror_name }} {{ mirror_path }}"},{"line_number":31,"context_line":"      sudo: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_8ed3c75f","line":28,"updated":"2015-07-02 13:23:50.000000000","message":"If you run repo-build.yml on rpc-openstack this will create IIRC /var/www/repo/rpc-releases.  Should we be concerned w/ that potentially getting deleted here?","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"294712bb20e752310032366dd6fca9cd3c3a417f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tasks:"},{"line_number":26,"context_line":"    - name: Sync the upstream repo(s)"},{"line_number":27,"context_line":"      shell: |"},{"line_number":28,"context_line":"        rsync -avzlHAX --delete \\"},{"line_number":29,"context_line":"              {{ mirror_excludes }} \\"},{"line_number":30,"context_line":"              {{ mirror_source_host }}::{{ mirror_name }} {{ mirror_path }}"},{"line_number":31,"context_line":"      sudo: yes"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_0e2a57db","line":28,"in_reply_to":"ba3cc151_8ed3c75f","updated":"2015-07-02 13:29:46.000000000","message":"Yes, adding delete here would break some of the additional interop the repo-infra should support. I will remove that and revise.","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"ef493bec83f4bbdbff888fa83e4cf51d4ab16771","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      sudo_user: \"{{ repo_service_user_name }}\""},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    repo_mirror_excludes:"},{"line_number":35,"context_line":"      - \"repos\""},{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_831687a5","line":35,"updated":"2015-07-01 08:57:37.000000000","message":"I think this list should be modified so that each member starts with a slash, e.g. \"/repos\". This will ensure that it only matches against the top level directories.","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"294712bb20e752310032366dd6fca9cd3c3a417f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      sudo_user: \"{{ repo_service_user_name }}\""},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    repo_mirror_excludes:"},{"line_number":35,"context_line":"      - \"repos\""},{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_4e829fc9","line":35,"in_reply_to":"ba3cc151_4e57ffc9","updated":"2015-07-02 13:29:46.000000000","message":"Done","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"294712bb20e752310032366dd6fca9cd3c3a417f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      sudo_user: \"{{ repo_service_user_name }}\""},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    repo_mirror_excludes:"},{"line_number":35,"context_line":"      - \"repos\""},{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_8e7c27ed","line":35,"in_reply_to":"ba3cc151_831687a5","updated":"2015-07-02 13:29:46.000000000","message":"Done","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"f173738c2cfcf438041e8b0073405823ed90c2f8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      sudo_user: \"{{ repo_service_user_name }}\""},{"line_number":33,"context_line":"  vars:"},{"line_number":34,"context_line":"    repo_mirror_excludes:"},{"line_number":35,"context_line":"      - \"repos\""},{"line_number":36,"context_line":"      - \"mirror\""},{"line_number":37,"context_line":"      - \"rpcgit\""},{"line_number":38,"context_line":"      - \"openstackgit\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba3cc151_4e57ffc9","line":35,"in_reply_to":"ba3cc151_831687a5","updated":"2015-07-02 13:23:50.000000000","message":"You\u0027re unlikely to encounter these dirs deeper in the tree, but I agree we may as well be explicit here.","commit_id":"6a277dcb0b7bf73e631c547a5dd0dc3f0007d1ca"}]}