)]}'
{"etc/openstack_deploy/user_group_vars.yml":[{"author":{"_account_id":12606,"name":"Miguel Grinberg","email":"miguel.grinberg@gmail.com","username":"miguelgrinberg"},"change_message_id":"87fbf195099f801a4b427a83cbdd2a0cc6416837","unresolved":false,"context_lines":[{"line_number":145,"context_line":"keystone_service_internaluri: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":146,"context_line":"keystone_service_internalurl: \"{{ keystone_service_internaluri }}/v2.0\""},{"line_number":147,"context_line":"keystone_service_adminuri: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""},{"line_number":148,"context_line":"keystone_service_adminurl_v2: \"{{ keystone_service_adminuri }}/v2.0\""},{"line_number":149,"context_line":"keystone_service_internaluri_v3: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":150,"context_line":"keystone_service_internalurl_v3: \"{{ keystone_service_internaluri_v3 }}/v3\""},{"line_number":151,"context_line":"keystone_service_adminuri_v3: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9a41bdd9_a8805b47","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":28},"updated":"2015-07-14 02:45:45.000000000","message":"I\u0027m manually rebasing and this seems odd. Why do we want the _v2 suffix added here? I think I\u0027m not finding any usages of this with the suffix, I\u0027m going to submit the rebased patch w/o this, please review and correct if I messed it up.","commit_id":"9f104cb29e6b3dd52351a8ba6b7ff1f4f3104cdd"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"968811628d2df11f1aee6d49241b8855a1d9e1bc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"keystone_service_internaluri: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":146,"context_line":"keystone_service_internalurl: \"{{ keystone_service_internaluri }}/v2.0\""},{"line_number":147,"context_line":"keystone_service_adminuri: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""},{"line_number":148,"context_line":"keystone_service_adminurl_v2: \"{{ keystone_service_adminuri }}/v2.0\""},{"line_number":149,"context_line":"keystone_service_internaluri_v3: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":150,"context_line":"keystone_service_internalurl_v3: \"{{ keystone_service_internaluri_v3 }}/v3\""},{"line_number":151,"context_line":"keystone_service_adminuri_v3: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9a41bdd9_92756afb","line":148,"in_reply_to":"9a41bdd9_8b32270f","updated":"2015-07-14 14:12:05.000000000","message":"Because a few lines down we redefine \"keystone_service_adminurl\" as \"keystone_service_adminurl_v3\". I renamed that to _v2 so it was still present","commit_id":"9f104cb29e6b3dd52351a8ba6b7ff1f4f3104cdd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2ef03eb4726aaaa80a5bed20b26d8d3650a20b3a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"keystone_service_internaluri: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":146,"context_line":"keystone_service_internalurl: \"{{ keystone_service_internaluri }}/v2.0\""},{"line_number":147,"context_line":"keystone_service_adminuri: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""},{"line_number":148,"context_line":"keystone_service_adminurl_v2: \"{{ keystone_service_adminuri }}/v2.0\""},{"line_number":149,"context_line":"keystone_service_internaluri_v3: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":150,"context_line":"keystone_service_internalurl_v3: \"{{ keystone_service_internaluri_v3 }}/v3\""},{"line_number":151,"context_line":"keystone_service_adminuri_v3: \"{{ keystone_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_admin_port }}\""}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9a41bdd9_8b32270f","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":28},"in_reply_to":"9a41bdd9_a8805b47","updated":"2015-07-14 09:23:56.000000000","message":"This was part of the library patch, but you\u0027re right it\u0027s not necessary IMO.","commit_id":"9f104cb29e6b3dd52351a8ba6b7ff1f4f3104cdd"}],"playbooks/library/keystone":[{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"60625863886789976e74c6f8747ea29162f39f7f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            \u0027tenant_name\u0027"},{"line_number":214,"context_line":"        ]"},{"line_number":215,"context_line":"    },"},{"line_number":216,"context_line":"    \u0027get_projectt\u0027: {"},{"line_number":217,"context_line":"        \u0027variables\u0027: ["},{"line_number":218,"context_line":"            \u0027project_name\u0027,"},{"line_number":219,"context_line":"            \u0027tenant_name\u0027"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba3cc151_573835a0","line":216,"updated":"2015-07-01 10:04:03.000000000","message":"double t","commit_id":"d9a9ec44f13f61764eb902dff2dce3bfc14e580b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1acc1dec4471bf740616d7411d847f1a21da65c6","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                )"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        if token:"},{"line_number":423,"context_line":"            self.keystone \u003d client.Client(endpoint\u003dendpoint, token\u003dtoken)"},{"line_number":424,"context_line":"        else:"},{"line_number":425,"context_line":"            self.keystone \u003d client.Client("},{"line_number":426,"context_line":"                auth_url\u003dendpoint,"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"ba3cc151_20c958ac","line":423,"updated":"2015-07-02 17:31:00.000000000","message":"Can we also add the option for a \u0027insecure\u0027 boolean (defaults to false) so that we can use the module with self-signed certs? This will need to be done in the glance \u0026 neutron modules too.","commit_id":"d432e42342375e1bec11f360559ae5471d057d5b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"25010bffd97396d512ec46d37b479f18df3416de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DOCUMENTATION \u003d \"\"\""},{"line_number":21,"context_line":"---"},{"line_number":22,"context_line":"module: keystone"},{"line_number":23,"context_line":"version_added: \"1.6.2\""},{"line_number":24,"context_line":"short_description:"},{"line_number":25,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":26,"context_line":"description:"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"ba3cc151_774cab76","line":23,"updated":"2015-07-06 14:21:12.000000000","message":"Shouldn\u0027t the version increase?","commit_id":"00dcf0e2e0a36b5ce8f4d7f5a26d79e1197af5db"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"25010bffd97396d512ec46d37b479f18df3416de","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        description:"},{"line_number":99,"context_line":"            - Name of the domain to add a project to."},{"line_number":100,"context_line":"        required: false"},{"line_number":101,"context_line":"        default: \u0027default\u0027"},{"line_number":102,"context_line":"    description:"},{"line_number":103,"context_line":"        description:"},{"line_number":104,"context_line":"            - A description for the project"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"ba3cc151_d719f77a","line":101,"updated":"2015-07-06 14:21:12.000000000","message":"Lowercase \u0027default\u0027 happens to be the domain ID, not the domain name. I do think that we should specify the use of the domain name though - so this value should be \u0027Default\u0027 (which is the name).","commit_id":"00dcf0e2e0a36b5ce8f4d7f5a26d79e1197af5db"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"ff9af02e33f8856d31fec1bf253f0a0df16ffd12","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            \u0027tenant_name\u0027"},{"line_number":221,"context_line":"        ]"},{"line_number":222,"context_line":"    },"},{"line_number":223,"context_line":"    \u0027get_projectt\u0027: {"},{"line_number":224,"context_line":"        \u0027variables\u0027: ["},{"line_number":225,"context_line":"            \u0027project_name\u0027,"},{"line_number":226,"context_line":"            \u0027tenant_name\u0027"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"ba3cc151_803f7924","line":223,"updated":"2015-07-07 11:58:18.000000000","message":"double t","commit_id":"141b383116a48bc4064e075d174f20c22cf0f668"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"bc0489219d7135904f2cc04aff924d6332b4b9d7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            \u0027tenant_name\u0027"},{"line_number":221,"context_line":"        ]"},{"line_number":222,"context_line":"    },"},{"line_number":223,"context_line":"    \u0027get_projectt\u0027: {"},{"line_number":224,"context_line":"        \u0027variables\u0027: ["},{"line_number":225,"context_line":"            \u0027project_name\u0027,"},{"line_number":226,"context_line":"            \u0027tenant_name\u0027"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"ba3cc151_76779bd4","line":223,"in_reply_to":"ba3cc151_803f7924","updated":"2015-07-07 12:39:28.000000000","message":"Done","commit_id":"141b383116a48bc4064e075d174f20c22cf0f668"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9cb2352e2d2968d7c949b177191796b80d6e617b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"module: keystone"},{"line_number":23,"context_line":"version_added: \"1.6.2\""},{"line_number":24,"context_line":"short_description:"},{"line_number":25,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":26,"context_line":"description:"},{"line_number":27,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":28,"context_line":"options:"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"ba3cc151_5a27a062","line":25,"updated":"2015-07-09 11:29:48.000000000","message":"flake8: E501 line too long (80 \u003e 79 characters)","commit_id":"097821e38eb41b9ea02040a85cf0cdf713439ac4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"17389adbffdb649cd60d74a6ea602d5e0b38f0dc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"module: keystone"},{"line_number":23,"context_line":"version_added: \"1.6.2\""},{"line_number":24,"context_line":"short_description:"},{"line_number":25,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":26,"context_line":"description:"},{"line_number":27,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":28,"context_line":"options:"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"ba3cc151_9552d911","line":25,"in_reply_to":"ba3cc151_5a27a062","updated":"2015-07-09 11:45:16.000000000","message":"Done","commit_id":"097821e38eb41b9ea02040a85cf0cdf713439ac4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9cb2352e2d2968d7c949b177191796b80d6e617b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"short_description:"},{"line_number":25,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":26,"context_line":"description:"},{"line_number":27,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":28,"context_line":"options:"},{"line_number":29,"context_line":"    return_code:"},{"line_number":30,"context_line":"        description:"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"ba3cc151_1a1ef80b","line":27,"updated":"2015-07-09 11:29:48.000000000","message":"flake8: E501 line too long (80 \u003e 79 characters)","commit_id":"097821e38eb41b9ea02040a85cf0cdf713439ac4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"17389adbffdb649cd60d74a6ea602d5e0b38f0dc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"short_description:"},{"line_number":25,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":26,"context_line":"description:"},{"line_number":27,"context_line":"   - Manage OpenStack Identity (keystone) users, projects, roles, and endpoints."},{"line_number":28,"context_line":"options:"},{"line_number":29,"context_line":"    return_code:"},{"line_number":30,"context_line":"        description:"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"ba3cc151_35550df9","line":27,"in_reply_to":"ba3cc151_1a1ef80b","updated":"2015-07-09 11:45:16.000000000","message":"Done","commit_id":"097821e38eb41b9ea02040a85cf0cdf713439ac4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"694d27ed88440879ebecbac060ca26e258581119","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027domain\u0027"},{"line_number":294,"context_line":"        ]"},{"line_number":295,"context_line":"    },"},{"line_number":296,"context_line":"    \u0027ensure_tenant\u0027: {"},{"line_number":297,"context_line":"        \u0027variables\u0027: ["},{"line_number":298,"context_line":"            \u0027project_name\u0027,"},{"line_number":299,"context_line":"            \u0027tenant_name\u0027,"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba3cc151_19583b30","line":296,"updated":"2015-07-09 14:54:16.000000000","message":"rookie question, this can\u0027t be collapsed with `ensure_project`?","commit_id":"473c3748af50c5aadf7ab7f4a9a5a4db12e8c318"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d728dcaf5bdb2d080864d79dc6169d30d123d753","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            \u0027domain\u0027"},{"line_number":294,"context_line":"        ]"},{"line_number":295,"context_line":"    },"},{"line_number":296,"context_line":"    \u0027ensure_tenant\u0027: {"},{"line_number":297,"context_line":"        \u0027variables\u0027: ["},{"line_number":298,"context_line":"            \u0027project_name\u0027,"},{"line_number":299,"context_line":"            \u0027tenant_name\u0027,"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba3cc151_8197f146","line":296,"in_reply_to":"ba3cc151_19583b30","updated":"2015-07-09 15:40:34.000000000","message":"Lance, I was trying to keep the review small and have a minimal impact on playbooks. For now this is a backwards compatibility shim. I\u0027m going to submit a new review that removes usage of it in the playbooks and then a third to remove the shim code.","commit_id":"473c3748af50c5aadf7ab7f4a9a5a4db12e8c318"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"694d27ed88440879ebecbac060ca26e258581119","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        endpoint \u003d variables_dict.pop(\u0027endpoint\u0027)"},{"line_number":406,"context_line":"        login_user \u003d variables_dict.pop(\u0027login_user\u0027)"},{"line_number":407,"context_line":"        login_password \u003d variables_dict.pop(\u0027login_password\u0027)"},{"line_number":408,"context_line":"        # NOTE(sigmavirus24): Remove fallback to login_tenant_name"},{"line_number":409,"context_line":"        login_project_name \u003d (variables_dict.pop(\u0027login_project_name\u0027, None) or"},{"line_number":410,"context_line":"                              variables_dict.pop(\u0027login_tenant_name\u0027))"},{"line_number":411,"context_line":"        token \u003d variables_dict.pop(\u0027token\u0027)"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba3cc151_b96a6fb1","line":408,"updated":"2015-07-09 14:54:16.000000000","message":"# NOTE or TODO/FIXME?","commit_id":"473c3748af50c5aadf7ab7f4a9a5a4db12e8c318"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d728dcaf5bdb2d080864d79dc6169d30d123d753","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        endpoint \u003d variables_dict.pop(\u0027endpoint\u0027)"},{"line_number":406,"context_line":"        login_user \u003d variables_dict.pop(\u0027login_user\u0027)"},{"line_number":407,"context_line":"        login_password \u003d variables_dict.pop(\u0027login_password\u0027)"},{"line_number":408,"context_line":"        # NOTE(sigmavirus24): Remove fallback to login_tenant_name"},{"line_number":409,"context_line":"        login_project_name \u003d (variables_dict.pop(\u0027login_project_name\u0027, None) or"},{"line_number":410,"context_line":"                              variables_dict.pop(\u0027login_tenant_name\u0027))"},{"line_number":411,"context_line":"        token \u003d variables_dict.pop(\u0027token\u0027)"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba3cc151_41748934","line":408,"in_reply_to":"ba3cc151_b96a6fb1","updated":"2015-07-09 15:40:34.000000000","message":"More of a TODO, but I stopped putting these. It\u0027ll be taken care of as part of the commit mentioned above.","commit_id":"473c3748af50c5aadf7ab7f4a9a5a4db12e8c318"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"694d27ed88440879ebecbac060ca26e258581119","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            return None"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def get_tenant(self, variables):"},{"line_number":461,"context_line":"        # NOTE(sigmavirus24): remove after converting playbooks to project"},{"line_number":462,"context_line":"        return self.get_project(variables)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def get_project(self, variables):"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"ba3cc151_995beb21","line":461,"updated":"2015-07-09 14:54:16.000000000","message":"same comment here","commit_id":"473c3748af50c5aadf7ab7f4a9a5a4db12e8c318"}]}