)]}'
{"etc/openstack_deploy/conf.d/swift.yml.aio":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"e23de09a127e2e2f7576be6344a148768065b967","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ip: 172.29.236.100"},{"line_number":29,"context_line":"    container_vars:"},{"line_number":30,"context_line":"      swift_vars:"},{"line_number":31,"context_line":"        limit_container_types: swift"},{"line_number":32,"context_line":"        zone: 0"},{"line_number":33,"context_line":"        region: 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a41bdd9_18e60215","line":31,"updated":"2015-07-15 22:00:01.000000000","message":"How does this affect the swift services running on bare metal?","commit_id":"e3db882aa7a3a05f828d3bec8ff8b3315133e5ba"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"4433040a142b03ccbd5671b782b6c8530da1d3ae","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ip: 172.29.236.100"},{"line_number":29,"context_line":"    container_vars:"},{"line_number":30,"context_line":"      swift_vars:"},{"line_number":31,"context_line":"        limit_container_types: swift"},{"line_number":32,"context_line":"        zone: 0"},{"line_number":33,"context_line":"        region: 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a41bdd9_d1ae2380","line":31,"in_reply_to":"9a41bdd9_18e60215","updated":"2015-07-16 09:52:58.000000000","message":"Assuming the change to the dynamic inventory is correct, the vars \u0027swift_vars\u0027 will get added to the vars on aio1 and the swift_proxy containers.","commit_id":"e3db882aa7a3a05f828d3bec8ff8b3315133e5ba"}],"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"79326d2f71c74809feb30093fb7f5f27ea77efe6","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                    \u0027limit_container_types\u0027, None"},{"line_number":273,"context_line":"                                )"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        if limit is None or component and limit in component:"},{"line_number":276,"context_line":"                            hdata[_keys] \u003d options"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_687ae589","line":275,"updated":"2015-07-15 20:11:20.000000000","message":"I\u0027m pretty sure that and has higher precedence than or in Python, but it would still be quite nice to reformat this with ()s for clarity, e.g., \n\n    if limit is None or (component and limit in component):","commit_id":"e3db882aa7a3a05f828d3bec8ff8b3315133e5ba"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"4433040a142b03ccbd5671b782b6c8530da1d3ae","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                    \u0027limit_container_types\u0027, None"},{"line_number":273,"context_line":"                                )"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        if limit is None or component and limit in component:"},{"line_number":276,"context_line":"                            hdata[_keys] \u003d options"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_55b8be10","line":275,"in_reply_to":"9a41bdd9_687ae589","updated":"2015-07-16 09:52:58.000000000","message":"\u0027and\u0027 has a higher precedence that \u0027or\u0027 [1], I did not add brackets because there was only one of each so I thought it looked fairly clear.\n\nSo, the line in the patch is equivalent to:\n\nif ((limit is None) or (component and (limit in component))):\n\nor as Ian wrote:\n\nif limit is None or (component and limit in component):\n\n[1] https://docs.python.org/2/reference/expressions.html#operator-precedence","commit_id":"e3db882aa7a3a05f828d3bec8ff8b3315133e5ba"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e1dbb517eb7d6ca4ab76e49bdc2a890e9fcbba8e","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                    \u0027limit_container_types\u0027, None"},{"line_number":273,"context_line":"                                )"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        if limit is None or component and limit in component:"},{"line_number":276,"context_line":"                            hdata[_keys] \u003d options"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_27088327","line":275,"in_reply_to":"9a41bdd9_687ae589","updated":"2015-07-16 00:29:12.000000000","message":"wrapping the \"or\" should be done. \n\nIE:  if (limit is None or component) and limit in component","commit_id":"e3db882aa7a3a05f828d3bec8ff8b3315133e5ba"}]}