)]}'
{"playbooks/roles/os_nova/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"023d2668e1354a813eb73be70e07820e444693e7","unresolved":false,"context_lines":[{"line_number":184,"context_line":"nova_libvirt_inject_password: False"},{"line_number":185,"context_line":"nova_libvirt_disk_cachemodes: \u0027{{ nova_libvirt_images_rbd_pool is defined | ternary(\"network\u003dwriteback\", \"\") }}\u0027"},{"line_number":186,"context_line":"nova_libvirt_hw_disk_discard: \u0027{{ nova_libvirt_images_rbd_pool is defined | ternary(\"unmap\", \"ignore\") }}\u0027"},{"line_number":187,"context_line":"nova_libvirt_live_migration_flag: \"VIR_MIGRATE_UNDEFINE_SOURCE,VIR_MIGRATE_PEER2PEER,VIR_MIGRATE_LIVE,VIR_MIGRATE_PERSIST_DEST\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"## Nova conductor"},{"line_number":190,"context_line":"nova_conductor_program_name: nova-conductor"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a4dcd0f_256ef696","line":187,"updated":"2015-08-14 08:10:03.000000000","message":"If the order of these flags doesn\u0027t matter, then I\u0027d suggest defaulting to the normal nova defaults, but using the ternary filter to add the ceph required one on the end of the list.","commit_id":"a873933bb2037bf409d28ef8dd3fb7ff5808aa55"}],"playbooks/roles/os_nova/templates/nova.conf.j2":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"aba44f0396877c64eaf948ae57629022f8844c06","unresolved":false,"context_lines":[{"line_number":253,"context_line":"images_rbd_pool \u003d {{ nova_libvirt_images_rbd_pool }}"},{"line_number":254,"context_line":"images_rbd_ceph_conf \u003d /etc/ceph/ceph.conf"},{"line_number":255,"context_line":"{% endif %}"},{"line_number":256,"context_line":"live_migration_flag \u003d \"{{ nova_libvirt_live_migration_flag }}\""},{"line_number":257,"context_line":"hw_disk_discard \u003d {{ nova_libvirt_hw_disk_discard }}"},{"line_number":258,"context_line":"disk_cachemodes \u003d {{ nova_libvirt_disk_cachemodes }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a4dcd0f_c1505dd7","line":256,"updated":"2015-08-14 11:03:17.000000000","message":"default\u003d\u0027VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, \u0027\n \u0027VIR_MIGRATE_LIVE, VIR_MIGRATE_TUNNELLED\u0027,\n\nThis doesn\u0027t quite match so I think we\u0027ll need to leave that in the \"if\" statement.","commit_id":"10d393ac5b1693aa46c83b0251f32912173926b0"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"e4c0d59923a0f003d11b18d01d01575e910f2b15","unresolved":false,"context_lines":[{"line_number":253,"context_line":"images_rbd_pool \u003d {{ nova_libvirt_images_rbd_pool }}"},{"line_number":254,"context_line":"images_rbd_ceph_conf \u003d /etc/ceph/ceph.conf"},{"line_number":255,"context_line":"{% endif %}"},{"line_number":256,"context_line":"live_migration_flag \u003d \"{{ nova_libvirt_live_migration_flag }}\""},{"line_number":257,"context_line":"hw_disk_discard \u003d {{ nova_libvirt_hw_disk_discard }}"},{"line_number":258,"context_line":"disk_cachemodes \u003d {{ nova_libvirt_disk_cachemodes }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1a4dcd0f_d2b4a936","line":256,"in_reply_to":"1a4dcd0f_c1505dd7","updated":"2015-08-14 12:12:34.000000000","message":"Thanks Andy!  I actually meant to commit the nova default, as that is what I tested.  I see a few sources mentioning VIR_MIGRATE_PERSIST_DEST but in my lab when I live-migrated an instance it was still there after a host reboot, etc even without VIR_MIGRATE_PERSIST_DEST specified.  I suggest we use the nova default and then look at adding VIR_MIGRATE_PERSIST_DEST either to the ceph config or to nova_libvirt_live_migration_flag if we feel there is a need.","commit_id":"10d393ac5b1693aa46c83b0251f32912173926b0"}]}