)]}'
{"scripts/bootstrap-aio.sh":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"a34ea97fe2550ad2795988a202bf0be643b1a801","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    sed -i \"s/heat_ceilometer_enabled:.*/heat_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":335,"context_line":"    sed -i \"s/cinder_ceilometer_enabled:.*/cinder_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":336,"context_line":"    sed -i \"s/glance_ceilometer_enabled:.*/glance_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":337,"context_line":"    sed -i \"s/nova_ceilometer_enabled:.*/nova_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":338,"context_line":"  fi"},{"line_number":339,"context_line":"fi"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa1b9901_f65ae082","line":337,"updated":"2015-08-18 14:35:13.000000000","message":"Nitpick, but for consistency I\u0027d either create a loop here to do this as you do with \"for svc in ...\" above, or change the above to be explicit without the loop.","commit_id":"87afbfee728381f7a5a3360d801abb5e20897f80"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0a128ac0e503393905aaf0ed322643299aed5335","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    sed -i \"s/heat_ceilometer_enabled:.*/heat_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":335,"context_line":"    sed -i \"s/cinder_ceilometer_enabled:.*/cinder_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":336,"context_line":"    sed -i \"s/glance_ceilometer_enabled:.*/glance_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":337,"context_line":"    sed -i \"s/nova_ceilometer_enabled:.*/nova_ceilometer_enabled: True/\" /etc/openstack_deploy/user_variables.yml"},{"line_number":338,"context_line":"  fi"},{"line_number":339,"context_line":"fi"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa1b9901_a8de200f","line":337,"in_reply_to":"fa1b9901_f65ae082","updated":"2015-08-19 08:00:04.000000000","message":"Good call. Done.","commit_id":"87afbfee728381f7a5a3360d801abb5e20897f80"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"01286a7385952075d8a3a55b42d64dabdd0607ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DEFAULT_PASSWORD\u003d$(tr -dc \u0027a-zA-Z0-9\u0027 \u003c /dev/urandom | head -c 32)"},{"line_number":23,"context_line":"export ADMIN_PASSWORD\u003d${ADMIN_PASSWORD:-$DEFAULT_PASSWORD}"},{"line_number":24,"context_line":"export SERVICE_REGION\u003d${SERVICE_REGION:-\"RegionOne\"}"},{"line_number":25,"context_line":"export BOOTSTRAP_AIO\u003d${BOOTSTRAP_AIO:-\"yes\"}"},{"line_number":26,"context_line":"export DEPLOY_OPENSTACK\u003d${DEPLOY_OPENSTACK:-\"yes\"}"},{"line_number":27,"context_line":"export DEPLOY_SWIFT\u003d${DEPLOY_SWIFT:-\"yes\"}"},{"line_number":28,"context_line":"export DEPLOY_CEILOMETER\u003d${DEPLOY_CEILOMETER:-\"yes\"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"fa1b9901_2879b0c8","line":25,"updated":"2015-08-19 08:07:52.000000000","message":"I wonder if this should always be \"yes\", considering we\u0027re running in the AIO itself here.","commit_id":"46ed134ea886f4929309dbe3560cd9f4db5d588d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e98d7e5f3ca83252000bf1e1a934007243b599d9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"DEFAULT_PASSWORD\u003d$(tr -dc \u0027a-zA-Z0-9\u0027 \u003c /dev/urandom | head -c 32)"},{"line_number":23,"context_line":"export ADMIN_PASSWORD\u003d${ADMIN_PASSWORD:-$DEFAULT_PASSWORD}"},{"line_number":24,"context_line":"export SERVICE_REGION\u003d${SERVICE_REGION:-\"RegionOne\"}"},{"line_number":25,"context_line":"export BOOTSTRAP_AIO\u003d${BOOTSTRAP_AIO:-\"yes\"}"},{"line_number":26,"context_line":"export DEPLOY_OPENSTACK\u003d${DEPLOY_OPENSTACK:-\"yes\"}"},{"line_number":27,"context_line":"export DEPLOY_SWIFT\u003d${DEPLOY_SWIFT:-\"yes\"}"},{"line_number":28,"context_line":"export DEPLOY_CEILOMETER\u003d${DEPLOY_CEILOMETER:-\"yes\"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"fa1b9901_1b43d843","line":25,"in_reply_to":"fa1b9901_2879b0c8","updated":"2015-08-19 08:12:12.000000000","message":"So this provides you the ability to override the behaviour - I\u0027m thinking that this script may end up being used in multi-node builds for host preparation or whatever. I\u0027m happy to revert this if you feel that it really is out of place.","commit_id":"46ed134ea886f4929309dbe3560cd9f4db5d588d"}]}