)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aac2f52335a7e80748d1797bebf264d02be9012","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable HAProxy Stats Web UI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable HAProxy Stats Web UI"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This patch enables the HAProxy webstats for all the configures backends"},{"line_number":12,"context_line":"and frontends."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_975457fe","line":9,"updated":"2015-08-20 10:24:07.000000000","message":"This extra line can be removed.","commit_id":"f53404825e67c96e3c3b9cbc8e445eaf914f158a"}],"etc/openstack_deploy/user_variables.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5ac6218beac323c694933d83c327408988320130","unresolved":false,"context_lines":[{"line_number":136,"context_line":"#   - { url: \"{{ keystone_service_internalurl }}\", name: \"{{ keystone_service_region }}\" }"},{"line_number":137,"context_line":"#   - { url: \"http://cluster1.example.com:5000/v2.0\", name: \"RegionTwo\" }"},{"line_number":138,"context_line":"#HAProxy"},{"line_number":139,"context_line":"haproxy_stats_enabled: False "},{"line_number":140,"context_line":"haproxy_stats_bind_address: 127.0.0.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa1b9901_201f316d","line":139,"updated":"2015-08-20 15:44:44.000000000","message":"this should move into playbooks/roles/haproxy_server/defaults/main.yml","commit_id":"9292ae4f327fce5c03047fe1be8707c89d01708a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5ac6218beac323c694933d83c327408988320130","unresolved":false,"context_lines":[{"line_number":137,"context_line":"#   - { url: \"http://cluster1.example.com:5000/v2.0\", name: \"RegionTwo\" }"},{"line_number":138,"context_line":"#HAProxy"},{"line_number":139,"context_line":"haproxy_stats_enabled: False "},{"line_number":140,"context_line":"haproxy_stats_bind_address: 127.0.0.1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa1b9901_7222e0a4","line":140,"updated":"2015-08-20 15:44:44.000000000","message":"this should move into playbooks/roles/haproxy_server/defaults/main.yml","commit_id":"9292ae4f327fce5c03047fe1be8707c89d01708a"}],"playbooks/roles/haproxy_server/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5ac6218beac323c694933d83c327408988320130","unresolved":false,"context_lines":[{"line_number":45,"context_line":"#haproxy Stats"},{"line_number":46,"context_line":"haproxy_stats_port: 1936"},{"line_number":47,"context_line":"haproxy_username: admin"},{"line_number":48,"context_line":"haproxy_password: \"{{ haproxy_stats_password }}\""},{"line_number":49,"context_line":"# Default haproxy backup nodes to empty list so this doesn\u0027t have to be"},{"line_number":50,"context_line":"# defined for each service."},{"line_number":51,"context_line":"haproxy_backup_nodes: []"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa1b9901_32dc6872","line":48,"updated":"2015-08-20 15:44:44.000000000","message":"Add a default value of something here just in case the user_secrets has not been repopulated.","commit_id":"9292ae4f327fce5c03047fe1be8707c89d01708a"}],"playbooks/roles/haproxy_server/tasks/haproxy_post_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"fdeaea5f5532a86ebe1efeeeea3911f9831ece64","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    src: \"{{ item }}\""},{"line_number":19,"context_line":"    dest: \"/etc/haproxy/haproxy.cfg\""},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - haproxy.j2"},{"line_number":22,"context_line":"  notify: Restart haproxy"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - haproxy-base-config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa1b9901_43436542","line":21,"updated":"2015-08-20 09:04:19.000000000","message":"I\u0027d call it haproxy.cfg.j2, this way we know directly when we are in the templates folder (so without going inside this task) what we are dealing with..\n\nIt\u0027s only cosmetic.","commit_id":"f53404825e67c96e3c3b9cbc8e445eaf914f158a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aac2f52335a7e80748d1797bebf264d02be9012","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    src: \"{{ item }}\""},{"line_number":19,"context_line":"    dest: \"/etc/haproxy/haproxy.cfg\""},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - haproxy.j2"},{"line_number":22,"context_line":"  notify: Restart haproxy"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - haproxy-base-config"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa1b9901_fc37bafc","line":21,"in_reply_to":"fa1b9901_43436542","updated":"2015-08-20 10:24:07.000000000","message":"Agreed.","commit_id":"f53404825e67c96e3c3b9cbc8e445eaf914f158a"}],"playbooks/roles/haproxy_server/templates/haproxy.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aac2f52335a7e80748d1797bebf264d02be9012","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {{ ansible_managed }}"},{"line_number":2,"context_line":"global"},{"line_number":3,"context_line":"        log 127.0.0.1 local0"},{"line_number":4,"context_line":"        log 127.0.0.1 local1 notice"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa1b9901_773983d6","line":1,"updated":"2015-08-20 10:24:07.000000000","message":"Good idea - perhaps add an empty line afterwards - not essential, but just seems cleaner.","commit_id":"f53404825e67c96e3c3b9cbc8e445eaf914f158a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5aac2f52335a7e80748d1797bebf264d02be9012","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        timeout server 50s"},{"line_number":21,"context_line":"        maxconn 4096"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"listen stats :{{ haproxy_stats_port }}"},{"line_number":24,"context_line":"    mode http"},{"line_number":25,"context_line":"    stats enable"},{"line_number":26,"context_line":"    stats hide-version"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"fa1b9901_7712e358","line":23,"updated":"2015-08-20 10:24:07.000000000","message":"As stats may not be something you want to share publically, I think this should also have a bind address - perhaps default it to 127.0.0.1, but ensure that it\u0027s a variable so that it can be overridden. Also, I\u0027d suggest also having a variable called haproxy_stats which is a boolean and defaults to \u0027False\u0027, then wrap this section in a conditional to determine whether it\u0027s True and only to implement this section if it\u0027s True. This allows the deployer to set it if they want it, but doesn\u0027t force anyone to use it.","commit_id":"f53404825e67c96e3c3b9cbc8e445eaf914f158a"}]}