)]}'
{"playbooks/roles/os_neutron/defaults/main.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"950f109baa6e7a02f1bf308eee8eaa7479e54892","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_1d7a17f2","side":"PARENT","line":339,"updated":"2015-11-17 12:19:54.000000000","message":"There is the potential that a deployer may have built there own deployment tool around this role and so there is the possibility that this variable is used by that tooling. Alternatively they may just have overridden it. Based on that, it may make sense to have a deprecating process for variables when they are removed or the data they reference changes.","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"15e06ad0cbc8120bf181f6f37d9bce9b8d5d0d4e","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_fad06455","side":"PARENT","line":339,"in_reply_to":"ba8a016a_1d7a17f2","updated":"2015-11-17 17:35:10.000000000","message":"Yes, I see your point, although within OSA this parameter is only used in the handler task which has been updated to not need this anymore.\n\nIf it makes more sense to leave it in we can do that?","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"0fbc57cafdd16ed463680606175ac6f51e3c3610","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_c09d4367","side":"PARENT","line":339,"in_reply_to":"ba8a016a_27af89e3","updated":"2015-11-18 13:35:25.000000000","message":"Sounds good to me. So we will keep this fix to trunk and liberty branches only?\n\n@git-harry, if the proposal sounds good to you, I\u0027ll proceed.","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1d5a7ac744970f6e7d4151f38965b8653bd57f12","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_27af89e3","side":"PARENT","line":339,"in_reply_to":"ba8a016a_4015de46","updated":"2015-11-18 12:35:11.000000000","message":"An alternative compromise:\nConsidering that most deployers we know about are not yet consuming Liberty and that this was introduced just before the release of Liberty, it may be fair to assume that no-one is overriding this variable.\nHow about we just add the \u0027UpgradeImpact\u0027 tag to the commit message and add a note in the commit message saying that this variable has been removed?","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"c1254e9fb6f395b4be26bf897748b596fa151723","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_4015de46","side":"PARENT","line":339,"in_reply_to":"ba8a016a_623589f5","updated":"2015-11-18 10:19:09.000000000","message":"The issue is that if we were to conditionalize any of the \u0027service_en\u0027 keys for each neutron_service; like you have done for neutron_lbaas; the condition would still evaluate to a string \u0027True\u0027/\u0027False\u0027. And the handler task using neutron_service_names would be incorrect as this filter is limited to parsing for boolean values only. So as it happens now, regardless of whether the neutron_lbaas condition is true or not, the handler always attempts to restart this service. \n\nTo avoid deprecating this parameter, we can just wait for ansible v2, which should provide improved type-casting, and we\u0027ll be able to implement both optimizations?","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"04a05d7ec1fcfa2c4e1593cc6512ddd4ec6fc9bf","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba8a016a_623589f5","side":"PARENT","line":339,"in_reply_to":"ba8a016a_fad06455","updated":"2015-11-18 09:56:04.000000000","message":"Yeah, this is a fair statement. Perhaps the best would be to have the handler use the optimal route as you\u0027ve done it - but to use neutron_service_names if it\u0027s defined?","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"1248f842bff92a2cc8bec9f6cc9a025d7d6bde11","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba8a016a_10afd22a","side":"PARENT","line":339,"updated":"2015-11-19 15:27:54.000000000","message":"I think update map(attribute\u003d\u00270\u0027) to map(attribute\u003d\u00271.service_name\u0027) may look better rather than update handlers/main.yml.","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"613e0558da3a1dee32317c6ad5654ce20a543087","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  - networking-plumgrid"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"## Service Names"},{"line_number":339,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"## Tunable overrides"},{"line_number":342,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba8a016a_1411f803","side":"PARENT","line":339,"in_reply_to":"ba8a016a_10afd22a","updated":"2015-11-19 19:11:15.000000000","message":"Same problem as before, this does not evaluate strings properly.","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"0d65b410fc2bfbe8a5d757794ec5f29a4c0a0ddc","unresolved":false,"context_lines":[{"line_number":335,"context_line":"  - networking-plumgrid"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"## Service Names"},{"line_number":338,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"## Tunable overrides"},{"line_number":341,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba8a016a_f61c3115","side":"PARENT","line":338,"updated":"2015-11-21 03:01:00.000000000","message":"\"{{ neutron_lbaas }}\" variable result in this problem, it alway get the string type.  We may need aohter way to get boolean of neutron_lbaas variable if remains the neutron_service_names.","commit_id":"4d736b98e30f11d5f59072b84ec1cb9a4d5976e3"},{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"8559c11da692265bbbb80b3a94940adda924958b","unresolved":false,"context_lines":[{"line_number":335,"context_line":"  - networking-plumgrid"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"## Service Names"},{"line_number":338,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"## Tunable overrides"},{"line_number":341,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba8a016a_f8c09a7e","side":"PARENT","line":338,"in_reply_to":"ba8a016a_589a06c7","updated":"2015-11-21 14:41:08.000000000","message":"yeah , I agree with you.","commit_id":"4d736b98e30f11d5f59072b84ec1cb9a4d5976e3"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"71eeede14666ada3984d152128744c398d76b8f3","unresolved":false,"context_lines":[{"line_number":335,"context_line":"  - networking-plumgrid"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"## Service Names"},{"line_number":338,"context_line":"neutron_service_names: \"{{ neutron_services.items()|selectattr(\u00271.service_en\u0027)|map(attribute\u003d\u00270\u0027)|list }}\""},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"## Tunable overrides"},{"line_number":341,"context_line":"neutron_neutron_conf_overrides: {}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba8a016a_589a06c7","side":"PARENT","line":338,"in_reply_to":"ba8a016a_f61c3115","updated":"2015-11-21 14:27:44.000000000","message":"XiaBing anything we manage to create will eventually turn into a string once it passes through the jinja parameter quotes. The issue is to either be able to use type casting outside of such parametrization or to be able to create a filter on strings rather than boolean items. This is the only solution for now.","commit_id":"4d736b98e30f11d5f59072b84ec1cb9a4d5976e3"}],"playbooks/roles/os_neutron/handlers/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"718824b2ad51bc473f019c7082c4a6f25ca68b5a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    state: restarted"},{"line_number":20,"context_line":"    pattern: \"{{ item }}\""},{"line_number":21,"context_line":"  with_items: neutron_service_names"},{"line_number":22,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba8a016a_8c8da333","side":"PARENT","line":22,"updated":"2015-11-16 19:12:32.000000000","message":"The current handler may be failing because of the assumption that the various services are on all of the nodes. Previously this was worked around by setting ``failed_when: false``","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"ef9355bad2ecb9de46c8e5a72905c174b081b2fe","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    state: restarted"},{"line_number":20,"context_line":"    pattern: \"{{ item }}\""},{"line_number":21,"context_line":"  with_items: neutron_service_names"},{"line_number":22,"context_line":"  failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba8a016a_4cec9bc7","side":"PARENT","line":22,"in_reply_to":"ba8a016a_8c8da333","updated":"2015-11-16 19:14:08.000000000","message":"Yes just saw as well, its failing on services not present on agent containers. I\u0027ll put this back in.","commit_id":"9e8e4c78e679b674f474929937f8eff8c05bcdc6"}]}