)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"bd558df99a8eb3c527ae80b65a73a5f80202ad9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - statsd_default_sample_rate"},{"line_number":14,"context_line":"  - statsd_sample_rate_factor"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Which can be defined under swift globablly or on the server level."},{"line_number":17,"context_line":"The configuration will only be added if statsd_host is defined."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This is the initial version, let me know if I missed any places, i.e documentation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_aa0cc694","line":16,"updated":"2015-12-05 14:26:02.000000000","message":"s/globablly/globally/","commit_id":"3722b91ce05707a3b68d829ad7419e3807555d82"}],"etc/openstack_deploy/conf.d/swift.yml.example":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"#     Option: statsd_host (optional, string)"},{"line_number":85,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":86,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":87,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":88,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"#     Option: statsd_port (optional, integer, default 8125)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_ff000f03","line":87,"updated":"2015-11-18 19:43:57.000000000","message":"nit: in the cluster","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":86,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":87,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":88,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"#     Option: statsd_port (optional, integer, default 8125)"},{"line_number":91,"context_line":"#     Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_dc14394e","line":88,"updated":"2015-11-18 19:43:57.000000000","message":"nit: want to only","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#     Statsd port, requires statsd_host set."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":94,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":95,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     The following statsd related options are a little more complicated and is"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_5f8b5b68","line":94,"updated":"2015-11-18 19:43:57.000000000","message":"nit: will prepend all metrics\n\nIt is such a bad idea to allow all metrics from all hosts to be lumped together with one prefix that I would suggest removing this option. \n\nThe only(?) valid configuration to avoid that would be to specify something like \"swift\" as the value here, and not specify the statsd_host globally -- rather specify one per host to direct to a local statsd service which itself has a prefix specified in the configuration indicating the host. That is convoluted enough that I think it is fair to just eliminate this option from the doc.","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":95,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     The following statsd related options are a little more complicated and is"},{"line_number":98,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":99,"context_line":"#     settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":100,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_5f503bd4","line":97,"updated":"2015-11-18 19:43:57.000000000","message":"nit: and are used","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":286,"context_line":"#         store Object PUT replicas on up to 6 disks in region 1 assuming"},{"line_number":287,"context_line":"#         replicas is 3, and write_affinity \u003d r1"},{"line_number":288,"context_line":"#"},{"line_number":289,"context_line":"#         Option: statsd_host (optional, string)"},{"line_number":290,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":291,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":292,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_1f3393ac","line":289,"updated":"2015-11-18 19:43:57.000000000","message":"multiple nits repeated, as found above.","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"#"},{"line_number":389,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":390,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":391,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":392,"context_line":"#"},{"line_number":393,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":394,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba8a016a_3ffa1744","line":391,"updated":"2015-11-18 19:43:57.000000000","message":"Remove \"...specified deeper in the configuration...\" unless there is a deeper level.","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"#     Option: statsd_host (optional, string)"},{"line_number":89,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":90,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":91,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":92,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":93,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_485547c4","line":90,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027a cluster\u0027 or \u0027the cluster\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"#"},{"line_number":88,"context_line":"#     Option: statsd_host (optional, string)"},{"line_number":89,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":90,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":91,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":92,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":93,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_65059ec0","line":90,"in_reply_to":"ba8a016a_485547c4","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":90,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":91,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":92,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"#     Option: statsd_port (optional, integer, default 8125)"},{"line_number":95,"context_line":"#     Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_280803d9","line":92,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027to only\u0027 or \u0027only to\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#     Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":90,"context_line":"#     receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":91,"context_line":"#     cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":92,"context_line":"#     want only catch statsd metrics on certain hosts."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"#     Option: statsd_port (optional, integer, default 8125)"},{"line_number":95,"context_line":"#     Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_250f96e2","line":92,"in_reply_to":"ba8a016a_280803d9","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#     Statsd port, requires statsd_host set."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_e8119b05","line":98,"updated":"2015-11-23 06:46:43.000000000","message":"will be prepended to all","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"#     Statsd port, requires statsd_host set."},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_4512da0a","line":98,"in_reply_to":"ba8a016a_e8119b05","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"},{"line_number":102,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_282fa33f","line":99,"updated":"2015-11-23 06:46:43.000000000","message":"be separated","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"},{"line_number":102,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_e5f98ec9","line":99,"in_reply_to":"ba8a016a_282fa33f","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"},{"line_number":102,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":103,"context_line":"#     settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":104,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_88200f4b","line":101,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027are used\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#     Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration different host metrics can we seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and is"},{"line_number":102,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":103,"context_line":"#     settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":104,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_05f5b2c9","line":101,"in_reply_to":"ba8a016a_88200f4b","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":291,"context_line":"#"},{"line_number":292,"context_line":"#         Option: statsd_host (optional, string)"},{"line_number":293,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":294,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":295,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":296,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":297,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_48f1c7cc","line":294,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027the cluster\u0027 or \u0027a cluster\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"#"},{"line_number":292,"context_line":"#         Option: statsd_host (optional, string)"},{"line_number":293,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":294,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":295,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":296,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":297,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_45e09afa","line":294,"in_reply_to":"ba8a016a_48f1c7cc","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":293,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":294,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":295,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":296,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":297,"context_line":"#"},{"line_number":298,"context_line":"#         Option: statsd_port (optional, integer, default 8125)"},{"line_number":299,"context_line":"#         Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_08889f21","line":296,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027to only\u0027 or \u0027only to\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":293,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":294,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":295,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":296,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":297,"context_line":"#"},{"line_number":298,"context_line":"#         Option: statsd_port (optional, integer, default 8125)"},{"line_number":299,"context_line":"#         Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_05e37206","line":296,"in_reply_to":"ba8a016a_08889f21","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":299,"context_line":"#         Statsd port, requires statsd_host set."},{"line_number":300,"context_line":"#"},{"line_number":301,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_a877133a","line":302,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027will be prepended to\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"#         Statsd port, requires statsd_host set."},{"line_number":300,"context_line":"#"},{"line_number":301,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_65ba7ee3","line":302,"in_reply_to":"ba8a016a_a877133a","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":300,"context_line":"#"},{"line_number":301,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":306,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_2892434c","line":303,"updated":"2015-11-23 06:46:43.000000000","message":"Seems like \u0027Different\u0027 should start a new sentence.","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"#"},{"line_number":301,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":306,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_85bd22d9","line":303,"in_reply_to":"ba8a016a_2892434c","updated":"2015-11-24 00:59:03.000000000","message":"Actually this shouldn\u0027t be here cause we are lower in the configuration. Yay copy and paste problems.","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":306,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":307,"context_line":"#         settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":308,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_e8b2fbe4","line":305,"updated":"2015-11-23 06:46:43.000000000","message":"are","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":302,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":303,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":304,"context_line":"#"},{"line_number":305,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":306,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":307,"context_line":"#         settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":308,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_25b476f0","line":305,"in_reply_to":"ba8a016a_e8b2fbe4","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":382,"context_line":"#"},{"line_number":383,"context_line":"#         Option: statsd_host (optional, string)"},{"line_number":384,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":385,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":386,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":387,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":388,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_08ddff13","line":385,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027a cluster\u0027 or \u0027the cluster\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":382,"context_line":"#"},{"line_number":383,"context_line":"#         Option: statsd_host (optional, string)"},{"line_number":384,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":385,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":386,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":387,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":388,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_a54946d2","line":385,"in_reply_to":"ba8a016a_08ddff13","updated":"2015-11-24 00:59:03.000000000","message":"Done","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":384,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":385,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":386,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":387,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":388,"context_line":"#"},{"line_number":389,"context_line":"#         Option: statsd_port (optional, integer, default 8125)"},{"line_number":390,"context_line":"#         Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_c8e617e8","line":387,"updated":"2015-11-23 06:46:43.000000000","message":"\u0027want to only\u0027 or \u0027want only to\u0027","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":384,"context_line":"#         Swift supports statsd metrics, this option sets the statsd host that will"},{"line_number":385,"context_line":"#         receive statsd metrics. Specifying this here will apply to all hosts in"},{"line_number":386,"context_line":"#         cluster. It can be overridden or specified deeper in the structure if you"},{"line_number":387,"context_line":"#         want only catch statsd metrics on certain hosts."},{"line_number":388,"context_line":"#"},{"line_number":389,"context_line":"#         Option: statsd_port (optional, integer, default 8125)"},{"line_number":390,"context_line":"#         Statsd port, requires statsd_host set."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_c5448ab8","line":387,"in_reply_to":"ba8a016a_c8e617e8","updated":"2015-11-24 00:59:03.000000000","message":"Actually this shouldn\u0027t be here cause we are lower in the configuration.","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":391,"context_line":"#"},{"line_number":392,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":393,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":394,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":395,"context_line":"#"},{"line_number":396,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":397,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_48db071c","line":394,"updated":"2015-11-23 06:46:43.000000000","message":"be separated","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b25c62b9bc43b96bf96b18e01dda001a7e488e0f","unresolved":false,"context_lines":[{"line_number":391,"context_line":"#"},{"line_number":392,"context_line":"#         Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":393,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":394,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":395,"context_line":"#"},{"line_number":396,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":397,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_8515229c","line":394,"in_reply_to":"ba8a016a_48db071c","updated":"2015-11-24 00:59:03.000000000","message":"Actually this shouldn\u0027t be here cause we are lower in the configuration.","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"9e388bfc84b9bec6ce2b5f098e74b4e18aa9ee59","unresolved":false,"context_lines":[{"line_number":393,"context_line":"#         Specify a prefix that will prepended all metrics, this should be specified"},{"line_number":394,"context_line":"#         deeper in the configuration different host metrics can we seperated."},{"line_number":395,"context_line":"#"},{"line_number":396,"context_line":"#         The following statsd related options are a little more complicated and is"},{"line_number":397,"context_line":"#         used to tune how many samples are sent to statsd. If you need to tweak these"},{"line_number":398,"context_line":"#         settings then first read: http://docs.openstack.org/developer/swift/admin_guide.html"},{"line_number":399,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba8a016a_08041f7c","line":396,"updated":"2015-11-23 06:46:43.000000000","message":"are used","commit_id":"302fb323925234c09c4b9e38d140523912fdb4a3"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"5b1c0e2e85d59b7c7d803082420197afc7ffc848","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"#     Option: statsd_metric_prefix (optional, string, default ansible_host)"},{"line_number":98,"context_line":"#     Specify a prefix that will be prepended to all metrics, this should be specified"},{"line_number":99,"context_line":"#     deeper in the configuration so different host metrics can be seperated."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"#     The following statsd related options are a little more complicated and are"},{"line_number":102,"context_line":"#     used to tune how many samples are sent to statsd. If you need to tweak these"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba8a016a_c58ecacf","line":99,"updated":"2015-11-24 01:03:23.000000000","message":"separated","commit_id":"2a3f4b1041120b8bad2bc11a0cc1031217cb5ee8"}],"playbooks/roles/os_swift/defaults/main.yml":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"4749a8f1a9cc9538760626145e5aa70bdbb2948f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"swift_service_internaluri: \"{{ swift_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ swift_proxy_port }}\""},{"line_number":97,"context_line":"swift_service_internalurl: \"{{ swift_service_internaluri }}/v1/AUTH_%(tenant_id)s\""},{"line_number":98,"context_line":"swift_service_region: RegionOne"},{"line_number":99,"context_line":"statsd_host:"},{"line_number":100,"context_line":"statsd_port: 8125"},{"line_number":101,"context_line":"statsd_default_sample_rate: 1.0"},{"line_number":102,"context_line":"statsd_sample_rate_factor: 1.0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba8a016a_ff2c8f03","line":99,"updated":"2015-11-18 19:43:57.000000000","message":"our convention (as exercised with passwords and other secrets) is to entirely omit these keys rather than leave them blank. I\u0027m don\u0027t recall anywhere we specify blank keys in role defaults.","commit_id":"bdfeb99a46cd5e7daf9dedc1773c706954d61397"}],"playbooks/roles/os_swift/templates/object-expirer.conf.j2":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"85ade5481d03201d57dc7202064a1c0247eb7312","unresolved":false,"context_lines":[{"line_number":20,"context_line":"log_statsd_sample_rate_factor \u003d {{ statsd_sample_rate_factor }}                                                               "},{"line_number":21,"context_line":"log_statsd_metric_prefix \u003d {{ statsd_metric_prefix | default(inventory_hostname) }}                                           "},{"line_number":22,"context_line":"{% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[object-expirer]"},{"line_number":25,"context_line":"interval \u003d 300"},{"line_number":26,"context_line":"auto_create_account_prefix \u003d ."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a8ffd7b_a1af60e2","line":23,"updated":"2015-11-24 15:13:32.000000000","message":"Lots of whitespace here, also the run failed due to:\n\n2015-11-24 01:51:57,754 p\u003d2840 u\u003droot |  fatal: [aio1] \u003d\u003e file: /home/jenkins/workspace/gate-openstack-ansible-dsvm-commit/playbooks/roles/os_swift/templates/object-expirer.conf.j2, line number: 8, error: expected token \u0027end of statement block\u0027, got \u0027+\u0027","commit_id":"2a3f4b1041120b8bad2bc11a0cc1031217cb5ee8"}],"playbooks/roles/os_swift/templates/object-server.conf.j2":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"89ddaae560978307027e854ac4643328133d54c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"devices \u003d {{ swift_vars.mount_point | default(swift.mount_point) }}"},{"line_number":14,"context_line":"log_facility \u003d LOG_LOCAL4"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if swift_vars.statsd_host is defined %}                                                                                                        {%   set statsd \u003d 1 %}"},{"line_number":17,"context_line":"log_statsd_host \u003d {{ swift_vars.statsd_host | default(statsd_host) }}"},{"line_number":18,"context_line":"{% elif swift.statsd_host is defined %}"},{"line_number":19,"context_line":"{%   set statsd \u003d1 %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a8ffd7b_8436f4e5","line":16,"updated":"2015-11-30 14:43:30.000000000","message":"Actually swift_vars is the same (as my previous comment regarding the swift_proxy_vars), that isn\u0027t a required var, so it will fail if you haven\u0027t specified it - it just so happens I had specified it so missed this change!\nNot gonna comment on this for every conf file but that probably needs to get changed for every conf file.","commit_id":"3722b91ce05707a3b68d829ad7419e3807555d82"}],"playbooks/roles/os_swift/templates/proxy-server.conf.j2":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"daec1d711f72ff48386c8c51fb0a538212d68556","unresolved":false,"context_lines":[{"line_number":11,"context_line":"user \u003d {{ swift_system_user_name }}"},{"line_number":12,"context_line":"log_facility \u003d LOG_LOCAL1"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% if swift_proxy_vars.statsd_host is defined %}"},{"line_number":15,"context_line":"{%   set statsd \u003d 1 %}"},{"line_number":16,"context_line":"log_statsd_host \u003d {{ swift_proxy_vars.statsd_host | default(statsd_host) }}"},{"line_number":17,"context_line":"{% elif swift.statsd_host is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9a8ffd7b_a958b18b","line":14,"updated":"2015-11-30 14:36:45.000000000","message":"We need to put a \"if swift_proxy_vars is defined\" above this.\n\nIts one thing that mildly annoys me about ansible, but it won\u0027t evaluate this if the \"parent\" var doesn\u0027t exist, it will just fail out - which means you either HAVE to have defined swift_proxy_vars (which in a lot of use cases you don\u0027t have to), or we need to add a nested \"if\" statement where we check for swift_proxy_vars first.","commit_id":"3722b91ce05707a3b68d829ad7419e3807555d82"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"6a2bb441b6bc12fdaf8fc94c627a33c2c1e2fd45","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{%     set statsd \u003d 1 %}"},{"line_number":17,"context_line":"log_statsd_host \u003d {{ swift_proxy_vars.statsd_host | default(statsd_host) }}"},{"line_number":18,"context_line":"{%   elif swift.statsd_host is defined %}"},{"line_number":19,"context_line":"{%     set statsd \u003d1 %}"},{"line_number":20,"context_line":"log_statsd_host \u003d {{ swift.statsd_host | default(statsd_host) }}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{%   if statsd is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"fa69d971_3e15059b","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":20},"updated":"2016-01-06 18:56:13.000000000","message":"nit: spacing","commit_id":"e73633b3be48a39ddd6d886640eba51354189632"}]}
