)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"683e09c69bfcdcd07aef2f5993806a0254f880ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow neutron services to move around environment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable neutron services to be moved around the environment by addressing the service groups directly in neutron tasks instead of assuming everything lives on the neutron_agents containers."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I631226d695ae5e916d74be51a126896e45589610"},{"line_number":12,"context_line":"Closes-Bug: #1510202"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_523c1e2f","line":9,"updated":"2015-11-22 04:26:14.000000000","message":"Subsequent lines of git commit message should be wrapped at 72 characters. ref: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"c3932822df9325e134caecfbe328a2b9b917e13d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"753ba01ce88ee1787e1e1417c633a54343f49fc2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow neutron services to move around environment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable neutron services to be moved around the environment by addressing the service groups directly in neutron tasks instead of assuming everything lives on the neutron_agents containers."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I631226d695ae5e916d74be51a126896e45589610"},{"line_number":12,"context_line":"Closes-Bug: #1510202"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_c50927df","line":9,"in_reply_to":"ba8a016a_523c1e2f","updated":"2015-11-22 15:15:55.000000000","message":"+1 for what XiaBing said, this commit message needs to be updated to wrap lines @ 72","commit_id":"c3932822df9325e134caecfbe328a2b9b917e13d"}],"playbooks/roles/os_neutron/tasks/neutron_post_install.yml":[{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"67431cb5d2db237d7ccfab3f2fdeb6329f000645","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba8a016a_6b2fe588","line":102,"updated":"2015-11-23 07:09:26.000000000","message":"I suggested that whether the \"item.key|replace(\u0027-\u0027,\u0027_\u0027)\" is better.","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"42d3257160cdbf04070e1cd0a85b629778dbf278","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_58620018","line":102,"in_reply_to":"7a740942_9987e3d6","updated":"2016-01-18 04:17:04.000000000","message":"Done","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"78a559aef2b59628014f982974141b8cf23954b3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_9987e3d6","line":102,"in_reply_to":"7a740942_f0071c1a","updated":"2015-12-06 12:11:58.000000000","message":"You\u0027re right, the neutron_lbaas_agent group is present in master however I was looking at kilo and it\u0027s not present there. Your approach with using the dict key does indeed make sense and is clean, but it might break for cases such as I just described.\n\nSo this is one of those cases where this service agent does not have a container group defined and it will use groups[\u0027neutron_agents_container\u0027] or groups[\u0027neutron_agent\u0027]. The intent for \u0027service_group\u0027 is the same, basically where it is used in neutron_upstart_init.yml,  we should be able to reference the service group through its items rather than explicit definition  in the task.\n\nSo coming back to my original suggestion, since the service_group is already defined, you should use this item instead, and also update them all in the dict to appropriate values for each service that has a container group defined already and leave the remaining to \u0027neutron_agent\u0027.","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"1e0db2c6207b2f7ba154c89935e19e66ff7c00d1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba8a016a_a0c958ae","line":102,"in_reply_to":"ba8a016a_17ee768b","updated":"2015-11-23 13:20:43.000000000","message":"I agree with you","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6b526f24a04c6f7e306024f98e43cebbe6bdc071","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba8a016a_8f8ecece","line":102,"in_reply_to":"ba8a016a_17ee768b","updated":"2015-11-23 10:24:19.000000000","message":"I think Javeria\u0027s suggestion is a great idea.","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"4b2af27a0f6559549139d429f2cb492e6c36f29f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_f0071c1a","line":102,"in_reply_to":"ba8a016a_17ee768b","updated":"2015-12-06 06:08:29.000000000","message":"XiaBing Yao: Sure. Makes sense.\n\nJaveria: \nRegarding neutron_lbaas_agent, I see it under neutron_services in defaults/main.yml at line 137. \n\nRegarding a container group not existing, if that is what you are saying I do not follow. Looking at env.d/neutron.yml a neutron_lbaas_agent group is created the same as all the other service groups.\n\nI also am not sure about adding a \u0027group:\u0027 to the neutron_services items. There is already a \u0027service_group:\u0027 in the dict that is not referenced anywhere I can see. I am not sure what the intent is for that field, or if it will be used at some point, but having \u0027group:\u0027 and \u0027service_group:\u0027 seems a little confusing to me. Especially weighing that against the key name or \u0027service_name\u0027 fields which already do what we want. Is there some case where the group names in env.d might not match the dict keys or \u0027service_name\u0027?\n\nMy opinion is that changing this to use neutron_services dict key probably makes the most sense. There are already examples of env.d groups being used to key against neutron_services dict keys in this role, such as all of the references to neutron-server in various tasks.","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"},{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"e65ee787a33a760bc497427d50f3e7009c97c39a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"       - item.value.service_en | bool"},{"line_number":101,"context_line":"       - item.value.service_conf is defined"},{"line_number":102,"context_line":"       - inventory_hostname in \"{{ groups[ item.value.service_name|replace(\u0027-\u0027, \u0027_\u0027) ]}}\""},{"line_number":103,"context_line":"  tags:"},{"line_number":104,"context_line":"    - neutron-config"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba8a016a_17ee768b","line":102,"in_reply_to":"ba8a016a_6b2fe588","updated":"2015-11-23 09:29:30.000000000","message":"While XiaBing\u0027s suggestion is a cleaner/shorter option otherwise. As far as I can tell, I do not see a neutron_lbaas_agent group, so this might not be the best solution. \n\nIn view of the goal of this commit, I suggest adding a \u0027group:\u0027 item to each service defined under the neutron_services dictionary. This task or any other then can just continue iterating by referencing that value to determine what group that host lives in.","commit_id":"3eb9f14baca71748406d5c2d0e5eaa5e8b40f96e"}],"playbooks/roles/os_neutron/tasks/neutron_upstart_init.yml":[{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"f89a61dcb61d38f4202833890355b6597379ab6f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    system_group: \"{{ neutron_system_group_name }}\""},{"line_number":37,"context_line":"    service_home: \"{{ neutron_system_home_folder }}\""},{"line_number":38,"context_line":"  when:"},{"line_number":39,"context_line":"    - inventory_hostname in groups[\u0027neutron_dhcp_agent\u0027]"},{"line_number":40,"context_line":"    - neutron_services[\u0027neutron-dhcp-agent\u0027].service_en | bool"},{"line_number":41,"context_line":"  tags:"},{"line_number":42,"context_line":"    - upstart-init"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_00b718f6","line":39,"updated":"2016-01-18 13:36:48.000000000","message":"I think all of these should probably reference the new groups parameter in neutron_services... ie\n- inventory_hostname in groups[neutron_services[\u0027neutron-dhcp-agent\u0027].group]","commit_id":"5aa9934412d4157073f56525992411325cf0a05a"}]}