)]}'
{"playbooks/roles/os_neutron/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6a80f273210a53cc081c46f7c5fbcf93e5f5e9b5","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# Enable or disable L2 Population. This is set to true because under most cases"},{"line_number":246,"context_line":"#  this will need to be enabled for neutron to function. However it should be"},{"line_number":247,"context_line":"#  noted that the in tree neutron L3HA will automatically be disabled."},{"line_number":248,"context_line":"neutron_l2_population: \"True\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Set this to configure overlay networks. The default is set as an empty hash."},{"line_number":251,"context_line":"# neutron_overlay_network:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a8ffd7b_24e8fa7b","line":248,"updated":"2015-12-02 08:07:31.000000000","message":"This negates the work done in https://review.openstack.org/233389 - if this is to be implemented, then that logic should be removed.","commit_id":"950c773f98a8ae3e8cbbec1631cc442d2167a25a"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5736f5d8c14f569d493c365009676355df5f3bec","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# Enable or disable L2 Population. This is set to true because under most cases"},{"line_number":246,"context_line":"#  this will need to be enabled for neutron to function. However it should be"},{"line_number":247,"context_line":"#  noted that the in tree neutron L3HA will automatically be disabled."},{"line_number":248,"context_line":"neutron_l2_population: \"True\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Set this to configure overlay networks. The default is set as an empty hash."},{"line_number":251,"context_line":"# neutron_overlay_network:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a8ffd7b_0f05a178","line":248,"in_reply_to":"9a8ffd7b_04bcad04","updated":"2015-12-02 20:37:02.000000000","message":"It would seem from discussions in IRC that l2pop should be enabled by default, and l3ha should only be enabled by default when the number of agents \u003e 1. Both values need to be in the hands of the deployer so that l2pop can be disabled in special circumstances.","commit_id":"950c773f98a8ae3e8cbbec1631cc442d2167a25a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8439694def04b07715c4ec911b24efc61b023712","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# Enable or disable L2 Population. This is set to true because under most cases"},{"line_number":246,"context_line":"#  this will need to be enabled for neutron to function. However it should be"},{"line_number":247,"context_line":"#  noted that the in tree neutron L3HA will automatically be disabled."},{"line_number":248,"context_line":"neutron_l2_population: \"True\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Set this to configure overlay networks. The default is set as an empty hash."},{"line_number":251,"context_line":"# neutron_overlay_network:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a8ffd7b_8edbca7b","line":248,"in_reply_to":"9a8ffd7b_0f05a178","updated":"2015-12-03 00:31:56.000000000","message":"Done","commit_id":"950c773f98a8ae3e8cbbec1631cc442d2167a25a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"595cbc2bcf800e43858291e29591b869c243fc3c","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# Enable or disable L2 Population. This is set to true because under most cases"},{"line_number":246,"context_line":"#  this will need to be enabled for neutron to function. However it should be"},{"line_number":247,"context_line":"#  noted that the in tree neutron L3HA will automatically be disabled."},{"line_number":248,"context_line":"neutron_l2_population: \"True\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Set this to configure overlay networks. The default is set as an empty hash."},{"line_number":251,"context_line":"# neutron_overlay_network:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a8ffd7b_04bcad04","line":248,"in_reply_to":"9a8ffd7b_24e8fa7b","updated":"2015-12-02 18:44:43.000000000","message":"I can buy in that the logic here \"https://review.openstack.org/#/c/233389/7/playbooks/roles/os_neutron/tasks/neutron_post_install.yml\" could be removed however everything else needs to stay. If l2 population is enabled l3ha needs to be disabled by default..","commit_id":"950c773f98a8ae3e8cbbec1631cc442d2167a25a"}],"playbooks/roles/os_neutron/tasks/neutron_post_install.yml":[{"author":{"_account_id":15526,"name":"Javeria Khan","email":"javeria.ak@gmail.com","username":"JaveriaK"},"change_message_id":"eac7d6c1e99a97468814e3624a75d0c6b62f711b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Enable L2 population support"},{"line_number":28,"context_line":"  set_fact:"},{"line_number":29,"context_line":"    neutron_l2_population: \"True\""},{"line_number":30,"context_line":"  when:"},{"line_number":31,"context_line":"    - neutron_plugin_type \u003d\u003d \u0027ml2\u0027"},{"line_number":32,"context_line":"    - neutron_l2_population is undefined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a740942_b0dc4de5","side":"PARENT","line":29,"updated":"2015-12-04 17:50:03.000000000","message":"Change look good otherwise.\n\nBut I\u0027m probably not seeing something here, wont the previous task always get overwritten by this one? i.e. neutron_l2_population wont stay False, since a subset of the conditions is being checked for again.","commit_id":"a2bd70e8bc64d8aad4f999afcb9a8c2823a33e8a"}]}