)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"60a4b330534fafb440e8775e1e347c135d990525","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"A example configuration can be"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"glance_default_store \u003d rbd"},{"line_number":17,"context_line":"glance_available_stores: [ \u0027swift\u0027, \u0027http\u0027, \u0027cinder\u0027 ]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"to maintain glance images over RBD and Swift/HTTP."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_07418839","line":16,"updated":"2015-12-09 23:49:37.000000000","message":"Should be \n\n    glance_default_store: rbd","commit_id":"b3a98d328eb4cb09923811db6d16ae186f838509"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"111c7df7735db027b0b9ca05c559c5c7935f81ca","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DocImpact"},{"line_number":24,"context_line":"Closes-Bug: #1524544"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2517fd5170bc67460fe3f66e0a0215af390343bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_5cdc4618","line":25,"updated":"2015-12-10 01:03:42.000000000","message":"Total Nit: remove the blank line in the commit message.","commit_id":"b3a98d328eb4cb09923811db6d16ae186f838509"}],"playbooks/roles/os_glance/defaults/main.yml":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"60a4b330534fafb440e8775e1e347c135d990525","unresolved":false,"context_lines":[{"line_number":55,"context_line":"glance_registry_host: \"{{ internal_lb_vip_address }}\""},{"line_number":56,"context_line":"glance_rpc_backend: glance.openstack.common.rpc.impl_kombu"},{"line_number":57,"context_line":"glance_default_store: file"},{"line_number":58,"context_line":"glance_available_stores: [ \u0027http\u0027, \u0027cinder\u0027 ]"},{"line_number":59,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""},{"line_number":60,"context_line":"glance_show_image_direct_url: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_e730fcea","line":58,"updated":"2015-12-09 23:49:37.000000000","message":"Might be better to us the syntax other places use, e.g.,\n\n    glance_available_stores:\n    - http\n    - cinder","commit_id":"b3a98d328eb4cb09923811db6d16ae186f838509"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"111c7df7735db027b0b9ca05c559c5c7935f81ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":"glance_registry_host: \"{{ internal_lb_vip_address }}\""},{"line_number":56,"context_line":"glance_rpc_backend: glance.openstack.common.rpc.impl_kombu"},{"line_number":57,"context_line":"glance_default_store: file"},{"line_number":58,"context_line":"glance_available_stores: [ \u0027http\u0027, \u0027cinder\u0027 ]"},{"line_number":59,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""},{"line_number":60,"context_line":"glance_show_image_direct_url: \"{{ glance_default_store \u003d\u003d \u0027rbd\u0027 }}\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_dcc9165c","line":58,"in_reply_to":"7a740942_e730fcea","updated":"2015-12-10 01:03:42.000000000","message":"+1 to using the long way yaml syntax.","commit_id":"b3a98d328eb4cb09923811db6d16ae186f838509"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a2f5cb743ff303c67fba57a4efa47b6fc8e8b1a4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"glance_registry_host: \"{{ internal_lb_vip_address }}\""},{"line_number":56,"context_line":"glance_rpc_backend: glance.openstack.common.rpc.impl_kombu"},{"line_number":57,"context_line":"glance_default_store: file"},{"line_number":58,"context_line":"glance_available_stores:"},{"line_number":59,"context_line":"  - http"},{"line_number":60,"context_line":"  - cinder"},{"line_number":61,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a740942_af9abfc3","line":58,"updated":"2015-12-10 07:32:33.000000000","message":"I\u0027m not sure I like the variable name, maybe glance_additional_stores since it is not supposed to contain the default store in this usage.\n\nIf you retain this name, only prepend the default store over on the template file if it isn\u0027t already in the available stores.\n\nEither of these might make the proper usage more obvious.","commit_id":"0ed48dda866959ea1153f5e768fadcd378cf0d47"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6032f5587d35d00451662769ad2bebf880e94db6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"glance_registry_host: \"{{ internal_lb_vip_address }}\""},{"line_number":56,"context_line":"glance_rpc_backend: glance.openstack.common.rpc.impl_kombu"},{"line_number":57,"context_line":"glance_default_store: file"},{"line_number":58,"context_line":"glance_available_stores:"},{"line_number":59,"context_line":"  - http"},{"line_number":60,"context_line":"  - cinder"},{"line_number":61,"context_line":"glance_flavor: \"{% if glance_default_store \u003d\u003d \u0027rbd\u0027 %}keystone{% else %}keystone+cachemanagement{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a740942_0cd196fb","line":58,"in_reply_to":"7a740942_af9abfc3","updated":"2015-12-10 10:51:05.000000000","message":"+1 to Steve\u0027s comment","commit_id":"0ed48dda866959ea1153f5e768fadcd378cf0d47"}],"playbooks/roles/os_glance/templates/glance-api.conf.j2":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a2f5cb743ff303c67fba57a4efa47b6fc8e8b1a4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"default_store \u003d {{ glance_default_store }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% if glance_default_store \u003d\u003d \"file\" %}"},{"line_number":97,"context_line":"  {% set glance_available_stores \u003d  [\u0027file\u0027] + glance_available_stores %}"},{"line_number":98,"context_line":"filesystem_store_datadir \u003d {{ glance_system_user_home }}/images/"},{"line_number":99,"context_line":"{% elif glance_default_store \u003d\u003d \"swift\" %}"},{"line_number":100,"context_line":"  {% set glance_available_stores \u003d  [\u0027swift\u0027] + glance_available_stores %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7a740942_afe87f17","line":97,"updated":"2015-12-10 07:32:33.000000000","message":"I think you could just \n\n{% set glance_available_stores \u003d  [\u0027{{ glance_default_store }}\u0027] + glance_available_stores %}\n\nand drop the conditionals to make this simpler.","commit_id":"0ed48dda866959ea1153f5e768fadcd378cf0d47"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"23059ac07c303ccd71024373cb980c11070b6cf6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"[glance_store]"},{"line_number":94,"context_line":"default_store \u003d {{ glance_default_store }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% if glance_default_store \u003d\u003d \"file\" %}"},{"line_number":97,"context_line":"  {% set glance_additional_stores \u003d  [\u0027file\u0027] + glance_additional_stores %}"},{"line_number":98,"context_line":"filesystem_store_datadir \u003d {{ glance_system_user_home }}/images/"},{"line_number":99,"context_line":"{% elif glance_default_store \u003d\u003d \"swift\" %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a740942_d221d9fd","line":96,"updated":"2015-12-10 15:00:24.000000000","message":"I\u0027m not sure if this logic makes sense any more, especially considering the bug details.\n\nIt strikes me that we should build the additional stores based on what we know about the environment.\n\nie a Default should be set and should be part of the store list, then if we\u0027ve installed swift it should be added to the list and if we\u0027ve configured an rbd store too, then it should be added. The file, cinder, http stores should perhaps just be part of the default if that\u0027s applicable - whereas the others should be added if we\u0027ve done other configuration for them.\n\nI\u0027m not sure if this makes more sense than the logic here? ;)","commit_id":"a6d88fa40ea9c2e1dee6cf11446cdbea9cdacf42"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"3719dd325f76d0dd886aec91222a3deed839e604","unresolved":false,"context_lines":[{"line_number":93,"context_line":"[glance_store]"},{"line_number":94,"context_line":"default_store \u003d {{ glance_default_store }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% if glance_default_store \u003d\u003d \"file\" %}"},{"line_number":97,"context_line":"  {% set glance_additional_stores \u003d  [\u0027file\u0027] + glance_additional_stores %}"},{"line_number":98,"context_line":"filesystem_store_datadir \u003d {{ glance_system_user_home }}/images/"},{"line_number":99,"context_line":"{% elif glance_default_store \u003d\u003d \"swift\" %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a740942_9b7286e2","line":96,"in_reply_to":"7a740942_97aa6084","updated":"2015-12-10 17:14:54.000000000","message":"The way this is written right now, filesystem_store_datadir will never be configured unless it is the default store. That would probabably have been resolved if my recommendation from PS2 was used, but I note it here because it requires a fix.\n\nI\u0027d accept the looping technique discussed here but make sure the logic gets fixed up.","commit_id":"a6d88fa40ea9c2e1dee6cf11446cdbea9cdacf42"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"ea9b6adaa0ab96ee44debcfa2fab2a1367ca8e97","unresolved":false,"context_lines":[{"line_number":93,"context_line":"[glance_store]"},{"line_number":94,"context_line":"default_store \u003d {{ glance_default_store }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% if glance_default_store \u003d\u003d \"file\" %}"},{"line_number":97,"context_line":"  {% set glance_additional_stores \u003d  [\u0027file\u0027] + glance_additional_stores %}"},{"line_number":98,"context_line":"filesystem_store_datadir \u003d {{ glance_system_user_home }}/images/"},{"line_number":99,"context_line":"{% elif glance_default_store \u003d\u003d \"swift\" %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a740942_97aa6084","line":96,"in_reply_to":"7a740942_d221d9fd","updated":"2015-12-10 16:10:02.000000000","message":"You are still forced to setup a default store inside glance, regardless of how many store you actually want to have available. I\u0027m not sure if we can assume that the first store from the glance_additional_stores would be the  default store as well.\nThat would make the coding part pretty easy and we just need loop rather than the conditionals in place.","commit_id":"a6d88fa40ea9c2e1dee6cf11446cdbea9cdacf42"}]}
