)]}'
{"playbooks/openstack-hosts-setup.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cb3c23f5dea659f7915c390b7b6afc6f92ed2e92","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - { role: \"openstack_hosts\", tags: [ \"openstack-hosts-setup\" ] }"},{"line_number":22,"context_line":"    - { role: \"openstack-ansible-security\", when: apply_security_hardening | bool }"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_daa844de","line":22,"updated":"2016-01-26 11:43:09.000000000","message":"Does it make sense to test this so early on?  A bunch of things may touch the host later on (especially when you\u0027re talking about nova, cinder, swift, etc.) and none of those interactions are going to be validated by this role.","commit_id":"8e51d6f97152e8ab41d48e7f8e0d75bc73b7ddca"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"b08676a6ab7e2ce3d68a93667021012224c178da","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - { role: \"openstack_hosts\", tags: [ \"openstack-hosts-setup\" ] }"},{"line_number":22,"context_line":"    - { role: \"openstack-ansible-security\", when: apply_security_hardening | bool }"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a68dd71_adc67747","line":22,"in_reply_to":"9a68dd71_daa844de","updated":"2016-01-26 13:29:19.000000000","message":"By applying the role here, it ensures that all of the security enhancements are in place early on. If the role causes problems with the deployment, we should see some of that in the tempest tests or other playbooks.","commit_id":"8e51d6f97152e8ab41d48e7f8e0d75bc73b7ddca"}],"scripts/run-playbooks.sh":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"1b52d9dbe0c85cb44161cc451c9f86161c8a4e6c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"DEPLOY_TEMPEST\u003d${DEPLOY_TEMPEST:-\"yes\"}"},{"line_number":29,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":30,"context_line":"ADD_NEUTRON_AGENT_CHECKSUM_RULE\u003d${ADD_NEUTRON_AGENT_CHECKSUM_RULE:-\"yes\"}"},{"line_number":31,"context_line":"APPLY_SECURITY_HARDENING\u003d${APPLY_SECURITY_HARDENING:-\u0027no\u0027}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Functions -----------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba63e191_92515965","line":31,"range":{"start_line":31,"start_character":51,"end_line":31,"end_character":54},"updated":"2016-01-18 19:57:34.000000000","message":"Should this be double quoted for consistency with other assignments? And are we preferring the :- bash substitution rather than the :\u003d assignment?","commit_id":"39739c6a6b288b94cd5e976c35aac9db4fb94fc1"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"4fbe57fa11b2dbacc1d747b0f8c1bf02255c11b2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"DEPLOY_TEMPEST\u003d${DEPLOY_TEMPEST:-\"yes\"}"},{"line_number":29,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":30,"context_line":"ADD_NEUTRON_AGENT_CHECKSUM_RULE\u003d${ADD_NEUTRON_AGENT_CHECKSUM_RULE:-\"yes\"}"},{"line_number":31,"context_line":"APPLY_SECURITY_HARDENING\u003d${APPLY_SECURITY_HARDENING:-\u0027no\u0027}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Functions -----------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba63e191_45eebded","line":31,"in_reply_to":"ba63e191_92515965","updated":"2016-01-18 20:12:55.000000000","message":"Good call on the double quotes. I was keeping the :- to maintain consistency with the previous lines.","commit_id":"39739c6a6b288b94cd5e976c35aac9db4fb94fc1"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cb3c23f5dea659f7915c390b7b6afc6f92ed2e92","unresolved":false,"context_lines":[{"line_number":28,"context_line":"DEPLOY_TEMPEST\u003d${DEPLOY_TEMPEST:-\"yes\"}"},{"line_number":29,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":30,"context_line":"ADD_NEUTRON_AGENT_CHECKSUM_RULE\u003d${ADD_NEUTRON_AGENT_CHECKSUM_RULE:-\"yes\"}"},{"line_number":31,"context_line":"APPLY_SECURITY_HARDENING\u003d${APPLY_SECURITY_HARDENING:-\u0027no\u0027}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Functions -----------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9a68dd71_9f215eb7","line":31,"updated":"2016-01-26 11:43:09.000000000","message":"Hi Major, is this used anywhere else?","commit_id":"8e51d6f97152e8ab41d48e7f8e0d75bc73b7ddca"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"b08676a6ab7e2ce3d68a93667021012224c178da","unresolved":false,"context_lines":[{"line_number":28,"context_line":"DEPLOY_TEMPEST\u003d${DEPLOY_TEMPEST:-\"yes\"}"},{"line_number":29,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":30,"context_line":"ADD_NEUTRON_AGENT_CHECKSUM_RULE\u003d${ADD_NEUTRON_AGENT_CHECKSUM_RULE:-\"yes\"}"},{"line_number":31,"context_line":"APPLY_SECURITY_HARDENING\u003d${APPLY_SECURITY_HARDENING:-\u0027no\u0027}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## Functions -----------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9a68dd71_6d72bf4b","line":31,"in_reply_to":"9a68dd71_9f215eb7","updated":"2016-01-26 13:29:19.000000000","message":"Oof, that should have been removed. Good catch.","commit_id":"8e51d6f97152e8ab41d48e7f8e0d75bc73b7ddca"}]}