)]}'
{"playbooks/roles/os_horizon/tasks/horizon_pre_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f42749c42e8fe119539dc1b08725107595f371ee","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    url: \"{{ horizon_venv_download_url }}\""},{"line_number":77,"context_line":"    dest: \"/var/cache/{{ horizon_venv_download_url | basename }}\""},{"line_number":78,"context_line":"  ignore_errors: true"},{"line_number":79,"context_line":"  register: get_venv"},{"line_number":80,"context_line":"  when: horizon_venv_enabled | bool"},{"line_number":81,"context_line":"  tags:"},{"line_number":82,"context_line":"    - horizon-install"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da6ed579_babe2263","side":"PARENT","line":79,"updated":"2016-01-14 10:44:52.000000000","message":"shouldn\u0027t this be horizon_get_venv ?","commit_id":"4cd89d3f5cef9ad0848969777ae3bf3a748cb7b7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f42749c42e8fe119539dc1b08725107595f371ee","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  when:"},{"line_number":107,"context_line":"    - horizon_venv_enabled | bool"},{"line_number":108,"context_line":"    - (local_venv_stat.stat.exists \u003d\u003d False or"},{"line_number":109,"context_line":"        {{ local_venv_stat.stat.checksum is defined and local_venv_stat.stat.checksum !\u003d remote_venv_checksum.content | trim }})"},{"line_number":110,"context_line":"  tags:"},{"line_number":111,"context_line":"    - horizon-install"},{"line_number":112,"context_line":"    - horizon-pip-packages"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da6ed579_7acf4a29","line":109,"updated":"2016-01-14 10:44:52.000000000","message":"I\u0027d be far more confident/it\u0027s more readable if the brackets were placed differently: \nwhen (not exists or (defined and different))","commit_id":"45350fae02cb756042ae2c5e279cca7dcfc5bc96"}],"playbooks/roles/repo_build/tasks/repo_venv_build.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c6d1b73bea15bdee925132056bd4f7845ca2d6e6","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: Create venv archive checksum"},{"line_number":84,"context_line":"  shell: \u003e"},{"line_number":85,"context_line":"    sha1sum \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.tgz\" | awk \u0027{print $1}\u0027 \u003e \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""},{"line_number":86,"context_line":"  args:"},{"line_number":87,"context_line":"    chdir: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}\""},{"line_number":88,"context_line":"    creates: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}/{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_52ee2fb5","line":85,"updated":"2016-01-13 11:30:42.000000000","message":"Would it not be possible to rather to sha256sum here? If you do, then the validation is much simpler as the sha256sum value can be used directly in the get_url module instead of doing the localised checksum.","commit_id":"b272566d7b25453245de87e9b4ccfcd06bbbfa07"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"5541dfc5beccc75c3b62832b3329a07e20e13aae","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: Create venv archive checksum"},{"line_number":84,"context_line":"  shell: \u003e"},{"line_number":85,"context_line":"    sha1sum \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.tgz\" | awk \u0027{print $1}\u0027 \u003e \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""},{"line_number":86,"context_line":"  args:"},{"line_number":87,"context_line":"    chdir: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}\""},{"line_number":88,"context_line":"    creates: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}/{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_cd711eaa","line":85,"in_reply_to":"da6ed579_52ee2fb5","updated":"2016-01-13 11:37:16.000000000","message":"The reason why I use sha1sum here is because the stat module (used to obtain the checksum of the cached file) uses sha1. \n\nWe cannot use get_url\u0027s sha256sum option because that would result in downloading the venv to calculate the checksum, which is precisely what we\u0027re trying to avoid.","commit_id":"b272566d7b25453245de87e9b4ccfcd06bbbfa07"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"649253c57c9c19e0e277e4bcdc3a0671ab472915","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: Create venv archive checksum"},{"line_number":84,"context_line":"  shell: \u003e"},{"line_number":85,"context_line":"    sha1sum \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.tgz\" | awk \u0027{print $1}\u0027 \u003e \"{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""},{"line_number":86,"context_line":"  args:"},{"line_number":87,"context_line":"    chdir: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}\""},{"line_number":88,"context_line":"    creates: \"{{ repo_build_venv_dir }}/{{ repo_build_release_tag }}/{{ ansible_distribution | lower }}/{{ item.key | replace(\u0027os_\u0027, \u0027\u0027) }}-{{ repo_build_release_tag }}.checksum\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_b02c4203","line":85,"in_reply_to":"da6ed579_cd711eaa","updated":"2016-01-13 12:43:49.000000000","message":"Agreed, I\u0027ve confirmed that get_url will never do the sha256sum check unless force \u003d true, which defeats the object of what I was hoping to achieve. ie I\u0027m doing a fresh review.","commit_id":"b272566d7b25453245de87e9b4ccfcd06bbbfa07"}]}