)]}'
{"id":"openstack%2Fopenstack-ansible~265325","triplet_id":"openstack%2Fopenstack-ansible~master~I63deb23629b306f4e2aca0e359edc2007c419727","project":"openstack/openstack-ansible","branch":"master","topic":"glance_policy_updates","hashtags":[],"change_id":"I63deb23629b306f4e2aca0e359edc2007c419727","subject":"Add security improvement to glance\u0027s default policy","status":"ABANDONED","created":"2016-01-08 15:56:04.000000000","updated":"2016-01-29 08:29:06.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0eeff0cebc06aa2a771e15a9bbf2a8e8219438d8","_number":265325,"virtual_id_number":265325,"owner":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":-1,"date":"2016-01-08 20:23:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-08 16:11:23.000000000","updated_by":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"reviewer":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"state":"REVIEWER"},{"updated":"2016-01-08 20:23:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bf7721d934010d56a4d0db4cec9c7c46a00a61da","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-08 15:56:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"914877d5c87deb79963a826c3d67a41f5ea4f688","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-08 16:04:36.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"637e243b407b81950c64e02e6ed7a8d7e51211c6","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-08 16:05:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"facc0ba946fa08d0f0066b23474919df88d26dcc","author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"date":"2016-01-08 16:11:23.000000000","message":"Patch Set 2:\n\nI\u0027d rather let that to the deployer.\n\nDoing that assumes you\u0027re the holder of a sane default (whether its for glance or others), while upstream has another sane default (no overrides). \n\nMy question is, why do you want to provide defaults and force you to keep up with these updates? \nIsn\u0027t it better to document this somewhere or change the upstream?","accounts_in_message":[],"_revision_number":2},{"id":"e507caf2a0de048e130f4de80ff3adf9ab3b8527","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 18:12:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-docs http://docs-draft.openstack.org/25/265325/2/check/gate-openstack-ansible-docs/0845b50//doc/build/html/ : SUCCESS in 1m 23s\n- gate-openstack-ansible-lint http://logs.openstack.org/25/265325/2/check/gate-openstack-ansible-lint/5c805fd/ : SUCCESS in 2m 42s\n- gate-openstack-ansible-pep8 http://logs.openstack.org/25/265325/2/check/gate-openstack-ansible-pep8/d3a3fa6/ : SUCCESS in 1m 05s\n- gate-openstack-ansible-commit-nv http://logs.openstack.org/25/265325/2/check/gate-openstack-ansible-commit-nv/40c423e/ : FAILURE in 1h 09m 19s (non-voting)\n- gate-openstack-ansible-dsvm-commit http://logs.openstack.org/25/265325/2/check/gate-openstack-ansible-dsvm-commit/98c46ed/ : FAILURE in 1h 28m 23s","accounts_in_message":[],"_revision_number":2},{"id":"c9d2509f0e0951ffe44ad54b9cc3628d00108b64","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-08 18:14:11.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"d18ea528c5024657541d1a6db6558f6b3cc05f9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 20:23:41.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-openstack-ansible-docs http://docs-draft.openstack.org/25/265325/3/check/gate-openstack-ansible-docs/96367c3//doc/build/html/ : SUCCESS in 1m 21s\n- gate-openstack-ansible-lint http://logs.openstack.org/25/265325/3/check/gate-openstack-ansible-lint/7dc6ca3/ : SUCCESS in 2m 35s\n- gate-openstack-ansible-pep8 http://logs.openstack.org/25/265325/3/check/gate-openstack-ansible-pep8/9596312/ : SUCCESS in 52s\n- gate-openstack-ansible-commit-nv http://logs.openstack.org/25/265325/3/check/gate-openstack-ansible-commit-nv/61c6e7a/ : SUCCESS in 1h 15m 43s (non-voting)\n- gate-openstack-ansible-dsvm-commit http://logs.openstack.org/25/265325/3/check/gate-openstack-ansible-dsvm-commit/92d199b/ : FAILURE in 1h 19m 22s","accounts_in_message":[],"_revision_number":3},{"id":"d785f1c71792d5e871348fdbb41dbd756315f4ba","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-01-29 08:29:06.000000000","message":"Abandoned\n\nI agree with Evrard - I don\u0027t think we should be carrying modifications. Deployers can do this if they wish to.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9a28e08a974eabed4674cdc947da9c854d1c3232","revisions":{"73c734e28478ccf6dc81c472f3b45ecef4dddc57":{"kind":"REWORK","_number":1,"created":"2016-01-08 15:56:04.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/25/265325/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/25/265325/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/1"}}},"commit":{"parents":[{"commit":"65b0cd6982be085c88fdea3340fb705749431525","subject":"Update Master SHAs - 8 Jan 2016","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/65b0cd6982be085c88fdea3340fb705749431525"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 15:54:58.000000000","tz":0},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 15:54:58.000000000","tz":0},"subject":"Add security improvement to glance\u0027s default policy","message":"Add security improvement to glance\u0027s default policy\n\nThese policy changes improve the security of Glance by allowing only\nthe admin or owner to:\n - publish an image publically\n - admin, remove or modify an image\u0027s membership\n\nChange-Id: I63deb23629b306f4e2aca0e359edc2007c419727\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/73c734e28478ccf6dc81c472f3b45ecef4dddc57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/73c734e28478ccf6dc81c472f3b45ecef4dddc57"}]},"branch":"refs/heads/master"},"eefa382a47f2dfce47be3a5da7bdabb7aba488e1":{"kind":"REWORK","_number":2,"created":"2016-01-08 16:05:18.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/25/265325/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/25/265325/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/2"}}},"commit":{"parents":[{"commit":"65b0cd6982be085c88fdea3340fb705749431525","subject":"Update Master SHAs - 8 Jan 2016","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/65b0cd6982be085c88fdea3340fb705749431525"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 15:54:58.000000000","tz":0},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 16:05:06.000000000","tz":0},"subject":"Add security improvement to glance\u0027s default policy","message":"Add security improvement to glance\u0027s default policy\n\nThese policy changes improve the security of Glance by allowing only\nthe admin or owner to:\n - publish an image publically\n - admin, remove or modify an image\u0027s membership\n\nChange-Id: I63deb23629b306f4e2aca0e359edc2007c419727\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/eefa382a47f2dfce47be3a5da7bdabb7aba488e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/eefa382a47f2dfce47be3a5da7bdabb7aba488e1"}]},"branch":"refs/heads/master"},"9a28e08a974eabed4674cdc947da9c854d1c3232":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-01-08 18:14:11.000000000","uploader":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"ref":"refs/changes/25/265325/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/25/265325/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/25/265325/3"}}},"commit":{"parents":[{"commit":"ddf9e65f39a91380f007aded634e647903cb2fa7","subject":"Update Master SHAs - 8 Jan 2016","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/ddf9e65f39a91380f007aded634e647903cb2fa7"}]}],"author":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 15:54:58.000000000","tz":0},"committer":{"name":"Jesse Pretorius","email":"jesse.pretorius@rackspace.co.uk","date":"2016-01-08 18:14:11.000000000","tz":0},"subject":"Add security improvement to glance\u0027s default policy","message":"Add security improvement to glance\u0027s default policy\n\nThese policy changes improve the security of Glance by allowing only\nthe admin or owner to:\n - publish an image publically\n - admin, remove or modify an image\u0027s membership\n\nChange-Id: I63deb23629b306f4e2aca0e359edc2007c419727\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/9a28e08a974eabed4674cdc947da9c854d1c3232"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/9a28e08a974eabed4674cdc947da9c854d1c3232"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}