)]}'
{"playbooks/roles/galera_server/handlers/main.yml":[{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"56656b53e589f93361e5d9878677bc9b99d24d12","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  environment:"},{"line_number":22,"context_line":"    MYSQLD_STARTUP_TIMEOUT: 180"},{"line_number":23,"context_line":"  register: galera_restart"},{"line_number":24,"context_line":"  failed_when: false"},{"line_number":25,"context_line":"  notify:"},{"line_number":26,"context_line":"    - \"remove stale .sst\""},{"line_number":27,"context_line":"    - \"Restart mysql fall back\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: remove stale .sst"},{"line_number":30,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_9de72512","line":27,"range":{"start_line":24,"start_character":2,"end_line":27,"end_character":31},"updated":"2016-01-12 08:49:37.000000000","message":"I\u0027m not sure this will work, I did a basic test and it seems that handlers don\u0027t get notified if a service action fails, even if failed_when false is set. Handlers only get notified on change, and failed_when overrides the result to OK not changed. You could force notification with failed_when: false and changed_when: true, but then the restart mysql handler will always result in a double restart. \n https://gist.github.com/hughsaunders/fe73638520f1dc2f08d7","commit_id":"bd3c1929415bac6aa9313c7e4d0dc84c2f6ee4af"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"d4c39a9b4f54ab870c1800216efa5531a94b7068","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  environment:"},{"line_number":22,"context_line":"    MYSQLD_STARTUP_TIMEOUT: 180"},{"line_number":23,"context_line":"  register: galera_restart"},{"line_number":24,"context_line":"  failed_when: false"},{"line_number":25,"context_line":"  notify:"},{"line_number":26,"context_line":"    - \"remove stale .sst\""},{"line_number":27,"context_line":"    - \"Restart mysql fall back\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: remove stale .sst"},{"line_number":30,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da6ed579_e0b5567e","line":27,"range":{"start_line":24,"start_character":2,"end_line":27,"end_character":31},"in_reply_to":"da6ed579_9de72512","updated":"2016-01-12 09:02:59.000000000","message":"Now with linebreaks:\n\nI\u0027m not sure this will work, I did a basic test and it seems that handlers\ndon\u0027t get notified if a service action fails, even if failed_when false is\nset. Handlers only get notified on change, and failed_when overrides\nthe result to OK not changed. You could force notification with\nfailed_when: false and changed_when: true, but then the restart\nmysql handler will always result in a double restart.\n \nhttps://gist.github.com/hughsaunders/fe73638520f1dc2f08d7","commit_id":"bd3c1929415bac6aa9313c7e4d0dc84c2f6ee4af"}],"playbooks/roles/galera_server/templates/my.cnf.j2":[{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"1878c845b61234eb5a44b20d3dae03c75a874402","unresolved":false,"context_lines":[{"line_number":16,"context_line":"socket \u003d /var/run/mysqld/mysqld.sock"},{"line_number":17,"context_line":"nice \u003d 0"},{"line_number":18,"context_line":"log_error \u003d /var/log/mysql_logs/galera_server_error.log"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[mysql]"},{"line_number":22,"context_line":"default-character-set \u003d utf8"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa69d971_28572759","line":19,"updated":"2016-01-11 21:00:14.000000000","message":"it seems pedantic, but imho it should be mysql_error.log or similar - galera is an implementation of wsrep, and not the sql server itself...and this is a server error log after all.\nYou could also argue for mariadb_error.log or similar. I\u0027d be ok with this too.","commit_id":"bd3c1929415bac6aa9313c7e4d0dc84c2f6ee4af"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7ab03de702abe89dda1e237ca9e32500a642cda0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"socket \u003d /var/run/mysqld/mysqld.sock"},{"line_number":17,"context_line":"nice \u003d 0"},{"line_number":18,"context_line":"log_error \u003d /var/log/mysql_logs/galera_server_error.log"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[mysql]"},{"line_number":22,"context_line":"default-character-set \u003d utf8"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"fa69d971_8b588d32","line":19,"in_reply_to":"fa69d971_28572759","updated":"2016-01-11 21:05:45.000000000","message":"Sure, but *points at line 36*... :)","commit_id":"bd3c1929415bac6aa9313c7e4d0dc84c2f6ee4af"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"d29290832355c33c48325447977aebc227bfec3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"socket \u003d /var/run/mysqld/mysqld.sock"},{"line_number":17,"context_line":"nice \u003d 0"},{"line_number":18,"context_line":"log_error \u003d /var/log/mysql_logs/galera_server_error.log"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[mysql]"},{"line_number":22,"context_line":"default-character-set \u003d utf8"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da6ed579_c2735f4c","line":19,"in_reply_to":"fa69d971_8b588d32","updated":"2016-01-12 15:29:00.000000000","message":"I know - I hate all the incorrect usage of \u0027galera\u0027 versus \u0027mysql\u0027. Maybe a separate review to fix all that","commit_id":"bd3c1929415bac6aa9313c7e4d0dc84c2f6ee4af"}]}