)]}'
{"playbooks/roles/os_horizon/tasks/horizon_ssl_user_provided.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  with_items:"},{"line_number":24,"context_line":"    - { src: \"{{ horizon_user_ssl_cert }}\", dest: \"{{ horizon_ssl_cert }}\", mode: \"0644\" }"},{"line_number":25,"context_line":"    - { src: \"{{ horizon_user_ssl_key }}\", dest: \"{{ horizon_ssl_key }}\", mode: \"0640\" }"},{"line_number":26,"context_line":"  when: horizon_user_ssl_cert is defined and horizon_user_ssl_key is defined"},{"line_number":27,"context_line":"  notify: Restart apache2"},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - horizon-configs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_c8ff3064","side":"PARENT","line":26,"updated":"2016-01-15 18:25:18.000000000","message":"This was here, and not in the include, because there\u0027s nothing wrong with dropping the CA cert if it happens to be defined, regardless of whether the server cert/key is defined. ie this change is not necessary unless it specifically breaks something?","commit_id":"3154ed79564d52597fe19cec36d35ad37c5812f9"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6f156ba215ee8eb712b6fa39171eb1b54f52158b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  with_items:"},{"line_number":24,"context_line":"    - { src: \"{{ horizon_user_ssl_cert }}\", dest: \"{{ horizon_ssl_cert }}\", mode: \"0644\" }"},{"line_number":25,"context_line":"    - { src: \"{{ horizon_user_ssl_key }}\", dest: \"{{ horizon_ssl_key }}\", mode: \"0640\" }"},{"line_number":26,"context_line":"  when: horizon_user_ssl_cert is defined and horizon_user_ssl_key is defined"},{"line_number":27,"context_line":"  notify: Restart apache2"},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - horizon-configs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_1ec7c264","side":"PARENT","line":26,"in_reply_to":"da6ed579_c8ff3064","updated":"2016-01-15 19:29:09.000000000","message":"In Ansible 1.x, a \u0027when\u0027 after an include applies the \u0027when\u0027 to every included task. In Ansible 2, the \u0027when\u0027 decides whether the file should be included in the run at all.\nEssentially, removing this won\u0027t change the behavior of 1.x at all, but yes, Ansible 2 will no longer drop the CA regardless since this task file will no longer be included.\n\nMoving the when is necessary because Ansible 2 is stricter about undefined items in a loop like this though, and throws a fatal error if either horizon_user_ssl_cert/key are undefined, the when isn\u0027t even considered.\n\nMaybe there should be individual copy tasks for cert and key similar to the CA task so that this file could still be included?","commit_id":"3154ed79564d52597fe19cec36d35ad37c5812f9"}],"playbooks/roles/os_horizon/tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    horizon_user_ssl_key is not defined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include: horizon_ssl_user_provided.yml"},{"line_number":30,"context_line":"  when: \u003e"},{"line_number":31,"context_line":"    horizon_user_ssl_cert is defined and"},{"line_number":32,"context_line":"    horizon_user_ssl_key is defined"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_28f12c95","line":30,"updated":"2016-01-15 18:25:18.000000000","message":"See my comment in playbooks/roles/os_horizon/tasks/horizon_ssl_user_provided.yml","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"}],"playbooks/roles/os_keystone/tasks/keystone_ssl.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - keystone-ssl"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- include: keystone_ssl_user_provided.yml"},{"line_number":24,"context_line":"  when: keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - keystone-ssl"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_c88410d4","line":24,"updated":"2016-01-15 18:25:18.000000000","message":"See my comment in playbooks/roles/os_horizon/tasks/horizon_ssl_user_provided.yml","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"}],"playbooks/roles/os_keystone/tasks/keystone_ssl_user_provided.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  with_items:"},{"line_number":24,"context_line":"    - { src: \"{{ keystone_user_ssl_cert }}\", dest: \"{{ keystone_ssl_cert }}\", mode: \"0644\" }"},{"line_number":25,"context_line":"    - { src: \"{{ keystone_user_ssl_key }}\", dest: \"{{ keystone_ssl_key }}\", mode: \"0640\" }"},{"line_number":26,"context_line":"  when: keystone_user_ssl_cert is defined and keystone_user_ssl_key is defined"},{"line_number":27,"context_line":"  notify: Restart Apache"},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - keystone-configs"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_087f88e0","side":"PARENT","line":26,"updated":"2016-01-15 18:25:18.000000000","message":"See my comment in playbooks/roles/os_horizon/tasks/horizon_ssl_user_provided.yml","commit_id":"3154ed79564d52597fe19cec36d35ad37c5812f9"}],"playbooks/roles/os_swift_sync/tasks/swift_rings_build.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4f1a9793d833a705c6e6b5253177ab664e594d7b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    owner: \"{{ swift_system_user_name }}\""},{"line_number":32,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { item: \"account\", port: \"{{ swift_account_port }}\", type: \"account\" }"},{"line_number":35,"context_line":"    - { item: \"container\", port: \"{{ swift_container_port}}\", type: \"container\" }"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - swift-rings"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_d8716b0d","line":34,"updated":"2016-01-15 05:19:15.000000000","message":"Shouldn\u0027t this be \"{{ swift.account }}\" to keep with the variable lookup from the swift global variable?","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"9edcf150049e30cb2644e4085c6fef96f12da76f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    owner: \"{{ swift_system_user_name }}\""},{"line_number":32,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { item: \"account\", port: \"{{ swift_account_port }}\", type: \"account\" }"},{"line_number":35,"context_line":"    - { item: \"container\", port: \"{{ swift_container_port}}\", type: \"container\" }"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - swift-rings"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_083228a7","line":34,"in_reply_to":"da6ed579_d8716b0d","updated":"2016-01-15 18:16:59.000000000","message":"Yep, looks like that\u0027s an optional level in the global variable. Will need an empty default here.","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4f1a9793d833a705c6e6b5253177ab664e594d7b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { item: \"account\", port: \"{{ swift_account_port }}\", type: \"account\" }"},{"line_number":35,"context_line":"    - { item: \"container\", port: \"{{ swift_container_port}}\", type: \"container\" }"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - swift-rings"},{"line_number":38,"context_line":"    - swift-rings-contents"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_9866934f","line":35,"updated":"2016-01-15 05:19:15.000000000","message":"Shouldn\u0027t this be \"{{ swift.container }}\" to keep with the variable lookup from the swift global variable?","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"9edcf150049e30cb2644e4085c6fef96f12da76f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    group: \"{{ swift_system_group_name }}\""},{"line_number":33,"context_line":"  with_items:"},{"line_number":34,"context_line":"    - { item: \"account\", port: \"{{ swift_account_port }}\", type: \"account\" }"},{"line_number":35,"context_line":"    - { item: \"container\", port: \"{{ swift_container_port}}\", type: \"container\" }"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - swift-rings"},{"line_number":38,"context_line":"    - swift-rings-contents"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_e8d5541b","line":35,"in_reply_to":"da6ed579_9866934f","updated":"2016-01-15 18:16:59.000000000","message":"Same as above.","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  command: \"/usr/bin/python /etc/swift/scripts/swift_rings.py -f /etc/swift/scripts/{{ item[0] }}.contents -r {{ item[1] }}\""},{"line_number":69,"context_line":"  with_nested:"},{"line_number":70,"context_line":"    - [ \u0027account\u0027, \u0027container\u0027 ]"},{"line_number":71,"context_line":"    - \"{{ swift_managed_regions|default([]) }}\""},{"line_number":72,"context_line":"  sudo: yes"},{"line_number":73,"context_line":"  sudo_user: \"{{ swift_system_user_name }}\""},{"line_number":74,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_08cd4830","line":71,"updated":"2016-01-15 18:25:18.000000000","message":"It makes it easier to read if there are spaces on either side of the |","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6f156ba215ee8eb712b6fa39171eb1b54f52158b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  command: \"/usr/bin/python /etc/swift/scripts/swift_rings.py -f /etc/swift/scripts/{{ item[0] }}.contents -r {{ item[1] }}\""},{"line_number":69,"context_line":"  with_nested:"},{"line_number":70,"context_line":"    - [ \u0027account\u0027, \u0027container\u0027 ]"},{"line_number":71,"context_line":"    - \"{{ swift_managed_regions|default([]) }}\""},{"line_number":72,"context_line":"  sudo: yes"},{"line_number":73,"context_line":"  sudo_user: \"{{ swift_system_user_name }}\""},{"line_number":74,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_e93a3598","line":71,"in_reply_to":"da6ed579_08cd4830","updated":"2016-01-15 19:29:09.000000000","message":"I agree, seems to be inconsistent between roles in the project. Will fix these.","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"}],"playbooks/roles/os_swift_sync/tasks/swift_sync_post_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5246e3c380f13ca7a1ca13bd3290afe9a90fa988","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: \"started\""},{"line_number":20,"context_line":"    pattern: \"{{ item }}\""},{"line_number":21,"context_line":"  with_items: \"{{ swift_account_program_names + swift_container_program_names + swift_object_program_names }}\""},{"line_number":22,"context_line":"  when: inventory_hostname in groups[\u0027swift_hosts\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: \"Ensure services are started\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_48f6e05d","line":21,"updated":"2016-01-15 18:25:18.000000000","message":"Would it work if this was a list of lists? ie can this be:\n\nwith_items:\n  - swift_account_program_names\n  - swift_container_program_names\n  - swift_object_program_names","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"6f156ba215ee8eb712b6fa39171eb1b54f52158b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    name: \"{{ item }}\""},{"line_number":19,"context_line":"    state: \"started\""},{"line_number":20,"context_line":"    pattern: \"{{ item }}\""},{"line_number":21,"context_line":"  with_items: \"{{ swift_account_program_names + swift_container_program_names + swift_object_program_names }}\""},{"line_number":22,"context_line":"  when: inventory_hostname in groups[\u0027swift_hosts\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: \"Ensure services are started\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da6ed579_def04a69","line":21,"in_reply_to":"da6ed579_48f6e05d","updated":"2016-01-15 19:29:09.000000000","message":"Looks like they\u0027ll still each need curly braces there, but that works and reads better.","commit_id":"0afbe9153cece7c6cbc41770803cf311e47424aa"}]}