)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a181b0553dea1cee1d7abfb669b977c416db2da7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nova_novncproxy_proto: https"},{"line_number":15,"context_line":"nova_console_user_ssl_cert: ~/certs/horizon.pem"},{"line_number":16,"context_line":"nova_console_user_ssl_key: ~/certs/horizon.key"},{"line_number":17,"context_line":"nova_console_user_ssl_ca_cert: \"{{ ssl_ca_cert }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icb66631ac0b00afe12519fd742e3198e828a10cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_6b52cb36","line":17,"updated":"2016-01-15 15:20:08.000000000","message":"This var has been left out of the configuration. The reason is that there is no option to use it in nova.conf. I would suggest that a subsequent patch is included with documentation about how to configure this, including the need to concatenate the ca cert and the cert into the pem file.","commit_id":"0e4d76dce1b74be4f14ef88c5aea445dfb80963d"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"5b3c51c8c8faaaa6b10e649beb7d89050bcde01c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nova_novncproxy_proto: https"},{"line_number":15,"context_line":"nova_console_user_ssl_cert: ~/certs/horizon.pem"},{"line_number":16,"context_line":"nova_console_user_ssl_key: ~/certs/horizon.key"},{"line_number":17,"context_line":"nova_console_user_ssl_ca_cert: \"{{ ssl_ca_cert }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Icb66631ac0b00afe12519fd742e3198e828a10cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_19acbc8a","line":17,"in_reply_to":"da6ed579_6b52cb36","updated":"2016-01-15 19:16:03.000000000","message":"Done","commit_id":"0e4d76dce1b74be4f14ef88c5aea445dfb80963d"}],"playbooks/roles/os_nova/tasks/nova_console_novnc_install.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a6eae2166f74e000430eaf824bf11ead287e3380","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  with_items:"},{"line_number":113,"context_line":"    - { src: \"{{ nova_console_user_ssl_cert }}\", dest: \"{{ nova_console_ssl_cert }}\", mode: \"0644\" }"},{"line_number":114,"context_line":"    - { src: \"{{ nova_console_user_ssl_key }}\", dest: \"{{ nova_console_ssl_key }}\", mode: \"0640\" }"},{"line_number":115,"context_line":"  when: nova_console_user_ssl_cert is defined and nova_console_user_ssl_key is defined"},{"line_number":116,"context_line":"  notify: Restart nova services"},{"line_number":117,"context_line":"  tags:"},{"line_number":118,"context_line":"    - nova-novnc-ssl"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da6ed579_284a8c55","line":115,"updated":"2016-01-15 18:14:52.000000000","message":"This will break with Ansible 2, it\u0027s stricter about undefined variables in loops. Maybe move these new tasks to a new file, include that file, and apply this \u0027when\u0027 to the include.\nAnsible 1.x will still apply the \u0027when\u0027 to each included task and skip each one, like it\u0027s working here, Ansible 2 will apply the \u0027when\u0027 to the include and skip the new file entirely.\n\nhttps://review.openstack.org/#/c/267842/\nhttps://review.openstack.org/#/c/267842/1/playbooks/roles/os_horizon/tasks/main.yml","commit_id":"0e4d76dce1b74be4f14ef88c5aea445dfb80963d"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"5b3c51c8c8faaaa6b10e649beb7d89050bcde01c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  with_items:"},{"line_number":113,"context_line":"    - { src: \"{{ nova_console_user_ssl_cert }}\", dest: \"{{ nova_console_ssl_cert }}\", mode: \"0644\" }"},{"line_number":114,"context_line":"    - { src: \"{{ nova_console_user_ssl_key }}\", dest: \"{{ nova_console_ssl_key }}\", mode: \"0640\" }"},{"line_number":115,"context_line":"  when: nova_console_user_ssl_cert is defined and nova_console_user_ssl_key is defined"},{"line_number":116,"context_line":"  notify: Restart nova services"},{"line_number":117,"context_line":"  tags:"},{"line_number":118,"context_line":"    - nova-novnc-ssl"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da6ed579_39998079","line":115,"in_reply_to":"da6ed579_284a8c55","updated":"2016-01-15 19:16:03.000000000","message":"Done","commit_id":"0e4d76dce1b74be4f14ef88c5aea445dfb80963d"}],"playbooks/roles/os_nova/tasks/nova_console_novnc_ssl.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a8511d3aa78768706cdeae026f3a07a8056dccc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da6ed579_b9947444","updated":"2016-01-16 18:05:59.000000000","message":"Please add the Apache2 license boilerplate here.","commit_id":"56bd706108f38a46962b3de71619d8a1c13c4396"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"91fde079c203b57da691436559f34711ec22ea38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da6ed579_18e6c8e8","in_reply_to":"da6ed579_b9947444","updated":"2016-01-18 03:59:12.000000000","message":"Done","commit_id":"56bd706108f38a46962b3de71619d8a1c13c4396"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cdb62bf1b84e993fe84f1973ccbb81a13a6c4f14","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Prepare combined nova-console SSL and CA certs"},{"line_number":25,"context_line":"  local_action: command cat {{ nova_console_user_ssl_cert }} {{ nova_console_user_ssl_ca_cert is defined | ternary(nova_console_user_ssl_ca_cert,\u0027\u0027) }}"},{"line_number":26,"context_line":"  register: nova_console_user_ssl_combined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Drop user provided ssl cert and key"},{"line_number":29,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_e4b7b3f3","line":26,"updated":"2016-01-26 11:10:46.000000000","message":"Would it be simpler and cleaner to just leave the assembly of the pem to the deployer?","commit_id":"ac5865399396279d172db44a2a12b03f886bc962"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"507183f50634fd4ff87ab47070e3a8e58ae60ef3","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Prepare combined nova-console SSL and CA certs"},{"line_number":25,"context_line":"  local_action: command cat {{ nova_console_user_ssl_cert }} {{ nova_console_user_ssl_ca_cert is defined | ternary(nova_console_user_ssl_ca_cert,\u0027\u0027) }}"},{"line_number":26,"context_line":"  register: nova_console_user_ssl_combined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Drop user provided ssl cert and key"},{"line_number":29,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_9a85ecae","line":26,"in_reply_to":"9a68dd71_e4b7b3f3","updated":"2016-01-26 11:59:22.000000000","message":"@Matt it could be, but that is often done incorrectly. Including this makes it more user-friendly. It ensures that the way that SSL certs are provided in all configurations are consistent. You always provide a CA cert, a key and a server cert. You never have to think about whether your server cert also needs to be concatenated with the CA cert and which order to concatenate them together. We take care of the implementation details.","commit_id":"ac5865399396279d172db44a2a12b03f886bc962"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"cdb62bf1b84e993fe84f1973ccbb81a13a6c4f14","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":33,"context_line":"    owner: \"nova\""},{"line_number":34,"context_line":"    group: \"nova\""},{"line_number":35,"context_line":"    mode: \"{{ item.mode }}\""},{"line_number":36,"context_line":"  with_items:"},{"line_number":37,"context_line":"    - { content: \"{{ nova_console_user_ssl_combined.stdout ~ \u0027\\n\u0027 }}\", dest: \"{{ nova_console_ssl_cert }}\", mode: \"0644\" }"},{"line_number":38,"context_line":"    - { src: \"{{ nova_console_user_ssl_key }}\", dest: \"{{ nova_console_ssl_key }}\", mode: \"0640\" }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_248ceb34","line":35,"updated":"2016-01-26 11:10:46.000000000","message":"Do we need a \"force: true\" here?  If a deployer updates their local key/cert those will never get deployed as this task will always skip when the files already exist.","commit_id":"ac5865399396279d172db44a2a12b03f886bc962"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"507183f50634fd4ff87ab47070e3a8e58ae60ef3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    dest: \"{{ item.dest }}\""},{"line_number":33,"context_line":"    owner: \"nova\""},{"line_number":34,"context_line":"    group: \"nova\""},{"line_number":35,"context_line":"    mode: \"{{ item.mode }}\""},{"line_number":36,"context_line":"  with_items:"},{"line_number":37,"context_line":"    - { content: \"{{ nova_console_user_ssl_combined.stdout ~ \u0027\\n\u0027 }}\", dest: \"{{ nova_console_ssl_cert }}\", mode: \"0644\" }"},{"line_number":38,"context_line":"    - { src: \"{{ nova_console_user_ssl_key }}\", dest: \"{{ nova_console_ssl_key }}\", mode: \"0640\" }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_950fff2d","line":35,"in_reply_to":"9a68dd71_248ceb34","updated":"2016-01-26 11:59:22.000000000","message":"Hmm, if that is the case then all of our SSL key/cert/CA distribution tasks throughout the stack need updating with the additional parameter.","commit_id":"ac5865399396279d172db44a2a12b03f886bc962"}]}