)]}'
{"tests/roles/bootstrap-host/tasks/check-requirements.yml":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"217032bf073cad00e6f40d0525429d7f72d45423","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Set min size fact"},{"line_number":58,"context_line":"  set_fact:"},{"line_number":59,"context_line":"    host_data_disk_min_size: \"{{ ((bootstrap_host_data_disk_min_size | int) * 1024**3) | int }}\""},{"line_number":60,"context_line":"  tags:"},{"line_number":61,"context_line":"    - check-disk-size"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_3088c070","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":4},"updated":"2016-01-25 20:56:39.000000000","message":"Not enthusiastic about this change as units are not obvious from variable names, and one is measured in K while the other is still G. \n\nthinking this would be clearer by replacing occurrences of \u0027size/space\u0027 and adding units in our facts:\nhost_root_available_kbytes\nhost_data_disk_capacity_bytes\n\nAlternatively, just use comments to capture units for easier maintenance later.\n\nAlso not doing quite what the commit msg says, as commit says bytes.","commit_id":"85aad72a910538732cd668676e1d4c88e814ba22"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"861ec690202a66afd4ce2cd5fc5441d0b6ca441d","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: Set min size fact"},{"line_number":58,"context_line":"  set_fact:"},{"line_number":59,"context_line":"    host_data_disk_min_size: \"{{ ((bootstrap_host_data_disk_min_size | int) * 1024**3) | int }}\""},{"line_number":60,"context_line":"  tags:"},{"line_number":61,"context_line":"    - check-disk-size"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_d307ee15","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":4},"in_reply_to":"9a68dd71_3088c070","updated":"2016-01-25 21:08:59.000000000","message":"Agree that this should be commented.  The conversion takes a number in GB and converts it to bytes, the number of GB * 1024^3 power \u003d bytes.  1024^2 would be KB.","commit_id":"85aad72a910538732cd668676e1d4c88e814ba22"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"217032bf073cad00e6f40d0525429d7f72d45423","unresolved":false,"context_lines":[{"line_number":63,"context_line":"- name: Fail if there is not enough space available in /"},{"line_number":64,"context_line":"  assert:"},{"line_number":65,"context_line":"    that: |"},{"line_number":66,"context_line":"      (host_root_space_available | int) \u003e\u003d ((host_data_disk_min_size | int) * 0.75)"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - bootstrap_host_data_disk_device is not defined"},{"line_number":69,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_f0f468f1","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":7},"updated":"2016-01-25 20:56:39.000000000","message":"nit: There is so much extra casting going on in here, can\u0027t decide if I like it or not.","commit_id":"85aad72a910538732cd668676e1d4c88e814ba22"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"861ec690202a66afd4ce2cd5fc5441d0b6ca441d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"- name: Fail if there is not enough space available in /"},{"line_number":64,"context_line":"  assert:"},{"line_number":65,"context_line":"    that: |"},{"line_number":66,"context_line":"      (host_root_space_available | int) \u003e\u003d ((host_data_disk_min_size | int) * 0.75)"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - bootstrap_host_data_disk_device is not defined"},{"line_number":69,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a68dd71_732e428d","line":66,"range":{"start_line":66,"start_character":6,"end_line":66,"end_character":7},"in_reply_to":"9a68dd71_f0f468f1","updated":"2016-01-25 21:08:59.000000000","message":"Unfortunately I had to do all of that casting or Ansible converted back to unicode :/  I agree, very ugly.","commit_id":"85aad72a910538732cd668676e1d4c88e814ba22"}]}