)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5a52eb0f296a9057563d5ed5cbdca83d0e046dbb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Byron McCollum \u003cbyron.mccollum@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-19 07:42:17 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accommodate Rabbitless Stand-Alone Swift Installations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When RabbitMQ is not installed (affinity: 0), because it is not used"},{"line_number":10,"context_line":"in a Stand-Alone Swift installation, do not setup messaging vhost and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bae84128_b12df1ff","line":7,"updated":"2016-02-24 16:48:43.000000000","message":"The content of the patch doesn\u0027t really match this subject of commit message content. This is the original intent, but not the resulting patch.","commit_id":"0f4e51df8a31bd87625a1175bb267a0cecd3e79d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f905845bb6fa4044f0da659addb92380b201ee0b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Byron McCollum \u003cbyron.mccollum@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-19 07:42:17 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Accommodate Rabbitless Stand-Alone Swift Installations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When RabbitMQ is not installed (affinity: 0), because it is not used"},{"line_number":10,"context_line":"in a Stand-Alone Swift installation, do not setup messaging vhost and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bae84128_71e409ab","line":7,"in_reply_to":"bae84128_b12df1ff","updated":"2016-02-24 16:50:16.000000000","message":"Perhaps it should be something along the lines of \u0027Accommodate environments where rabbitmq is not in the Ansible inventory\u0027.","commit_id":"0f4e51df8a31bd87625a1175bb267a0cecd3e79d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b3c8b3091e821c808ecaf0b65c1a707ad29d709b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When RabbitMQ is not installed (affinity: 0), because it is not used"},{"line_number":10,"context_line":"in a Stand-Alone Swift installation, do not setup messaging vhost and"},{"line_number":11,"context_line":"user for the various services."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Note: The only change that is actually needed is in Keystone, but all"},{"line_number":14,"context_line":"other services have been updated for consistency and clarity."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bae84128_c31fe107","line":11,"updated":"2016-02-25 09:26:14.000000000","message":"Perhaps this commit message should indicate that it is a partial solution for something like a standalone swift install - or it shouldn\u0027t mention this at all.\n\nBasically this patch applies when a selected part of the infrastructure is deployed. It might be that rabbitmq is already setup elsewhere and is not in the Ansible inventory, or it may be that the setup in question is only setting up something like Keystone, and therefore doesn\u0027t need RabbitMQ for anything.","commit_id":"3321f2bea93ede2559ed98b602f0b6767bf6915b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7db0bfff64b48c46ea51094dabbf2cc98f4d4027","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Byron McCollum \u003cbyron.mccollum@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-03 15:08:02 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not setup messaging vhost and user when Rabbit is not installed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When RabbitMQ is not installed (affinity: 0), because it is not used"},{"line_number":10,"context_line":"in a Stand-Alone Swift installation, do not setup messaging vhost and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7af24918_9e8c59db","line":7,"updated":"2016-03-04 09:31:13.000000000","message":"The actions taken in this patch are quite different to that expressed in the commit message. I think the commit message needs a pretty hefty revision!","commit_id":"34089fc43ba3f508063ad2da5585077a9710d56a"}],"playbooks/os-keystone-install.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"d54f9c460e13c6c0c2f064865b64a4b2de48c534","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      register: servers"},{"line_number":50,"context_line":"    - name: Set rabbitmq servers"},{"line_number":51,"context_line":"      set_fact:"},{"line_number":52,"context_line":"        rabbitmq_servers: \"{{ servers.sorted_list }}\""},{"line_number":53,"context_line":"    - name: Create log dir"},{"line_number":54,"context_line":"      file:"},{"line_number":55,"context_line":"        path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bae84128_dc4a30ac","line":52,"updated":"2016-02-25 01:59:45.000000000","message":"These two tasks are looking for and sorting hosts in groups[\u0027rabbitmq_all\u0027].","commit_id":"3321f2bea93ede2559ed98b602f0b6767bf6915b"},{"author":{"_account_id":4268,"name":"Byron McCollum","email":"byron.mccollum@rackspace.com","username":"byron-mccollum"},"change_message_id":"77fe8999d86d0602f333fb791388086ddde0f703","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      register: servers"},{"line_number":50,"context_line":"    - name: Set rabbitmq servers"},{"line_number":51,"context_line":"      set_fact:"},{"line_number":52,"context_line":"        rabbitmq_servers: \"{{ servers.sorted_list }}\""},{"line_number":53,"context_line":"    - name: Create log dir"},{"line_number":54,"context_line":"      file:"},{"line_number":55,"context_line":"        path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9aed3d3a_54d1eafa","line":52,"in_reply_to":"bae84128_dc4a30ac","updated":"2016-02-25 18:51:33.000000000","message":"While not ideal, these tasks do \"pass\" because it\u0027s sorting an empty list of RabbitMQ servers. This empty list eventually gets templated into the keystone.conf, but I see no ill side effects of this.","commit_id":"3321f2bea93ede2559ed98b602f0b6767bf6915b"}],"playbooks/roles/os_aodh/tasks/aodh_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0ac10d104f5880f41d0c2acd5446829c37068698","unresolved":false,"context_lines":[{"line_number":91,"context_line":"- include: aodh_messaging_setup.yml"},{"line_number":92,"context_line":"  when: \u003e"},{"line_number":93,"context_line":"    inventory_hostname \u003d\u003d groups[\u0027aodh_api\u0027][0] and"},{"line_number":94,"context_line":"    groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_b2003eac","line":94,"updated":"2016-02-19 13:24:12.000000000","message":"Can you change this to use a list format instead please? ie\n\n  when:\n    - inventory_hostname \u003d\u003d groups[\u0027aodh_api\u0027][0]\n    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0","commit_id":"ee5d6901eaed65f85aac6c4cf95dd13dced9a4ba"},{"author":{"_account_id":4268,"name":"Byron McCollum","email":"byron.mccollum@rackspace.com","username":"byron-mccollum"},"change_message_id":"d9244492115141e9a46e80b090c19008ac373eb3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"- include: aodh_messaging_setup.yml"},{"line_number":92,"context_line":"  when: \u003e"},{"line_number":93,"context_line":"    inventory_hostname \u003d\u003d groups[\u0027aodh_api\u0027][0] and"},{"line_number":94,"context_line":"    groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_525a9284","line":94,"in_reply_to":"bae84128_b2003eac","updated":"2016-02-19 13:31:19.000000000","message":"Done","commit_id":"ee5d6901eaed65f85aac6c4cf95dd13dced9a4ba"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- include: aodh_messaging_setup.yml"},{"line_number":92,"context_line":"  when:"},{"line_number":93,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":94,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_9277fad3","line":93,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/aodh_api/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_ceilometer/tasks/ceilometer_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- include: ceilometer_messaging_setup.yml"},{"line_number":107,"context_line":"  when:"},{"line_number":108,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":109,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_f2676623","line":108,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/ceilometer_api/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_cinder/tasks/cinder_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- include: cinder_messaging_setup.yml"},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":106,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_1263ea1b","line":105,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/cinder/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_glance/tasks/glance_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- include: glance_messaging_setup.yml"},{"line_number":97,"context_line":"  when:"},{"line_number":98,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":99,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_52b6128b","line":98,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/glance/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_heat/tasks/heat_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- include: heat_messaging_setup.yml"},{"line_number":105,"context_line":"  when:"},{"line_number":106,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":107,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_12bc8a6b","line":106,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/heat/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_keystone/tasks/keystone_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- include: keystone_messaging_setup.yml"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":125,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_9289bacd","line":124,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/keystone/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}],"playbooks/roles/os_neutron/tasks/neutron_pre_install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e1ea8ee117f0a31eb790407a7b0033063fa91b14","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"- include: neutron_messaging_setup.yml"},{"line_number":109,"context_line":"  when:"},{"line_number":110,"context_line":"    - inventory_hostname \u003d\u003d groups[\u0027nova_all\u0027][0]"},{"line_number":111,"context_line":"    - groups[\u0027rabbitmq_all\u0027]|length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bae84128_f2992621","line":110,"updated":"2016-02-19 13:34:12.000000000","message":"s/nova/neutron/","commit_id":"c145b3a64763510398c8c6ed52a55898dc2641d1"}]}