)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9fa9e2d8563c6655013bc3452b62f7c7c2ec93c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a function to check integrity of user config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The _ensure_config_integrity function determines first"},{"line_number":10,"context_line":"the need to have provider networks in our user config files by looking"},{"line_number":11,"context_line":"in environment content for first container without \"is_metal\" flag"},{"line_number":12,"context_line":"set to true. With that information, it checks if it can load any"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_529dce08","line":9,"updated":"2016-02-23 16:44:32.000000000","message":"I\u0027d suggest altering this commit message to explain the \u0027why\u0027 of the change, rather than the \u0027what\u0027. The code describes the checks, the commit message will help others in the future understand why such checks are necessary or useful.","commit_id":"d5f9fda671734ccafe5983a25121d0d3e5826b0f"}],"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"55f225da35b84845ded2b350f561251b1f133ea0","unresolved":false,"context_lines":[{"line_number":880,"context_line":"    if is_provider_networks_valid:"},{"line_number":881,"context_line":"        if (\u0027global_overrides\u0027 not in config):"},{"line_number":882,"context_line":"            raise SystemExit("},{"line_number":883,"context_line":"                \"global_overrides can\u0027t be find in user config\""},{"line_number":884,"context_line":"            )"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        elif (\u0027provider_networks\u0027 not in config[\u0027global_overrides\u0027]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_d0e99380","line":883,"updated":"2016-02-18 21:37:52.000000000","message":"Should be \"can\u0027t be found\"","commit_id":"0db61613e2d28552a242c85b338c5b93caf61cb5"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"55f225da35b84845ded2b350f561251b1f133ea0","unresolved":false,"context_lines":[{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        elif (\u0027provider_networks\u0027 not in config[\u0027global_overrides\u0027]):"},{"line_number":887,"context_line":"            raise SystemExit("},{"line_number":888,"context_line":"                \"provider networks can\u0027t be find under \""},{"line_number":889,"context_line":"                \"global_overrides in user config\""},{"line_number":890,"context_line":"            )"},{"line_number":891,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_50f6235d","line":888,"updated":"2016-02-18 21:37:52.000000000","message":"Should be \"can\u0027t be found\"","commit_id":"0db61613e2d28552a242c85b338c5b93caf61cb5"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2d84c9489de7e6b346767effd5473967ebf5c293","unresolved":false,"context_lines":[{"line_number":860,"context_line":"                    )"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"def _ensure_config_integrity(cidr_networks, config, container_skel):"},{"line_number":864,"context_line":"    \"\"\" check integrity of config"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    :param cidr_networks: ``dict`` cidr_networks from config"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_de3d6490","line":863,"range":{"start_line":863,"start_character":4,"end_line":863,"end_character":28},"updated":"2016-02-23 18:58:04.000000000","message":"The function name doesn\u0027t match the work being done here.","commit_id":"d5f9fda671734ccafe5983a25121d0d3e5826b0f"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"adda0e746a112907de7f656b6ec282c8f30abb7d","unresolved":false,"context_lines":[{"line_number":877,"context_line":"            is_provider_networks_valid \u003d True"},{"line_number":878,"context_line":"            break"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    if is_provider_networks_valid:"},{"line_number":881,"context_line":"        if (\u0027global_overrides\u0027 not in config):"},{"line_number":882,"context_line":"            raise SystemExit("},{"line_number":883,"context_line":"                \"global_overrides can\u0027t be found in user config\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c78e42cf","line":880,"updated":"2016-02-23 16:41:32.000000000","message":"This works, but the variable name is a little confusing, given that provider_networks is actually checked in the elif statement.\n\nPerhaps `is_provider_networks_needed`?","commit_id":"d5f9fda671734ccafe5983a25121d0d3e5826b0f"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"adda0e746a112907de7f656b6ec282c8f30abb7d","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            break"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    if is_provider_networks_valid:"},{"line_number":881,"context_line":"        if (\u0027global_overrides\u0027 not in config):"},{"line_number":882,"context_line":"            raise SystemExit("},{"line_number":883,"context_line":"                \"global_overrides can\u0027t be found in user config\""},{"line_number":884,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_325beaf7","line":881,"updated":"2016-02-23 16:41:32.000000000","message":"This check works, but a note for other testers - you may have a global_overrides dict somewhere in your conf.d, not just openstack_user_config.yml.","commit_id":"d5f9fda671734ccafe5983a25121d0d3e5826b0f"}],"releasenotes/notes/check_user-config_accuracy-3318f215a8d84b7d.yaml":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"63398be892d15c345ca06b999860acbb5748d59b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a function in dynamic_inventory.py to early"},{"line_number":4,"context_line":"    identify wrong settings inside user config data "}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bae84128_ac574825","line":4,"updated":"2016-02-25 00:34:13.000000000","message":"I might reword this as \"Added a function in dynamic_inventory.py to identify incorrect settings inside the user config file.\"","commit_id":"c0f4f2dc61e161accfe9625a60c39285432f660d"}]}