)]}'
{"etc/openstack_deploy/openstack_user_config.yml.example":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"20c8e1cb12d1596587e0756daa44ba9221e3dc7c","unresolved":false,"context_lines":[{"line_number":575,"context_line":"#           volume_backend_name: LVM_iSCSI"},{"line_number":576,"context_line":"#           volume_driver: cinder.volume.drivers.lvm.LVMVolumeDriver"},{"line_number":577,"context_line":"#           volume_group: cinder-volumes"},{"line_number":578,"context_line":"#           iscsi_ip_address: \"{{ storage_address }}\""},{"line_number":579,"context_line":"#         limit_container_types: cinder_volume"},{"line_number":580,"context_line":"#"},{"line_number":581,"context_line":"# Example:"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bae84128_61428daf","line":578,"updated":"2016-02-24 13:12:33.000000000","message":"If we\u0027re needing to implement the actual storage bridge IP here, then we need to describe this - otherwise people will copy-paste this and it won\u0027t work.\n\nWould it not be better to use the following instead?\n\n  \"{{ hostvars[inventory_hostname][\u0027ansible_br_storage\u0027][\u0027ipv4\u0027][\u0027address\u0027] }}\"","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1a7e9b366875d81acc080b8e666dd596a0fa6bcc","unresolved":false,"context_lines":[{"line_number":575,"context_line":"#           volume_backend_name: LVM_iSCSI"},{"line_number":576,"context_line":"#           volume_driver: cinder.volume.drivers.lvm.LVMVolumeDriver"},{"line_number":577,"context_line":"#           volume_group: cinder-volumes"},{"line_number":578,"context_line":"#           iscsi_ip_address: \"{{ storage_address }}\""},{"line_number":579,"context_line":"#         limit_container_types: cinder_volume"},{"line_number":580,"context_line":"#"},{"line_number":581,"context_line":"# Example:"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bae84128_a07e41e1","line":578,"in_reply_to":"bae84128_61428daf","updated":"2016-02-24 16:10:55.000000000","message":"The `storage_address` variable is being discovered in the playbook with a fact being set accordingly which makes it possible to support cinder both in and outside of a container. Setting this to a host variable that assumes \u0027ansible_br_storage\u0027 is always available will cause more confusion IMHO.","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"99c1d5554d40a533e87e2bc08ac1e9a5ebd93ca3","unresolved":false,"context_lines":[{"line_number":575,"context_line":"#           volume_backend_name: LVM_iSCSI"},{"line_number":576,"context_line":"#           volume_driver: cinder.volume.drivers.lvm.LVMVolumeDriver"},{"line_number":577,"context_line":"#           volume_group: cinder-volumes"},{"line_number":578,"context_line":"#           iscsi_ip_address: \"{{ storage_address }}\""},{"line_number":579,"context_line":"#         limit_container_types: cinder_volume"},{"line_number":580,"context_line":"#"},{"line_number":581,"context_line":"# Example:"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bae84128_60df19d6","line":578,"in_reply_to":"bae84128_a07e41e1","updated":"2016-02-24 16:12:23.000000000","message":"So this var works? Why didn\u0027t it work on the previous patch set when using this in the AIO config?","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"}],"playbooks/os-cinder-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"77ef19c7c875e9f23e4e33b994fc3b5e7863496f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      cinder_venv_download_url: \"{{ openstack_repo_url }}/venvs/{{ openstack_release }}/{{ ansible_distribution | lower }}/cinder-{{ openstack_release }}.tgz\""},{"line_number":159,"context_line":"      cinder_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":160,"context_line":"      cinder_storage_address: \"{{ container_address }}\""},{"line_number":161,"context_line":"      cinder_iscsi_ip_address: \"{{ storage_address | default(container_address) }}\""},{"line_number":162,"context_line":"      cinder_glance_host: \"{{ internal_lb_vip_address }}\""},{"line_number":163,"context_line":"      cinder_glance_service_port: \"{{ glance_service_port }}\""},{"line_number":164,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_bda24649","line":161,"updated":"2016-02-23 09:52:19.000000000","message":"The \u0027Set cinder storage address\u0027 tasks above are trying to achieve the same goal as this patch. It seems that they are not as effective as they should be so there\u0027s a bug here.\n\nIt\u0027d be better to improve the mechanism above, or remove it.\n\nTiago Gomes also came across a similar bug (I think) and resolved it using: http://paste.openstack.org/show/487757/","commit_id":"84692492429874a30d104b6e9cd96cb82b23ef85"},{"author":{"_account_id":4268,"name":"Byron McCollum","email":"byron.mccollum@rackspace.com","username":"byron-mccollum"},"change_message_id":"61cac6b462a8d99f015e32151078b7575f6b2274","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      cinder_venv_download_url: \"{{ openstack_repo_url }}/venvs/{{ openstack_release }}/{{ ansible_distribution | lower }}/cinder-{{ openstack_release }}.tgz\""},{"line_number":159,"context_line":"      cinder_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":160,"context_line":"      cinder_storage_address: \"{{ container_address }}\""},{"line_number":161,"context_line":"      cinder_iscsi_ip_address: \"{{ storage_address | default(container_address) }}\""},{"line_number":162,"context_line":"      cinder_glance_host: \"{{ internal_lb_vip_address }}\""},{"line_number":163,"context_line":"      cinder_glance_service_port: \"{{ glance_service_port }}\""},{"line_number":164,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_61fad076","line":161,"in_reply_to":"bae84128_bda24649","updated":"2016-02-23 13:30:40.000000000","message":"I now see the tasks above, but even after `storage_address` was being discovered, it wasn\u0027t being used at all. Maybe the confusion is the assignment of `container_address` to `cinder_storage_address` on line 160, after which the variable name loses its meaning...\n\nThat being said, I still think `cinder_iscsi_ip_address` needs setting here, but just with the discovered `storage_address` from above. This allows just the iscsi traffic to traverse the storage network, and lets other traffic (rabbit, db, api) traverse the management network.","commit_id":"84692492429874a30d104b6e9cd96cb82b23ef85"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a3579c445d77a73aed66c92a1640955919154598","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      cinder_venv_download_url: \"{{ openstack_repo_url }}/venvs/{{ openstack_release }}/{{ ansible_distribution | lower }}/cinder-{{ openstack_release }}.tgz\""},{"line_number":159,"context_line":"      cinder_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":160,"context_line":"      cinder_storage_address: \"{{ container_address }}\""},{"line_number":161,"context_line":"      cinder_iscsi_ip_address: \"{{ storage_address | default(container_address) }}\""},{"line_number":162,"context_line":"      cinder_glance_host: \"{{ internal_lb_vip_address }}\""},{"line_number":163,"context_line":"      cinder_glance_service_port: \"{{ glance_service_port }}\""},{"line_number":164,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bae84128_d88118c5","line":161,"in_reply_to":"bae84128_bda24649","updated":"2016-02-23 10:10:55.000000000","message":"This issue all relates to the local_ip fact setting which happens in Cinder, Nova and Neutron. The fact setting is adaptive based on whether the service is running on a host or in a container.\n\nSee:\n  https://github.com/openstack/openstack-ansible/commit/c506dda61d303735189abbee7c70d972b3096a40\n  https://github.com/openstack/openstack-ansible/commit/efe45551cb2f28fe13e32896935a39c4f610425a\n\nAlso, a mechanism was added to Neutron too as part of\n  https://github.com/openstack/openstack-ansible/commit/313627fbe178b0ee97c8a58488da4135a775dd4f\n\nIdeally if this mechanism is broken, then a fix needs to be found that works across all needs and can be applied to each of the plays","commit_id":"84692492429874a30d104b6e9cd96cb82b23ef85"}],"playbooks/roles/os_cinder/templates/cinder.conf.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"77ef19c7c875e9f23e4e33b994fc3b5e7863496f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_helper \u003d {{ cinder_iscsi_helper }}"},{"line_number":81,"context_line":"iscsi_iotype \u003d {{ cinder_iscsi_iotype }}"},{"line_number":82,"context_line":"iscsi_ip_address \u003d {{ cinder_iscsi_ip_address }}"},{"line_number":83,"context_line":"iscsi_num_targets \u003d {{ cinder_iscsi_num_targets }}"},{"line_number":84,"context_line":"iscsi_port \u003d {{ cinder_iscsi_port }}"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bae84128_3d4ab6ac","line":82,"updated":"2016-02-23 09:52:19.000000000","message":"See line 10.","commit_id":"84692492429874a30d104b6e9cd96cb82b23ef85"},{"author":{"_account_id":4268,"name":"Byron McCollum","email":"byron.mccollum@rackspace.com","username":"byron-mccollum"},"change_message_id":"61cac6b462a8d99f015e32151078b7575f6b2274","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_helper \u003d {{ cinder_iscsi_helper }}"},{"line_number":81,"context_line":"iscsi_iotype \u003d {{ cinder_iscsi_iotype }}"},{"line_number":82,"context_line":"iscsi_ip_address \u003d {{ cinder_iscsi_ip_address }}"},{"line_number":83,"context_line":"iscsi_num_targets \u003d {{ cinder_iscsi_num_targets }}"},{"line_number":84,"context_line":"iscsi_port \u003d {{ cinder_iscsi_port }}"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bae84128_013e64d9","line":82,"in_reply_to":"bae84128_3d4ab6ac","updated":"2016-02-23 13:30:40.000000000","message":"I was trying to accommodate deployers using the role independently here. If you don\u0027t specify `cinder_iscsi_ip_address`, then it uses the default `$my_ip`, which internally in cinder resolves to `cinder_storage_address` (line 10), which we are setting as the `container_address` when applying the role in the OSA playbook.","commit_id":"84692492429874a30d104b6e9cd96cb82b23ef85"},{"author":{"_account_id":4268,"name":"Byron McCollum","email":"byron.mccollum@rackspace.com","username":"byron-mccollum"},"change_message_id":"847ba2e693d38e1ba1aeae5c52d085e409317850","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"iscsi_helper \u003d {{ cinder_iscsi_helper }}"},{"line_number":81,"context_line":"iscsi_iotype \u003d {{ cinder_iscsi_iotype }}"},{"line_number":82,"context_line":"iscsi_ip_address \u003d {{ cinder_storage_address }}"},{"line_number":83,"context_line":"iscsi_num_targets \u003d {{ cinder_iscsi_num_targets }}"},{"line_number":84,"context_line":"iscsi_port \u003d {{ cinder_iscsi_port }}"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bae84128_7853936b","line":82,"updated":"2016-02-23 17:18:43.000000000","message":"This needs to go inside the backend sections, below line 102.","commit_id":"1c9b59cc58faf0d177283863db440010985e365d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"20c8e1cb12d1596587e0756daa44ba9221e3dc7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"verbose \u003d {{ verbose }}"},{"line_number":8,"context_line":"debug \u003d {{ debug }}"},{"line_number":9,"context_line":"fatal_deprecations \u003d {{ cinder_fatal_deprecations }}"},{"line_number":10,"context_line":"my_ip \u003d {{ cinder_management_address }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"osapi_volume_workers \u003d {{ cinder_osapi_volume_workers | default(api_threads) }}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"bae84128_61d44deb","line":10,"updated":"2016-02-24 13:12:33.000000000","message":"I think I\u0027d prefer to see this being:\n\n  {{ cinder_management_address | default(ansible_ssh_host) }}\n\nand then have line 160 removed from the playbook. It\u0027s then one less place to look for variables and achieves the same result.","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"33bba8be9791107d8d289d5eb5e2be3eaf3bef8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"verbose \u003d {{ verbose }}"},{"line_number":8,"context_line":"debug \u003d {{ debug }}"},{"line_number":9,"context_line":"fatal_deprecations \u003d {{ cinder_fatal_deprecations }}"},{"line_number":10,"context_line":"my_ip \u003d {{ cinder_management_address }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"osapi_volume_workers \u003d {{ cinder_osapi_volume_workers | default(api_threads) }}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"bae84128_e0a04944","line":10,"in_reply_to":"bae84128_40d13522","updated":"2016-02-24 16:13:06.000000000","message":"Ah, I see what you mean. Never mind.","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1a7e9b366875d81acc080b8e666dd596a0fa6bcc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"verbose \u003d {{ verbose }}"},{"line_number":8,"context_line":"debug \u003d {{ debug }}"},{"line_number":9,"context_line":"fatal_deprecations \u003d {{ cinder_fatal_deprecations }}"},{"line_number":10,"context_line":"my_ip \u003d {{ cinder_management_address }}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"osapi_volume_workers \u003d {{ cinder_osapi_volume_workers | default(api_threads) }}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"bae84128_40d13522","line":10,"in_reply_to":"bae84128_61d44deb","updated":"2016-02-24 16:10:55.000000000","message":"The default in this case is 127.0.0.1 which is set in the defaults/main.yml which is why the option is being set within the playbook. Do you want the \"ansible_ssh_host\" defined there instead?","commit_id":"5eb2af8e615bcb623ead34ba8a91808a8bce43d7"}]}