)]}'
{"doc/source/upgrade-guide/overview.rst":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c91fb1c96d9328448b3cf2cee2add3dff1d94aa1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"---------------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The upgrade process will modify files residing in ``/etc/openstack_deploy`` in"},{"line_number":10,"context_line":"order to reflect new Liberty values. "},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Flag Files"},{"line_number":13,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aed3d3a_a2c873a9","line":10,"updated":"2016-02-29 09:57:45.000000000","message":"nit: whitespace","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"a28500e67edb652f93230405e6830061ee81de72","unresolved":false,"context_lines":[{"line_number":13,"context_line":"----------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Some flag files are created by the migration scripts in order to achieve"},{"line_number":16,"context_line":"idempotency. These files are placed in the ``/etc/openstack_deploy.KILO``"},{"line_number":17,"context_line":"directory."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_924eecbf","line":16,"updated":"2016-03-01 11:52:41.000000000","message":"Is this correct? From the description it sounds like these files are those that take the form:\n\nupgrade_marker\u003d\"/etc/openstack_deploy/upgrade-kilo/$upgrade_marker_file.complete\"","commit_id":"f57d3265a22f2d38c703316b6f33fc0c15840ba3"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"63e9b6108373735f225be3a6e8297023d788fc7e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"----------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Some flag files are created by the migration scripts in order to achieve"},{"line_number":16,"context_line":"idempotency. These files are placed in the ``/etc/openstack_deploy.KILO``"},{"line_number":17,"context_line":"directory."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_4012bc63","line":16,"in_reply_to":"7af24918_924eecbf","updated":"2016-03-01 15:32:06.000000000","message":"It is for files created by scripts coming in later reviews,  in which case maybe I need to remove this. It was intended that the backup script makes one, too, but that\u0027s now changed. The .complete files are used by run_lock, not by the playbooks themselves.","commit_id":"f57d3265a22f2d38c703316b6f33fc0c15840ba3"}],"doc/source/upgrade-guide/scripts.rst":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"8561021e6c20892734ed47dcf8695538931cc511","unresolved":false,"context_lines":[{"line_number":22,"context_line":":ref:`config-change-playbook` playbook will use to determine whether or not to"},{"line_number":23,"context_line":"execute the command on subsequent runs."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This script was used rather than the Ansible ``copy`` or ``synchronize``"},{"line_number":26,"context_line":"modules since it was found those modules will copy the contents of"},{"line_number":27,"context_line":"``/etc/openstack_deploy`` to ``/etc/openstack_deploy.KILO`` on subsequent runs"},{"line_number":28,"context_line":"when changes by later scripts are detected. This behavior is undesirable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aed3d3a_4161a4d2","line":25,"updated":"2016-02-29 10:34:15.000000000","message":"There could have been a task to check for the presence of the directory/file.","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"330ec52023d20f30fb807c1ab9274796799901a7","unresolved":false,"context_lines":[{"line_number":22,"context_line":":ref:`config-change-playbook` playbook will use to determine whether or not to"},{"line_number":23,"context_line":"execute the command on subsequent runs."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This script was used rather than the Ansible ``copy`` or ``synchronize``"},{"line_number":26,"context_line":"modules since it was found those modules will copy the contents of"},{"line_number":27,"context_line":"``/etc/openstack_deploy`` to ``/etc/openstack_deploy.KILO`` on subsequent runs"},{"line_number":28,"context_line":"when changes by later scripts are detected. This behavior is undesirable"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9aed3d3a_c5f48a5c","line":25,"in_reply_to":"9aed3d3a_4161a4d2","updated":"2016-02-29 16:20:15.000000000","message":"Are you advocating for doing that? I looked into it and wasn\u0027t too impressed about doing conditionals within Ansible\u0027s YAML, but it would also mean 1 less script file.","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"}],"scripts/run-upgrade.sh":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"3df27e6f857a54a6b4213eaef25be1a282b51557","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  done"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  upgrade_marker_file\u003d$(basename ${file_part} .yml)"},{"line_number":42,"context_line":"  upgrade_marker\u003d\"/etc/openstack_deploy/upgrade-kilo/$upgrade_marker_file.complete\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if [ ! -f \"$upgrade_marker\" ];then"},{"line_number":45,"context_line":"    # note(sigmavirus24): use eval so that we properly turn strings like"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aed3d3a_a7a24049","line":42,"updated":"2016-02-29 11:20:39.000000000","message":"The directory \"/etc/openstack_deploy/upgrade-kilo\" needs creating before run_lock is used. In Kilo it was done in create-new-openstack-deploy-structure.sh [1]. Possibly it should have been done in the initial patch.\n\n[1] https://github.com/openstack/openstack-ansible/blob/kilo/scripts/upgrade-utilities/scripts/create-new-openstack-deploy-structure.sh#L33","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"c4467cd053c470b50fc13b6f0a29e3403a4694f9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    check_for_kilo"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":133,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.rst\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Run the tasks in order"},{"line_number":136,"context_line":"        for item in ${!RUN_TASKS[@]}; do"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aed3d3a_90bdd96a","line":133,"range":{"start_line":133,"start_character":63,"end_line":133,"end_character":67},"updated":"2016-02-27 14:23:18.000000000","message":"You probably mean .yml","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c91fb1c96d9328448b3cf2cee2add3dff1d94aa1","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    check_for_kilo"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":133,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.rst\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Run the tasks in order"},{"line_number":136,"context_line":"        for item in ${!RUN_TASKS[@]}; do"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aed3d3a_226bc386","line":133,"range":{"start_line":133,"start_character":63,"end_line":133,"end_character":67},"in_reply_to":"9aed3d3a_90bdd96a","updated":"2016-02-29 09:57:45.000000000","message":"++","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"330ec52023d20f30fb807c1ab9274796799901a7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    check_for_kilo"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":133,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.rst\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Run the tasks in order"},{"line_number":136,"context_line":"        for item in ${!RUN_TASKS[@]}; do"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aed3d3a_85f72258","line":133,"range":{"start_line":133,"start_character":63,"end_line":133,"end_character":67},"in_reply_to":"9aed3d3a_90bdd96a","updated":"2016-02-29 16:20:15.000000000","message":"Done","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"}],"scripts/upgrade-utilities/playbooks/deploy-config-changes.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"8561021e6c20892734ed47dcf8695538931cc511","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            creates: /etc/openstack_deploy.KILO/DEPRECATED"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":28,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9aed3d3a_229e2363","line":28,"updated":"2016-02-29 10:34:15.000000000","message":"This var isn\u0027t used.","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"330ec52023d20f30fb807c1ab9274796799901a7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            creates: /etc/openstack_deploy.KILO/DEPRECATED"},{"line_number":26,"context_line":"  vars:"},{"line_number":27,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":28,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9aed3d3a_65049e49","line":28,"in_reply_to":"9aed3d3a_229e2363","updated":"2016-02-29 16:20:15.000000000","message":"Done","commit_id":"51540b61742377e1eda8c3c5c873d4eac1a137bb"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"396cfb285c85e0bc1b64ce6aa7d3188e2d6e9460","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        copy:"},{"line_number":24,"context_line":"          src: \"/etc/openstack_deploy/\""},{"line_number":25,"context_line":"          dest: \"/etc/openstack_deploy.KILO/\""},{"line_number":26,"context_line":"          force: no"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7af24918_e4ba0e6e","line":26,"updated":"2016-03-01 11:40:16.000000000","message":"This playbook no longer creates \u0027/etc/openstack_deploy.KILO/DEPRECATED\u0027 or the tarball of the Kilo config. Is this intentional? I\u0027m not opposed to this because they don\u0027t seem necessary, I just want to be sure.\n\nAs this is effectively a backup, maybe it would be worth changing the file permissions to prevent the files being modified.","commit_id":"f57d3265a22f2d38c703316b6f33fc0c15840ba3"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"63e9b6108373735f225be3a6e8297023d788fc7e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        copy:"},{"line_number":24,"context_line":"          src: \"/etc/openstack_deploy/\""},{"line_number":25,"context_line":"          dest: \"/etc/openstack_deploy.KILO/\""},{"line_number":26,"context_line":"          force: no"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7af24918_bb901597","line":26,"in_reply_to":"7af24918_e4ba0e6e","updated":"2016-03-01 15:32:06.000000000","message":"Correct, I intended not to create those this time around. The Deprecated file was mostly used as a flag with the script in a previous revision, though it may be worth dropping one simply to communicate that the directory is deprecated.","commit_id":"f57d3265a22f2d38c703316b6f33fc0c15840ba3"}]}