)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"5f0c3212d46c6c09b23f4003bc751d789929cdc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update new user secrets in Liberty"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user-secrets-adjustments.yml playbook introduced for Kilo upgrades"},{"line_number":10,"context_line":"is brought foward to Liberty in this commit. Since the task is logically"},{"line_number":11,"context_line":"the same and new secrets variables were introduced, no changes from the"},{"line_number":12,"context_line":"Kilo version are made. The documentation is updated to be more clear"},{"line_number":13,"context_line":"about how existing secrets are handled."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7af24918_21bbe10f","line":10,"updated":"2016-03-02 16:13:50.000000000","message":"s/foward/forward/","commit_id":"7653f626de520623f278515004479ba3fd0c9ddf"}],"doc/source/upgrade-guide/upgrade-playbooks.rst":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"b42a4ca0aa1eba8092c48bf3a6704a7a52b24e8f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    * ``aodh.yml`` and ``haproxy.yml`` will be copied from the source tree into"},{"line_number":27,"context_line":"        ``/etc/openstack_deploy/env.d``."},{"line_number":28,"context_line":"    * ``/etc/openstack_deploy/env.d/neutron.yml`` will have LBaaS group "},{"line_number":29,"context_line":"      memberships added. See :ref:`neutron-env-script` for details."},{"line_number":30,"context_line":"    * ``/etc/openstack_deploy/env.d/ceilometer.yml`` will have two alarm group"},{"line_number":31,"context_line":"      memberships changed. See :ref:`ceilo-env-script` for details."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_b9ee4189","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":72},"updated":"2016-03-01 23:37:06.000000000","message":"nit: extra space here","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"96e48cdd3ce75f644fd27ca3fda609f32fe1a879","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    * ``aodh.yml`` and ``haproxy.yml`` will be copied from the source tree into"},{"line_number":27,"context_line":"        ``/etc/openstack_deploy/env.d``."},{"line_number":28,"context_line":"    * ``/etc/openstack_deploy/env.d/neutron.yml`` will have LBaaS group "},{"line_number":29,"context_line":"      memberships added. See :ref:`neutron-env-script` for details."},{"line_number":30,"context_line":"    * ``/etc/openstack_deploy/env.d/ceilometer.yml`` will have two alarm group"},{"line_number":31,"context_line":"      memberships changed. See :ref:`ceilo-env-script` for details."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_b47a94ef","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":72},"in_reply_to":"7af24918_b9ee4189","updated":"2016-03-02 16:00:25.000000000","message":"Done","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"b42a4ca0aa1eba8092c48bf3a6704a7a52b24e8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"user-secrets-adjustments.yml"},{"line_number":34,"context_line":"----------------------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This playbook ensures that the user secrets file is updated based on the example"},{"line_number":37,"context_line":"file in the main repository. This makes it possible to guarantee all secrets are"},{"line_number":38,"context_line":"carried into the upgraded environment and appropriately generated."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_59fa9d43","line":36,"range":{"start_line":36,"start_character":69,"end_line":36,"end_character":72},"updated":"2016-03-01 23:37:06.000000000","message":"Recommended to mention bringing the secrets file in line with the version of the secrets file found in Liberty. Possibly mention why (services added) and maybe ensure that current secrets values and keys for custom roles will not be removed in the process.","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"96e48cdd3ce75f644fd27ca3fda609f32fe1a879","unresolved":false,"context_lines":[{"line_number":33,"context_line":"user-secrets-adjustments.yml"},{"line_number":34,"context_line":"----------------------------"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This playbook ensures that the user secrets file is updated based on the example"},{"line_number":37,"context_line":"file in the main repository. This makes it possible to guarantee all secrets are"},{"line_number":38,"context_line":"carried into the upgraded environment and appropriately generated."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7af24918_346fa42c","line":36,"range":{"start_line":36,"start_character":69,"end_line":36,"end_character":72},"in_reply_to":"7af24918_59fa9d43","updated":"2016-03-02 16:00:25.000000000","message":"Added some verbiage for this.","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"}],"scripts/run-upgrade.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"470f2f9b2111b88db3f1f5d90355524ccedcfae6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":141,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.yml\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/user-secrets-adjustment.yml\")"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Run the tasks in order"},{"line_number":146,"context_line":"        for item in ${!RUN_TASKS[@]}; do"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_735aff51","line":143,"updated":"2016-03-02 09:23:15.000000000","message":"I don\u0027t see this file in this patch?","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9531145d1ca00facb7c4bab5f35295483549306e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":141,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.yml\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/user-secrets-adjustment.yml\")"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # Run the tasks in order"},{"line_number":146,"context_line":"        for item in ${!RUN_TASKS[@]}; do"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_4990d9ec","line":143,"in_reply_to":"7af24918_735aff51","updated":"2016-03-02 15:52:50.000000000","message":"Doh, yeah, forgot the git add.","commit_id":"1ceac3bd4f949496965980c21007a42697261b2a"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"f00ab697286f990de88e7fdf004fd052292d0717","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    check_for_juno"},{"line_number":139,"context_line":"    check_for_kilo"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    \"${SCRIPTS}/bootstrap-ansible.sh\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    pushd ${MAIN_PATH}/playbooks"},{"line_number":144,"context_line":"        RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/deploy-config-changes.yml\")"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7af24918_5b6658ed","line":141,"updated":"2016-03-04 12:27:27.000000000","message":"Not specific to this change, but I believe that should be ${SCRIPTS_PATH}.","commit_id":"021831aedbe6d2565848082525016355fef3674f"}],"scripts/upgrade-utilities/playbooks/user-secrets-adjustment.yml":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"201f0423adadfe46f0bfa0644c9fec70773c50ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      shell: \"grep \u0027^[a-zA-Z]\u0027 {{ playbook_dir }}/../../../etc/openstack_deploy/user_secrets.yml\""},{"line_number":24,"context_line":"      register: secrets"},{"line_number":25,"context_line":"    - name: Add missing secret"},{"line_number":26,"context_line":"      shell: |"},{"line_number":27,"context_line":"        if ! grep \u0027^{{ item }}\u0027 /etc/openstack_deploy/user_secrets.yml; then"},{"line_number":28,"context_line":"          echo {{ item }} | tee -a /etc/openstack_deploy/user_secrets.yml"},{"line_number":29,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7af24918_9d0b1f2a","line":26,"updated":"2016-03-02 23:25:54.000000000","message":"Couldn\u0027t the first task could also be command just as easily. Could the missing secrets be registered in the first task instead and then lineinfile used to append them?\n\nThis works, is readable, and I don\u0027t want to bikeshed the solution, but I\u0027m not fond of the use of shell.","commit_id":"ee67ffff491644bd02c2a3ac0f2900ce5bcf9083"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"6efd629fbfc089eb2d5a2638a7c4b06be233a0f5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      shell: \"grep \u0027^[a-zA-Z]\u0027 {{ playbook_dir }}/../../../etc/openstack_deploy/user_secrets.yml\""},{"line_number":24,"context_line":"      register: secrets"},{"line_number":25,"context_line":"    - name: Add missing secret"},{"line_number":26,"context_line":"      shell: |"},{"line_number":27,"context_line":"        if ! grep \u0027^{{ item }}\u0027 /etc/openstack_deploy/user_secrets.yml; then"},{"line_number":28,"context_line":"          echo {{ item }} | tee -a /etc/openstack_deploy/user_secrets.yml"},{"line_number":29,"context_line":"        fi"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7af24918_b84a6624","line":26,"in_reply_to":"7af24918_9d0b1f2a","updated":"2016-03-03 00:41:39.000000000","message":"This was taken directly from the Kilo code base without changes. I\u0027m willing to revisit it if a few reviewers want to see it changed, though.","commit_id":"ee67ffff491644bd02c2a3ac0f2900ce5bcf9083"}]}
