)]}'
{"doc/Makefile":[{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"e3b1b05ac24fece44222413e5e821fcfe2d22749","unresolved":false,"context_lines":[{"line_number":54,"context_line":"vars-table.inc:"},{"line_number":55,"context_line":"\t../scripts/upgrade-utilities/scripts/make_rst_table.py"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"html: varstable.inc"},{"line_number":58,"context_line":"\t$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html"},{"line_number":59,"context_line":"\t@echo"},{"line_number":60,"context_line":"\t@echo \"Build finished. The HTML pages are in $(BUILDDIR)/html.\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7af24918_34194b89","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"updated":"2016-03-02 21:31:42.000000000","message":"Missing the -","commit_id":"e31887ad7cf65362881a30a2989cfa6ada0065fa"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"88dfd5891c8a7dc7a7f5840153660ca099638e7c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"vars-table.inc:"},{"line_number":55,"context_line":"\t../scripts/upgrade-utilities/scripts/make_rst_table.py"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"html: varstable.inc"},{"line_number":58,"context_line":"\t$(SPHINXBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR)/html"},{"line_number":59,"context_line":"\t@echo"},{"line_number":60,"context_line":"\t@echo \"Build finished. The HTML pages are in $(BUILDDIR)/html.\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7af24918_0e899b75","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":19},"in_reply_to":"7af24918_34194b89","updated":"2016-03-02 21:33:42.000000000","message":"Done","commit_id":"e31887ad7cf65362881a30a2989cfa6ada0065fa"}],"doc/source/upgrade-guide/scripts.rst":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"5d2cbbb46b6484f38942d093bacc55a3a946f65a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"In Liberty, some variable names in the"},{"line_number":72,"context_line":"``/etc/openstack_deploy/user_variables.yml`` file were changed to reflect"},{"line_number":73,"context_line":"upstream decisions. This script will look for and replace any instances of"},{"line_number":74,"context_line":"these strings in the ``user_variables.yml`` file. Comments in the file will be"},{"line_number":75,"context_line":"preserved."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The variable changes are shown in the following table."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_962f4787","line":74,"updated":"2016-03-03 16:40:52.000000000","message":"Maybe we should be searching for all files of the form \"/etc/openstack_deploy/user_*.yml\" because that is what openstack-ansible looks for.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"94ab291fe1ffae9c833d2db064070e5704cb639d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"In Liberty, some variable names in the"},{"line_number":72,"context_line":"``/etc/openstack_deploy/user_variables.yml`` file were changed to reflect"},{"line_number":73,"context_line":"upstream decisions. This script will look for and replace any instances of"},{"line_number":74,"context_line":"these strings in the ``user_variables.yml`` file. Comments in the file will be"},{"line_number":75,"context_line":"preserved."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The variable changes are shown in the following table."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_b0b6bdf6","line":74,"in_reply_to":"7af24918_962f4787","updated":"2016-03-03 20:07:53.000000000","message":"Good point, I\u0027ll look at what I might be able to do with this.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"4e580d4828939a63a0ed861ce443f2d324196d31","unresolved":false,"context_lines":[{"line_number":71,"context_line":"In Liberty, some variable names in the"},{"line_number":72,"context_line":"``/etc/openstack_deploy/user_variables.yml`` file were changed to reflect"},{"line_number":73,"context_line":"upstream decisions. This script will look for and replace any instances of"},{"line_number":74,"context_line":"these strings in the ``user_variables.yml`` file. Comments in the file will be"},{"line_number":75,"context_line":"preserved."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The variable changes are shown in the following table."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_94d9eef5","line":74,"in_reply_to":"7af24918_b0b6bdf6","updated":"2016-03-03 22:23:38.000000000","message":"Done","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"07ae66a8bbf3ae10460f31eaca603d592cc2b3b0","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The variable changes are shown in the following table."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. include:: vars-table.inc"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Called by :ref:`config-change-playbook`"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_2070a9db","line":79,"updated":"2016-03-03 16:26:15.000000000","message":"Looking at the gate output, this doesn\u0027t appear to be inserted on build. Will investigate further as I think this is important to have.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"00f08454ef33ba6690b624c33c673e3bc9222373","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"The variable changes are shown in the following table."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. include:: vars-table.inc"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Called by :ref:`config-change-playbook`"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7af24918_1b5d2279","line":79,"in_reply_to":"7af24918_2070a9db","updated":"2016-03-03 16:36:23.000000000","message":"I tried the `python setup.py build_sphinx` command locally and got the table. I may have to go looking for gate logs to see if there was a warning or something for the .inc file being created.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"}],"releasenotes/notes/vars-liberty-migrate-28698d84a971219d.yaml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"4289e5ed2b0bd8993760564656763f634b9f262b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      `upgrade documentation"},{"line_number":13,"context_line":"      \u003chttp://docs.openstack.org/developer/openstack-ansible/liberty/upgrade-guide/scripts.html#migrate-openstack-vars-py\u003e`"},{"line_number":14,"context_line":"      for details."},{"line_number":15,"context_line":"      "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_d49bc770","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2016-03-02 21:22:30.000000000","message":"Nit: extra tab","commit_id":"730cbe4850d9715ef18dd38c02798dab3c6c715e"}],"scripts/upgrade-utilities/playbooks/deploy-config-changes.yml":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"5d2cbbb46b6484f38942d093bacc55a3a946f65a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      - name: Update OpenStack variable names"},{"line_number":48,"context_line":"        command: \"{{ upgrade_scripts }}/migrate_openstack_vars.py\""},{"line_number":49,"context_line":"        args:"},{"line_number":50,"context_line":"            creates: /etc/openstack_deploy.KILO/VARS_MIGRATED"},{"line_number":51,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7af24918_9b53f238","line":48,"updated":"2016-03-03 16:40:52.000000000","message":"The script should be supplied a filename argument.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"94ab291fe1ffae9c833d2db064070e5704cb639d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      - name: Update OpenStack variable names"},{"line_number":48,"context_line":"        command: \"{{ upgrade_scripts }}/migrate_openstack_vars.py\""},{"line_number":49,"context_line":"        args:"},{"line_number":50,"context_line":"            creates: /etc/openstack_deploy.KILO/VARS_MIGRATED"},{"line_number":51,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7af24918_30ec6df2","line":48,"in_reply_to":"7af24918_9b53f238","updated":"2016-03-03 20:07:53.000000000","message":"Done","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"965a4f0e99126a6569f3864e6fff2de26fa3ba92","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      - name: Get list of all user variable files"},{"line_number":48,"context_line":"        command: ls /etc/openstack_deploy/user_*.yml"},{"line_number":49,"context_line":"        register: user_var_files"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"      - name: Update OpenStack variable names"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7af24918_64dc5a46","line":48,"updated":"2016-03-04 11:19:35.000000000","message":"Shell expansion doesn\u0027t work with the command module. This needs changing to use the shell module.","commit_id":"7e304cd44f0d0f38971930bf6e51c7fdeabc444b"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"965a4f0e99126a6569f3864e6fff2de26fa3ba92","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      - name: Update OpenStack variable names"},{"line_number":52,"context_line":"        command: \"{{ upgrade_scripts }}/migrate_openstack_vars.py {{ item }}\""},{"line_number":53,"context_line":"        args:"},{"line_number":54,"context_line":"            creates: /etc/openstack_deploy.KILO/VARS_MIGRATED"},{"line_number":55,"context_line":"        with_items: user_var_files.stdout_lines"},{"line_number":56,"context_line":"  vars:"},{"line_number":57,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7af24918_744249af","line":54,"updated":"2016-03-04 11:19:35.000000000","message":"The script will need to create a flag file for each file on which it operates.","commit_id":"7e304cd44f0d0f38971930bf6e51c7fdeabc444b"}],"scripts/upgrade-utilities/scripts/make_rst_table.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"965a4f0e99126a6569f3864e6fff2de26fa3ba92","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# As of right now, running this script and inserting the output into"},{"line_number":21,"context_line":"# the file is manual."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":"from migrate_openstack_vars import VAR_MAPPINGS"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Print old/new values in each row, right aligned."}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_f41ad97b","line":23,"updated":"2016-03-04 11:19:35.000000000","message":"os is unused and causing gate failure.","commit_id":"7e304cd44f0d0f38971930bf6e51c7fdeabc444b"}],"scripts/upgrade-utilities/scripts/migrate_openstack_vars.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"bbc7d331cc94cababddb963c321e3982795089be","unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def update_variables(old_contents):"},{"line_number":49,"context_line":"    new_contents \u003d []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    for line in old_contents:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_727579f8","line":48,"updated":"2016-03-03 13:33:36.000000000","message":"This function does not update comments referencing the changed vars nor does it update any vars that use these vars.\n\nIf these are not fixed it might be worth documenting this, especially for the use of these vars by other vars.","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9eb7e024920fb290358d1bed60e3a4c4765da6f2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def update_variables(old_contents):"},{"line_number":49,"context_line":"    new_contents \u003d []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    for line in old_contents:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_d4043219","line":48,"in_reply_to":"7af24918_727579f8","updated":"2016-03-03 15:08:47.000000000","message":"Good point...should we loop over every word in each line to ensure we catch all references?","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"5d2cbbb46b6484f38942d093bacc55a3a946f65a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def update_variables(old_contents):"},{"line_number":49,"context_line":"    new_contents \u003d []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    for line in old_contents:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_bbfa2e41","line":48,"in_reply_to":"7af24918_d4043219","updated":"2016-03-03 16:40:52.000000000","message":"We can do, I don\u0027t know whether or not it\u0027s unnecessary complexity; I\u0027m not sure what the chances are that these values will be referenced. We would need to work out all the potential delimiters e.g. \u0027{}(),. |\u0027","commit_id":"2229aa5b603be564c351f481de3f22081dbd58f7"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"965a4f0e99126a6569f3864e6fff2de26fa3ba92","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    filename \u003d sys.argv[1]"},{"line_number":87,"context_line":"    main(filename)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    with open(\u0027/etc/openstack_deploy.KILO/VARS_MIGRATED\u0027, \u0027w\u0027) as f:"},{"line_number":90,"context_line":"        f.write(\u0027Openstack Kilo variables migrated.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_c779ed94","line":89,"updated":"2016-03-04 11:19:35.000000000","message":"This needs to create a unique filename based on the filename argument supplied to the script.","commit_id":"7e304cd44f0d0f38971930bf6e51c7fdeabc444b"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"a3aa59ecfacf2d8201953c8d4e9d8ac807dea41d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    flag_ref \u003d sys.argv[2]"},{"line_number":88,"context_line":"    main(filename)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    flag_file \u003d \u0027/etc/openstack_deploy.KILO/VARS_MIGRATED_%s\u0027 % flag_ref"},{"line_number":91,"context_line":"    with open(flag_file, \u0027w\u0027) as f:"},{"line_number":92,"context_line":"        f.write(\u0027OpenStack Kilo variables migrated.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5aef4532_c3524fdd","line":90,"updated":"2016-03-07 16:14:48.000000000","message":"We should probably note that multiple files are created within the docs.","commit_id":"350a61b8b78cb8aa51654446e79720a9d9f1a34e"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"c5e6a7acf8d508c0c911d8724400243e50098337","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    flag_ref \u003d sys.argv[2]"},{"line_number":88,"context_line":"    main(filename)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    flag_file \u003d \u0027/etc/openstack_deploy.KILO/VARS_MIGRATED_%s\u0027 % flag_ref"},{"line_number":91,"context_line":"    with open(flag_file, \u0027w\u0027) as f:"},{"line_number":92,"context_line":"        f.write(\u0027OpenStack Kilo variables migrated.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5aef4532_f999fc20","line":90,"in_reply_to":"5aef4532_c3524fdd","updated":"2016-03-07 16:51:59.000000000","message":"Done","commit_id":"350a61b8b78cb8aa51654446e79720a9d9f1a34e"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"11fe0e54702eae0b95c15cf713c4f00b4ecb0724","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    Replace all references to old variables."},{"line_number":51,"context_line":"    This includes comments and references within values for other variables."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    new_contents \u003d []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    for line in old_contents:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_3f8dc37b","line":52,"updated":"2016-03-08 18:54:02.000000000","message":"H404  multi line docstring should start without a leading new line\nH405  multi line docstring summary not separated with an empty line\n\nI think this needs newline margins above and below.","commit_id":"c3aae6bea563d7b988040014a76793b1ae65f047"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"b5a69768a0f7771cd97d0b819b182dffd467457e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":"    Replace all references to old variables."},{"line_number":51,"context_line":"    This includes comments and references within values for other variables."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    new_contents \u003d []"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    for line in old_contents:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5aef4532_73cae46e","line":52,"in_reply_to":"5aef4532_3f8dc37b","updated":"2016-03-08 20:21:30.000000000","message":"Done","commit_id":"c3aae6bea563d7b988040014a76793b1ae65f047"}]}
