)]}'
{"scripts/upgrade-utilities/playbooks/deploy-config-changes.yml":[{"author":{"_account_id":19805,"name":"Tom Cameron","email":"tomc603@gmail.com","username":"tomc603"},"change_message_id":"b49f42fdb59371bdd76ed43054578d1624467a23","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_8fb5ce32","line":48,"updated":"2016-03-08 16:07:29.000000000","message":"Would it be better not to make assumptions about where the repo has been checked out? Setting root_dir: \"/\" will always choose the proper location, but if I check out openstack-ansible to /home/mydir/openstack-ansible this won\u0027t work the way we expect.","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"},{"author":{"_account_id":19805,"name":"Tom Cameron","email":"tomc603@gmail.com","username":"tomc603"},"change_message_id":"8f8da4526e1d8608807b8317e26137eb27d73bc8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_ef2bb2e9","line":48,"in_reply_to":"5aef4532_8f9b0e72","updated":"2016-03-08 16:14:54.000000000","message":"Ah, for some reason I read playbook_dir as openstack-ansible/playbooks. Thanks. Maybe calling it repo_root or something similar would make it more clear.","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"68f500a76727c67354cbb2f9020056638f1f06bf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_8f9b0e72","line":48,"in_reply_to":"5aef4532_8fb5ce32","updated":"2016-03-08 16:11:11.000000000","message":"\"root_dir\" here is meant to mean \"root of the source tree\", I think. Perhaps the variable could be renamed to make that intention clearer.","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"ce32053f00c8c3f023d160c96baad800b077d286","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_0213550e","line":48,"in_reply_to":"5aef4532_ef2bb2e9","updated":"2016-03-08 16:27:27.000000000","message":"Done","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"95d1ce3d7cdd6b7aaade4c59ed02bdcdecb4343f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_4f8586ab","line":48,"in_reply_to":"5aef4532_ef2bb2e9","updated":"2016-03-08 16:18:57.000000000","message":"I believe playbook_dir is a built in Jinja variable provided by Ansible which means \"the directory this playbook is currently in\". In the case of this particular file, it\u0027s in \u003crepo_root\u003e/scripts/upgrade-utilities/playbooks/.","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"879b548f5a074a14cf3b75c7ec19cddef32a6c7a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            creates: /etc/openstack_deploy.KILO/CEILOMETER_MIGRATED"},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":48,"context_line":"      root_dir: \"{{ playbook_dir }}/../../../\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aef4532_ef63b218","line":48,"in_reply_to":"5aef4532_ef2bb2e9","updated":"2016-03-08 16:19:31.000000000","message":"Nit, I agree with Tom that rood_dir is somewhat misleading as to the path in question.","commit_id":"46016ab752869b9ba8f685b0e5920251df1194b5"}],"scripts/upgrade-utilities/scripts/add_new_neutron_env.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"0b9bbcc308e02955a06e4c68385fa80f0923a6aa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    repo_root \u003d sys.argv[1]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    kilo_file \u003d \u0027/etc/openstack_deploy.KILO/env.d/neutron.yml\u0027"},{"line_number":48,"context_line":"    repo_liberty_file \u003d os.path.join(repo_root, \u0027etc/openstack_deploy/env.d/neutron.yml\u0027)"},{"line_number":49,"context_line":"    liberty_file \u003d \u0027/etc/openstack_deploy/env.d/neutron.yml\u0027"},{"line_number":50,"context_line":"    flag_file \u003d \u0027/etc/openstack_deploy.KILO/NEUTRON_MIGRATED\u0027"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_48177c51","line":48,"updated":"2016-03-07 16:10:50.000000000","message":"Looks like this is 89 characters vs the 79 that linting allows to pass.","commit_id":"f45bf8c7a83e3f0fa076d0e054090a4dc0245706"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"e0a02ab66e103ed8654309e3ab3c5fca83728283","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    repo_root \u003d sys.argv[1]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    kilo_file \u003d \u0027/etc/openstack_deploy.KILO/env.d/neutron.yml\u0027"},{"line_number":48,"context_line":"    repo_liberty_file \u003d os.path.join(repo_root, \u0027etc/openstack_deploy/env.d/neutron.yml\u0027)"},{"line_number":49,"context_line":"    liberty_file \u003d \u0027/etc/openstack_deploy/env.d/neutron.yml\u0027"},{"line_number":50,"context_line":"    flag_file \u003d \u0027/etc/openstack_deploy.KILO/NEUTRON_MIGRATED\u0027"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1963081c","line":48,"in_reply_to":"5aef4532_48177c51","updated":"2016-03-07 16:52:23.000000000","message":"Done","commit_id":"f45bf8c7a83e3f0fa076d0e054090a4dc0245706"}]}
