)]}'
{"ansible-role-requirements.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4625a93404ee975d5ae0c064feb3b78bcf2681f3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"- name: sshd"},{"line_number":122,"context_line":"  src: https://github.com/willshersystems/ansible-sshd"},{"line_number":123,"context_line":"- name: os_ironic"},{"line_number":124,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-ironic"},{"line_number":125,"context_line":"  scm: git"},{"line_number":126,"context_line":"  version: master"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_7a8eea79","line":124,"range":{"start_line":124,"start_character":7,"end_line":124,"end_character":67},"updated":"2016-03-31 11:38:28.000000000","message":"Considering the pending rename of this repository[1], and the fact that git.o.o does not redirect a renamed repository, I would recommend that we make use of github [2] as a source for this role for now. This will ensure that the tagged release will continue to work after the rename.\n\nIn case you\u0027re wondering why github - go to [3] and see what happens.\n\nNote that it would be best if this use of this repo has an associated comment in this file to make it clear why this is being done. It should have a TODO note to return to this once [1] has merged.\n\n[1] https://review.openstack.org/299192\n[2] https://github.com/openstack/openstack-ansible-ironic\n[3] https://github.com/openstack/os-ansible-deployment","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":121,"context_line":"- name: sshd"},{"line_number":122,"context_line":"  src: https://github.com/willshersystems/ansible-sshd"},{"line_number":123,"context_line":"- name: os_ironic"},{"line_number":124,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-ironic"},{"line_number":125,"context_line":"  scm: git"},{"line_number":126,"context_line":"  version: master"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_4bc33e57","line":124,"range":{"start_line":124,"start_character":7,"end_line":124,"end_character":67},"in_reply_to":"ba0121b8_7a8eea79","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b86b73bd463e9593c821d5a26add41496bad6a3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"- name: os_horizon"},{"line_number":73,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_horizon"},{"line_number":74,"context_line":"  scm: git"},{"line_number":75,"context_line":"  version: 015ff90a447fb9f19342189123767e00cc20a3f4"},{"line_number":76,"context_line":"- name: os_ironic"},{"line_number":77,"context_line":"  src: https://github.com/openstack/openstack-ansible-ironic"},{"line_number":78,"context_line":"  scm: git"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9a061dce_1adbe3ee","line":75,"range":{"start_line":75,"start_character":11,"end_line":75,"end_character":51},"updated":"2016-04-09 10:38:55.000000000","message":"This needs to be \u0027master\u0027","commit_id":"9a3a189f29b8e08b39a8686176e18f31fc6e4182"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"6fcf8b32d9cb6b6db628aea8b11391a8f21ffb36","unresolved":false,"context_lines":[{"line_number":72,"context_line":"- name: os_horizon"},{"line_number":73,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_horizon"},{"line_number":74,"context_line":"  scm: git"},{"line_number":75,"context_line":"  version: 015ff90a447fb9f19342189123767e00cc20a3f4"},{"line_number":76,"context_line":"- name: os_ironic"},{"line_number":77,"context_line":"  src: https://github.com/openstack/openstack-ansible-ironic"},{"line_number":78,"context_line":"  scm: git"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a1b2928_c016cfa6","line":75,"range":{"start_line":75,"start_character":11,"end_line":75,"end_character":51},"in_reply_to":"9a061dce_1adbe3ee","updated":"2016-04-11 06:54:36.000000000","message":"Done","commit_id":"9a3a189f29b8e08b39a8686176e18f31fc6e4182"}],"etc/openstack_deploy/openstack_user_config.yml.aio":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  aio1:"},{"line_number":132,"context_line":"    ip: 172.29.236.100"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ironic-infra_hosts:"},{"line_number":135,"context_line":"  aio1:"},{"line_number":136,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba0121b8_596258ae","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":22},"updated":"2016-03-30 11:39:04.000000000","message":"This should not be included here. This file is for the core projects only. Please place a file similar to the swift file in etc/conf.d/","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  aio1:"},{"line_number":132,"context_line":"    ip: 172.29.236.100"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"ironic-infra_hosts:"},{"line_number":135,"context_line":"  aio1:"},{"line_number":136,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba0121b8_8e9c7d5e","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":22},"in_reply_to":"ba0121b8_596258ae","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"}],"etc/openstack_deploy/user_secrets.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ae92d3fff4293fdd822997f60d496e1d8272f3c0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ironic_rabbitmq_password:"},{"line_number":76,"context_line":"ironic_galera_password:"},{"line_number":77,"context_line":"ironic_service_password:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"## Horizon Options"},{"line_number":80,"context_line":"horizon_container_mysql_password:"},{"line_number":81,"context_line":"horizon_secret_key:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a18252c_755ac450","line":78,"updated":"2016-04-13 14:43:33.000000000","message":"we need to add \"ironic_swift_temp_url_secret_key\" to this section so that the swift temp url secret key can be auto generated.","commit_id":"b4edd8a09597d34f40a1b58e09a383a016702ed0"}],"playbooks/defaults/repo_packages/openstack_services.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 0ad5b13b5a5aeffcf12dd6c37afc99857b7012dd # HEAD of \"master\" as of 21.03.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_3950445d","line":112,"range":{"start_line":112,"start_character":27,"end_line":112,"end_character":103},"updated":"2016-03-30 11:39:04.000000000","message":"please update to the stable/mitaka SHA","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 0ad5b13b5a5aeffcf12dd6c37afc99857b7012dd # HEAD of \"master\" as of 21.03.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_e9153340","line":112,"range":{"start_line":112,"start_character":27,"end_line":112,"end_character":103},"in_reply_to":"ba0121b8_3950445d","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b86b73bd463e9593c821d5a26add41496bad6a3","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 8d105f60790ce108f65de90fc68e6e8651a87b4d # HEAD of \"stable/mitaka\" as of 23.03.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9a061dce_9aed3391","line":112,"range":{"start_line":112,"start_character":78,"end_line":112,"end_character":93},"updated":"2016-04-09 10:38:55.000000000","message":"The SHA will need to come from master to consider this patch finalised.","commit_id":"9a3a189f29b8e08b39a8686176e18f31fc6e4182"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"6fcf8b32d9cb6b6db628aea8b11391a8f21ffb36","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 8d105f60790ce108f65de90fc68e6e8651a87b4d # HEAD of \"stable/mitaka\" as of 23.03.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a1b2928_c0cb6f1d","line":112,"range":{"start_line":112,"start_character":78,"end_line":112,"end_character":93},"in_reply_to":"9a061dce_9aed3391","updated":"2016-04-11 06:54:36.000000000","message":"Done","commit_id":"9a3a189f29b8e08b39a8686176e18f31fc6e4182"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b145caddf05866c8e5d7f1189264aefe43900411","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 1bff8ddee44b9ecd083e1feb228238ee95e6528b # HEAD of \"master\" as of 11.04.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a18252c_ef039340","line":112,"updated":"2016-04-13 17:48:17.000000000","message":"I\u0027m curious why you\u0027re installing from master instead of a stable branch or a release.","commit_id":"b4edd8a09597d34f40a1b58e09a383a016702ed0"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"21e01a32d5e3a9f7a32f68742c0ac01d919c99ff","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 1bff8ddee44b9ecd083e1feb228238ee95e6528b # HEAD of \"master\" as of 11.04.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a18252c_eeff0ca8","line":112,"in_reply_to":"5a18252c_3264d4e2","updated":"2016-04-13 21:14:12.000000000","message":"That\u0027s a really clever way of doing it! Thanks for letting me know.","commit_id":"b4edd8a09597d34f40a1b58e09a383a016702ed0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cde07bac497c51435da800bfce6ad7a62a1820cd","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Ironic service"},{"line_number":111,"context_line":"ironic_git_repo: https://git.openstack.org/openstack/ironic"},{"line_number":112,"context_line":"ironic_git_install_branch: 1bff8ddee44b9ecd083e1feb228238ee95e6528b # HEAD of \"master\" as of 11.04.2016"},{"line_number":113,"context_line":"ironic_git_dest: \"/opt/ironic_{{ ironic_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a18252c_3264d4e2","line":112,"in_reply_to":"5a18252c_ef039340","updated":"2016-04-13 17:53:13.000000000","message":"Hi Jay - in the OSA master branch we install from the OpenStack master branches from SHA\u0027s which are updated typically every milestone, but sometimes in between as well.\n\nIn the OSA stable branches we build from stable branch SHA\u0027s which are updated every two weeks for every new tag. Tags are cut every two weeks.\n\nSo typically when a deployer makes use of OSA they would be using our stable branches, and thus OpenStack stable branches. However if they wish to they could also be building from the master branches and even have the ability to override the SHA\u0027s we set so that they can build from trunk or whatever.","commit_id":"b4edd8a09597d34f40a1b58e09a383a016702ed0"}],"playbooks/inventory/group_vars/hosts.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"60c73ca1599f5d1fffaa422beed5ba510d992b6e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"rabbitmq_use_ssl: true"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"## Galera"},{"line_number":57,"context_line":"galera_root_user: \"root\""},{"line_number":58,"context_line":"galera_wsrep_cluster_address: \"{% for host in groups[\u0027galera_all\u0027] %}{{ hostvars[host][\u0027ansible_ssh_host\u0027] }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":59,"context_line":"galera_wsrep_address: \"{{ ansible_ssh_host }}\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_6c7edfaf","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":24},"updated":"2016-04-04 10:14:27.000000000","message":"I definitely prefer having this here instead of in the playbook. We should remove this var from all service playbooks.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e2f3027ab83d0fc5815bcfcfe87253f17be67cd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"rabbitmq_use_ssl: true"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"## Galera"},{"line_number":57,"context_line":"galera_root_user: \"root\""},{"line_number":58,"context_line":"galera_wsrep_cluster_address: \"{% for host in groups[\u0027galera_all\u0027] %}{{ hostvars[host][\u0027ansible_ssh_host\u0027] }}{% if not loop.last %},{% endif %}{% endfor %}\""},{"line_number":59,"context_line":"galera_wsrep_address: \"{{ ansible_ssh_host }}\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_28e673b4","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"9a061dce_6c7edfaf","updated":"2016-04-04 19:40:28.000000000","message":"+1","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"60c73ca1599f5d1fffaa422beed5ba510d992b6e","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"## Ironic"},{"line_number":274,"context_line":"ironic_rabbitmq_vhost: /ironic"},{"line_number":275,"context_line":"ironic_rabbitmq_userid: ironic"},{"line_number":276,"context_line":"ironic_galera_database: ironic"},{"line_number":277,"context_line":"ironic_galera_user: ironic"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"## OpenStack Openrc"},{"line_number":280,"context_line":"openrc_os_auth_url: \"{{ keystone_service_internalurl }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_8c589358","line":277,"range":{"start_line":274,"start_character":0,"end_line":277,"end_character":26},"updated":"2016-04-04 10:14:27.000000000","message":"I definitely prefer having this here instead of in the playbook. We should apply this same pattern to the other service playbooks.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"}],"playbooks/os-ironic-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Installation and setup of Ironic"},{"line_number":17,"context_line":"  hosts: ironic_all"},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Use the lxc-openstack aa profile"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_19aaa070","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":25},"updated":"2016-03-30 11:39:04.000000000","message":"I\u0027m not so sure that this should be included. This playbook will hit the control plane, and we don\u0027t want to allow any portion of the control plane to fail.","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Installation and setup of Ironic"},{"line_number":17,"context_line":"  hosts: ironic_all"},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Use the lxc-openstack aa profile"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_69280387","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":25},"in_reply_to":"ba0121b8_19aaa070","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    - role: \"system_crontab_coordination\""},{"line_number":116,"context_line":"      tags:"},{"line_number":117,"context_line":"        - \"system-crontab-coordination\""},{"line_number":118,"context_line":"  vars_files:"},{"line_number":119,"context_line":"    - defaults/repo_packages/openstack_other.yml"},{"line_number":120,"context_line":"  vars:"},{"line_number":121,"context_line":"    galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":122,"context_line":"    ansible_hostname: \"{{ container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_19c5805a","line":119,"range":{"start_line":118,"start_character":0,"end_line":119,"end_character":48},"updated":"2016-03-30 11:39:04.000000000","message":"What\u0027s this for? It should not be necessary.","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    - role: \"system_crontab_coordination\""},{"line_number":116,"context_line":"      tags:"},{"line_number":117,"context_line":"        - \"system-crontab-coordination\""},{"line_number":118,"context_line":"  vars_files:"},{"line_number":119,"context_line":"    - defaults/repo_packages/openstack_other.yml"},{"line_number":120,"context_line":"  vars:"},{"line_number":121,"context_line":"    galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":122,"context_line":"    ansible_hostname: \"{{ container_name }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_699da3bb","line":119,"range":{"start_line":118,"start_character":0,"end_line":119,"end_character":48},"in_reply_to":"ba0121b8_19c5805a","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  vars_files:"},{"line_number":119,"context_line":"    - defaults/repo_packages/openstack_other.yml"},{"line_number":120,"context_line":"  vars:"},{"line_number":121,"context_line":"    galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":122,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":123,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":124,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_9902306e","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":51},"updated":"2016-03-30 11:39:04.000000000","message":"Does this actually get used? I\u0027m not sure it\u0027s necessary.","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  vars_files:"},{"line_number":119,"context_line":"    - defaults/repo_packages/openstack_other.yml"},{"line_number":120,"context_line":"  vars:"},{"line_number":121,"context_line":"    galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":122,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":123,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":124,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba0121b8_49a25ffe","line":121,"range":{"start_line":121,"start_character":4,"end_line":121,"end_character":51},"in_reply_to":"ba0121b8_9902306e","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"287862127458a3ecb3914b311af91aac4c90e978","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":47,"context_line":"        login_host: \"{{ ironic_galera_address }}\""},{"line_number":48,"context_line":"        name: \"{{ ironic_galera_database }}\""},{"line_number":49,"context_line":"        state: \"present\""},{"line_number":50,"context_line":"      tags:"},{"line_number":51,"context_line":"        - ironic-db-setup"},{"line_number":52,"context_line":"    - name: Grant access to the DB for Ironic"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_fc05d310","line":49,"updated":"2016-03-31 12:48:39.000000000","message":"We need to add:\ndelegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\"\nrun_once: true","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        login_password: \"{{ galera_root_password }}\""},{"line_number":47,"context_line":"        login_host: \"{{ ironic_galera_address }}\""},{"line_number":48,"context_line":"        name: \"{{ ironic_galera_database }}\""},{"line_number":49,"context_line":"        state: \"present\""},{"line_number":50,"context_line":"      tags:"},{"line_number":51,"context_line":"        - ironic-db-setup"},{"line_number":52,"context_line":"    - name: Grant access to the DB for Ironic"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_ebe692e6","line":49,"in_reply_to":"ba0121b8_fc05d310","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"287862127458a3ecb3914b311af91aac4c90e978","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        priv: \"{{ ironic_galera_database }}.*:ALL\""},{"line_number":62,"context_line":"      with_items:"},{"line_number":63,"context_line":"        - \"localhost\""},{"line_number":64,"context_line":"        - \"%\""},{"line_number":65,"context_line":"      tags:"},{"line_number":66,"context_line":"        - ironic-db-setup"},{"line_number":67,"context_line":"    - name: Ensure Rabbitmq vhost for Ironic"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_790b952a","line":64,"updated":"2016-03-31 12:48:39.000000000","message":"We need to add:\ndelegate_to: \"{{ groups[\u0027galera_all\u0027][0] }}\"\nrun_once: true","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        priv: \"{{ ironic_galera_database }}.*:ALL\""},{"line_number":62,"context_line":"      with_items:"},{"line_number":63,"context_line":"        - \"localhost\""},{"line_number":64,"context_line":"        - \"%\""},{"line_number":65,"context_line":"      tags:"},{"line_number":66,"context_line":"        - ironic-db-setup"},{"line_number":67,"context_line":"    - name: Ensure Rabbitmq vhost for Ironic"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_2b436ab3","line":64,"in_reply_to":"ba0121b8_790b952a","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"287862127458a3ecb3914b311af91aac4c90e978","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      rabbitmq_vhost:"},{"line_number":69,"context_line":"        name: \"{{ ironic_rabbitmq_vhost }}\""},{"line_number":70,"context_line":"        state: \"present\""},{"line_number":71,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":72,"context_line":"      tags:"},{"line_number":73,"context_line":"        - ironic-rabbitmq"},{"line_number":74,"context_line":"        - ironic-rabbitmq-vhost"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_792435c4","line":71,"updated":"2016-03-31 12:48:39.000000000","message":"we\u0027re going to need to add the following line below this:\nrun_once: true","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      rabbitmq_vhost:"},{"line_number":69,"context_line":"        name: \"{{ ironic_rabbitmq_vhost }}\""},{"line_number":70,"context_line":"        state: \"present\""},{"line_number":71,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":72,"context_line":"      tags:"},{"line_number":73,"context_line":"        - ironic-rabbitmq"},{"line_number":74,"context_line":"        - ironic-rabbitmq-vhost"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_6b20c2f7","line":71,"in_reply_to":"ba0121b8_792435c4","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"287862127458a3ecb3914b311af91aac4c90e978","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        read_priv: \".*\""},{"line_number":82,"context_line":"        write_priv: \".*\""},{"line_number":83,"context_line":"        state: \"present\""},{"line_number":84,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":85,"context_line":"      tags:"},{"line_number":86,"context_line":"        - ironic-rabbitmq"},{"line_number":87,"context_line":"        - ironic-rabbitmq-user"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_393e3dda","line":84,"updated":"2016-03-31 12:48:39.000000000","message":"we\u0027re going to need to add the following line below this:\nrun_once: true","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        read_priv: \".*\""},{"line_number":82,"context_line":"        write_priv: \".*\""},{"line_number":83,"context_line":"        state: \"present\""},{"line_number":84,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":85,"context_line":"      tags:"},{"line_number":86,"context_line":"        - ironic-rabbitmq"},{"line_number":87,"context_line":"        - ironic-rabbitmq-user"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_6b4e02c2","line":84,"in_reply_to":"ba0121b8_393e3dda","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"287862127458a3ecb3914b311af91aac4c90e978","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        rabbitmq_servers: \"{{ servers.sorted_list }}\""},{"line_number":97,"context_line":"  roles:"},{"line_number":98,"context_line":"    - role: \"os_ironic\""},{"line_number":99,"context_line":"      ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":100,"context_line":"      ironic_venv_tag: \"{{ openstack_release }}\""},{"line_number":101,"context_line":"      ironic_venv_download_url: \"{{ openstack_repo_url }}/venvs/{{ openstack_release }}/{{ ansible_distribution | lower }}/ironic-{{ openstack_release }}.tgz\""},{"line_number":102,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_3c23cba8","line":99,"updated":"2016-03-31 12:48:39.000000000","message":"We need to move this (ironic_galera_address) var definition to the vars: stanza at the bottom (line 117) - otherwise it isn\u0027t available for the pre-tasks.","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"0fcd8c0267c4fe980369bdab9b36c1ca8ed33951","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        rabbitmq_servers: \"{{ servers.sorted_list }}\""},{"line_number":97,"context_line":"  roles:"},{"line_number":98,"context_line":"    - role: \"os_ironic\""},{"line_number":99,"context_line":"      ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":100,"context_line":"      ironic_venv_tag: \"{{ openstack_release }}\""},{"line_number":101,"context_line":"      ironic_venv_download_url: \"{{ openstack_repo_url }}/venvs/{{ openstack_release }}/{{ ansible_distribution | lower }}/ironic-{{ openstack_release }}.tgz\""},{"line_number":102,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ba0121b8_2b588a87","line":99,"in_reply_to":"ba0121b8_3c23cba8","updated":"2016-03-31 20:09:27.000000000","message":"Done","commit_id":"04cb980e9e064563ceba63421dda49312dedde07"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"60c73ca1599f5d1fffaa422beed5ba510d992b6e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      tags:"},{"line_number":121,"context_line":"        - \"system-crontab-coordination\""},{"line_number":122,"context_line":"  vars:"},{"line_number":123,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":124,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":125,"context_line":"    ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":126,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_8ce533aa","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":47},"updated":"2016-04-04 10:14:27.000000000","message":"I\u0027m not entirely sure these are needed. I don\u0027t think it needs to be changed, but I do wonder why this is needed at all.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e2f3027ab83d0fc5815bcfcfe87253f17be67cd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"      tags:"},{"line_number":121,"context_line":"        - \"system-crontab-coordination\""},{"line_number":122,"context_line":"  vars:"},{"line_number":123,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":124,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":125,"context_line":"    ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":126,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_e8547b55","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":47},"in_reply_to":"9a061dce_8ce533aa","updated":"2016-04-04 19:40:28.000000000","message":"Done. ++ I dont think these are needed.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"60c73ca1599f5d1fffaa422beed5ba510d992b6e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  vars:"},{"line_number":123,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":124,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":125,"context_line":"    ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":126,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_ac991722","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":58},"updated":"2016-04-04 10:14:27.000000000","message":"Would it not be better to include this in the group_vars along with the other Ironic bits? I know this is a pattern shared across the other playbooks, but perhaps they need to change too.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e2f3027ab83d0fc5815bcfcfe87253f17be67cd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  vars:"},{"line_number":123,"context_line":"    ansible_hostname: \"{{ container_name }}\""},{"line_number":124,"context_line":"    ansible_ssh_host: \"{{ container_address }}\""},{"line_number":125,"context_line":"    ironic_galera_address: \"{{ internal_lb_vip_address }}\""},{"line_number":126,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a061dce_88d69fc3","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":58},"in_reply_to":"9a061dce_ac991722","updated":"2016-04-04 19:40:28.000000000","message":"I\u0027d say that it could be refactored however at this time I\u0027d recommend keeping the patter the same and not creating a special case.","commit_id":"26bb4c002f6241cfe1f266f2057071df69e07685"}],"scripts/run-playbooks.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2bae504fe65231f2fa1833aafdd27fafef354142","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    install_bits os-swift-install.yml"},{"line_number":135,"context_line":"  fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if [ \"${DEPLOY_IRONIC}\" \u003d\u003d \"yes\" ]; then"},{"line_number":138,"context_line":"    if [ \"${DEPLOY_OPENSTACK}\" \u003d\u003d \"no\" ]; then"},{"line_number":139,"context_line":"      # When os install is no, make sure we still have keystone for use in ironic."},{"line_number":140,"context_line":"      install_bits os-keystone-install.yml"},{"line_number":141,"context_line":"    fi"},{"line_number":142,"context_line":"    # install all of the ironic Bits"},{"line_number":143,"context_line":"    install_bits os-ironic-install.yml"},{"line_number":144,"context_line":"  fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  if [ \"${DEPLOY_TEMPEST}\" \u003d\u003d \"yes\" ]; then"},{"line_number":147,"context_line":"    # Deploy tempest"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba0121b8_59c098e0","line":144,"range":{"start_line":137,"start_character":0,"end_line":144,"end_character":4},"updated":"2016-03-30 11:39:04.000000000","message":"This script is specifically for development and gate testing, so I don\u0027t really see this as necessary. The ironic install playbook should rather be included in the setup-openstack meta playbook, then whether it gets deployed or not is effectively determined by whether any hosts are allocated into the group. All we need to do here is add the os-ironic-install play execution.","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"ae353192610c5a63efcf4da622384ca01be54628","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    install_bits os-swift-install.yml"},{"line_number":135,"context_line":"  fi"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if [ \"${DEPLOY_IRONIC}\" \u003d\u003d \"yes\" ]; then"},{"line_number":138,"context_line":"    if [ \"${DEPLOY_OPENSTACK}\" \u003d\u003d \"no\" ]; then"},{"line_number":139,"context_line":"      # When os install is no, make sure we still have keystone for use in ironic."},{"line_number":140,"context_line":"      install_bits os-keystone-install.yml"},{"line_number":141,"context_line":"    fi"},{"line_number":142,"context_line":"    # install all of the ironic Bits"},{"line_number":143,"context_line":"    install_bits os-ironic-install.yml"},{"line_number":144,"context_line":"  fi"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  if [ \"${DEPLOY_TEMPEST}\" \u003d\u003d \"yes\" ]; then"},{"line_number":147,"context_line":"    # Deploy tempest"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba0121b8_e941b3aa","line":144,"range":{"start_line":137,"start_character":0,"end_line":144,"end_character":4},"in_reply_to":"ba0121b8_59c098e0","updated":"2016-03-30 22:29:33.000000000","message":"Done","commit_id":"9d4c74aa90d4aa39d02d4ccdcf5936f3a3f04de5"}]}