)]}'
{"playbooks/haproxy-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b6ead3c06f165ca6d296b431ba5f980ad22d6c9d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            haproxy_ssl: \"{% if haproxy_ssl | bool and keystone_service_internaluri_proto \u003d\u003d \u0027https\u0027 %}true{% else %}false{% endif %}\""},{"line_number":121,"context_line":"            haproxy_balance_type: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027tcp\u0027,\u0027http\u0027) }}\""},{"line_number":122,"context_line":"            haproxy_balance_alg: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027source\u0027, \u0027leastconn\u0027) }}\""},{"line_number":123,"context_line":"            haproxy_backend_options: \"{{ (keystone_ssl_internal | bool) | ternary(haproxy_backend_options_https, haproxy_backend_options_http) }}\""},{"line_number":124,"context_line":"      when: internal_lb_vip_address !\u003d external_lb_vip_address"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    - role: \"rsyslog_client\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_3ea2ad99","line":123,"range":{"start_line":123,"start_character":82,"end_line":123,"end_character":141},"updated":"2016-03-31 09:07:53.000000000","message":"These two options aren\u0027t defined any more.","commit_id":"358480edff62025f904c9fbfef384760434f4316"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"040d593690a3c2abb1de2a47e6d10e8984bd940f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            haproxy_ssl: \"{% if haproxy_ssl | bool and keystone_service_internaluri_proto \u003d\u003d \u0027https\u0027 %}true{% else %}false{% endif %}\""},{"line_number":121,"context_line":"            haproxy_balance_type: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027tcp\u0027,\u0027http\u0027) }}\""},{"line_number":122,"context_line":"            haproxy_balance_alg: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027source\u0027, \u0027leastconn\u0027) }}\""},{"line_number":123,"context_line":"            haproxy_backend_options: \"{{ (keystone_ssl_internal | bool) | ternary(haproxy_backend_options_https, haproxy_backend_options_http) }}\""},{"line_number":124,"context_line":"      when: internal_lb_vip_address !\u003d external_lb_vip_address"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    - role: \"rsyslog_client\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_4a24f15e","line":123,"range":{"start_line":123,"start_character":82,"end_line":123,"end_character":141},"in_reply_to":"ba0121b8_3ea2ad99","updated":"2016-03-31 13:20:07.000000000","message":"these options are still here: https://github.com/openstack/openstack-ansible/blob/master/playbooks/vars/configs/haproxy_config.yml#L15-L21 -- are they being removed and should I remove this line or just the ternary filter?","commit_id":"358480edff62025f904c9fbfef384760434f4316"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"203a2aca762fc3b5fe424fcf438bb8057ced5d57","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            haproxy_ssl: \"{% if haproxy_ssl | bool and keystone_service_internaluri_proto \u003d\u003d \u0027https\u0027 %}true{% else %}false{% endif %}\""},{"line_number":121,"context_line":"            haproxy_balance_type: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027tcp\u0027,\u0027http\u0027) }}\""},{"line_number":122,"context_line":"            haproxy_balance_alg: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027source\u0027, \u0027leastconn\u0027) }}\""},{"line_number":123,"context_line":"            haproxy_backend_options: \"{{ (keystone_ssl_internal | bool) | ternary(haproxy_backend_options_https, haproxy_backend_options_http) }}\""},{"line_number":124,"context_line":"      when: internal_lb_vip_address !\u003d external_lb_vip_address"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    - role: \"rsyslog_client\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_b68ecf76","line":123,"range":{"start_line":123,"start_character":82,"end_line":123,"end_character":141},"in_reply_to":"ba0121b8_4a24f15e","updated":"2016-03-31 15:02:02.000000000","message":"I know they\u0027re still in the vars file and are used there, but I thought that the lack of inclusion of the vars file meant that this filter won\u0027t produce the right result (ie it won\u0027t return the dict but will instead return a string or something). I haven\u0027t tested it so I\u0027m not sure.\n\nThe point of having this extra task is so that there can be SSL endpoints at the LB and at the Keystone service, or only SSL at either one. We may need to revisit that to determine whether that\u0027s something we really want to support as a design requirement in Newton.","commit_id":"358480edff62025f904c9fbfef384760434f4316"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"95a74596ca04cd9ed854354e1d8ca0e65f1144bb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            haproxy_ssl: \"{% if haproxy_ssl | bool and keystone_service_internaluri_proto \u003d\u003d \u0027https\u0027 %}true{% else %}false{% endif %}\""},{"line_number":121,"context_line":"            haproxy_balance_type: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027tcp\u0027,\u0027http\u0027) }}\""},{"line_number":122,"context_line":"            haproxy_balance_alg: \"{{ (keystone_ssl_internal | bool) | ternary(\u0027source\u0027, \u0027leastconn\u0027) }}\""},{"line_number":123,"context_line":"            haproxy_backend_options: \"{{ (keystone_ssl_internal | bool) | ternary(haproxy_backend_options_https, haproxy_backend_options_http) }}\""},{"line_number":124,"context_line":"      when: internal_lb_vip_address !\u003d external_lb_vip_address"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    - role: \"rsyslog_client\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_ea3ac997","line":123,"range":{"start_line":123,"start_character":82,"end_line":123,"end_character":141},"in_reply_to":"ba0121b8_b68ecf76","updated":"2016-04-02 11:19:49.000000000","message":"The var file is still being included its just at the bottom of the play and there\u0027s no need to include it within the specific task. As for the functional bits this still produces the same outcome just in a bit of a longer fashion because the full role has to run.","commit_id":"358480edff62025f904c9fbfef384760434f4316"}]}
