)]}'
{"playbooks/filter_plugins/core.py":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e2d8f5db7353cf3380516e4933f6d27e288cbad1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"def filter_dict(list, key, value):"},{"line_number":2,"context_line":"    return filter(lambda t: t[key] in value, list)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class FilterModule(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_ebdb7619","line":1,"updated":"2016-05-15 18:10:12.000000000","message":"If the filter_dict_byKey must exist, it should be in the plugins repo instead.","commit_id":"38c950ea2d96556c37fc1f61a538361c9e105395"}],"playbooks/os-heat-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b08bc3b9064235eff88f50130c6472013cd2c68e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: add haproxy service configs"},{"line_number":17,"context_line":"  hosts: haproxy"},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - { role: \"haproxy_server\", services: \"[heat_api_cfn, heat_api_cloudwatch, heat_api]\" }"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dab17558_b6029b07","line":18,"range":{"start_line":18,"start_character":2,"end_line":18,"end_character":25},"updated":"2016-05-09 10:56:21.000000000","message":"I really don\u0027t think this belongs here. If any one of the haproxy hosts fail, the play should fail. This same comment applies to all the other plays.","commit_id":"7018430725b76da3eac7d763c3ddf678368a0be3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b08bc3b9064235eff88f50130c6472013cd2c68e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  roles:"},{"line_number":21,"context_line":"    - { role: \"haproxy_server\", services: \"[heat_api_cfn, heat_api_cloudwatch, heat_api]\" }"},{"line_number":22,"context_line":"  vars_files:"},{"line_number":23,"context_line":"    - vars/configs/haproxy_config.yml"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dab17558_b650db0b","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":91},"updated":"2016-05-09 10:56:21.000000000","message":"If this dict is expressed vertically it\u0027ll read a lot easier. This same comment applies to all the other plays.\n\nie\n\n  roles:\n    - role: \"haproxy_server\"\n      services:\n        - heat_api_cfn\n        - heat_api_cloudwatch\n        - heat_api","commit_id":"7018430725b76da3eac7d763c3ddf678368a0be3"}],"playbooks/roles/haproxy_server/tasks/haproxy_service_config.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e2d8f5db7353cf3380516e4933f6d27e288cbad1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  template:"},{"line_number":18,"context_line":"    src: service.j2"},{"line_number":19,"context_line":"    dest: \"/etc/haproxy/conf.d/{{ item.haproxy_service_name }}\""},{"line_number":20,"context_line":"  with_items: role_haproxy_service_configs"},{"line_number":21,"context_line":"  when: \u003e"},{"line_number":22,"context_line":"    (item.haproxy_backend_nodes is defined and"},{"line_number":23,"context_line":"     item.haproxy_backend_nodes | length \u003e 0) or"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_811d6a64","line":20,"range":{"start_line":20,"start_character":14,"end_line":20,"end_character":42},"updated":"2016-05-15 18:10:12.000000000","message":"could you use ansible 2 notation {{ }}?","commit_id":"38c950ea2d96556c37fc1f61a538361c9e105395"}],"playbooks/roles/haproxy_server/tasks/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e2d8f5db7353cf3380516e4933f6d27e288cbad1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: haproxy_pre_install.yml"},{"line_number":17,"context_line":"  when: services is not defined"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- include: haproxy_add_ppa_repo.yml"},{"line_number":20,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_01321af2","line":17,"range":{"start_line":17,"start_character":8,"end_line":17,"end_character":31},"updated":"2016-05-15 18:10:12.000000000","message":"could you use ansible2 notation:\nservices | default()","commit_id":"38c950ea2d96556c37fc1f61a538361c9e105395"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"e2d8f5db7353cf3380516e4933f6d27e288cbad1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  when: services is not defined"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- include: haproxy_service_config.yml"},{"line_number":36,"context_line":"  when: services is defined"},{"line_number":37,"context_line":"  role_haproxy_service_configs:"},{"line_number":38,"context_line":"    \u0027{{ haproxy_service_configs|filter_dict_byKey(\"haproxy_service_name\",services)|list }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_a13fceb2","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":27},"updated":"2016-05-15 18:10:12.000000000","message":"when can be removed here","commit_id":"38c950ea2d96556c37fc1f61a538361c9e105395"}]}
