)]}'
{"ansible-role-requirements.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f67c58b4a00165562c51a1a7b0fca6f74b24b2dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: 00c3eee5f629b8e4d6bb3d54a5a35e5ffa15a4d4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_9892cc4a","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":51},"updated":"2016-04-07 11:00:40.000000000","message":"While I\u0027m not averse to including this patch personally, having this SHA here means something to manage which does not get managed anywhere else in the Liberty branch. Will you manually be maintaining this (as there\u0027s not Liberty branch in the role), is this expected to stay static, or how will updating this work?","commit_id":"40ee0f56ba4853b44e9632e9ae8cbd8196b87d63"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"784e0d7ea4ff2bfeb824d397d3999d47ff94797a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: 00c3eee5f629b8e4d6bb3d54a5a35e5ffa15a4d4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_d2f8534c","line":15,"in_reply_to":"9a061dce_5ef44f86","updated":"2016-04-08 14:26:50.000000000","message":"Done","commit_id":"40ee0f56ba4853b44e9632e9ae8cbd8196b87d63"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4304257cb4b4240c91beff36239695003793fd38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: 00c3eee5f629b8e4d6bb3d54a5a35e5ffa15a4d4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_5ef44f86","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":51},"in_reply_to":"9a061dce_96dbb07b","updated":"2016-04-08 13:46:23.000000000","message":"This SHA now matches the \u0027liberty\u0027 branch and \u002712.0.0\u0027 tag for the repo. If this is going to be manually managed it may be an idea to simply use the latest tag instead of the SHA. It makes th eversion used a little more obvious.","commit_id":"40ee0f56ba4853b44e9632e9ae8cbd8196b87d63"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"70c3ca94222cd167b3149a65b88447e4429ff548","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: 00c3eee5f629b8e4d6bb3d54a5a35e5ffa15a4d4"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_96dbb07b","line":15,"range":{"start_line":15,"start_character":2,"end_line":15,"end_character":51},"in_reply_to":"9a061dce_9892cc4a","updated":"2016-04-07 14:33:15.000000000","message":"+1 this is something to consider with the inclusion of this role in liberty. Should we tag/branch the security role? If it were to create a branch (stable/liberty) I think we could mitigate risk by forcing changes to be backported to that branch while also removing the need to manage this SHA.","commit_id":"40ee0f56ba4853b44e9632e9ae8cbd8196b87d63"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4f375c29a7f3fef7095a155cc5325642bf303c25","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: liberty"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_cb19be7b","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":18},"updated":"2016-04-08 14:42:53.000000000","message":"This should either be a SHA or a tag number to ensure that every tag of OpenStack-Ansible deploys the same thing.","commit_id":"79f40f608dfa384ad8bf135f2bf8febf8932cf00"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"7feda9baa75d887ceb4e7a680ff2006cf771be53","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- name: openstack-ansible-security"},{"line_number":13,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-security"},{"line_number":14,"context_line":"  scm: git"},{"line_number":15,"context_line":"  version: liberty"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_ebb8022d","line":15,"in_reply_to":"9a061dce_cb19be7b","updated":"2016-04-08 14:44:49.000000000","message":"Tags might be overkill for this -- would a SHA be sufficient?","commit_id":"79f40f608dfa384ad8bf135f2bf8febf8932cf00"}],"tests/roles/bootstrap-host/templates/user_variables.aio.yml.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a67c3bb5c5c708901593e2739261bfd4c2a287d4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"lxc_container_template_apt_components: {{ bootstrap_host_apt_components }}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"## Security hardening"},{"line_number":96,"context_line":"apply_security_hardening: true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a18252c_f5e6ebb2","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":30},"updated":"2016-04-13 09:02:28.000000000","message":"Could you explain why you set this in stone for the testing?\nWhy not using a default variable in the testing role?\n\nAlso, why would the value be true here?\nI\u0027m surprised this is true without explanation.","commit_id":"b8f12c86b288b83c4e602846d1f5b5f282448b41"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"8adb9f09b95d6cdc496e8dacd47aa3146d721669","unresolved":false,"context_lines":[{"line_number":93,"context_line":"lxc_container_template_apt_components: {{ bootstrap_host_apt_components }}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"## Security hardening"},{"line_number":96,"context_line":"apply_security_hardening: true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a18252c_676e9a96","line":96,"in_reply_to":"5a18252c_e83720ae","updated":"2016-04-13 14:12:56.000000000","message":"My goal here was to test as much as we can in the AIO to catch any potential bugs in the Liberty branch. I\u0027d prefer to leave it enabled in the AIO so we can catch any of those bugs.","commit_id":"b8f12c86b288b83c4e602846d1f5b5f282448b41"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4b7f990a48229a1b8659110a104db2f1fc76298f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"lxc_container_template_apt_components: {{ bootstrap_host_apt_components }}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"## Security hardening"},{"line_number":96,"context_line":"apply_security_hardening: true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a18252c_e83720ae","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":30},"in_reply_to":"5a18252c_f4826351","updated":"2016-04-13 12:57:06.000000000","message":"My point would be to have the testing as close as possible to the deliverable: for Mitaka, set to true, for the Liberty, set to false. It\u0027s just a variable...\n\nBut I don\u0027t see a problem of testing this too.","commit_id":"b8f12c86b288b83c4e602846d1f5b5f282448b41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"632d29f5f21d3375aff8acfd852957ef4c5cb5a4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"lxc_container_template_apt_components: {{ bootstrap_host_apt_components }}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"## Security hardening"},{"line_number":96,"context_line":"apply_security_hardening: true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5a18252c_f4826351","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":30},"in_reply_to":"5a18252c_f5e6ebb2","updated":"2016-04-13 11:58:21.000000000","message":"We\u0027ve had this set for gate testing for the whole Mitaka cycle. This has been enabled to ensure that we discover any problems and resolve them before we end up with a deployer reporting a bug.\n\nThe AIO settings don\u0027t really need too much explanation I don\u0027t think - the documentation covers what this does is a fair amount of detail.","commit_id":"b8f12c86b288b83c4e602846d1f5b5f282448b41"}]}